From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A23C54E41 for ; Tue, 5 Mar 2024 14:12:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AF056B00C1; Tue, 5 Mar 2024 09:12:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 05F6A6B00C2; Tue, 5 Mar 2024 09:12:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E41B56B00C3; Tue, 5 Mar 2024 09:12:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D44F46B00C1 for ; Tue, 5 Mar 2024 09:12:27 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7F9421C0FEC for ; Tue, 5 Mar 2024 14:12:27 +0000 (UTC) X-FDA: 81863175534.11.AF0F4C9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf14.hostedemail.com (Postfix) with ESMTP id 378CA100012 for ; Tue, 5 Mar 2024 14:12:24 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=R2mixKG7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lIPfLtV7; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=R2mixKG7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lIPfLtV7; spf=pass (imf14.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709647945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mVMBkO26srIvGNGxarIEl9k+TtBSK7K2iz5x0GMIPNI=; b=2lskj9IL6s/5mlfLlX8wD3rpyMkmHdzOZP+udBI3d4smJEdfDe02CwrmaBEd6BzmgFt37s H2KyPzILMaU5GaPiJcar2Uq1gQN6Q49OTImC/RdUjgpX7O2nHOd402kWb92PN4N1CKyLI1 4xfwCtP6GANkhL6d9mp/8dheSu0RE/4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709647945; a=rsa-sha256; cv=none; b=KQ0W5ez5GHdeuQ1sISxKgHoU0ANSOLLX/+JCDMWfWg4ZCg6UavZc1tF/2ZvUkBUOPYDQkr cXbE2OF2JJNtM1PzE9vsHMf9q+nf8je7QtW9Qdir2Dos4TOQt/X83xbXMLAHWliCJTom2a qFMUOalHzonWSuKoBOzj+crw/tONyU4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=R2mixKG7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lIPfLtV7; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=R2mixKG7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lIPfLtV7; spf=pass (imf14.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9A2776B3B9; Tue, 5 Mar 2024 14:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709647941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mVMBkO26srIvGNGxarIEl9k+TtBSK7K2iz5x0GMIPNI=; b=R2mixKG7Zh6QZR/Qh41CErDOndna+q/VFmZRP/msuxr/i8gbGrsUqZ9iwhPKkl5v78NzEZ WuKruK8UmBU4Uf3kt00M+/036KT46+co0g4T1MFJX8Rmukk/XxrVsaXb23+Wd9Z5U/Ysk/ 3QbUeHu1mp71P437KM70146pVvtdIlw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709647941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mVMBkO26srIvGNGxarIEl9k+TtBSK7K2iz5x0GMIPNI=; b=lIPfLtV7U5aiOgX1FD84+no+5Dr9oyBWTCe+LcMVgXMb2DJm6O5FH80xG29ngUWag9mYE2 sHkKBVYNTJWdHeDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709647941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mVMBkO26srIvGNGxarIEl9k+TtBSK7K2iz5x0GMIPNI=; b=R2mixKG7Zh6QZR/Qh41CErDOndna+q/VFmZRP/msuxr/i8gbGrsUqZ9iwhPKkl5v78NzEZ WuKruK8UmBU4Uf3kt00M+/036KT46+co0g4T1MFJX8Rmukk/XxrVsaXb23+Wd9Z5U/Ysk/ 3QbUeHu1mp71P437KM70146pVvtdIlw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709647941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mVMBkO26srIvGNGxarIEl9k+TtBSK7K2iz5x0GMIPNI=; b=lIPfLtV7U5aiOgX1FD84+no+5Dr9oyBWTCe+LcMVgXMb2DJm6O5FH80xG29ngUWag9mYE2 sHkKBVYNTJWdHeDA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 8CFC813A5D; Tue, 5 Mar 2024 14:12:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id I/BkIkUo52VtQwAAn2gu4w (envelope-from ); Tue, 05 Mar 2024 14:12:21 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 31BF0A0650; Tue, 5 Mar 2024 15:12:21 +0100 (CET) Date: Tue, 5 Mar 2024 15:12:21 +0100 From: Jan Kara To: chengming.zhou@linux.dev Cc: jack@suse.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com, Chengming Zhou Subject: Re: [PATCH] ext2: remove SLAB_MEM_SPREAD flag usage Message-ID: <20240305141221.um4zuvnro7tg5fgq@quack3> References: <20240224134816.829424-1-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240224134816.829424-1-chengming.zhou@linux.dev> X-Rspamd-Queue-Id: 378CA100012 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: cxkpxgg7sfo6zj9zg75sdpdctm144ez9 X-HE-Tag: 1709647944-736243 X-HE-Meta: U2FsdGVkX19Yy+xKa3dxPlhgyBoauMgaWG9wBFAMCZglFgpKo2f7//jMGD2zn4+LwChPc2QXn8G0WDoQW9lmrlyegAXG4xb9CiYkELU8wwYP29j8n7HCqJCEAFa6ZZ8MyrVdPchUNra+bUnCaZEJTZ+nnCIvl4TRgv6ujDnf7DJdoSPh0kw68C8cieka4+5tujX7sb/K1lO2Ui60SgyDPYB9qKEtA33h5Mrh7xNLc7nvD8ZlMPuDDlEJgGo2ieB+Q9fXRNdVwwKU2h2Dl2egaDIq0SYxxPxiuBNI83zdmzuEg1iRSVrypybKqyV/jdj+YWayJQ5pGoFz4lOU0ZQT1Kz8VsbENLyFQHyRFpfSLEUb2VsvAEw0cz84xhzfNdICm0ZqMMZ2u8tOj53ub+EUg2A8sHn84w5+jhkr4klrKACoHFXTJkptqgwMwsud7lq6l+5wLqjF9hDlemrtyBg6bgdNw96QMmz4QGBjy5BDHB2SzTeBTSYfYuiRvbOdVxucQUNgRYLDi1Fva0zW05ch1aPvfxbc7bN1+UxQJndLH5Fh9322SbGWmTJsz1U2aVlH9iYnyOoLJG6XES/LfjhIYA+ek+mS+XMu6fPSr88uuh2fdcXfiBghwwmnIdElOzIZJD8oEHHGLLFtS5io4Gb8xXHMvKsohCleVsuodEA/lN7lcv6Xeq1aa4LU1L9ExkBArnxmUCRmM0al7CDcs19YiifOnO97z4II2DROmG9DiH0vJt3mF6SL9PSMQYW0Z6Xi7mBcoThSYxGpvAWI7h38Tu2/6BOhzTVB3bUb7rHLo/Hopcfwr+P2yF3ILcL9/p49WJ92+vqCQzENxUMJml/T+Osizqwy0tgOxU7KJVtSwNozaFCV1j5AdDwRFHKckbDLaNyeS18J6jQlrBLVW2HBo1PLPLhTV1MEq09vL/WQ69pLlF3YwU2EKzFTqQdKLXd6NkPzumdOkAH88shrz1V WvHsG7Qe jxhaJGWp19rJ6kzg3vQ1Mtt39D5UMcaRQq5ok/5R5DleIvuRRIms8OFR8q87gJ5HJ4yO1Iv6zPg9PCGDZIbWcMRWy5nLqW5tFuMi3WATesnXU96yRULqdSs0weLc1dqrMTdmnsI7y+LJm4Yq/jscfOmNP3FKrBbnCZ+OF1NuB8i3dw+DJ7ZTt/SSgnWrOjftKuia86/zPxotZ8qdMVsnfiO8NbQoOrY9tdb1+DcjBkGAujVN+oL7UzvnLTHAeV7EfK1DmCBqdTa8jXUv1jQxS5CdU9mddQSs0OVDVSi3IRSBVPLGyw2Q500aFvThntmKWoV5TWP5V0pu6MECwFTRvpiCirFAWI2AzVBI4KC3OFyUnCnI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat 24-02-24 13:48:16, chengming.zhou@linux.dev wrote: > From: Chengming Zhou > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove > its usage so we can delete it from slab. No functional change. > > Signed-off-by: Chengming Zhou Thanks. I've added the patch to my tree. Honza > --- > fs/ext2/super.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/ext2/super.c b/fs/ext2/super.c > index 6d8587505cea..7162c61c0402 100644 > --- a/fs/ext2/super.c > +++ b/fs/ext2/super.c > @@ -213,8 +213,7 @@ static int __init init_inodecache(void) > { > ext2_inode_cachep = kmem_cache_create_usercopy("ext2_inode_cache", > sizeof(struct ext2_inode_info), 0, > - (SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD| > - SLAB_ACCOUNT), > + SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT, > offsetof(struct ext2_inode_info, i_data), > sizeof_field(struct ext2_inode_info, i_data), > init_once); > -- > 2.40.1 > -- Jan Kara SUSE Labs, CR