From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE91C48BF6 for ; Tue, 5 Mar 2024 02:37:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24C5C6B007D; Mon, 4 Mar 2024 21:37:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FBE46B007E; Mon, 4 Mar 2024 21:37:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 076086B0080; Mon, 4 Mar 2024 21:37:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EBCCD6B007D for ; Mon, 4 Mar 2024 21:37:23 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A77CF120ACE for ; Tue, 5 Mar 2024 02:37:23 +0000 (UTC) X-FDA: 81861423966.03.33B9380 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf07.hostedemail.com (Postfix) with ESMTP id 93F7340013 for ; Tue, 5 Mar 2024 02:37:19 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709606242; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+UvG76RujFHwyW36xPxNnLhAlpJqTDJCnbhf1YBbgqU=; b=X9ua7jRnV44QxonNHtDbLNM2ovmwIqP0ssFedmDvpfxAcnJylhtqhVcwApi2NIqN0isdH5 C52ynbKk3Sf5QksR1IvjMxLS82jSmmj/zuqT3OUvO130tetcX1D+WqBuZwSX+n4+CvxvzA v3G4cTdwkCJr9WXh63R5lfVo7L8XjMA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709606242; a=rsa-sha256; cv=none; b=swqOQRrCcmoV//jLLZHSSomEAWZwYkuYVCeYuOCcxxsI8ZGIha6OFYeZL7+6D4lwsGx2Rj uRns0komaLk2aytHcZkM+dMboEaKgMN2kuUgfeWJtbcF5UklTXbk3z4V9YCoxRno3nFaDc ttmdP6HUnFUfsfPgvThmCcH+c/m7My8= X-AuditID: a67dfc5b-d6dff70000001748-ec-65e68559f94a Date: Tue, 5 Mar 2024 11:37:08 +0900 From: Byungchul Park To: "Huang, Ying" Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, yuzhao@google.com, hannes@cmpxchg.org Subject: Re: [PATCH v6] mm, vmscan: retry kswapd's priority loop with cache_trim_mode off on failure Message-ID: <20240305023708.GA60719@system.software.com> References: <20240304033611.GD13332@system.software.com> <20240304082118.20499-1-byungchul@sk.com> <87zfvda1f8.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zfvda1f8.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsXC9ZZnoW5k67NUg2+3dSzmrF/DZrF6k6/F 5V1z2CzurfnPanFy1mQWi3cTvrA6sHkcfvOe2WPBplKPxXteMnls+jSJ3ePEjN8sHp83yQWw RXHZpKTmZJalFunbJXBlHG1TLLhnU9F99jljA+ML7S5GTg4JAROJtYu6mWHs3Q9/sIDYLAIq EvMX/GIDsdkE1CVu3PgJViMioCHxaeFy9i5GLg5mgcmMEs/2rwFrEBZIk3h17DNYEa+AhcT0 m22sIEVCAjMYJb7/nw+VEJQ4OfMJWAOzgJbEjX8vmboYOYBsaYnl/zhAwpwCdhI3/+wHKxcV UJY4sO04E8Rxa9gkjn+0hLAlJQ6uuMEygVFgFpKps5BMnYUwdQEj8ypGocy8stzEzBwTvYzK vMwKveT83E2MwLBeVvsnegfjpwvBhxgFOBiVeHhP7HuaKsSaWFZcmXuIUYKDWUmEt+bXk1Qh 3pTEyqrUovz4otKc1OJDjNIcLErivEbfylOEBNITS1KzU1MLUotgskwcnFINjGol/8zu+3q2 TH8av/nth109oj+fTNqjJ/Jtr+7sCZ7Xr1kHaVV/Z33k1vzplkygaGGUSR7r1xcOBm/0lCd+ 1H11Nc8sw63xWcTPO9t+LXvItGIpx8HQJ1wHGx+E31+2vK/H6uX85gcbdZoLym9NfqJ6qsFl yxTes26KC9QOLzp5qOTl7hXZpzYrsRRnJBpqMRcVJwIAfoRaN2cCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDLMWRmVeSWpSXmKPExsXC5WfdrBvZ+izVYPtkJYs569ewWaze5Gtx eO5JVovLu+awWdxb85/V4uSsySwW7yZ8YXVg9zj85j2zx4JNpR6L97xk8tj0aRK7x4kZv1k8 Fr/4wOTxeZNcAHsUl01Kak5mWWqRvl0CV8bRNsWCezYV3WefMzYwvtDuYuTkkBAwkdj98AcL iM0ioCIxf8EvNhCbTUBd4saNn8wgtoiAhsSnhcvZuxi5OJgFJjNKPNu/BqxBWCBN4tWxz2BF vAIWEtNvtrGCFAkJzGCU+P5/PlRCUOLkzCdgDcwCWhI3/r1k6mLkALKlJZb/4wAJcwrYSdz8 sx+sXFRAWeLAtuNMExh5ZyHpnoWkexZC9wJG5lWMIpl5ZbmJmTmmesXZGZV5mRV6yfm5mxiB Ybqs9s/EHYxfLrsfYhTgYFTi4b1w9GmqEGtiWXFl7iFGCQ5mJRHeml9PUoV4UxIrq1KL8uOL SnNSiw8xSnOwKInzeoWnJggJpCeWpGanphakFsFkmTg4pRoYm7ZG2Ao3PfC7uc97skz9Et/7 sjP2VSwX/B58hF97w1W+vwvj1mvIMahlHOgOuejwP7htZZNLdH1eyjo/Cc9p61y+LZLYxX/S KEgv4bvORplga7+rBS/Ydt/V6eE4oBvLPuNT8J2N5zp3bl6s3ZIyZVHR7yPvpaVifZ5xnqp4 41z+MKojS9hViaU4I9FQi7moOBEAsg309U8CAAA= X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 93F7340013 X-Stat-Signature: xcq5iijt58148hpgj56gj4c7abaem79t X-Rspam-User: X-HE-Tag: 1709606239-968524 X-HE-Meta: U2FsdGVkX18Y7x9j8DZUyvun7PTl07GaS20YvOBR+/B00+9wTLmPKv3gF4b99FslGhcBD8RrPx2uM5tD/4sCgPmOaRxOZefw72msOB3D4egNNRNEMGA6Fn+LI6vsglMP1auDe9hVGtBaxh48UO1c+QpPiqKKfEdM66IuZQdsINerGHHMt4crPlbOuNqBvyYTFcB1vexlTMID2ZEOTbj8mqznencH2T3VnCmhdOlv6FcNiHuftjfIOHspZw/NqddRof1Ood53PE520ESRf3AIbDGFf2Y5R8WRpQo4GaPAKBtTqAah5NAHbkAn+QmUKVA1uPrq/GqM7GKs+o5Eas5/Pi7jhVPcaCdyUUwz7vE7H6aC7X0MO+P886XVfI957lNqNifZdaCEsILfpOfLrIm4RLlbgm9MFxfUAbErU/BnGy4B0KM/QMPhVgY9Uxe/dHOsTv6r5CVOJ4uhkh1k2F73TvNCd4EBBun8nkvtLWDNYCK/0Z+rMFfdXw0GYrq9J35Uh7VwZCvnpE74Eo5IZiVlbEeJPpwfOnUo6pjugTxF6ls0GEGL9OeUPI77GMezK9urrIzT4oFwDBqOSUqNdJZO4jMZ63kutHqMHaE/BJ+6IClOgtAia+OWWp2TzBNyas/2QyQe2oZk/Jmf31YHT3udeFYgnAzAtq7U16bIR5Q3hlX9q1zOL2N4XdIso4sRyeekNoQ9giQl2GltfYGor0R18g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 05, 2024 at 09:54:19AM +0800, Huang, Ying wrote: > Byungchul Park writes: > > > Changes from v5: > > 1. Make it retry the kswapd's scan priority loop with > > cache_trim_mode off *only if* the mode didn't work in the > > previous loop. (feedbacked by Huang Ying) > > 2. Take into account 'break's from the priority loop when making > > the decision whether to retry. (feedbacked by Huang Ying) > > 3. Update the test result in the commit message. > > > > Changes from v4: > > 1. Make other scans start with may_cache_trim_mode = 1. > > > > Changes from v3: > > 1. Update the test result in the commit message with v4. > > 2. Retry the whole priority loop with cache_trim_mode off again, > > rather than forcing the mode off at the highest priority, > > when the mode doesn't work. (feedbacked by Johannes Weiner) > > > > Changes from v2: > > 1. Change the condition to stop cache_trim_mode. > > > > From - Stop it if it's at high scan priorities, 0 or 1. > > To - Stop it if it's at high scan priorities, 0 or 1, and > > the mode didn't work in the previous turn. > > > > (feedbacked by Huang Ying) > > > > 2. Change the test result in the commit message after testing > > with the new logic. > > > > Changes from v1: > > 1. Add a comment describing why this change is necessary in code > > and rewrite the commit message with how to reproduce and what > > the result is using vmstat. (feedbacked by Andrew Morton and > > Yu Zhao) > > 2. Change the condition to avoid cache_trim_mode from > > 'sc->priority != 1' to 'sc->priority > 1' to reflect cases > > where the priority goes to zero all the way. (feedbacked by > > Yu Zhao) > > > > --->8--- > > From f811ee583158fd53d0e94d32ce5948fac4b17cfe Mon Sep 17 00:00:00 2001 > > From: Byungchul Park > > Date: Mon, 4 Mar 2024 15:27:37 +0900 > > Subject: [PATCH v6] mm, vmscan: retry kswapd's priority loop with cache_trim_mode off on failure > > > > With cache_trim_mode on, reclaim logic doesn't bother reclaiming anon > > pages. However, it should be more careful to use the mode because it's > > going to prevent anon pages from being reclaimed even if there are a > > huge number of anon pages that are cold and should be reclaimed. Even > > worse, that leads kswapd_failures to reach MAX_RECLAIM_RETRIES and > > stopping kswapd from functioning until direct reclaim eventually works > > to resume kswapd. > > > > So kswapd needs to retry its scan priority loop with cache_trim_mode > > off again if the mode doesn't work for reclaim. > > > > The problematic behavior can be reproduced by: > > > > CONFIG_NUMA_BALANCING enabled > > sysctl_numa_balancing_mode set to NUMA_BALANCING_MEMORY_TIERING > > numa node0 (8GB local memory, 16 CPUs) > > numa node1 (8GB slow tier memory, no CPUs) > > > > Sequence: > > > > 1) echo 3 > /proc/sys/vm/drop_caches > > 2) To emulate the system with full of cold memory in local DRAM, run > > the following dummy program and never touch the region: > > > > mmap(0, 8 * 1024 * 1024 * 1024, PROT_READ | PROT_WRITE, > > MAP_ANONYMOUS | MAP_PRIVATE | MAP_POPULATE, -1, 0); > > > > 3) Run any memory intensive work e.g. XSBench. > > 4) Check if numa balancing is working e.i. promotion/demotion. > > 5) Iterate 1) ~ 4) until numa balancing stops. > > > > With this, you could see that promotion/demotion are not working because > > kswapd has stopped due to ->kswapd_failures >= MAX_RECLAIM_RETRIES. > > > > Interesting vmstat delta's differences between before and after are like: > > > > +-----------------------+-------------------------------+ > > | interesting vmstat | before | after | > > +-----------------------+-------------------------------+ > > | nr_inactive_anon | 321935 | 1664772 | > > | nr_active_anon | 1780700 | 437834 | > > | nr_inactive_file | 30425 | 40882 | > > | nr_active_file | 14961 | 3012 | > > | pgpromote_success | 356 | 1293122 | > > | pgpromote_candidate | 21953245 | 1824148 | > > | pgactivate | 1844523 | 3311907 | > > | pgdeactivate | 50634 | 1554069 | > > | pgfault | 31100294 | 6518806 | > > | pgdemote_kswapd | 30856 | 2230821 | > > | pgscan_kswapd | 1861981 | 7667629 | > > | pgscan_anon | 1822930 | 7610583 | > > | pgscan_file | 39051 | 57046 | > > | pgsteal_anon | 386 | 2192033 | > > | pgsteal_file | 30470 | 38788 | > > | pageoutrun | 30 | 412 | > > | numa_hint_faults | 27418279 | 2875955 | > > | numa_pages_migrated | 356 | 1293122 | > > +-----------------------+-------------------------------+ > > > > Signed-off-by: Byungchul Park > > --- > > mm/vmscan.c | 21 ++++++++++++++++++++- > > 1 file changed, 20 insertions(+), 1 deletion(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index bba207f41b14..6fe45eca7766 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -108,6 +108,12 @@ struct scan_control { > > /* Can folios be swapped as part of reclaim? */ > > unsigned int may_swap:1; > > > > + /* Not allow cache_trim_mode to be turned on as part of reclaim? */ > > + unsigned int no_cache_trim_mode:1; > > + > > + /* Has cache_trim_mode failed at least once? */ > > + unsigned int cache_trim_mode_failed:1; > > + > > /* Proactive reclaim invoked by userspace through memory.reclaim */ > > unsigned int proactive:1; > > > > @@ -2268,7 +2274,8 @@ static void prepare_scan_control(pg_data_t *pgdat, struct scan_control *sc) > > * anonymous pages. > > */ > > file = lruvec_page_state(target_lruvec, NR_INACTIVE_FILE); > > - if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE)) > > + if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE) && > > + !sc->no_cache_trim_mode) > > sc->cache_trim_mode = 1; > > else > > sc->cache_trim_mode = 0; > > @@ -5967,6 +5974,8 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc) > > */ > > if (reclaimable) > > pgdat->kswapd_failures = 0; > > + else if (sc->cache_trim_mode) > > + sc->cache_trim_mode_failed = 1; > > } > > > > /* > > @@ -6898,6 +6907,16 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx) > > sc.priority--; > > } while (sc.priority >= 1); > > > > + /* > > + * Restart only if it went through the priority loop all the way, > > + * but cache_trim_mode didn't work. > > + */ > > + if (!sc.nr_reclaimed && sc.priority < 1 && > > + !sc.no_cache_trim_mode && sc.cache_trim_mode_failed) { > > Can we just use sc.cache_trim_mode (instead of > sc.cache_trim_mode_failed) here? That is, if cache_trim_mode is enabled As Johannes mentioned, within a priority scan, all the numa nodes are scanned each with its own value of cache_trim_mode. So we cannot use cache_trim_mode for that purpose. Byungchul > for priority == 1 and failed to reclaim, we will restart. If this > works, we can avoid to add another flag. > > > + sc.no_cache_trim_mode = 1; > > + goto restart; > > + } > > + > > if (!sc.nr_reclaimed) > > pgdat->kswapd_failures++; > > -- > Best Regards, > Huang, Ying