From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C871C54798 for ; Tue, 5 Mar 2024 10:10:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACE836B00A3; Tue, 5 Mar 2024 05:10:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A307E6B00A4; Tue, 5 Mar 2024 05:10:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85AA36B00A5; Tue, 5 Mar 2024 05:10:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 66C166B00A3 for ; Tue, 5 Mar 2024 05:10:55 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 47C5F140361 for ; Tue, 5 Mar 2024 10:10:55 +0000 (UTC) X-FDA: 81862566870.26.FEF7ADB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 8C6A2160021 for ; Tue, 5 Mar 2024 10:10:53 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="lLU1H/51"; spf=pass (imf08.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709633453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FY7vgKo6Jca0WLesqPwmD6RtTG2/tvxMHgoSjdZ0tEc=; b=2vYymrcIJ5nG4LbtpVFtfNyY9fFJ4hYe63magLeQjDzl//XqbtSlTryn2gtPiXrxj7sBMz p+eN2ALHZ61e55YY0Ua00uOTUfYHNZ4ndwHFUu4xgDGpmk4K0nAm5fwJfDQFWgTJYJo8zn yngh5JMmhYD2HQknt7IYFde1uJdMfnM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709633453; a=rsa-sha256; cv=none; b=Jlfv2rGPn6F9tbIImyC2srz9Of/lsdmFSqfrbZF7sfQa+/R/FACQ1Z9t8n4zCokL61y0J3 FhY0o1YGl2Co4K77+8kbLlZbkJoHhnSO7vJyqcYM3nAWe7XI9UDJqdwCbZNjkdcl1xc5ah iusJ28cxrgfCSLVG6eCXYJem8gHwoKk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="lLU1H/51"; spf=pass (imf08.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9509B61482; Tue, 5 Mar 2024 10:10:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63EEDC433C7; Tue, 5 Mar 2024 10:10:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709633452; bh=1G1yCPEY6/Z8IdXz/ph95WvY99y1zo8FJPxv3Vlatgg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lLU1H/5133cmQIPX5OOkI1K2xyGjdAmAr15A/umM40p24fwHTjDNYeAvYNwu7ERn4 zqZNlsh2r9M2XQIQQQohLHHv1duV6hVnXlgE89VFUVyzcIQyiW5qIKOLpoBUCh5+Jv UsMwNI8kvdGhiHbjAM2LF4ZAHwYj/k1bPluWEu8mu3KV/JbnKTqCpkuJ7mB4n16Z5e 2/8cjXjKTH1oiV5uqMvqlDy8xkm3D7yD82fRYcZDmYLKOLJcXSqOrgrHUsZ84hfe8J bm+jdbW30c2HIeZMkvi+gJAvP1lDdFhrJZOTZJckyo2lo5nJ2BXfuibADjMkQTObFS /1AJ3VDP00ghg== Date: Tue, 5 Mar 2024 11:10:47 +0100 From: Christian Brauner To: Mikulas Patocka Cc: Hugh Dickins , Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] tmpfs: don't interrupt fallocate with EINTR Message-ID: <20240305-zugunsten-busbahnhof-6dc705d80152@brauner> References: <20240305-abgas-tierzucht-1c60219b7839@brauner> <84acfa88-816f-50d7-50a2-92ea7a7db42@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <84acfa88-816f-50d7-50a2-92ea7a7db42@redhat.com> X-Rspamd-Queue-Id: 8C6A2160021 X-Rspam-User: X-Stat-Signature: baz5egd6owpkig93r8i5a4umgfeeyrmk X-Rspamd-Server: rspam03 X-HE-Tag: 1709633453-732807 X-HE-Meta: U2FsdGVkX18QnCBR8pIW0O9BVehkydGwXkL5KSFM277z4FVSBU5FRusDk+pgPbWrVa8MNMogOSUkfyLpAwzqfj562I1yr7E6W9mBBf3ucwMaix7CUnd7Ldb15ye6h/F2EVtaZ98FkfaAEhAp+mReRvj8R8B45qOfGvqpaHngiGnB3fZL+HTe7YN2o3i0TajZcLNgYCvYb+B7BvexEIGSzgMhP8AI8ZwkWvtwDhoE37/XxZPzOVyghzeU6IibMBwXKWyBp2v+vCAjDudCIUKIMuwI6uqvW0mVKjh8kpw9nSa73jCr0pGH7DGU99B6C7KBSrzJvmE4DzzibZv+vkSXIemrZlLCsJjrL2xs53s3PAKc/NBZfnMjYbeaANNss43pWfCkKYP8d5P7l5LNDkDqxh490ZPFeS2AYVF/UuWVT32DHXaB747QRQmTh4H4dLaVlWC7ULutG9oFjZ/YFe90NHtRGcV88JZc7BDk+nTxC/OepIOxyBLUiajCNrAdRrkyFAtHwy0xNMTVGfnzmeDG/F3nobSNHD/Jc84AI8rkaIyZMV7sHok+EWEqiGiDWPK0ibho357p0cguRZdBUiCiFaeKPgFkpNYlquTm8wBK0PSgqzO4+MvbNa4TmDgjzixRsljHZVSL6RfZgEz6CuvxXFt/MHco/cdtIrAQqk4L6AsmujXr3UAmND6QF/JRKJDFRRGPHAsWnC9iH74lZXKfM9gPxUH96PYEVAO+0XsX4YWGYYNvsY4WhYYnaUE5+K4uCmi/KRGZAkgC43gn9dIB4rd1+EDkMrbcsIqw47V+pTTR9YqBVOy+p20XCsssz/J+X0pGX+wmPuxcYhMcCspXjp9CHZkAo+FS4E341EptGXCUzf5HhlWa7j7mXcAgh7eV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 05, 2024 at 10:34:26AM +0100, Mikulas Patocka wrote: > > > On Tue, 5 Mar 2024, Christian Brauner wrote: > > > On Mon, Mar 04, 2024 at 07:43:39PM +0100, Mikulas Patocka wrote: > > > > > > Index: linux-2.6/mm/shmem.c > > > =================================================================== > > > --- linux-2.6.orig/mm/shmem.c 2024-01-18 19:18:31.000000000 +0100 > > > +++ linux-2.6/mm/shmem.c 2024-03-04 19:05:25.000000000 +0100 > > > @@ -3143,7 +3143,7 @@ static long shmem_fallocate(struct file > > > * Good, the fallocate(2) manpage permits EINTR: we may have > > > * been interrupted because we are using up too much memory. > > > */ > > > - if (signal_pending(current)) > > > + if (fatal_signal_pending(current)) > > > > I think that's likely wrong and probably would cause regressions as > > there may be users relying on this? > > ext4 fallocate doesn't return -EINTR. So, userspace code can't rely on it. I'm confused what does this have to do with ext4 since this is about tmpfs. Also note, that fallocate(2) documents EINTR as a valid return value. And fwiw, the manpage also states that "EINTR A signal was caught during execution; see signal(7)." not a "fatal signal". Aside from that. If a user sends SIGUSR1 then with the code as it is now that fallocate call will be interrupted. With your change that SIGUSR1 won't do anything anymore. Instead userspace would need to send SIGKILL. So userspace that uses SIGUSR1 will suddenly hang.