From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C56C48BF6 for ; Mon, 4 Mar 2024 10:49:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 616476B0075; Mon, 4 Mar 2024 05:49:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C5356B0078; Mon, 4 Mar 2024 05:49:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 471956B007B; Mon, 4 Mar 2024 05:49:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3166E6B0075 for ; Mon, 4 Mar 2024 05:49:01 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E2000A094F for ; Mon, 4 Mar 2024 10:49:00 +0000 (UTC) X-FDA: 81859034040.14.8E80D3C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 65CDD2001A for ; Mon, 4 Mar 2024 10:48:59 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=GXfakCda; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709549339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K4ZJCjvqZDnck/c1E7aTttbRFZXCTxCmwxh9nFtHlzY=; b=u4ZQ71UaZ9rCwvXtI1iQmVy4bDAB1s5Qh8bg89NGQSInz8+5a2A7sDXBd+WAMDA1198XZO gxCrb+OabpiOVEC4hJ1as9M4UjgfTxcNvUVXtc6Zfulbbk9lEvL3RFYc6m0L35e1lEunj2 jeHzA83V2C/TGxEFGM7dGYCPZkDZkFA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=GXfakCda; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709549339; a=rsa-sha256; cv=none; b=K3MpuaI+qIXOwThnHVJVqrEuMCgWlv4Gvztr8ejo0p0zgqfst1wPAApCit4s9BhjOw+tRV Pw/I1BL0FjYlGRqgDYDQ4kZrsbAEfzvjLmeLq4yvGj9zJhYBG37P+3ZtC+aTDDR5YeyLM1 h96WsVtw6KVg61ZWkZZscJH/VmBUvUA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5FA6A60E8D; Mon, 4 Mar 2024 10:48:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B83B3C433F1; Mon, 4 Mar 2024 10:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709549338; bh=9CRzSnUxCADHGSf4ROldZkRv1p7amv4W/QBk5HAlgIo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GXfakCdaeON+xoPZzd9ddQQQAOjxak1Wx+/JTj8pSNiQdkFeSDTOa8oJShfagW7cf FyxYBxdUuzaj+2AReqyQSNZJIovulnFyLFwyAlWXV+cattPgu+10STcfSTFc20t9i3 wSnubIqJwumJLQkMt1J5gxwNUe7a2qNY7SPuy+XU= Date: Mon, 4 Mar 2024 11:48:55 +0100 From: Greg KH To: Charan Teja Kalla Cc: Zi Yan , David Hildenbrand , Matthew Wilcox , akpm@linux-foundation.org, vbabka@suse.cz, dhowells@redhat.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, # see patch description , Huang Ying , Naoya Horiguchi Subject: Re: [PATCH] mm/huge_memory: fix swap entry values of tail pages of THP Message-ID: <2024030444-unfreeze-crystal-1ccf@gregkh> References: <845ca78f-913b-4a92-8b40-ff772a7ad333@redhat.com> <30ea073d-0ccf-46e1-954d-e22f5cbf69f7@redhat.com> <1ABD022A-35FC-4A6E-ADAD-36F3D745FB91@nvidia.com> <42be658c-cb13-4001-aae4-8d8275a84038@redhat.com> <07A26237-B17E-4418-9A19-E86F450B9695@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 65CDD2001A X-Stat-Signature: iecpfyswot8oxdp9bqh4c6qpnt7pr1ed X-HE-Tag: 1709549339-645954 X-HE-Meta: U2FsdGVkX1+pLw2CP3HjRDwKlTnjKi1/QD9cauWVMqW80tZwD5fh3GtTqARGUk5D+48u+qccJy3SHXKgjz9iizYhx2V1hDt3poXIRTwbbMMRGHCaxrM6RCnSrIMJ0sAKO6sG9O8mKWhtda6BA4bDrQHVloaElAnOcetqTEq7XuDrONebD43MGZ+WQe23p+LoVk4JOaOzzsEpY9bTKE/MoyE1gkod8hF/17rAQ7IcneqQ5zJjsrAGkhpKoTHnhxiq0IuTNiaWj0MchWMZhHW6EjmU4tFss+kQErjWkB6kPfN4BMxgj2M0bHES9XnQXcNRIw2Ft1LtUfndB4rU1+1u8xFQG9jS3iJSWr+x+X/69JJpGhNNN9hoq5G8RpTOvyQtkCPRPRQ8agXLMHG/bqB6/Ug7jIprJI7s1ifMBraQvd4eEt3//WVYoagj/S95DcjkDMNu0Mhydg4tEuO3NsoqdGzEfPSh5YNwibPcxbtKtJa/AThOFrZia65Q/ReoIMPZaB3xWdzbscJNcLj/paDZ44BWNNdXCOBuU7L3Vk89vCFOEG1h1X4xwjqHxNspyfkDlRDxfYFta78PnYFQ8pn67mJTapdBx1gZtyfTvMaK369nqW4oQ2TwZ/Wj0lSirbAgOBAlaoy8oPpeeELWJd0i2N+dZh8VJcH2j4fb8ETW9y/fuUIqdevjEk4faq/jf8wb8Darss+AvbCKV+HOYYBIkzl53bpzt6npjEUPlmO0gsMLzMAofJrsJ+esqlnPQK0X54pgdvK6lxbl1S05UxnrVYSr4IwiRBAPvFb5AxrQNOuMG8aAAd/IWtURq545m8MRJGSUs4YLVsZrr1FPmYa12F8+2f7uBvuuDc3gxQst8fCKfUDjMfMQAMYI21PlzKPF/rA6azFkliHFu+4YQaH06WO4W12UF+5QVIDdPDts3DhFvFSKEFjNpdpLlfeVqqCnmTOCqj938Mt3zh6ZYVP uiA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 28, 2024 at 09:06:19PM +0530, Charan Teja Kalla wrote: > Thanks David/Zi Yan, > > On 2/27/2024 9:45 PM, Zi Yan wrote: > > So likely we'd have to fix the stable kernels: > > > > 4.19 > > 5.4 > > 5.10 > > 5.15 > > 6.1 > > > > That's a lot of pre-folio code. A backport of my series likely won't really make any sense. > > So, I assume this is a consensus to have stable-only fix for this issue. > > > > > For v6.1, the fix would like below? > > > > diff --git a/mm/migrate.c b/mm/migrate.c > > index c93dd6a31c31..c5968021fde0 100644 > > --- a/mm/migrate.c > > +++ b/mm/migrate.c > > @@ -423,8 +423,12 @@ int folio_migrate_mapping(struct address_space *mapping, > > if (folio_test_swapbacked(folio)) { > > __folio_set_swapbacked(newfolio); > > if (folio_test_swapcache(folio)) { > > + int i; > > + > > folio_set_swapcache(newfolio); > > - newfolio->private = folio_get_private(folio); > > + for (i = 0; i < nr; i++) > > + set_page_private(folio_page(newfolio, i), > > + page_private(folio_page(folio, i))); > > } > > entries = nr; > > } else { > > Similar to this is what we had tested[1] internally and observed no issues. > > Can this be taken to 6.1, please? Someone needs to submit it properly and get it reviewed by the relevent maintainers. thanks, greg k-h