From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B156C48BF6 for ; Mon, 4 Mar 2024 22:16:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 978446B0082; Mon, 4 Mar 2024 17:16:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 927FD6B0088; Mon, 4 Mar 2024 17:16:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EF966B008A; Mon, 4 Mar 2024 17:16:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6F6C66B0082 for ; Mon, 4 Mar 2024 17:16:58 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 416AE1402DE for ; Mon, 4 Mar 2024 22:16:58 +0000 (UTC) X-FDA: 81860767716.27.1FDF8A2 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf22.hostedemail.com (Postfix) with ESMTP id 57170C000A for ; Mon, 4 Mar 2024 22:16:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="gO//cuMW"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of ebiggers@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=ebiggers@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709590616; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JBtZ3OmHSgfPNwmgIx/oEH2RUzgwVFTaohfToZaumF8=; b=vc1a3kchMqzLbE0cSax57dKG8mjCgGtLeNjp6PgF5utVsV+YTz+ACq7kg9q8MYjAxQ2lp3 LagW+s/SP7fIojwv9frtEOi7Or9vPSFtfz7wWydkbOYQ/YT7DAMM1l5+ZrfF+9J1E/8nFP THb5Ewgq7EpgNk5FlUpRpHxHSIUjkuU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="gO//cuMW"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of ebiggers@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=ebiggers@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709590616; a=rsa-sha256; cv=none; b=HTI2ZYDg2XuQE9opNOlyt8wM4ACCSc6IWqIVxixm4pf344IwpRIQPLWSd0kvy+28b/9qc7 EGsDD2KX4WFI0x3irooX9NzAPs0M8bP20Mtms+nUDmyXIjpwRYiqMWODbWwgawSWVQaaDr Sre1ZBWwv/YQDbrpFzsolWhjs0SgF9A= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 652CECE178E; Mon, 4 Mar 2024 22:16:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C956C433C7; Mon, 4 Mar 2024 22:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709590610; bh=oMSW/l9lKinrJpplamNpwDg1l6Mk3deCCLXQTPl4Ew8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gO//cuMWvYrQDHWFKIz6ScWuPTxyaJMFL/e9iiHrsWfSyTgfmlagTGS08AN/ddNgJ 0X5/udRKi0nY7KKQos4k4Udc4VJLeFNscvXTHkWZaCqCSWq1nbj4y63IPRmKDp5pq2 RumO4j13a3ItcPFEUNAcx7SggcO9xRNXE6jMoM8rSu6aDEUEUdpLY2LJzw74JteThe so0bK4avvz0DoVQQ4E8BbBECxh3ia2UTz1Z+Pnl78cQG8CKqwKutmzZtpQ7fOFf1ff oRoIXYFVan0Mt7HLYc7meTHjayf03NL9hBGQkA/Vq9l+IaljmkonxBHlusdY0sFvw7 0B7AWi1Bni51w== Date: Mon, 4 Mar 2024 14:16:48 -0800 From: Eric Biggers To: Kees Cook Cc: Vlastimil Babka , Christian Brauner , Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org, "GONG, Ruiqi" , Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 3/4] xattr: Use dedicated slab buckets for setxattr() Message-ID: <20240304221648.GA17145@sol.localdomain> References: <20240304184252.work.496-kees@kernel.org> <20240304184933.3672759-3-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304184933.3672759-3-keescook@chromium.org> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 57170C000A X-Stat-Signature: dt81d1jejo733s8q9r9twun8kcoo5ie8 X-Rspam-User: X-HE-Tag: 1709590615-305616 X-HE-Meta: U2FsdGVkX1/3/tg64Isk/SsqIBt8mgY20WVSTCQQzCI2J4O8t9DwQI1JC34v5EvGdfw8uqPbFLCxcAltCbrwFv9sZEUswp6sInyIDFN/oVC5CgO+5YvuPqK2YdPHa6UzXMbwKLmNzAVqGOjNdzYY14/LZwCSc8cBkJD8c9Ndu6mc3zfdEau/R3sgfEf+7tT3GKwLG/gzAVQOB8wd9zTRFZupv9yYAQX7RZHUYASBWiFPV8cOtVIyPpE6kTwD4+sejvV40ai7k9Y3x6EVUnPzCBRejx7ml6Abx9JVl4dYhedi/GCoRJCzUv+KvljDwox38BZre82QqJDVjyCC0fPBxH5lUQbkveAFIJYWOSuiAatDFzyNVFs+oNsIBj1ER7smzHflnqW5TW15rxPp8jKiiTOaGM3blMSMM+5BFzYTjTEp0S6nqhU+W8anCxidYUEWr27IKmTnh5jMAD8PT1jb/bl9AfDDJmegE0cgrXI8e08O7FcyOoVeDhjazCds5m74epcR0Imv1irUg1Y0s+YhhPsz4h+1AYxdEpRkm55IHCZcg/4BEcNsyDql7fXq2vLkGSjIqRexbVDeEU+hZ3svR3C63459tO2nHgDK0/fMcdCKLZe5aU+xIsey+jzCfrQ1Pqp4fE/SZ+sCuxVo6CZ8FDZgO+7D1w/yHUXoCq5J/RvTbekVxccLaF6BCP1VPBLQbhMQ5KV75pBZdESVtlYT+JSRQnJEwKCKEbMHNbquY/oXIq+giVG4j5mtGaKAaOpqN9WUDP2HKqNmWLZiSS6JqRj+Xd5nVdANiBmiiWr0YFtwjNDz8HiLwCQ08gvPvIFrGdb5B+CJjg4tMiAPBqv9N82kKnCIGrqsm2q+ZBqL3/t4CEIuPSTPgTMxmy4HaSCBSbmvXVf4T9r+nau7KMyVDxNyjOCJVaqEAt0uoEK2Jr8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 04, 2024 at 10:49:31AM -0800, Kees Cook wrote: > xattr: Use dedicated slab buckets for setxattr() This patch actually changes listxattr(), not setxattr(). getxattr(), setxattr(), and listxattr() all allocate a user controlled size. Perhaps you meant to change all three? What is special about listxattr() (or setxattr() if you actually meant to change that one)? - Eric