From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC1EC48BF6 for ; Tue, 5 Mar 2024 00:49:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97F776B007D; Mon, 4 Mar 2024 19:49:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92DAB6B007E; Mon, 4 Mar 2024 19:49:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F52F6B0080; Mon, 4 Mar 2024 19:49:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6E17E6B007D for ; Mon, 4 Mar 2024 19:49:46 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2D602140DA9 for ; Tue, 5 Mar 2024 00:49:46 +0000 (UTC) X-FDA: 81861152772.06.8B1AA8F Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 8036E40018 for ; Tue, 5 Mar 2024 00:49:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=bB0ITiRy; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf27.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709599783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pLTHWOpwORAA/6xhkm7gAcsqrhyIQwakuqBmkuchlIE=; b=i/tgmqS35O44UbJKk15Yyj8SYPPYrdFB2QKZoLCSH3UdGqgz6QFS/7K7e8v9QPs6o8ubzd NIPOBlMiMoXWhzSm4t5q3T9i4ayjWpmC8umKeH2fUkXPyosMuc/sYEPGXVRW8+l3m3CAwc 1yUBRnoFlhW4g1o3An/LZxSjP/KeIpc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=bB0ITiRy; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf27.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709599783; a=rsa-sha256; cv=none; b=15GttSvT3DaMeZ4OT7429PhTEKxId3azsPhAq43BLxyalMMljGoO/da4iUi/7et9CNPz9P cekbJwlKVRBCZ7L9FQB0dliEHoI3JdacXIKHKpvH7+JSxMnBSS27gIq4iMnpEI45J/0boC j0qKYQ5cRIQ1ylwOnaAggXRmB/vqoD0= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1dbd32cff0bso43184605ad.0 for ; Mon, 04 Mar 2024 16:49:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709599782; x=1710204582; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pLTHWOpwORAA/6xhkm7gAcsqrhyIQwakuqBmkuchlIE=; b=bB0ITiRyz6i2ekrj44wVWJGPydnXCVWvXz7wcIqW1pR8W4OMPLeJQoXSY49RDhu8XS sXoSRMG/Kp3ZB95+JLnINf/ZhqiPP4n0FJ9kVLfZAF1ZVsSHqCa3WR/ZNUQEKch/2nmg EsCoe21+3rWTVguNfO8psUuErPFoB5r/LLpEw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709599782; x=1710204582; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pLTHWOpwORAA/6xhkm7gAcsqrhyIQwakuqBmkuchlIE=; b=UHqqj0SsiwMuDwnRZXgVP5pbBkgQU9m0UdPeBjBM/8VNM8tsO4ZmjXhhH0y/gRNM7y DlQMdbyb2w0FNW9Z+Dj4VfXVoTqFzWVD2IvPS/7iBBrDODauF2Q7xmQcT4QAnO3Saeu/ HZuGHDFyEa5+JaaFQqr/OZVFiCfVCzNkgBub6LS25/jWuw05efLvbbtRwsISidlUUNgf 8Cg6GSirn9XqvBsb4rrfJE4mwSwHx33FmWy1wkMt1kuow4ArFCcR6jZyKpNa9vpnquF8 RTdg/RU5EpHlNAL6IZ+MXkxe+KzcvQA+TdSe89ZbGSpiSwPAJ+w+4UtK8Oasse7+/Ph6 QPxQ== X-Forwarded-Encrypted: i=1; AJvYcCVb45WzymH2zcr5w02i3Uq1RNSh0FTL1688SfD66YvI8F+cU92wbXOfDJxdu7GuPyStCIzg9YP+IQ4mT9ogEcXqdoc= X-Gm-Message-State: AOJu0YxgcQfp5a/qYrASpx85mVWbb4WFbS8r2ZM5lE6GqG0a4cRFHASY LVtf5mql2MFuiu51UTfZ6z4MToLaOlYTV5vjgrWYrP3UcQFYnQQcul52T/KdJQ== X-Google-Smtp-Source: AGHT+IG+PWHRb3lwWh5ITo9aPOQFlQpXHSOSLQf9cGB4/pQxqAA6tAd8JXNzvJhOfi9TgaJTI+9rJw== X-Received: by 2002:a17:902:6544:b0:1dc:7890:72d6 with SMTP id d4-20020a170902654400b001dc789072d6mr369728pln.22.1709599782309; Mon, 04 Mar 2024 16:49:42 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id q17-20020a170902e31100b001dbcf653017sm9156081plc.289.2024.03.04.16.49.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 16:49:41 -0800 (PST) Date: Mon, 4 Mar 2024 16:49:41 -0800 From: Kees Cook To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, Mark Brown , ivan.orlov0322@gmail.com, perex@perex.cz, tiwai@suse.com, shuah@kernel.org, jglisse@redhat.com, akpm@linux-foundation.org, linux-sound@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next] selftests: avoid using SKIP(exit()) in harness fixure setup Message-ID: <202403041649.51EDC22DD@keescook> References: <20240304233621.646054-1-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304233621.646054-1-kuba@kernel.org> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8036E40018 X-Stat-Signature: 79yn8exbshgkxmzijjgwwq76i4feky3o X-Rspam-User: X-HE-Tag: 1709599783-914664 X-HE-Meta: U2FsdGVkX1+uAZ13dBfQWwUu1CYEYO/Ip3txt4+qXWFr+2SuqHJWdrmckzhwEqw1AEkdPuVwHnDP//RFPKpYedfKgl06PK7kIEued1eI36jNfrZ/VOUMV//ojyzWJhSAWnPJm4OZ2TV9wYGfmKXpkz238LCpZDncT30nH7YpsGzXbQklDf53y8WfGaYA9WeJUqZfp+6NRuPMn6bUjvh/+OSwE1B+YlYPkFiQWHvrQNEFT/At9T5hBhNQU01I1+88mvGQQMgwYaOHZ5lyw8s03Jlr9ojRJlfL/qB0GFceBiRP51L0E5XmBeQg2ti7CG2FXDhXsq62eM67UWhOZSW14VDtSEDIfeLt1SpM+QpCmo4KKNPeymZZCUQ9qdY0nbllOcEzR8gOhXbtGuJ9yprjggwtMCPLto0vRy+2Bn0X1ZcMamGcH2xDtMf2Ah66rVSzvvNOgUc5jQLCNZ4GBKyEs2iXieK+PhOJKCzUHltGlB9MBlY3yIGcsFXg0mbzE4JCcmasDGMg5W0VSiAs1tP8H0CBLQqZ19Cqt1PCqwBUTpn+V30+pVWsVHAohsVKoe9Zmds4kuvhnFO28Iul4L5+wtwNjON2tUwajQOcKsW0QL0tLU49wkJJ2KkzRSF99hgUaatDsfsuywYE102T6uVAYsLmInOYWTDABxEu+YwZcEHWmCG2SRvkbscZbgg1LVIbWlzouyPxKBw2NJJ2yCt7HE0XjKxmZR1/VFZyGNn0hBI2sRMDkcXygddlewf8BIcOpzVh2gIs6qUeWLo3Mzj+rMTGwPQJfhiADgvoo2NKyMew6tCj/EJ8lh2jN+QlZ6amLP+REd7In0CIaT/RscChliKTLtNxjYM86MEzxOusY4K8Xe8NNwJO6zJZdUrbcZY1wC953AJN1joZ+HE8m2w+69sX97QV2fQRAYt3GvCjXw2pznoZ+wMMueJwCfKDNH0H+H+CfLhdnZJ+ufrjBIC j2lQJWmi 0f1P+xOMQ0hH20ptjjgqBEAQ9yqjuI3otg5VaEhkV0liVIWvkyV53zFXlwN1Gd8DnCHVIt3cSppegPIu/cVBT1mqIPVPTNVOZPL/l9As/DN3UXR5FRjfHXjOU+xw1f0nD8s4lerHfdSIBVpggPRWvel8W6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 04, 2024 at 03:36:20PM -0800, Jakub Kicinski wrote: > selftest harness uses various exit codes to signal test > results. Avoid calling exit() directly, otherwise tests > may get broken by harness refactoring (like the commit > under Fixes). SKIP() will instruct the harness that the > test shouldn't run, it used to not be the case, but that > has been fixed. So just return, no need to exit. > > Note that for hmm-tests this actually changes the result > from pass to skip. Which seems fair, the test is skipped, > after all. > > Reported-by: Mark Brown > Link: https://lore.kernel.org/all/05f7bf89-04a5-4b65-bf59-c19456aeb1f0@sirena.org.uk > Fixes: a724707976b0 ("selftests: kselftest_harness: use KSFT_* exit codes") > Signed-off-by: Jakub Kicinski Reviewed-by: Kees Cook -- Kees Cook