From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E59BC48BF6 for ; Mon, 4 Mar 2024 23:03:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAA476B0081; Mon, 4 Mar 2024 18:03:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E584E6B0083; Mon, 4 Mar 2024 18:03:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF92F6B0088; Mon, 4 Mar 2024 18:03:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BA2546B0081 for ; Mon, 4 Mar 2024 18:03:21 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8F485A01A6 for ; Mon, 4 Mar 2024 23:03:21 +0000 (UTC) X-FDA: 81860884602.24.DA23D10 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf22.hostedemail.com (Postfix) with ESMTP id AAFBBC0025 for ; Mon, 4 Mar 2024 23:03:19 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Pz4Yju6b; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.176 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709593399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zra570GFR/pjaJOF7w0ZjlWxu8eCrPVL1ueeZxNYpzs=; b=RZ5xDsHptJ3nmkG95C9VqzciINnOeHyG9c3+CwWm2AbDRxY/gNxPii2mYjscUTdqXS17NQ jv52h3CTNPafw2efRV+BK7PEC5Qg/zVyq1TWrEsx2hqt/S6RSDYn2tXj3hnsOQwo58l1gp 6M4WfwoiOpP4cYEs4j162lxzzoJRZfw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709593399; a=rsa-sha256; cv=none; b=pdcjRWuf3iRyrqjnFNEywusu06H5yEvxgRFhPHIs9Kc0cABlJztVPVbGSnDK7tfuQVLzrm cKWmgElGJ9RlRCpE2t8izC1C0vNwWJWUvYVJRExCyTaNc76oFER07FvaHW8KcdcCJ4u6Yy WV8jXORjIzixn2oLnID8yoRn1bRHv74= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Pz4Yju6b; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.176 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1dba177c596so31278235ad.0 for ; Mon, 04 Mar 2024 15:03:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709593398; x=1710198198; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Zra570GFR/pjaJOF7w0ZjlWxu8eCrPVL1ueeZxNYpzs=; b=Pz4Yju6bybtmc/hn5r8uR4e3TLotg8HtUTZQfXgOxSZITBu933EY1WiUDicMrNri8z iUcZlHPwdANu5yFw4UiBgYK47yVDK1czcY80NgpBxDo0cVQro5y8vmn41IkOCEGK5zqX BWuBCao5WRtdkNUUKneByWdFweSuBBSD4vNVE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709593398; x=1710198198; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Zra570GFR/pjaJOF7w0ZjlWxu8eCrPVL1ueeZxNYpzs=; b=XnftmLouIsBwVlHUB5p3bFfnHkRpIwGfHFFsvCvcvv56U6GQi4ulqqJtxxUESJelmn P+H0pDS0VVjU3yj2SJo30FDOvZwxBZ6dzCF604A5EtAGzjLtm+PAeT9jaGBXj6F10KTZ 3SilRZ3Ls2+Qps6IXZrosIUlKKtGwhE1S2MDx6+UFAH/AdX+QCS/jmjW9HwiR0BTCmaH sM4GQaG23i2fnOylOokXOtX5X6Bp2LiChH1Tdosnw+lUeNnOJvpIj9Lx+Po9mXxBIRjT cEeXgSMsPF4CWBEjn7i5m2blo/02zX5XWYaZykljUjnVUCWyiO/+Pb8gExSqB3kfBt1l /U2w== X-Forwarded-Encrypted: i=1; AJvYcCWA/ln1WUPSRzZfYf2H0XInHppifXSgFIADpZtWvAxW9dsEOA/2GNGfL3ESUemAf+DCXrCQ4smHnDIE6xB367Tb0EU= X-Gm-Message-State: AOJu0YxlZb/06DYzgLXMCscxSU55YAk2LnLwmB03+l7rPaizDlz+M/2b h473+j6NWP26G731dtUIR+rDNingUaPAnDwjpARpNyXVc8QFbdeGETMa3aZSrw== X-Google-Smtp-Source: AGHT+IHsjDW+/7Ivd2i5nhU9uSJtEYy1nZXqKX/92Fray8kBkmWVSPGumJAavlMlS3tPeIDd5jdokQ== X-Received: by 2002:a17:902:ec8f:b0:1dc:fc84:198 with SMTP id x15-20020a170902ec8f00b001dcfc840198mr231857plg.29.1709593398024; Mon, 04 Mar 2024 15:03:18 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id o12-20020a170902d4cc00b001dc9422891esm9060623plg.30.2024.03.04.15.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 15:03:17 -0800 (PST) Date: Mon, 4 Mar 2024 15:03:16 -0800 From: Kees Cook To: Eric Biggers Cc: Vlastimil Babka , Christian Brauner , Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org, "GONG, Ruiqi" , Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 3/4] xattr: Use dedicated slab buckets for setxattr() Message-ID: <202403041502.28477148C0@keescook> References: <20240304184252.work.496-kees@kernel.org> <20240304184933.3672759-3-keescook@chromium.org> <20240304221648.GA17145@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304221648.GA17145@sol.localdomain> X-Rspamd-Queue-Id: AAFBBC0025 X-Rspam-User: X-Stat-Signature: stdks3n35ft569awaqfgm1k5fmpzdygf X-Rspamd-Server: rspam03 X-HE-Tag: 1709593399-776181 X-HE-Meta: U2FsdGVkX1+Z9+XgLb/drQWxcpdHuqv9DdI3afy5UnlZWHLQT/t2+MydpjQL6Oq7IAXf/9xPCRUXbIw0ZZyD4ibLo2h94XtPfBwJxac5Bj59dsBvWMF7IuxLdcI1BgnXpo6oTY+hQaQAFJSDqy/JFBd7R89cU6B7kRYjr77WvOiqooWkZy9/wOiVx+3X5EvILJNpl7Ddhh/bsqtRTZCEADoTOY7G7HVszdZrdlSZEAE1onYgbwJxFbdPxhzYBnK8lemwMAwDAx0ie6yBXUygPfsjh8He7rhphBNQOqNapBu7QFtf+XYmONLTNzdUeCqkaH1U5azkXZKCGyJq9c5nmTgZDG4B/zDjvov8/0k+jqXZpzJsaAKYBSop1ZnirApTIJvFCuTR2BBCUsfUZaFOHnA4sytmm1K4MoEGKgiTCIsOQp52Ip2S2htLtQtCIg/4z0Hux5OMrcaW6ZJKSVx44R9Pr9xRgoArvIR4QLkh9o6SFsiFBO6wk/+MgOjvNDN+gP5ebFAePeWsXRon5HassI7ssqPPODjQN4PdZoAELckiSXh/ue+JzwKbPzvffYJGFifyZqmmlyB2/73yFEZ94btZviP58ZHt+wvortpLgy2aAMplydfSe6L/QosETuuvq+pw3bsoWgvlOUB6kLM0a86QS10lHXxZKHPkSYf4hcxwfuCQrUI2ZhsB+Jk/aDuLL48TD+wyp+ihf2z2B0P7P/7ZzAz+FaIzbn7fv/Iy4liZ7A0rJRUblE66rKePzvdKde3ERa00h5uhCnMMXNzXEGo4x46RWyKKpoYBczD/PdxBe+8HE8pyWlKD7gXtMDeAH0ElIbystXw8jh4YjqNzmskYNuP/rloEpHcj2/BFj2nLjOvlKuBF1hOGqUwU2Bqu3HPerTfu9ovuKNIs56OBDdiUySaWf0KRyyjza7WsG6quGMwo0dWXtGmfOp72hG71m6Ti9zGsGztzjaEXvp/ bOGzh5Ld bt2DgBAYndZs7YLqwu89oG4JE7076DxGdW7LBDTLd/0uPd9Vy2YTQvAaxEL+utdvr9c7YSUWV3EpxM+Oszck+DEuxoyH5mohN9Z22UdQWH+f79h5wY2SeKi1QqvCnJPIrU7bwwoKa01JjBo+eivc7MweVZ2vFCcJo/8LQaJeiTMmEVeVqqTNNmxsys6RP8d/fivaLiwYJbMFULEkoiaZ1IPtTGnZ4o9C5P3ZPsx13Zv0gIyaiOzTTqbB/j3mAvtjFhNy0svxPrh93mXAb6/OZ/3HvVRGglh1QGZ1llSnukM6Elq/r58lxNPXh4eGtkrZ6f7uCgsEs7fHjX/M3oX20+9rU1HWcGzcSTtQPwRhz6T+bFpVVX/0aIJXXlvbipgplhGcr2mafNi6nZIOCZetzWCX03XP8dDDhe1W/EZU+e6X0p9g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 04, 2024 at 02:16:48PM -0800, Eric Biggers wrote: > On Mon, Mar 04, 2024 at 10:49:31AM -0800, Kees Cook wrote: > > xattr: Use dedicated slab buckets for setxattr() > > This patch actually changes listxattr(), not setxattr(). > > getxattr(), setxattr(), and listxattr() all allocate a user controlled size. > Perhaps you meant to change all three? What is special about listxattr() (or > setxattr() if you actually meant to change that one)? Whoops. Yes, I did one and stopped. :P I'll fix it up in v2. -- Kees Cook