From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 544E2C54E41 for ; Mon, 4 Mar 2024 13:03:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D82476B006E; Mon, 4 Mar 2024 08:03:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D0A636B007E; Mon, 4 Mar 2024 08:03:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0EB46B008A; Mon, 4 Mar 2024 08:03:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9E68E6B006E for ; Mon, 4 Mar 2024 08:03:46 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 72612160A7C for ; Mon, 4 Mar 2024 13:03:46 +0000 (UTC) X-FDA: 81859373652.25.F709AA3 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2042.outbound.protection.outlook.com [40.107.243.42]) by imf24.hostedemail.com (Postfix) with ESMTP id A9AC9180008 for ; Mon, 4 Mar 2024 13:03:43 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="VCxR5Y/J"; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf24.hostedemail.com: domain of jgg@nvidia.com designates 40.107.243.42 as permitted sender) smtp.mailfrom=jgg@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709557423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z4IrSclbt7V4Ji+rXWfqz5p8s0mDeK8V8fu4Ky+noFI=; b=74tjgVR8OSaehWsKYhS4cmPZZ9wUwjb4n5HYmb8nN2NmA1lVegM/QXV1A4FjCyS+fw06kr 1BXf3d9e2MAdevncLchGmj1lbkEmR4bBPgL9CPuf7LqDVaaaYmZwvz7Gbuh0c8j5miaBRH k9f52MHmbbf0JF/BUeYdou516anIKik= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="VCxR5Y/J"; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf24.hostedemail.com: domain of jgg@nvidia.com designates 40.107.243.42 as permitted sender) smtp.mailfrom=jgg@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1709557423; a=rsa-sha256; cv=pass; b=mi1mKWXqG/75/lT0XGci1+XXTKVVMOKiWzZCgBv1Z008X40/NeHJIIkxdSLIfy3QeG0lCH pEPEAHMJL7RdpUsgYJCP94umWB9Air3rFSRabnBkwjHZxAWZwXuLIk+2fryBvN7yNtMQJV n6PiiDaoM1ABxASc5DQXMprVBQj0rkw= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CMh68gUkXq63PXVzu50dlauXQw2cZ41eGfTBGk+jfNvIUGKu2g6urjzY5xNSeujFoQJWBFWIjLZVeAyshUVJUKIOq8AHpZUi7Rzyk1WVbZyKtIsc1eeldYO92bBI0jE4I1Ar/GhF1jeOswMt7wHvON7otxrNtlWtrN+t6Nh9iI4H86k8NbMjQqV2StzdLen3XO95MPZdfA+1lqnQhcIfV3lFhcUcyt5i+GG674z5nSsa5y+3Ccp6HFdGz7hRSpOA6t1A/EkYcuz0MEzWiAhPVZKSwybjy6lG4xbwt04Z8bnoXwErxchWzLaMgFLe3En6BXieDz9KR8J/CHQh8Nc8Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z4IrSclbt7V4Ji+rXWfqz5p8s0mDeK8V8fu4Ky+noFI=; b=LuSIgHINnSsVXrPFDYIaoex6mdVuWf7GzqRbwbwfUJNFixXcnB5cJL7EHN2vI03vivbEMjzwS+qAqHdpW/RlWUNPQFD8YijVI5jYTIdxWuHpmLss++fqh1cvTL7lRjKLji6EFgv+GKRLyyOtCCgsfxxBu+NqQBzkPNGuaK28nL68snnIYDjTwXIm+RzdYvzpApSpWKh7T1MHP8mXjeKSragjWEGhiKPLkBl+gsfjhePBtCTip91dTefT4YnxzQJD1+QgmTO6JY5IQYlbFaRWn8+hOQyk2PA+q07s2WiWIR8Kwb171QQdDeM8KxjcsTDXlm36rqu5vtqPWjjHeb+VIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z4IrSclbt7V4Ji+rXWfqz5p8s0mDeK8V8fu4Ky+noFI=; b=VCxR5Y/JB1OjAotbYA+xXsAMHLiZYeXDrxVf93w4IOofcJ/sdSWrMM6Jwb92vOKncjOBYQs+bHa2qqkVQx9F7YKQKQUEW3MgAekFCiYMslP3Lf2OGwep84jRQUbLnpYUcAoRX1CU5b3vII8KN6fz9pa+wCc4y9QZCKV0kZFyHvTlzMh0ZZvDs5eu2yiIN5LoXfSGNACOn1ah6o7bCkCVdGv2JxRVjal3snNBWdV+FnD4gJIRCbeJ/mMMjkniBsUYnwluDFoTVbGov/8s245rbercMKbL4WmUSnyTrastHaDwbjnO3g8D98EyR9nbufr+FCaaSwgYkX5+nQ68p8V+tw== Received: from DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) by DM4PR12MB6397.namprd12.prod.outlook.com (2603:10b6:8:b4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Mon, 4 Mar 2024 13:03:36 +0000 Received: from DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::c33c:18db:c570:33b3]) by DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::c33c:18db:c570:33b3%5]) with mapi id 15.20.7339.035; Mon, 4 Mar 2024 13:03:36 +0000 Date: Mon, 4 Mar 2024 09:03:34 -0400 From: Jason Gunthorpe To: peterx@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Yang Shi , "Kirill A . Shutemov" , Muchun Song , Andrew Morton , x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Subject: Re: [PATCH v2 4/7] mm/x86: Drop two unnecessary pud_leaf() definitions Message-ID: <20240304130334.GR9179@nvidia.com> References: <20240229084258.599774-1-peterx@redhat.com> <20240229084258.599774-5-peterx@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240229084258.599774-5-peterx@redhat.com> X-ClientProxiedBy: SA9PR13CA0179.namprd13.prod.outlook.com (2603:10b6:806:28::34) To DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3849:EE_|DM4PR12MB6397:EE_ X-MS-Office365-Filtering-Correlation-Id: cb166c61-980c-4b52-f026-08dc3c4b80ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bTjejDyBeHwtqWgmtEykQtgXR1g360JBdIk47PiOLywQA72ecg9qPmkP1bEh2A9+7PqL06vMf1AHpDHXYL8axd2iHCGpbL9wRH/czZqQ5SEmaUswdmXPUsYAmhIj1zQLkO4X7aY1CQ3Nc8k9JdJGhWGcANr9UuoDIvf1rCQo/gBK0jtIOzNZlPLqFts7RJ6x7HQUcXq/CfPtOLz61uI6F3o5373CByGgBHEvO3qmp0qV68Hu7sB5ldKVkb4vAm8gMoXpibChiWtuIJOyWbuh4Rv/uYfOpm4CwoeOz4W/4VKhuXyOsk+gt5ZhN8FsOxcA6wuZlADg0TLZvzd6qKpfWf/z6i5Va0PsLK9sqCQs44KU3CH/vafxk5S1H36pHF36v3roR6avgZW8c6f3OwlwBRJnqeVCP3O2b8E1qjDvHnz0rW42CeBdSyyhM0Ov4KYYFWe8ykldQGaBYHOz9kj9nN46Oll5Nj6hJWNg32xm0E+OJ5uIs0WbWeVpQuFw5JQlI4rsSVpSq3sTJzPx06UQbPbCm/SGK3buX2TGQWOb3oiusBY6ug6IeaMqUKnbysqhDmq5JEVLw/nESEWPSJamD1AYr+5dUqOc/PvbjtTkQrp2+aroHq5Y4Xg1iihXAMAmo88odelNa4iffKABbABAvwjBH5YX/MQMqimvKkUWrN4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Yix7zzUWlmQhIuX1op0uRkhcHilIPZOpgmJnaJ9TIIkB5WMoFXMZxZY0r+fu?= =?us-ascii?Q?NjswBJuFDd4ywTS+FVpz3R2GKCtWkGarK38cl/RakSGlJE0DgLIjerESUdwO?= =?us-ascii?Q?1TrYvvRv0w+66Cna6ZizE4Wojax86v3o9enxY3bW+DrOC3lTkZtGxLWU+YFQ?= =?us-ascii?Q?XnPgHGhsaQqXMOST73ZGesBXA99e6zLskeXLrAZBzoXbJHElQr+p/LhHdpRq?= =?us-ascii?Q?ErARxtZgoYOXHl4wkWEpzoJZk2UD9mhHJDSRGQT/gKnozxa9Vi8j6GZmS34n?= =?us-ascii?Q?MJzbDEpsU+pfji6U/1wJU8wFFTi/YUHc35XCNj1DbPXEkhAMW7qir7AMfRK+?= =?us-ascii?Q?Cyxp7TpHHNuMln8uERlYKJMaIFZXa+JPwqI5QVkq7AcTRSauWE/1nKJCJrRr?= =?us-ascii?Q?CsuE4GEormSic+ojYZSADd/rfvB73Azvp7YOb7abd3OhhGgA5aWcsbdsPS05?= =?us-ascii?Q?aHadnRl+5qA1QdW36WpOOAgCqI4Xz06vuyXVPC88sX4KbkhHSC3dpEszQjXV?= =?us-ascii?Q?RWrGrKfdku/D2742D2Rmcu2UyfwiU2udMM97Azq3B/PXopVJXHFZO00r7l7S?= =?us-ascii?Q?2XpXvOc8saKDxuTrrW/5dXPQEG/l7x5wyZUsgGdj09noSdJNrOPrOT+wDt/n?= =?us-ascii?Q?QfXmorafRDlfkiqU7fqE3wraNq0gnRRqOA97JwSRk7WkwSIi2SHbpSj2d9Rb?= =?us-ascii?Q?EGBbVj3oy4frSLXvbefnDE7f2sHHzLtRVTjyJW7V+jZCDHBJjaomT42wDWGk?= =?us-ascii?Q?GqG//C6unWzIBQILqisy0VWZfQF55PgyYwxijZtOS4Em7VVIqCBtc+YAOWxG?= =?us-ascii?Q?4cFSuMjuGX7s2lh/P674rV6IOb2NPAX3HZDpcb84Qtvbcw+9KnieFhHGHnAf?= =?us-ascii?Q?+pdsWXbPGanyRFeD83rXfs4u27zCiEVFXExdk9Tr64M92bhjvLHjAqrvCSu4?= =?us-ascii?Q?r4KD2kLurls8vO5uXBnHgIh40FMr+sUyYSHE0AdANgZ83vjYgyqB8Bkf1qjZ?= =?us-ascii?Q?Xel69gL/RrjdXmBqQz9ZMkFg+sh9hv/jLi8z6uRZKDztOtbo1RwOXFO3+tk7?= =?us-ascii?Q?Nm/jVSP14uGUxsU5rtVgJQVAXvcUIy26R1tHrec5UV4QrtusSYoEEBM3NYGw?= =?us-ascii?Q?tMJs0RIKElVhshKUIbmLcDW9hZzpJD90i40A47M1hpnhJhtjj0qupQMlCl1D?= =?us-ascii?Q?seHQ+Ktwe3tNR2YASskNOA2hupe3SUjvuSjLiKs2S2buToHtoA4/BTfR3ukv?= =?us-ascii?Q?tmhHmexUDebQKohTp/Gc4qvW+geYgwnRn7Fy2UHH8L2N71YF78QcaBnN0Bw6?= =?us-ascii?Q?Uj1fRPJ4DA3OHPqZ6uRozGcFLoGBG+gpu91inJHxPfdRVOh0j0G8Ul7WqYCl?= =?us-ascii?Q?OJJsXWn8uggCHvg28f5KLzlGvMhQf3GHYEzAq9u2IIg+D96ia8hRdADdkCqX?= =?us-ascii?Q?eZePIkRMKiSO2C0ZZ5y1/n/E1qohh9iqQjfLcXtJlE5CRxJKj53pX1cV0Sd/?= =?us-ascii?Q?SpTzQR2jFLSmrQXWKvBhl0fYZczWF2BictbPhJU511nbFFo+zON2+YCtBjMZ?= =?us-ascii?Q?lCrsEzccSlHZaL3NWf8=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb166c61-980c-4b52-f026-08dc3c4b80ff X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 13:03:36.6990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W+huBfKBTuwXTWWd/f0PxQhar4UJV4imd1/2voIR3aQEF9FvsKr+IjNhpSt4yoH6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6397 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A9AC9180008 X-Stat-Signature: 4ma1konj6pkjbpeed5ys6a5s6gf3nt9z X-Rspam-User: X-HE-Tag: 1709557423-511505 X-HE-Meta: U2FsdGVkX1++9rgqKSrDVxpCJetAGbzLbT1mz13clljP5N85pWZne35q9rvBZANaw82vs2bVnjNgbDLOxdj3ITofB/wSNgCl1vUmrLjOj7WQDd345bZ7mhb710lqXyEMEG5/LuNqZGjMEVFEN7fUpzeeyphLSjD2yH6pr+sHeKXSLnqapBJ0pldQsOMKGexj4nr9yj8ME3aFRLZSeabDxd1ovpqYB6lw+FhvM8WG6h72t179BRKEmI1TDRReLHskXX957o81+uBXhfYCKVwtdlgFVLbgVMLo8IL+5S9/ySac5xakq7FjzFszrGBLiwunW6jBZkB66zw60bCnQXqlAindbk/3lYBuXOu3F3aRG5rOsa9fKbMhqNMvwb5gCpDrDCt/2T71lbyhzTKWRoOR7LRw7EesGP35MLE55lshk1E6vrWEoiw07TOHhNk/3XWJq1D73lmawc/RMKbw2+3+JK0QSrx9vgVAprLHR2270a1ZHVnJwjsE5yC87TJ//Z1mpo/NbN1ecQFkrgMADdJ6ry9rUsbfpvEtB+KiS37UwLYDPLTX+3jqeBMAt2oDifJUIoglGYZq+/Lr9KpzVuT9hWL6RT4LLj/5qK2Zw3QfVseC0YYx1SCY9iEfs6Noht0wS2Bxrlbn528hkSl0QsTa3QX1CB55ijudjMoMNtSN9rwDiflDpqgpeK1OjZqBMCOZjhvVgEpcnoL85NCaLS9i+aZXExF5EfTwpbuzPSRNLhFHSmEQakDi0jJ3mZxBA1+qIsYmzilF2uVvixUO+sNwZ4w5kCfligelZceQS8SNz7k621tcBkzFj+nnCQfEnwesTvFPWNIeMmVBx2n/9AHHYOrY+YYaSBDvDbVmTulVLBW+gQ9+m6n1oadRXTML7w2FS4hzSGh8itj0QlBQBiHQQDiwzff7/yxy+wibH1FA3X8Z8NY9/PIsc/ydKooxGZLAdXXGs42TvVh/PlpbcEg ZGAIkU5J V22jCH6sIX9zxx/zi7U2QLdKt+S2V1Xu/16K99Yk0J0HH7/9iXJdu56FAi2tyFmkvPkEdq6vfDxMtXZHlmxkfzcxxWqK+jkCNNeZj3YNGnRxYEY9r1T6HhX1a4arPHHDf2knxp+9zNJocasEfoJ/V+twucdJvHkHkALea1YxLeYxax+3KjfMGz2SWOWSj9xGqwe4D4piI+vChFttfaoblwy0bBmmUa43vEd05UqV12WLfiwrXsNbOj2ZEH8lBQxfRHRl6esi/EfE3xBwypN0bhTL7bdNjGpH/RJU864u7C23V9OsALoiCp+UlX7kMM9i3amuJxcI5KI5InJ2MO3r2sJgi0HpDK2AWn7hbRy6vi5gonLpeyfX4yrN/I0QXddD7F1uHKiefC97HPuQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 29, 2024 at 04:42:55PM +0800, peterx@redhat.com wrote: > From: Peter Xu > > pud_leaf() has a fallback macro defined in include/linux/pgtable.h already. > Drop the extra two for x86. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Signed-off-by: Peter Xu > --- > arch/x86/include/asm/pgtable.h | 1 - > include/asm-generic/pgtable-nopmd.h | 1 - > 2 files changed, 2 deletions(-) Reviewed-by: Jason Gunthorpe > @@ -31,7 +31,6 @@ static inline int pud_none(pud_t pud) { return 0; } > static inline int pud_bad(pud_t pud) { return 0; } > static inline int pud_present(pud_t pud) { return 1; } > static inline int pud_user(pud_t pud) { return 0; } > -static inline int pud_leaf(pud_t pud) { return 0; } It would be nice to have a final patch making the signatures consistent on all the arch inlines, it should return bool not int. Jason