From: Jason Gunthorpe <jgg@nvidia.com>
To: peterx@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, Yang Shi <shy828301@gmail.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>
Subject: Re: [PATCH v2 2/7] mm/ppc: Replace pXd_is_leaf() with pXd_leaf()
Date: Mon, 4 Mar 2024 08:57:47 -0400 [thread overview]
Message-ID: <20240304125747.GP9179@nvidia.com> (raw)
In-Reply-To: <20240229084258.599774-3-peterx@redhat.com>
On Thu, Feb 29, 2024 at 04:42:53PM +0800, peterx@redhat.com wrote:
> From: Peter Xu <peterx@redhat.com>
>
> They're the same macros underneath. Drop pXd_is_leaf(), instead always use
> pXd_leaf().
>
> At the meantime, instead of renames, drop the pXd_is_leaf() fallback
> definitions directly in arch/powerpc/include/asm/pgtable.h. because similar
> fallback macros for pXd_leaf() are already defined in
> include/linux/pgtable.h.
>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>
> Cc: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
> Cc: linuxppc-dev@lists.ozlabs.org
> Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> arch/powerpc/include/asm/book3s/64/pgtable.h | 10 ++++----
> arch/powerpc/include/asm/pgtable.h | 24 --------------------
> arch/powerpc/kvm/book3s_64_mmu_radix.c | 12 +++++-----
> arch/powerpc/mm/book3s64/radix_pgtable.c | 14 ++++++------
> arch/powerpc/mm/pgtable.c | 6 ++---
> arch/powerpc/mm/pgtable_64.c | 6 ++---
> arch/powerpc/xmon/xmon.c | 6 ++---
> 7 files changed, 26 insertions(+), 52 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2024-03-04 12:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 8:42 [PATCH v2 0/7] mm/treewide: Replace pXd_large() " peterx
2024-02-29 8:42 ` [PATCH v2 1/7] mm/ppc: Define " peterx
2024-03-04 12:56 ` Jason Gunthorpe
2024-02-29 8:42 ` [PATCH v2 2/7] mm/ppc: Replace pXd_is_leaf() " peterx
2024-03-04 12:57 ` Jason Gunthorpe [this message]
2024-02-29 8:42 ` [PATCH v2 3/7] mm/x86: Replace p4d_large() with p4d_leaf() peterx
2024-03-04 12:58 ` Jason Gunthorpe
2024-02-29 8:42 ` [PATCH v2 4/7] mm/x86: Drop two unnecessary pud_leaf() definitions peterx
2024-03-04 13:03 ` Jason Gunthorpe
2024-03-05 3:25 ` Peter Xu
2024-03-04 14:18 ` Thomas Gleixner
2024-02-29 8:42 ` [PATCH v2 5/7] mm/treewide: Replace pmd_large() with pmd_leaf() peterx
2024-03-04 13:09 ` Jason Gunthorpe
2024-02-29 8:42 ` [PATCH v2 6/7] mm/treewide: Replace pud_large() with pud_leaf() peterx
2024-03-04 13:09 ` Jason Gunthorpe
2024-02-29 8:42 ` [PATCH v2 7/7] mm/treewide: Drop pXd_large() peterx
2024-03-04 13:10 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304125747.GP9179@nvidia.com \
--to=jgg@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=muchun.song@linux.dev \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=peterx@redhat.com \
--cc=shy828301@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox