From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1AF4C48BF6 for ; Mon, 4 Mar 2024 20:58:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48A006B0085; Mon, 4 Mar 2024 15:58:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 439CF6B0088; Mon, 4 Mar 2024 15:58:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3013F6B0089; Mon, 4 Mar 2024 15:58:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 217016B0085 for ; Mon, 4 Mar 2024 15:58:20 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EF40C1A08F7 for ; Mon, 4 Mar 2024 20:58:19 +0000 (UTC) X-FDA: 81860569518.27.7952AC8 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf18.hostedemail.com (Postfix) with ESMTP id 455CB1C000E for ; Mon, 4 Mar 2024 20:58:18 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GHPewqpd; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf18.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709585898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MBysldzXTflPzomKWRmSMXhF54SNqFAu7g8kqMxzJW8=; b=jerNaXssNM6lmvXUynw0ADsWjYdmKeDazHnufmiXqfXYkFqVSBJXCDJNH2tNwbtnYSvZm3 Xy05kzBj2RQCH1+TXRjWxTFoDetqazNrsB+52Ki7IBlf2rupjpJyAePSjezOr/eD4FeH2U x0DvP7KGVpdkL4EoeI6X0F+n+c9C//I= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GHPewqpd; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf18.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709585898; a=rsa-sha256; cv=none; b=ujIJIJrC1Z4DbQLBtyXE2a4rnxsxM4/nodg0i7NC/r9zkBeH5n2VDd83Ta4uqjtlvuey5f lubkR+4ynf1mXV3LuwvG38egt3DWetsZC25jhStJe4WQNkovgY1EU3fvW0QP/JDYAomco5 RyBsoXuVymAAb82gCUsPoxVusXtpxN0= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1dcd6a3da83so36466065ad.3 for ; Mon, 04 Mar 2024 12:58:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709585897; x=1710190697; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MBysldzXTflPzomKWRmSMXhF54SNqFAu7g8kqMxzJW8=; b=GHPewqpdBm3Q0EuwjOojb9f98QxXFEc35uYgopRsNZ9OK1d9yvgzCYQi2+WBhXR8IU wh2JZ2R1W4+Jcb3buSEpKR7QOqcPyATDtLLPuhAzTcgNz1opTA5rgC+gmJXt2nDrDG9S 0PyyDsBSaTfrcjCxKuya2zOpZ2iGpkcEryffc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709585897; x=1710190697; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MBysldzXTflPzomKWRmSMXhF54SNqFAu7g8kqMxzJW8=; b=Kvml9VEoQJP/Qdd0E1qulrPWD4h+Q8gWnJRU18I3swtEAOyz8exG/Dz6SWvqJMjoVO 5TBiIsr1GlFNb/jNW3MKiiVO2hdq8TReU2ePyOUSEI78c5Sm66SNoekc1ZiG/lT++ruj S0OWb/7V863quXS8gRF18A69M7dVEyWup6my7MnE8yr9k8k1ak8hnO9YuiYEJoiZDDIO df9R1zbMUcm1S3CMFfhGFxA2FjNnsqt0hlrioj7pK4p26SHpw5J7UhVBcEfA5K17KaSw Abaz/3f+rGIuHhA8+WJdBMO1n3s6WxWHqlSkFflcta06JVcWMFQbrKv7KG39htHPSW2I 9btg== X-Forwarded-Encrypted: i=1; AJvYcCUlh7lQaITdmQJLBcssmXpLc6jqoPfMQzM6WTTiHLFMIoHS97uxcBoFvhTcfVV4mQaPmjw2e07gFUVdVDPpV/b97QA= X-Gm-Message-State: AOJu0YyCa3SuRNbTGUYNCPeXG1qrglPYxXx+cuOpnljbXj+jIlBK+HOm Wd3kVHavRyrDT/ZANrB4OfvrkU0HhM1eG2wEJBTjMKIywGiEPX/hylE3np4Wdw== X-Google-Smtp-Source: AGHT+IHa3YpcV8KFwBIJ1K/azj4a+KW8cW4kPPah4+2gIkxeNC+6+YuYOXOCykzg7xOmrXCDdKZsvA== X-Received: by 2002:a17:902:a3cc:b0:1dc:794e:27b2 with SMTP id q12-20020a170902a3cc00b001dc794e27b2mr10676858plb.56.1709585897109; Mon, 04 Mar 2024 12:58:17 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id jv11-20020a170903058b00b001dc96c5fa13sm8950726plb.295.2024.03.04.12.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 12:58:16 -0800 (PST) Date: Mon, 4 Mar 2024 12:58:15 -0800 From: Kees Cook To: Muhammad Usama Anjum Cc: Eric Biederman , Shuah Khan , kernel@collabora.com, kernel-janitors@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] selftest/exec: conform test to TAP format output Message-ID: <202403041256.80EDE9BA2@keescook> References: <20240304155928.1818928-1-usama.anjum@collabora.com> <20240304155928.1818928-2-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304155928.1818928-2-usama.anjum@collabora.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 455CB1C000E X-Stat-Signature: t9po96i6yi75atjfumwj66zjeagco1zk X-HE-Tag: 1709585898-810063 X-HE-Meta: U2FsdGVkX18lMUyVK5VnmOujrP9FiTaTlTry+cIaOWA4Kstmy6E1UNvw+PXO6r3Fcrk6Wtm6V6A6ryTXgeSlXCxC05IqjlUpNPUeoelpId/p/fOmCof6B4E+LEcrge3zhJr/qub2fIUeaA3DTjnQPtsZgnhzTVi+9lrfqULIO1tTnJJJUHAlhf/5p+RkO3ZRtFN57iN+9RZM0PPl1BtGPcMx7Siq4O7CfJENKGnZgKV9Uj6XSf9jApMF617S2SJSh1SRJyskhAtoWXE+OPyWO6ubqOzuKA+g0ONsOuqaI1TAFbiMBJOWw9SP3ydREJ+/3QvcKwzG5WUWDhsg0WvNp4KKEneWH19WtL0adwIltdyYbvA4Z0EoBcWtCAox6AIW79DtCjOOpy7uoBY+qujAX0CdsYQxTo8vezcn/sJIg/fgZuj+2NiLSliAK1WGZ9nEhXbyZpXMA3LW3WDaEBL58uG75X+FgJNPGeNOMNUIpg4wvvr8VtiebhO8XYK5Ua6FbKzmHw26L5A1QiP/1JeUsp0qb3r/jPdWV0y/UvFnUNEUBX4XgYw2LmwLvxPOm0MRfAzufwR0nQ4oJBikLaGQrmZDy0r9Sgnh8JBjY6TIW+Cagj4Qw7AnzLSW4/GHiYjwDuVpO3TPdcxy5x+umUiWBrpTH3zmGrLQeKFgKctpEG/En5/RlcqZpFQz8VelvdxCMYIBkRpmyNcruKNd0AUawvQbPXccSZ30WBjlc7PkZgdGZtBAtrH2GgycoVtWY5Q4ixUAO+5IgxLTXUUNPSwsr9Ml8f4iMX7sSg8U4v7CSdiG0O/emvgWyC845Ib6A5BPTRbe56lFZ4LvBUHjDvXlu6Ph1eyTnolWsAJciE7pIQN54w2qT+zpFHCKMlJdRmJlo5VG+8FyZ2yhWC2MSPNasbKBowWH3KwqEaLyqkzH89R79C/8xXYyALXCCn+hALHhQ8/SS+w690TT9XnZb5r qXh8JrhD NNal5R2yvbb7txx7TuXR7KyMLppQi/x1UHT2UxtaIn90fkv88sSsZLv1rx2Wu7exGqNzXrcm185B4eaU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 04, 2024 at 08:59:24PM +0500, Muhammad Usama Anjum wrote: > Conform the layout, informational and status messages to TAP. No > functional change is intended other than the layout of output messages. > > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/exec/load_address.c | 34 +++++++++------------ > 1 file changed, 15 insertions(+), 19 deletions(-) > > diff --git a/tools/testing/selftests/exec/load_address.c b/tools/testing/selftests/exec/load_address.c > index d487c2f6a6150..17e3207d34ae7 100644 > --- a/tools/testing/selftests/exec/load_address.c > +++ b/tools/testing/selftests/exec/load_address.c > @@ -5,6 +5,7 @@ > #include > #include > #include > +#include "../kselftest.h" > > struct Statistics { > unsigned long long load_address; > @@ -41,28 +42,23 @@ int main(int argc, char **argv) > unsigned long long misalign; > int ret; > > + ksft_print_header(); > + ksft_set_plan(1); > + > ret = dl_iterate_phdr(ExtractStatistics, &extracted); > - if (ret != 1) { > - fprintf(stderr, "FAILED\n"); > - return 1; > - } > + if (ret != 1) > + ksft_exit_fail_msg("FAILED: dl_iterate_phdr\n"); I'm for this series, but I do note a weird glitch in the ksft API. ksft_exit_fail_msg does: va_start(args, msg); printf("Bail out! "); errno = saved_errno; vprintf(msg, args); va_end(args); "Bail out!" is not very descriptive. I think I'd rather this should be: "FAILED: " and then that added prefix doesn't need to be added everywhere in this patch, nor the "error: " prefix in the next patch. -- Kees Cook