From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9025DC48BF6 for ; Mon, 4 Mar 2024 17:40:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 247E06B007D; Mon, 4 Mar 2024 12:40:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F7EA6B007E; Mon, 4 Mar 2024 12:40:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C0986B0080; Mon, 4 Mar 2024 12:40:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F17046B007D for ; Mon, 4 Mar 2024 12:40:05 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CA3FA1C0D1E for ; Mon, 4 Mar 2024 17:40:05 +0000 (UTC) X-FDA: 81860069970.22.8F3C967 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf11.hostedemail.com (Postfix) with ESMTP id 6F2FC40022 for ; Mon, 4 Mar 2024 17:40:03 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=l+3XL2MG; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709574003; a=rsa-sha256; cv=none; b=HwU2H8f6g7UI5u0PjjlZPBdCJ0GQWAGFjBgKqtIKL6h5F9Mp2fxaFJsHJEeUVzSNJAsrKS qL25QA92OQUJKGpLZ9kVKOiZUKKXxa2OJ4SrUZIxDD8/MphhS4J7WkM7c6bIgjvT4gLuxO cQLjs2vAKAfDY+SQgzSbdGHO3mPpqnw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=l+3XL2MG; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709574003; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RyZsHAo58L7KMnZ/iYkcv6g6DGnJjygri39sflW2A24=; b=gC1NJ2OfO2zEPo2IdOePWLFqbXXNwcByWLgoG+JzdXyGnwu+6DJivyZDZVbliZDbiQ0rY0 49EBzTMaMHhjJ/abxbMI7gLia3FLoMnJNmgE5brg+RrvWxyqvoQLpKy3C5OsDLVm7g5REm jhEzTeTgaqXjTs+07WHSKPxzT5DrgVM= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6e617b39877so1154953b3a.3 for ; Mon, 04 Mar 2024 09:40:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709574002; x=1710178802; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=RyZsHAo58L7KMnZ/iYkcv6g6DGnJjygri39sflW2A24=; b=l+3XL2MGgIll/pI4US2i3AUflZz8SIS+/tVugmsK2IkfOLt0C+wxM+H/rbjLnocMU4 gJUnGuCawk6htg88SCidweZyoZDUwhuG6Hpel8qhHve0jNZdFM5rPuRI+wmuHXXdBMFF LKvwVsgbvuNrAm3qNa9feBlsqVOCodPojKtGc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709574002; x=1710178802; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RyZsHAo58L7KMnZ/iYkcv6g6DGnJjygri39sflW2A24=; b=cgyARIvy0xrhUuGjOsa8nnQiUxrlN3MapG3VIXNskW4+AB0vXbSE0ahjwHYe9iBOha yIIMRovhc++9SrRxIOqX6KSkkKMb/+noCqTtO77Voaf4PyXelrgJYjBmXhFlGZe9khYr NG418rE0nDtoLaHwwGrExYLI7Vs9U7TIm6trp83y+TEU787Ssm+Zs3OuDlJhqiZObO7m 1pG14MGxRJpZtwCsffNtjQzgu1fhlT0gjU9/U14c2sTChpXJusM8xJ8IachvTSjzEZtl BANiT8lnKCOVyJXuaZ+9NJgEtB5CQaz2vKY/0fqjNXuzPpX+krjwv8Z3ou/DjNHde8/I SA9w== X-Forwarded-Encrypted: i=1; AJvYcCVeT3ezFOVkyJIuJxa1/jEeLYy45YUgH7xtqh7m8uhWk9/zH59o81a+Kel9YAqowMGRqZGf1Tarq7ZDO1yi8od1fPU= X-Gm-Message-State: AOJu0Yxi+wqK0XWqKugwnFGDuQjrqj+Z6J6YpxSIbH5EKYVpxUgS94+9 V63+9FfXArmGX7XmraN7PSXIfUQLuJRBLOfNMWmJZqTRMmV2z88yb0k6hgCX3Q== X-Google-Smtp-Source: AGHT+IGQ7bchTfFmOCc/+mlkhCkqHxq4az+ZQyntLHbRLi0vYhRoD1GW4l+IVJmIASmmaG0WZgoZEw== X-Received: by 2002:a05:6a00:4b02:b0:6e6:279e:3dc2 with SMTP id kq2-20020a056a004b0200b006e6279e3dc2mr2611552pfb.25.1709574002161; Mon, 04 Mar 2024 09:40:02 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id u20-20020a62d454000000b006e468cd0a5asm8103347pfl.178.2024.03.04.09.40.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 09:40:01 -0800 (PST) Date: Mon, 4 Mar 2024 09:40:01 -0800 From: Kees Cook To: Jann Horn Cc: Jiangfeng Xiao , gustavoars@kernel.org, akpm@linux-foundation.org, jpoimboe@kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, kirill.shutemov@linux.intel.com, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, nixiaoming@huawei.com, kepler.chenxin@huawei.com, wangbing6@huawei.com, wangfangpeng1@huawei.com, douzhaolei@huawei.com Subject: Re: [PATCH] usercopy: delete __noreturn from usercopy_abort Message-ID: <202403040938.D770633@keescook> References: <1709516385-7778-1-git-send-email-xiaojiangfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6F2FC40022 X-Stat-Signature: p6h98p9p1fs1ho73xmdurzo9y1xjds8o X-HE-Tag: 1709574003-118939 X-HE-Meta: U2FsdGVkX1+WXat0LFbjFu3Wd4rVjwA9d78uFkUnLM0og0pZhsEFH3ysBUqUovmJMO9UCfZMB71IFDXecRAuGRAETH2yWIONrS1VLt4vTszUFaaGI6uOGuq5buiZviNwH30Z9KOZvbnIDttTwI8cC2+Nc3xpSMerjp4evarNzWaHw0qZmyguOpjqARN/2RcP6vZ8q8t0txCoxgx7FT36XVqH9YMDaaz+As/KMj68AtZIFj1z+6DgdAKdokGDd+VBr984UFCYjFIdE51AfX8crKwcVu4hOWSFk5kTABwyorpoTtyoEgdx8enNQnD58l0xJ3cWYEpEWMg7opYuJ5EukVKYji6Ogn2r64gIc+TV2pcVOyy7vmck3N7qTeIS8aO8Eou4MoKJt/r5tmJY3OZZvE5pA6hOyxYFtw1kdVxzQ1bfWqfizE+aI3Zd+KfByhEeUCf9hjk+TXSK6ptE9AWxeEv5/HMd3AAFaRxUyMyvPUoTuJAH1kpC8DjfQ1ubLGee/ZvxnlCdxxTX2VgwXJ5B8+w9WN3UPneYSvoxCxbRKx0bc25AIJc13OK3up0MDO7+6hwQTm5DNMBiGC13weSsvDTCbzlvFYqIkZx9qtZ/tk2ryk8ooFkzV2fX+9IX9ZQ0Y1aDEhMwOwqEzYrphNSk065UlRFyoabTypVsGPX+7bhRZID002u1fCidqXQYYbUU3EOGIizZli1pnvAu7OtlUF3niGopjXRacOZGxfZGvoPVd3X8taV1zSxWG7EVehd4AMs+bEy5f8bDaJGQ6ssV6Gp+aN3biOMIACBH8AXmw2HaCx4kwXj9E4+wsehDu7AB8ZzsbfMp2ga8AYCes1wh0pun8tARKYIa8HiAGMqW8v+H1k3NXOE579O+NWgyTlkEcYDQ1GyQO6AKTc0zCsRfUzKE5LUJVX9YbKeo+zkeeV7IiOF+8+hbqS59J3YtWXiLPM4E1dAWygepCPTF5FK 79MGKQ2l c7UFGKIvxoruPcqDa7Kh9edmyQuMjWw92Zu8Ph9lN44SJtli4iZO016Poel1o8qNagGnQlroW+K4EQQk7W9+yQEJSyrL1QcxgCZmbuFCIzIiP8h/N+JoiL7bglKxyFhBnLyRI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 04, 2024 at 04:15:07PM +0100, Jann Horn wrote: > On Mon, Mar 4, 2024 at 3:02 AM Jiangfeng Xiao wrote: > > When the last instruction of a noreturn function is a call > > to another function, the return address falls outside > > of the function boundary. This seems to cause kernel > > to interrupt the backtrace. FWIW, all email from huawei.com continues to get eaten by anti-spam checking. I've reported this a few times -- it'd be really nice if the domain configuration could get fixed. > [...] > > Delete __noreturn from usercopy_abort, > > This sounds like the actual bug is in the backtracing logic? I don't > think removing __noreturn annotations from an individual function is a > good fix, since the same thing can happen with other __noreturn > functions depending on what choices the compiler makes. Yeah, NAK. usercopy_abort() doesn't return. It ends with BUG(). -- Kees Cook