From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B215C5478C for ; Fri, 1 Mar 2024 11:26:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA3996B0083; Fri, 1 Mar 2024 06:25:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A53C86B0085; Fri, 1 Mar 2024 06:25:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 969F76B0087; Fri, 1 Mar 2024 06:25:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8743D6B0083 for ; Fri, 1 Mar 2024 06:25:59 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4C833C1253 for ; Fri, 1 Mar 2024 11:25:59 +0000 (UTC) X-FDA: 81848240838.16.2D88E36 Received: from mail114-241.sinamail.sina.com.cn (mail114-241.sinamail.sina.com.cn [218.30.114.241]) by imf26.hostedemail.com (Postfix) with ESMTP id 48CF814001A for ; Fri, 1 Mar 2024 11:25:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of hdanton@sina.com designates 218.30.114.241 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709292357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fsfWcsIVOLL42JQcnPKF9lSl7NrBLx3pSAISowecf7g=; b=2rAJONp6SFNBtZp8aRAHb6CI3NZStksOhz/dUPGgrOOqGCgNBG9cZPn5uScasS9TIsB2cs +LRB96rG1vGAw4VOnkqugbju/FO6V2veKbXDK43Z8k50GLsl9vAZSm1GjmK6s3iN12gNcC n5mtQ9XGnV8Oj8FhBVZGBP5RXBNR2pU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709292357; a=rsa-sha256; cv=none; b=M7XFZ9DCPL4rCyj4b7coQ+XmImLTZbDF+xKO0kFZt+caoBFd4jFcdjyV2fsTCgUraQMl+w x1BuxrYncbVzp8olL3WWmoZs2sMPF7EmVqjjkmNdXgZukmwY/Rv9WcAVwDo/9wv4TAgJyu tPliBM1UeSy/qCE5FxZSwCrMbKaAN4I= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of hdanton@sina.com designates 218.30.114.241 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.118.67.15]) by sina.com (172.16.235.24) with ESMTP id 65E1BB37000026BE; Fri, 1 Mar 2024 19:25:46 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 51075845089115 X-SMAIL-UIID: EBE7EC53C58A480281876D9622824AFE-20240301-192546-1 From: Hillf Danton To: Axel Rasmussen Cc: chris@chrisdown.name, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, yuzhao@google.com Subject: Re: MGLRU premature memcg OOM on slow writes Date: Fri, 1 Mar 2024 19:25:35 +0800 Message-Id: <20240301112535.1609-1-hdanton@sina.com> In-Reply-To: <20240229235134.2447718-1-axelrasmussen@google.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 48CF814001A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: qjdkkmb1ri4h8drqgy8sp3e94fpf4f5s X-HE-Tag: 1709292354-760667 X-HE-Meta: U2FsdGVkX1+2ZUvxI1FW800Xl6GpoTtSipS2kOmN9hSZSzFUI0PcRBO2NFKLRiAFhYmvPK/NTzGjDZumiooC4YkcB890fquFd758dFonEtno3C9u/t6dMSFZy0u7yNCxXeReM5nugVro3BMJln4Nizz7ha1Gl55cn/ek3cqjzIAGcQaGwllxAp/zuaW9ynTl2dc8bEHKrLGUPHr36ijUn89Y1JTekD65Gm7iWkGzqs7h7xEek+JGquM5UC44yf4wxRipjh4LAXjY7OxzJW2aJNqQEYOeL8qe0CJ1yCfH9Y7Wpf4352WKCtoMX9MpVd79rCLHB9eHmlcaiittNkhkjIytv+Msb7R6WgnCD9d8a7doxqQc9WI4BbtfSH6OTHUjOjyb4+xskKZ938BtcSqiHuLl+SO/u0+gvReqBCnQVwnmnQc8vr50GMxfGyc/I0m43WzIjxgKxdQT4r1bSjMTNjrvhj62/9PZgkzf1fYkCFqNdlR7S3HFxm33b2toJrL2OA6bJfGy2HAqJV1Tw0cTVJ0142G3U007g5kNWWA8+uubIpUl1vz7qAGUnfsjKOcmwYPw0ZEDTJQ16r0duuNi2b6b9QEu/WIFcFXeyPqpf08OewHGkRvRFuCfAsi9zq1v7gzYWXCO5Q2NtrUB2iKL56/7fcFfhvDo4hraOC873hDuw1PvHpqcaoTrI/G1WP8sgsCcoAWWCOpUjLLrRrGuOOkFsCdgbr1bCCdB6WN0PcQwkBLb+4Iu1z74WrIG0LYgjtMJz28Mk1bbYCLG/G2o6NullDlcVMbyVrdkWotfNVIJehk3unAmvVcST4lhDJsJJdPTN+rzqjDn4maJA5gGIQANIdidVYnS3j5mn6LkyBCGZVpqNampob80BhCyktKVoMgdJ0LA7Fq4QbKVa/SoeRo3cEO+YLBCHD5dhdHEUy8e8PXwlHVeZlh9XrFg+dqAmh+3r5qnbWYyA1oDScb KMS7usPW doPRuzKXuKQXcivd9TxV1tt5CJH5Gp7Fc2hx8sefiD73xJ89PXca4udGQfz8hSiK/F+bGFKjAJ2LdoZPM70gnvd2Pz4Z+kMr44KqHNTSAiGTUd3I5kt/pY1RiCdZ4AvY9J6BfiH2w8fVprk4orx4IpyUxMJ8D9f7iWPse X-Bogosity: Ham, tests=bogofilter, spamicity=0.002834, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 29 Feb 2024 15:51:33 -0800 Axel Rasmussen > > Yosry pointed out [1], where MGLRU used to call this but stopped doing that. It > makes sense to me at least that doing writeback every time we age is too > aggressive, but doing it in evict_folios() makes some sense to me, basically to > copy the behavior the non-MGLRU path (shrink_inactive_list()) has. > > I can send a patch which tries to implement this next week. In the meantime, Yu, Better after working out why flusher failed to do the job, given background writeback and balance_dirty_pages_ratelimited(). If pushing kswapd on the back makes any sense, what prevents you from pushing flusher instead, given they are two different things by define? > please let me know if what I've said here makes no sense for some reason. :) > > [1]: https://lore.kernel.org/lkml/YzSiWq9UEER5LKup@google.com/