linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Hillf Danton <hdanton@sina.com>
To: Axel Rasmussen <axelrasmussen@google.com>
Cc: chris@chrisdown.name, hannes@cmpxchg.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	yuzhao@google.com
Subject: Re: MGLRU premature memcg OOM on slow writes
Date: Fri,  1 Mar 2024 19:25:35 +0800	[thread overview]
Message-ID: <20240301112535.1609-1-hdanton@sina.com> (raw)
In-Reply-To: <20240229235134.2447718-1-axelrasmussen@google.com>

On Thu, 29 Feb 2024 15:51:33 -0800 Axel Rasmussen <axelrasmussen@google.com>
> 
> Yosry pointed out [1], where MGLRU used to call this but stopped doing that. It
> makes sense to me at least that doing writeback every time we age is too
> aggressive, but doing it in evict_folios() makes some sense to me, basically to
> copy the behavior the non-MGLRU path (shrink_inactive_list()) has.
> 
> I can send a patch which tries to implement this next week. In the meantime, Yu,

Better after working out why flusher failed to do the job, given background
writeback and balance_dirty_pages_ratelimited().
If pushing kswapd on the back makes any sense, what prevents you from pushing
flusher instead, given they are two different things by define?

> please let me know if what I've said here makes no sense for some reason. :)
> 
> [1]: https://lore.kernel.org/lkml/YzSiWq9UEER5LKup@google.com/


      parent reply	other threads:[~2024-03-01 11:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09  2:31 Chris Down
2024-02-29 17:28 ` Chris Down
2024-02-29 23:51 ` Axel Rasmussen
2024-03-01  0:30   ` Chris Down
2024-03-08 19:18     ` Axel Rasmussen
2024-03-08 21:22       ` Johannes Weiner
2024-03-11  9:11       ` Yafang Shao
2024-03-12 16:44         ` Axel Rasmussen
2024-03-12 20:07           ` Yu Zhao
2024-03-12 20:11             ` Yu Zhao
2024-03-13  3:33               ` Yafang Shao
2024-03-14 22:23                 ` Yu Zhao
2024-03-15  2:38                   ` Yafang Shao
2024-03-15 14:27                     ` Johannes Weiner
2024-03-12 21:08             ` Johannes Weiner
2024-03-13  2:08               ` Yu Zhao
2024-03-13  3:22                 ` Johannes Weiner
2024-03-13 10:59               ` Hillf Danton
2024-03-01 11:25   ` Hillf Danton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240301112535.1609-1-hdanton@sina.com \
    --to=hdanton@sina.com \
    --cc=axelrasmussen@google.com \
    --cc=chris@chrisdown.name \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox