From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52C25C48BF6 for ; Thu, 29 Feb 2024 23:51:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CA526B007E; Thu, 29 Feb 2024 18:51:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8538C6B0080; Thu, 29 Feb 2024 18:51:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A6656B0082; Thu, 29 Feb 2024 18:51:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 504BB6B007E for ; Thu, 29 Feb 2024 18:51:38 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1B3211A0405 for ; Thu, 29 Feb 2024 23:51:38 +0000 (UTC) X-FDA: 81846491076.05.335CC02 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf25.hostedemail.com (Postfix) with ESMTP id 77632A000E for ; Thu, 29 Feb 2024 23:51:36 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dHHdjtGa; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of 3hxjhZQ0KCHIQnUbhQickiiUdWeeWbU.SecbYdkn-ccalQSa.ehW@flex--axelrasmussen.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3hxjhZQ0KCHIQnUbhQickiiUdWeeWbU.SecbYdkn-ccalQSa.ehW@flex--axelrasmussen.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709250696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wGdhmGNHVTXKtr8Coxlis0Li3Bk52TXuxtZPxJDknj4=; b=6YU59u+iZPljR4jTmTPv7m9FqMIisf6A3x4MD49JuPGphxNO0qbw/sl/XBfSl65No/X9gX t5tr5wkXPnkYJ78afgIB99fp9R6huH6orr/6uMDtXgtl4z9kmWKUaVcCMbuzyKSczjXJD7 Dq4OlK1V0pSJQ9VhMPSpEEUFl8sUJn8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dHHdjtGa; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of 3hxjhZQ0KCHIQnUbhQickiiUdWeeWbU.SecbYdkn-ccalQSa.ehW@flex--axelrasmussen.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3hxjhZQ0KCHIQnUbhQickiiUdWeeWbU.SecbYdkn-ccalQSa.ehW@flex--axelrasmussen.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709250696; a=rsa-sha256; cv=none; b=u1WPZpl8mR1Z5oRbyYgLp/CgxFpqxT/fFsvCMIGTUcWV2hiKEXRel4FMJ9GB5kEz5L+TiD R7fyClF4aR7mpblW3mAEfKdIOhRUcHCo0iCdpyLwuxjJbcoITHR2+LK+CQtvYbc7HgZaay K29U5Oll25YZnWmdxztSHfZq4dxxT3o= Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-5ee22efe5eeso26975477b3.3 for ; Thu, 29 Feb 2024 15:51:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709250695; x=1709855495; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=wGdhmGNHVTXKtr8Coxlis0Li3Bk52TXuxtZPxJDknj4=; b=dHHdjtGas+JJq45cGHS11VjlchKeSa1nfS8YgxmLH9hhkadYMKa+Oep+E17SJbBwK1 SO7gWWuKYwNl4QvZ6OnS6OYNXuHXtep8/EA4PhHVANvlbvMKsnTzON1RYMhsYkh3ZLqe 6hYqPLkxxBL1uig9uy33kSflMwwUKKuDLdm3zBIX95LqNSDjlghgsTxWdpnbGdCuV7/v oc/P7FfSt2+wWP8SBDObNEFM5U61J8db0/AQXLJfulU64psPm9zXSUIOAqj+gOrNwYub d8xMgNI6PjGLhmaYRz+NYCDaq1b+Gf+yZX7h2L1Aw9wuX0wfXmqqxwREH63EsEWKVuYD 954A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709250695; x=1709855495; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wGdhmGNHVTXKtr8Coxlis0Li3Bk52TXuxtZPxJDknj4=; b=Fsz9yQD0pAEojllnhKjLzSdu9aFdOrxEof8LO20u/Ttj3m++Ts0XK8hG1lTCXOC4Yh mfmU6aQ6510N7RBU1AzvxUw63AC2JyvUsaX5vBcHwUF+1Uj2C7kEy1/i+mLy1xqBNsr2 b6UmQfegBpX0UOAqYq2sDVpx38uzc6fkcbWU9Wwoonqa5m5QRQ33gNJBkBj6B+t4Ovxx 6UdPtjqX1mkYzgnlNUx3QRKBWv05cHDL/Ipw9l3NcP2oRMXDvfcZwHeiszW0mqsxczTj sr3Fni7VVQAZp6B9JWK3zDlgFq2h7DIGRFPASCvwpkKEHfl4frvYasRrtqyG7/Bpemeb qKXw== X-Forwarded-Encrypted: i=1; AJvYcCVb4AVrhQvRTnnJeLmc+rD0XpOHd5zuf+qTceP8s6wyN+3xABbnaWU+cWLoZ4lvjzL51KRrsJQkc1XrNtaaoxmDwtU= X-Gm-Message-State: AOJu0YzKMl96CJvRTPqMNNLFUXS06FKfyEOzTxaklJ8lCpZ/5C6iC2D+ xps4hEsGgWOJ+nI3Rr4KBg9zGga1lwrlL8v+Sw/ivnybDv4Fsp4DSbmyoSwG944oaIZipvumFEv ZPEorXrssDMyt6ob1+faCNq8A2BgLaQ== X-Google-Smtp-Source: AGHT+IH867rn03DULgpAnZN98NdftWiJfM3usfRmVuNXYLi9bkM7Uz9nOwttJ34eI/OIA2Ca2LK6EGXn14L13DXQ6nxP X-Received: from axel.svl.corp.google.com ([2620:15c:2a3:200:4ca4:66d0:de29:8d39]) (user=axelrasmussen job=sendgmr) by 2002:a05:6902:100a:b0:dbe:387d:a8ef with SMTP id w10-20020a056902100a00b00dbe387da8efmr177541ybt.1.1709250695530; Thu, 29 Feb 2024 15:51:35 -0800 (PST) Date: Thu, 29 Feb 2024 15:51:33 -0800 In-Reply-To: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.44.0.rc1.240.g4c46232300-goog Message-ID: <20240229235134.2447718-1-axelrasmussen@google.com> Subject: MGLRU premature memcg OOM on slow writes From: Axel Rasmussen To: chris@chrisdown.name Cc: cgroups@vger.kernel.org, hannes@cmpxchg.org, kernel-team@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, yuzhao@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 77632A000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: hsj4p1fg95u5f6knkbhbzunw5e51uhbp X-HE-Tag: 1709250696-805893 X-HE-Meta: U2FsdGVkX1+0zeu8xEtYN8QAkwYZHENfQDmjBi7w8yzlbhUkv1KmGFDmcn6L9OLxxUEHAn83G3FjppbbeEeGLtk1SFi4TRy6Q9NwDaq08fYljSaCk5rnll3k1AbFc13UOdB/oM3fb3cstzl33g2EgxOyifcoSotnpjbklt703ptXM92yGK+4Y+AZ2VffBYG2IZbBYTiqYgUwrXniAuVqFWdT17SasM6WVA7xQvO+hVtfTy8CY0LXq/+reD5WIVxvYO601wwwj+HYyiC0QnRofe69tPaKKjvOichZakULZZidJF2wUeXtcVM+OAo1IZ3DOYurC60qBK3JpQAWLgjKtm4dE+H7tHEcSynMU51LTX9KBrSaBjvyYluFiQD+J4H97JwM/KIALwACMGmvJ7dHFZcD7RkwvRC16a0LNbOzaK38vOxP2yj99waSh3xrAU8iAlAdsfa/amMKPG/SvScWe6U/sJOGKKaRvxjNw1gLlFyvYxcMtcGuT7HxTtBY7/YsodM8CF8hY+hJ9QHWxitVtiJiBylMoY8u5TWvzq+ZWu8achTmMSJNbjXOdmrTuIL9lV+YDpqeLbYWRp96SG7U36BHe9B1tm3YOFqWhZCLjKez2nY5iQ7sFAj2HA6/TbcjpSoZamY4jAoOhl68EyjI9+ie4wxtGpn/KyDbecstWlYHYfH8fGyCWKrlePQaqvBau1nzsi6CqLT733uu/AH2T7C4CsPYnF+40iCiuvJIG7bFa7wSKpLXt+JNvJBLN1a4HkndHTXaus5CEdtiZbDOBNKwo4OLOkdC+PwltNyux/fJ79j4ogTrA9e3jmkfbk0Uc4thdhSPYt/qqs9eaVvdoAXZcAGmGkgqhvrKq42nrhK+60bPs7WPwA80rh4+W3IeFIPK11v52951tAdvdRmjaWZHDkekjesndXF/eHp1Cg3GjPyE3th0MsoxOkXTvYTA+Rm1151YYUdXEXLSeZr VP5Nn9Dc hgIcaDGJddj7+p7gmwCLvosVM05MrPJKxIFb5S1GlqdflYWj988sLi4GGZij9GzOCbgH8Amm9KDbkK/+iSOmueGorFbUAmaTEp+FvhmDEYfemaQQcRV0GxNJARCA8WyvbQed1ql5cJUxM96VDOmIvQCOVXODC+A5WDgZgBUuW9FSWEZZGX02rUED0w1qPAiCW5hrUDN4MJmUHszTK3aMAS7ly9sPErSPB44v5Q7lAsZXn9qUuv0/I2wHxfi/X+JpKF9hYZ//KfeeZUWYbTKFb5IwvMepWX0eyPXPM7X2TYuLZ9ZiU4fRY14TdCKQ31yNdCoIzNQsFVHTCqprJvOo7nW6UzsgwZcwH/7yIOxLgZ6ukVjnkkCV8A0hhwWgpZUEir5/hCSKVHjAYXKaViuRtVg46sQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.270250, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Chris, A couple of dumb questions. In your test, do you have any of the following configured / enabled? /proc/sys/vm/laptop_mode memory.low memory.min Besides that, it looks like the place non-MGLRU reclaim wakes up the flushers is in shrink_inactive_list() (which calls wakeup_flusher_threads()). Since MGLRU calls shrink_folio_list() directly (from evict_folios()), I agree it looks like it simply will not do this. Yosry pointed out [1], where MGLRU used to call this but stopped doing that. It makes sense to me at least that doing writeback every time we age is too aggressive, but doing it in evict_folios() makes some sense to me, basically to copy the behavior the non-MGLRU path (shrink_inactive_list()) has. I can send a patch which tries to implement this next week. In the meantime, Yu, please let me know if what I've said here makes no sense for some reason. :) [1]: https://lore.kernel.org/lkml/YzSiWq9UEER5LKup@google.com/