From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 464BCC48BF6 for ; Thu, 29 Feb 2024 08:39:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0B816B00A3; Thu, 29 Feb 2024 03:39:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BBB7D6B00A4; Thu, 29 Feb 2024 03:39:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A84196B00A5; Thu, 29 Feb 2024 03:39:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9833B6B00A3 for ; Thu, 29 Feb 2024 03:39:55 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 41976C12DC for ; Thu, 29 Feb 2024 08:39:55 +0000 (UTC) X-FDA: 81844193550.01.96C74C3 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf02.hostedemail.com (Postfix) with ESMTP id 0DA9C80004 for ; Thu, 29 Feb 2024 08:39:50 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709195993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZFYyFcVdXLdZSzaIFCSUFzwK4UWn7xmjNK3IUl6+bPI=; b=pLzLC8oIhawKpBoWTOpaF0qGIBtjcYgLyNCeONv7JFhKtOV4e88ik6DSPIEJCbhsmaZAcr zCBV/2tybGP5+oHaFAV9JEKJGkFjcjOXWSelTsbIC+xDKRqh4lMKUYvRpNSg4vIptPZlJE JUJKbPpcKDwJQSCWfGoUNkZHwLAijHc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709195993; a=rsa-sha256; cv=none; b=1W3OHwdipVo1/q83PhAPoUsLio5A+yTviLANoHa6GGZIHWbiylNSSaTmD7fh3xpV7tKr0u mw4vgboWbT6Xb0HXh4ZHvUH3RpuRF/v87pT/ZfbSDitYEoPsMdcZ6HgrTPBnTDqVqVSBVW y9AcQ9f4tzp/HJtxoLg2A4Il811wGks= X-AuditID: a67dfc5b-d85ff70000001748-28-65e042d11ed9 Date: Thu, 29 Feb 2024 17:39:38 +0900 From: Byungchul Park To: "Huang, Ying" Cc: Johannes Weiner , Michal Hocko , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, yuzhao@google.com, Mel Gorman , Vlastimil Babka Subject: Re: [PATCH v3] mm, vmscan: do not turn on cache_trim_mode if it doesn't work Message-ID: <20240229083938.GA64252@system.software.com> References: <20240223054407.14829-1-byungchul@sk.com> <20240228223601.GA53666@cmpxchg.org> <87jzmndc4k.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87jzmndc4k.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsXC9ZZnke5FpwepBoceSVjMWb+GzWL1Jl+L y7vmsFncW/Of1WLyu2eMFvf7HCxmN/YxWpycNZnF4t2EL6wOnB6H37xn9liwqdRj8Z6XTB6b Pk1i9zgx4zeLx/otV1k8ziw4wu6x+XS1x+dNcgGcUVw2Kak5mWWpRfp2CVwZFyesZi/oD664 PL2DtYFxml0XIyeHhICJxNM9ncww9pMfV9hAbBYBVYkHV3+xg9hsAuoSN278BKsREdCQ+LRw OVCci4NZoJ1Jou3wNBaQhLBAuETH3N2sIDavgIXEjI1nWUGKhATWM0p09i1hhEgISpyc+QSs gVlAS+LGv5dMXYwcQLa0xPJ/HCBhTgE7iZbeJUwgtqiAssSBbceZQOZICFxnk1h0bQ07xKWS EgdX3GCZwCgwC8nYWUjGzkIYu4CReRWjUGZeWW5iZo6JXkZlXmaFXnJ+7iZGYEwsq/0TvYPx 04XgQ4wCHIxKPLwJNvdThVgTy4orcw8xSnAwK4nwygjeTRXiTUmsrEotyo8vKs1JLT7EKM3B oiTOa/StPEVIID2xJDU7NbUgtQgmy8TBKdXAaH9K+7DPI/5V/0U+Txd9ZGJmt0Vb1/XL8wRP kVmvLOJ4WNxfLGdeKDyp/uS3wgvGjTuLlxQc4JknNMvvvdVmo5uCKfwXtYrCt5wKFXD3Unb7 lCl05arI+815D7Y8bKr9clvs1hemIrnJ84okW5hUN1o9PSEZ33DC4cKaklcTLDqDQzvsp8iq KLEUZyQaajEXFScCAL6g2IWFAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsXC5WfdrHvR6UGqwbo7/BZz1q9hs1i9ydfi 8NyTrBaXd81hs7i35j+rxeR3zxgt7vc5WMxu7GO0ODlrMovFuwlfWB24PA6/ec/ssWBTqcfi PS+ZPDZ9msTucWLGbxaPxS8+MHms33KVxePMgiPsHptPV3t83iQXwBXFZZOSmpNZllqkb5fA lXFxwmr2gv7gisvTO1gbGKfZdTFyckgImEg8+XGFDcRmEVCVeHD1FzuIzSagLnHjxk9mEFtE QEPi08LlQHEuDmaBdiaJtsPTWEASwgLhEh1zd7OC2LwCFhIzNp5lBSkSEljPKNHZt4QRIiEo cXLmE7AGZgEtiRv/XjJ1MXIA2dISy/9xgIQ5BewkWnqXMIHYogLKEge2HWeawMg7C0n3LCTd sxC6FzAyr2IUycwry03MzDHVK87OqMzLrNBLzs/dxAgM8GW1fybuYPxy2f0QowAHoxIPb4LN /VQh1sSy4srcQ4wSHMxKIrwygndThXhTEiurUovy44tKc1KLDzFKc7AoifN6hacmCAmkJ5ak ZqemFqQWwWSZODilGhjjKsR5U+qZmPZWfQ7nUWhz7p+f+f+TgpZ1Yt5blruPpMv93s8wrTLK yq35VqXRc+z9r7VeQm3eWuwM7o7rhc8dmCL12PKOkKCyohIbx7Wpn7+nej+esMHCXS3UcqXO p6DSgne2epssZ/ju2it2eMNrQWXO7rIEsQ4zi1NT2LUyeY9bTk9pVmIpzkg01GIuKk4EALrF GAdsAgAA X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0DA9C80004 X-Stat-Signature: 9p78bwasew81uynby7677drczisjyh9e X-Rspam-User: X-HE-Tag: 1709195990-984591 X-HE-Meta: U2FsdGVkX1/QCb+NxjryOuWFLzAwyxtyfqf1vQb01eC8p3ojh2y4MmSMV31GX0FyrmU62ZMTqYSRUqE9yZyT9JUipzo+DTxhRmuG4EVnGUEs6lRGsAy/95+nQxP9gGctrlih4CinUFFWpHKEhdqQrbXH7ldxSf704d/DFravwOvltMbqB0WZ5E4sBKAuDoOPHCOosMlffx+1/IFMRigLh3QHMFqjTfGqMLiqik22KdSIYNerAux3zlr3TgLXiI7Fv09xUxNtqhSjCm4Br54Kjav1acgKFJutm6y87rUgrHbUJhgOfZ5zHUIZHQplN0+xzLUwou7wGwRecQBqHGtiBLnQbosssob7dVEhWKPvf7z8FFjAOpYWVw3EVptJuwIFXmb6dtQYRmgbDE4sR50huGcVfz7dcHaXritzokHhlaxFhV+pxx8jcF/BkFj9m9KD6n/28oiYAeVzTbX0CE12z2qw1am5odK/YeF8eQGrPGHX3KHvXan2f4lvFb60M2IvBk5roFfOQWLop342OqJjcwlrI1PqFcuSzK8nb6SlzmeqUSwMmiCvcAVSM1vK6gDscBeITniNueAxcxyB4LxYHBUoWLnDkpNzbI+FLgZkUaab6FM3h79CbVCxfXsYvoT8hOF5ic4T+8fhm+vuqjW/ZnkuwEX22nwCafHrutCoP90c7YUOsAEw3thc6hMvbT16xKKFuo1oI+mUAcd6o6f4tV5LQoxZ1kHxVSoiFQcfP138kybSK5MSZQ1wAblWoBs+Znpt93/jzH5lOYtp/fJelyebDL8Y0VCBynDnoDkKc/TGrPYoknjA1kceJZ1KDZIy49Ebq6pkcbHEN+DSTohvKLSofu4X7YcRItI/ACRVb3ORCWzKB/5oijiGXD4oos/KwU4iNjWyE2Y4sU/yxjjfaMSfuqUttSkG14sAVRVJmvp2+g1j533+dmZYAPp9/uU8FwBFsCubJQzS1a8+Vnz mOMdTpjQ x1rtqqd66ybRUA5yeEFvClT0V6g5ZLYqWt81OrU9GkKxG3YVwX5ivdQbPsAflErKEgmDEs/qzf9zSyuxlYaCni++yLHiSHO6KP7mdk2B97z63bEJUSifjAkyRkDKBE2CfDiUzV0a6+UDe2Q8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 29, 2024 at 02:21:15PM +0800, Huang, Ying wrote: > Johannes Weiner writes: > > > On Mon, Feb 26, 2024 at 02:06:30PM +0100, Michal Hocko wrote: > >> [CC Mel, Vlastimil and Johannes for awareness] > >> > >> On Fri 23-02-24 14:44:07, Byungchul Park wrote: > >> > Changes from v2: > >> > 1. Change the condition to stop cache_trim_mode. > >> > > >> > From - Stop it if it's at high scan priorities, 0 or 1. > >> > To - Stop it if it's at high scan priorities, 0 or 1, and > >> > the mode didn't work in the previous turn. > >> > > >> > (feedbacked by Huang Ying) > >> > > >> > 2. Change the test result in the commit message after testing > >> > with the new logic. > >> > > >> > Changes from v1: > >> > 1. Add a comment describing why this change is necessary in code > >> > and rewrite the commit message with how to reproduce and what > >> > the result is using vmstat. (feedbacked by Andrew Morton and > >> > Yu Zhao) > >> > 2. Change the condition to avoid cache_trim_mode from > >> > 'sc->priority != 1' to 'sc->priority > 1' to reflect cases > >> > where the priority goes to zero all the way. (feedbacked by > >> > Yu Zhao) > >> > > >> > --->8--- > >> > >From 05846e34bf02ac9b3e254324dc2d7afd97a025d9 Mon Sep 17 00:00:00 2001 > >> > From: Byungchul Park > >> > Date: Fri, 23 Feb 2024 13:47:16 +0900 > >> > Subject: [PATCH v3] mm, vmscan: do not turn on cache_trim_mode if it doesn't work > >> > > >> > With cache_trim_mode on, reclaim logic doesn't bother reclaiming anon > >> > pages. However, it should be more careful to turn on the mode because > >> > it's going to prevent anon pages from being reclaimed even if there are > >> > a huge number of anon pages that are cold and should be reclaimed. Even > >> > worse, that leads kswapd_failures to reach MAX_RECLAIM_RETRIES and > >> > stopping kswapd from functioning until direct reclaim eventually works > >> > to resume kswapd. > >> > > >> > So do not turn on cache_trim_mode if the mode doesn't work, especially > >> > while the sytem is struggling against reclaim. > >> > > >> > The problematic behavior can be reproduced by: > >> > > >> > CONFIG_NUMA_BALANCING enabled > >> > sysctl_numa_balancing_mode set to NUMA_BALANCING_MEMORY_TIERING > >> > numa node0 (8GB local memory, 16 CPUs) > >> > numa node1 (8GB slow tier memory, no CPUs) > >> > > >> > Sequence: > >> > > >> > 1) echo 3 > /proc/sys/vm/drop_caches > >> > 2) To emulate the system with full of cold memory in local DRAM, run > >> > the following dummy program and never touch the region: > >> > > >> > mmap(0, 8 * 1024 * 1024 * 1024, PROT_READ | PROT_WRITE, > >> > MAP_ANONYMOUS | MAP_PRIVATE | MAP_POPULATE, -1, 0); > >> > > >> > 3) Run any memory intensive work e.g. XSBench. > >> > 4) Check if numa balancing is working e.i. promotion/demotion. > >> > 5) Iterate 1) ~ 4) until numa balancing stops. > >> > > >> > With this, you could see that promotion/demotion are not working because > >> > kswapd has stopped due to ->kswapd_failures >= MAX_RECLAIM_RETRIES. > >> > > >> > Interesting vmstat delta's differences between before and after are like: > >> > > >> > +-----------------------+-------------------------------+ > >> > | interesting vmstat | before | after | > >> > +-----------------------+-------------------------------+ > >> > | nr_inactive_anon | 321935 | 1636737 | > >> > | nr_active_anon | 1780700 | 465913 | > >> > | nr_inactive_file | 30425 | 35711 | > >> > | nr_active_file | 14961 | 8698 | > >> > | pgpromote_success | 356 | 1267785 | > >> > | pgpromote_candidate | 21953245 | 1745631 | > >> > | pgactivate | 1844523 | 3309867 | > >> > | pgdeactivate | 50634 | 1545041 | > >> > | pgfault | 31100294 | 6411036 | > >> > | pgdemote_kswapd | 30856 | 2267467 | > >> > | pgscan_kswapd | 1861981 | 7729231 | > >> > | pgscan_anon | 1822930 | 7667544 | > >> > | pgscan_file | 39051 | 61687 | > >> > | pgsteal_anon | 386 | 2227217 | > >> > | pgsteal_file | 30470 | 40250 | > >> > | pageoutrun | 30 | 457 | > >> > | numa_hint_faults | 27418279 | 2752289 | > >> > | numa_pages_migrated | 356 | 1267785 | > >> > +-----------------------+-------------------------------+ > >> > > >> > Signed-off-by: Byungchul Park > >> > --- > >> > mm/vmscan.c | 24 +++++++++++++++++++----- > >> > 1 file changed, 19 insertions(+), 5 deletions(-) > >> > > >> > diff --git a/mm/vmscan.c b/mm/vmscan.c > >> > index bba207f41b14..f7312d831fed 100644 > >> > --- a/mm/vmscan.c > >> > +++ b/mm/vmscan.c > >> > @@ -127,6 +127,9 @@ struct scan_control { > >> > /* One of the zones is ready for compaction */ > >> > unsigned int compaction_ready:1; > >> > > >> > + /* If the last try was reclaimable */ > >> > + unsigned int reclaimable:1; > >> > + > >> > /* There is easily reclaimable cold cache in the current node */ > >> > unsigned int cache_trim_mode:1; > >> > > >> > @@ -2266,9 +2269,14 @@ static void prepare_scan_control(pg_data_t *pgdat, struct scan_control *sc) > >> > * If we have plenty of inactive file pages that aren't > >> > * thrashing, try to reclaim those first before touching > >> > * anonymous pages. > >> > + * > >> > + * It doesn't make sense to keep cache_trim_mode on if the mode > >> > + * is not working while struggling against reclaim. So do not > >> > + * turn it on if so. Note the highest priority of kswapd is 1. > >> > */ > >> > file = lruvec_page_state(target_lruvec, NR_INACTIVE_FILE); > >> > - if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE)) > >> > + if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE) && > >> > + !(sc->cache_trim_mode && !sc->reclaimable && sc->priority <= 1)) > >> > sc->cache_trim_mode = 1; > >> > else > >> > sc->cache_trim_mode = 0; > > > > The overall goal makes sense to me. > > > > file >> priority is just a heuristic that there are enough potential > > candidate pages, not a guarantee that any forward progress will > > happen. So it makes sense to retry without before failing. > > > > The way you wrote this conditional kind of hurts my head, > > though. Please don't write negations of complex terms like this. > > > > It expands to this: > > > > !sc->cache_trim_mode || sc->reclaimable || sc->priority > 1 > > > > which I'm not sure makes sense. Surely it should be something like > > > > !sc->cache_trim_mode && sc->reclaimable && sc->priority > 1 > > > > instead? > > > > Also > > > > if (!sc->cache_trim_mode) > > sc->cache_trim_mode = 1 > > else > > sc->cache_trim_mode = 0 > > > > will toggle on every loop. So if direct reclaim runs through a > > zonelist, it'll cache trim every other numa node...? > > > >> > @@ -5862,7 +5870,6 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc) > >> > { > >> > unsigned long nr_reclaimed, nr_scanned, nr_node_reclaimed; > >> > struct lruvec *target_lruvec; > >> > - bool reclaimable = false; > >> > > >> > if (lru_gen_enabled() && root_reclaim(sc)) { > >> > lru_gen_shrink_node(pgdat, sc); > >> > @@ -5877,6 +5884,14 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc) > >> > nr_reclaimed = sc->nr_reclaimed; > >> > nr_scanned = sc->nr_scanned; > >> > > >> > + /* > >> > + * Reset to the default values at the start. > >> > + */ > >> > + if (sc->priority == DEF_PRIORITY) { > >> > + sc->reclaimable = 1; > >> > + sc->cache_trim_mode = 0; > >> > + } > >> > + > >> > prepare_scan_control(pgdat, sc); > >> > > >> > shrink_node_memcgs(pgdat, sc); > >> > @@ -5890,8 +5905,7 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc) > >> > vmpressure(sc->gfp_mask, sc->target_mem_cgroup, true, > >> > sc->nr_scanned - nr_scanned, nr_node_reclaimed); > >> > > >> > - if (nr_node_reclaimed) > >> > - reclaimable = true; > >> > + sc->reclaimable = !!nr_node_reclaimed; > > > > The scope of this doesn't quite make sense. If direct reclaim scans > > multiple nodes, reclaim failure on the first node would disable cache > > trim mode on the second node, which is totally unrelated. > > > > I think it needs separate paths for direct reclaim and kswapd. For > > direct reclaim, the retry should be before these similar retry catches > > in do_try_to_free_pages(), after all zones have been considered: > > > > /* > > * We make inactive:active ratio decisions based on the node's > > * composition of memory, but a restrictive reclaim_idx or a > > * memory.low cgroup setting can exempt large amounts of > > * memory from reclaim. Neither of which are very common, so > > * instead of doing costly eligibility calculations of the > > * entire cgroup subtree up front, we assume the estimates are > > * good, and retry with forcible deactivation if that fails. > > */ > > if (sc->skipped_deactivate) { > > sc->priority = initial_priority; > > sc->force_deactivate = 1; > > sc->skipped_deactivate = 0; > > goto retry; > > } > > > > /* Untapped cgroup reserves? Don't OOM, retry. */ > > if (sc->memcg_low_skipped) { > > sc->priority = initial_priority; > > sc->force_deactivate = 0; > > sc->memcg_low_reclaim = 1; > > sc->memcg_low_skipped = 0; > > goto retry; > > } > > In get_scan_count(), we have > > if (!sc->priority && swappiness) { > scan_balance = SCAN_EQUAL; > goto out; > } Even though this can mitigate the issue for direct reclaim, it's still suffering from the problem while direct reclaim goes from DEF_PRIORITY to 1. What we need is not a mitigation but making things right. Thoughts? Byungchul > So, we don't really need the heuristics in direct reclaim path. So, one > choice is to constrain this in kswapd reclaim only. > > -- > Best Regards, > Huang, Ying > > > > and for kswapd it looks like it should be in balance_pgdat(), after > > the priority loop, before increasing kswapd_failures. > > > > Instead of sc->reclaimable, which is very broad, it would be better to > > call it sc->may_cache_trim_mode. This is in line with a bunch of other > > such mechanisms in scan_control.