From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75568C5478C for ; Wed, 28 Feb 2024 13:36:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F12526B009B; Wed, 28 Feb 2024 08:36:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC3156B009C; Wed, 28 Feb 2024 08:36:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8A2D6B009D; Wed, 28 Feb 2024 08:36:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C59646B009B for ; Wed, 28 Feb 2024 08:36:21 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 69DB54103A for ; Wed, 28 Feb 2024 13:36:21 +0000 (UTC) X-FDA: 81841311762.24.7DB75D3 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf21.hostedemail.com (Postfix) with ESMTP id 7175D1C0023 for ; Wed, 28 Feb 2024 13:36:18 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VdraQnrE; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of lkp@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709127379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=/JDXnv8rS0zcMv5M7ZrUqXsN5Dx193xcdONrjG1/CS8=; b=bJI6ccAdwBxOIyzJECK4MITedhzO0tfXnWNzt0zMuATlq4yevHMw6AiFQXjcd+CVp3Mbt5 BB1lJc1w352WEUVn5ZU0oNDIQg1M5PPWmRuzTauocxpSCgcDvd2kDWZlTon7IaM20Wnq8d TBQtp1kKkMxdBy9L8ovBuuQqJmtxHcY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VdraQnrE; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of lkp@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709127379; a=rsa-sha256; cv=none; b=pTq2R+qBvmer+HfgsZELHZvtb/u+XCNi5v9uKrl9THYuUqE6Lf0Yew5CNvQZ0R+eIy18V0 GIiZaHf/5pOfhetHE0EgnmytvDAKCmOg9zlDpXn/PEDonAoGmTVlB4pUgTa243ilYE4keO v5McXjt1v9TWEwCoDUbAyx/uT1qTEKg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709127379; x=1740663379; h=date:from:to:cc:subject:message-id:mime-version; bh=xy4FiSe+thO/0ABaGNfMHX1m869Hzy6rmQXMGdJPUEU=; b=VdraQnrEUrVZ5x8TXtK+t3TdfK7geVyfloRM3fsKDTZxeVBtyF1bpm7y M7XiSlndAYTqKStHH8W5/26cuWwA8/Jr72syS4dqDRfRlHdgEzag2DLOt m8LWDyNqe6dxElFYjSycW0gSLIsZgBd13PA1c6oWQdtzGEGcCa+8F85cJ k3Guj3Hr9acRE7dXljz5t38Vj9z1SP0Gi/klFhJVTEmEbZbZ1GNLHyRda dzkGlSN/WZIwv6adVu0z95j0eey7xSqTsKzAHAUW0BTmSGUIp71g37te3 pm/W7P0uf1DKjFf/ds9Lgc7PdfNpsw00H8aapeBGqj5XOa1UVmLu8RCP0 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="3399439" X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="3399439" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 05:36:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="12103591" Received: from lkp-server02.sh.intel.com (HELO 3c78fa4d504c) ([10.239.97.151]) by orviesa004.jf.intel.com with ESMTP; 28 Feb 2024 05:36:16 -0800 Received: from kbuild by 3c78fa4d504c with local (Exim 4.96) (envelope-from ) id 1rfK5d-000C5n-1F; Wed, 28 Feb 2024 13:35:31 +0000 Date: Wed, 28 Feb 2024 21:34:41 +0800 From: kernel test robot To: Lucas De Marchi Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Matt Roper Subject: [linux-next:master 7237/10830] drivers/gpu/drm/xe/xe_mmio.c:109:23: error: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int') is always false Message-ID: <202402282106.ou7DStPq-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7175D1C0023 X-Stat-Signature: 97a17akg9cruxcqsgw8zsocu7b4c4oyw X-Rspam-User: X-HE-Tag: 1709127378-919292 X-HE-Meta: U2FsdGVkX1/s+KjvW2Q5kP8ymgAFOtr2Z9l044Y3T3lHpGAz4R8aq7WgvKuDXv1btkbNkkFtFX6URPhE4OKeczm09T1k7AhJwQjVm9Vx7/tejyVEWJ6vAX1b15+4w6fs+hbQ0sHIivJxMyYCDKhCDzZQ92nMRzVmyAMv+BdZZxNlEqRNPFQmnvW56JJnLA+5yKnFtHNtpRHix83BReApvvn8Td3GHCfOmVkstnfM26A5dOeXbkd4b8Bmsfga/e3/CtPQ580xYsz7vsq1L2BKnNqvyfXDm0q6sTQyLpbVh0YuNPZJKWxpGqwtr00xaNXrNBryLdzvJ7yqyxsJfOdsYDNNRurYvR8lu6w19lb2dZ4NMI2mcnwNX8F25s6zQ/hScMJ2CML4AAo1NdysHncntStjuIwOKTzf8Dk/ODjyCXxFtAIpkRmQ03Nid9DnjcM/wXihklwWjxdNZCwebhpmFtT/krTb2fqFbYgW3lslLe0HiQzkh08XqcwxzLlVLKyyjjbK0IAwqp6Ah+MIkUEjmotq3amJg+EgXm2jXoMXOh4SLjZSfsRikErBmh9XWrneqxTeeZ+qzZg2LrLk61FefdcT+v+OwyLSIhd3Z0R7/9v8GpyZo+YUU1W7nvaoraJAU5cWjM1IU54Es0l6XUoWB1JYTxJz9T5EN9DuZvJO7EFVBgSD7XhKTym695YwKylr2/pyt9iHIWnBa2sA7qk+xhMEEkMrGMlo8nAEpvrhoXbEnLUYBoaLU/H276/Ak4gsRYikLqAzDbimT5gwb59NE7GQYbhLrMhJjbNCkvuiXjga3cfwpgBRmYV/QmAmy6GksiydA1Bp9zdvD4Y4kOqbg/JOqQsqa+zQLDm64U8zTdg3JcVanZA/qoI5sEzs4ETHc0TF+zuKfGo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 20af1ca418d2c0b11bc2a1fe8c0c88f67bcc2a7e commit: 237412e45390805e14a6936fb998d756c4eac9d8 [7237/10830] drm/xe: Enable 32bits build config: i386-randconfig-r051-20240227 (https://download.01.org/0day-ci/archive/20240228/202402282106.ou7DStPq-lkp@intel.com/config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240228/202402282106.ou7DStPq-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202402282106.ou7DStPq-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/gpu/drm/xe/xe_mmio.c:109:23: error: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare] 109 | root_res->start > 0x100000000ull) | ~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ 1 error generated. vim +109 drivers/gpu/drm/xe/xe_mmio.c dd08ebf6c3525a Matthew Brost 2023-03-30 50 7f075300a31829 Michael J. Ruhl 2023-05-25 51 /* 7f075300a31829 Michael J. Ruhl 2023-05-25 52 * if force_vram_bar_size is set, attempt to set to the requested size 7f075300a31829 Michael J. Ruhl 2023-05-25 53 * else set to maximum possible size 7f075300a31829 Michael J. Ruhl 2023-05-25 54 */ 433002ca367076 Michael J. Ruhl 2023-06-05 55 static void xe_resize_vram_bar(struct xe_device *xe) dd08ebf6c3525a Matthew Brost 2023-03-30 56 { adce1b393f90c3 Bommithi Sakeena 2023-11-17 57 u64 force_vram_bar_size = xe_modparam.force_vram_bar_size; dd08ebf6c3525a Matthew Brost 2023-03-30 58 struct pci_dev *pdev = to_pci_dev(xe->drm.dev); dd08ebf6c3525a Matthew Brost 2023-03-30 59 struct pci_bus *root = pdev->bus; dd08ebf6c3525a Matthew Brost 2023-03-30 60 resource_size_t current_size; 7f075300a31829 Michael J. Ruhl 2023-05-25 61 resource_size_t rebar_size; 7f075300a31829 Michael J. Ruhl 2023-05-25 62 struct resource *root_res; 7f075300a31829 Michael J. Ruhl 2023-05-25 63 u32 bar_size_mask; dd08ebf6c3525a Matthew Brost 2023-03-30 64 u32 pci_cmd; dd08ebf6c3525a Matthew Brost 2023-03-30 65 int i; dd08ebf6c3525a Matthew Brost 2023-03-30 66 7f075300a31829 Michael J. Ruhl 2023-05-25 67 /* gather some relevant info */ 0bc519d20ffa7a Lucas De Marchi 2023-11-17 68 current_size = pci_resource_len(pdev, LMEM_BAR); 0bc519d20ffa7a Lucas De Marchi 2023-11-17 69 bar_size_mask = pci_rebar_get_possible_sizes(pdev, LMEM_BAR); 7f075300a31829 Michael J. Ruhl 2023-05-25 70 7f075300a31829 Michael J. Ruhl 2023-05-25 71 if (!bar_size_mask) 433002ca367076 Michael J. Ruhl 2023-06-05 72 return; dd08ebf6c3525a Matthew Brost 2023-03-30 73 7f075300a31829 Michael J. Ruhl 2023-05-25 74 /* set to a specific size? */ 2a8477f7614a62 Matthew Auld 2023-03-08 75 if (force_vram_bar_size) { 7f075300a31829 Michael J. Ruhl 2023-05-25 76 u32 bar_size_bit; dd08ebf6c3525a Matthew Brost 2023-03-30 77 2a8477f7614a62 Matthew Auld 2023-03-08 78 rebar_size = force_vram_bar_size * (resource_size_t)SZ_1M; dd08ebf6c3525a Matthew Brost 2023-03-30 79 7f075300a31829 Michael J. Ruhl 2023-05-25 80 bar_size_bit = bar_size_mask & BIT(pci_rebar_bytes_to_size(rebar_size)); dd08ebf6c3525a Matthew Brost 2023-03-30 81 7f075300a31829 Michael J. Ruhl 2023-05-25 82 if (!bar_size_bit) { dd08ebf6c3525a Matthew Brost 2023-03-30 83 drm_info(&xe->drm, 7f075300a31829 Michael J. Ruhl 2023-05-25 84 "Requested size: %lluMiB is not supported by rebar sizes: 0x%x. Leaving default: %lluMiB\n", 7f075300a31829 Michael J. Ruhl 2023-05-25 85 (u64)rebar_size >> 20, bar_size_mask, (u64)current_size >> 20); 433002ca367076 Michael J. Ruhl 2023-06-05 86 return; dd08ebf6c3525a Matthew Brost 2023-03-30 87 } 7f075300a31829 Michael J. Ruhl 2023-05-25 88 7f075300a31829 Michael J. Ruhl 2023-05-25 89 rebar_size = 1ULL << (__fls(bar_size_bit) + BAR_SIZE_SHIFT); 7f075300a31829 Michael J. Ruhl 2023-05-25 90 7f075300a31829 Michael J. Ruhl 2023-05-25 91 if (rebar_size == current_size) 433002ca367076 Michael J. Ruhl 2023-06-05 92 return; dd08ebf6c3525a Matthew Brost 2023-03-30 93 } else { 7f075300a31829 Michael J. Ruhl 2023-05-25 94 rebar_size = 1ULL << (__fls(bar_size_mask) + BAR_SIZE_SHIFT); dd08ebf6c3525a Matthew Brost 2023-03-30 95 7f075300a31829 Michael J. Ruhl 2023-05-25 96 /* only resize if larger than current */ 7f075300a31829 Michael J. Ruhl 2023-05-25 97 if (rebar_size <= current_size) 433002ca367076 Michael J. Ruhl 2023-06-05 98 return; dd08ebf6c3525a Matthew Brost 2023-03-30 99 } dd08ebf6c3525a Matthew Brost 2023-03-30 100 433002ca367076 Michael J. Ruhl 2023-06-05 101 drm_info(&xe->drm, "Attempting to resize bar from %lluMiB -> %lluMiB\n", 96cb46df567e04 Balasubramani Vivekanandan 2023-04-25 102 (u64)current_size >> 20, (u64)rebar_size >> 20); 96cb46df567e04 Balasubramani Vivekanandan 2023-04-25 103 dd08ebf6c3525a Matthew Brost 2023-03-30 104 while (root->parent) dd08ebf6c3525a Matthew Brost 2023-03-30 105 root = root->parent; dd08ebf6c3525a Matthew Brost 2023-03-30 106 dd08ebf6c3525a Matthew Brost 2023-03-30 107 pci_bus_for_each_resource(root, root_res, i) { dd08ebf6c3525a Matthew Brost 2023-03-30 108 if (root_res && root_res->flags & (IORESOURCE_MEM | IORESOURCE_MEM_64) && dd08ebf6c3525a Matthew Brost 2023-03-30 @109 root_res->start > 0x100000000ull) dd08ebf6c3525a Matthew Brost 2023-03-30 110 break; dd08ebf6c3525a Matthew Brost 2023-03-30 111 } dd08ebf6c3525a Matthew Brost 2023-03-30 112 dd08ebf6c3525a Matthew Brost 2023-03-30 113 if (!root_res) { 96cb46df567e04 Balasubramani Vivekanandan 2023-04-25 114 drm_info(&xe->drm, "Can't resize VRAM BAR - platform support is missing. Consider enabling 'Resizable BAR' support in your BIOS\n"); 433002ca367076 Michael J. Ruhl 2023-06-05 115 return; dd08ebf6c3525a Matthew Brost 2023-03-30 116 } dd08ebf6c3525a Matthew Brost 2023-03-30 117 dd08ebf6c3525a Matthew Brost 2023-03-30 118 pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd); dd08ebf6c3525a Matthew Brost 2023-03-30 119 pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd & ~PCI_COMMAND_MEMORY); dd08ebf6c3525a Matthew Brost 2023-03-30 120 0bc519d20ffa7a Lucas De Marchi 2023-11-17 121 _resize_bar(xe, LMEM_BAR, rebar_size); dd08ebf6c3525a Matthew Brost 2023-03-30 122 dd08ebf6c3525a Matthew Brost 2023-03-30 123 pci_assign_unassigned_bus_resources(pdev->bus); dd08ebf6c3525a Matthew Brost 2023-03-30 124 pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd); dd08ebf6c3525a Matthew Brost 2023-03-30 125 } dd08ebf6c3525a Matthew Brost 2023-03-30 126 :::::: The code at line 109 was first introduced by commit :::::: dd08ebf6c3525a7ea2186e636df064ea47281987 drm/xe: Introduce a new DRM driver for Intel GPUs :::::: TO: Matthew Brost :::::: CC: Rodrigo Vivi -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki