From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F0CBC54E4A for ; Wed, 28 Feb 2024 11:48:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E72F6B00A0; Wed, 28 Feb 2024 06:48:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 296616B00A1; Wed, 28 Feb 2024 06:48:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15DDB6B00A2; Wed, 28 Feb 2024 06:48:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 03E9A6B00A0 for ; Wed, 28 Feb 2024 06:48:29 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AD3E51C10B8 for ; Wed, 28 Feb 2024 11:48:28 +0000 (UTC) X-FDA: 81841039896.23.B0C4FA1 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf26.hostedemail.com (Postfix) with ESMTP id C3CF114001A for ; Wed, 28 Feb 2024 11:48:25 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of gehao@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=gehao@kylinos.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709120906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=CzcHGzXEZRopItWiRbAzzztTORD73TitBv27e4Rw9VQ=; b=ZbvQNT2F9qQ4FC5ZTJ0ijbYC2riXwBLkstrEayNwbLUirMEBYbh+4uu2YnZjGMsuFUUSKP bZKgAcV4nkhGayMdYNZYOxu9E/CWrauN+CD45zQzgIGotHpXTIzbTJZDSsyzkeUPE507Xf BC83d47SUoX/Bu9l7cqzqaeyjt6HbMw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of gehao@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=gehao@kylinos.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709120906; a=rsa-sha256; cv=none; b=Z6dWbLEHM8kTgrcH3Rf0Qz2CR3wNGRuY8N7Om6rynwGmocTSasYOf7wecMzhjDsaqlQPJ9 GAWLQNymVoCft8vu79FosG+Ot15h9Eb56tlxylT8X6uFNsv89TlTcJ0LSiy6SvdlhOlfmQ lsnoWVx1LdlNfYHp1wUhgWCRY5tHoyI= X-UUID: dde3066479fe4382bc4efadbeab66e36-20240228 X-CID-O-RULE: Release_Ham X-CID-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.37,REQID:ed1b5a2b-df31-4a64-b9ae-00bffb2acdba,IP:15, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:25 X-CID-INFO: VERSION:1.1.37,REQID:ed1b5a2b-df31-4a64-b9ae-00bffb2acdba,IP:15,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:25 X-CID-META: VersionHash:6f543d0,CLOUDID:bf656884-8d4f-477b-89d2-1e3bdbef96d1,B ulkID:240228193342X0FU5XHX,BulkQuantity:5,Recheck:0,SF:24|17|19|44|66|102, TC:nil,Content:0,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:40,QS:nil,BEC:nil, COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: dde3066479fe4382bc4efadbeab66e36-20240228 X-User: gehao@kylinos.cn Received: from localhost.localdomain [(116.128.244.171)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 1002070599; Wed, 28 Feb 2024 19:48:20 +0800 From: Hao Ge To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, gehao618@163.com, Hao Ge Subject: [PATCH] mm/vmstat: Add order's information for extfrag_index and unusable_index Date: Wed, 28 Feb 2024 19:48:17 +0800 Message-Id: <20240228114817.360084-1-gehao@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C3CF114001A X-Rspam-User: X-Stat-Signature: afwqfszz5uc6ha7r1jp7ahpfneeeaneq X-Rspamd-Server: rspam01 X-HE-Tag: 1709120905-547692 X-HE-Meta: U2FsdGVkX1+RPmL65H6LtCjVKDWdaGGbl+lg4L6VqQiind9iTDnQbP7dMxsDxXed7b7NAyAY2sJP8gywJs6GoyZUmZiZkyU3kA5pLRqoLBuVzhyIDls84Giuz+9eQeJHB2MG2RHe35eHAN1k3a+kgAu6E9V4IDnR84QI4EcC2sNdeplvBCXbwo4VQnOPE3nvrAjz6+r6WlzUNaxqwo9GxvdMHqTB/IpYEcd5tR9D9rE3TB2ZXAQFMyFJXV5Khqh4YFXOvEg4EgigQLSr5e3aKLWHmCGpc77aXL3Mr/1TZuhEJY9EQK4kl5dNUqArOLdmPbtSNSNqKuVP6/xWfJZirhKpfsd3Qf1GmCjjnqwzh8SYnAfXw4hqA4s1kr+MD7KlGCyFHGsD7FVQA83N+BPXSvZMDDmMYHrJRSF9E9xClE2ru9sOEfSGcjxmFhObApk2VVvHTOYneXaTEZbOsmgP/MkmnDymvK37+bG8qyZJJjnHwGMkILlFmJaYsA2gzfkIyhiRQ9hw5Xle4CvLo1aawRsagbuym9vAibGhwPBFdUD7rlpTHEhiJAiAHso0PYxfUTRGwxeFdxlyL0I7s4sBhLEZyI3+9a0dpD/xsI+iiImgE2nL+iZEA2l6GS5HF0h2toF9jzAun3LxcK8YbUeBqvdvJAcVEIrtYD5PETHz3lxk8GyCEOuLLstE1q4sg5TAonttdI0f8XPwLb8Ln9Pwu5NMUbPSPqkkUAHTtXZjURc7eOps1KDMQ0kcDCNgLKASRc8otsJIz7y/gHICqd+/K2zgk8ahY6rIZs7IDHAO6aRUQPqIR/hhDK4XKadcvihdxpFqys3iXhg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Current cat /sys/kernel/debug/extfrag/extfrag_index and /sys/kernel/debug/extfrag/unusable_index is not friendly to userspace. We should add order's information so that users can clearly understand the situation of each order at a glance like pagetypeinfo. before: cat /sys/kernel/debug/extfrag/extfrag_index: Node 0, zone DMA32 -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ... Node 0, zone Normal -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ... cat /sys/kernel/debug/extfrag/unusable_index: Node 0, zone DMA32 0.000 0.000 0.000 0.000 0.001 0.003 0.007 ... Node 0, zone Normal 0.000 0.053 0.106 0.159 0.205 0.244 0.265 ... after: cat /sys/kernel/debug/extfrag/extfrag_index: Extfrag index at order: 0 1 2 3 4 5 ... Node 0, zone DMA -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ... Node 0, zone Normal -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ... cat /sys/kernel/debug/extfrag/unusable_index: Unusable index at order: 0 1 2 3 4 5 ... Node 0, zone DMA 0.000 0.030 0.059 0.085 0.096 0.102 ... Node 0, zone Normal 0.000 0.225 0.427 0.569 0.776 0.827 ... Signed-off-by: Hao Ge --- mm/vmstat.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index db79935e4a54..fe0b811e9d7f 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -2178,7 +2178,7 @@ static void unusable_show_print(struct seq_file *m, int index; struct contig_page_info info; - seq_printf(m, "Node %d, zone %8s ", + seq_printf(m, "Node %d, zone %11s ", pgdat->node_id, zone->name); for (order = 0; order < NR_PAGE_ORDERS; ++order) { @@ -2201,12 +2201,19 @@ static void unusable_show_print(struct seq_file *m, */ static int unusable_show(struct seq_file *m, void *arg) { + int order; pg_data_t *pgdat = (pg_data_t *)arg; /* check memoryless node */ if (!node_state(pgdat->node_id, N_MEMORY)) return 0; + /* Print header */ + seq_printf(m, "%s ", "Unusable index at order:"); + for (order = 0; order < NR_PAGE_ORDERS; ++order) + seq_printf(m, "%5d ", order); + seq_putc(m, '\n'); + walk_zones_in_node(m, pgdat, true, false, unusable_show_print); return 0; @@ -2230,7 +2237,7 @@ static void extfrag_show_print(struct seq_file *m, /* Alloc on stack as interrupts are disabled for zone walk */ struct contig_page_info info; - seq_printf(m, "Node %d, zone %8s ", + seq_printf(m, "Node %d, zone %10s ", pgdat->node_id, zone->name); for (order = 0; order < NR_PAGE_ORDERS; ++order) { @@ -2247,8 +2254,15 @@ static void extfrag_show_print(struct seq_file *m, */ static int extfrag_show(struct seq_file *m, void *arg) { + int order; pg_data_t *pgdat = (pg_data_t *)arg; + /* Print header */ + seq_printf(m, "%s ", "Extfrag index at order:"); + for (order = 0; order < NR_PAGE_ORDERS; ++order) + seq_printf(m, "%6d ", order); + seq_putc(m, '\n'); + walk_zones_in_node(m, pgdat, true, false, extfrag_show_print); return 0; -- 2.25.1