From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED719C5478C for ; Wed, 28 Feb 2024 11:33:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54B3E6B009C; Wed, 28 Feb 2024 06:33:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D5176B009D; Wed, 28 Feb 2024 06:33:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 374EE6B009E; Wed, 28 Feb 2024 06:33:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2583C6B009C for ; Wed, 28 Feb 2024 06:33:51 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AD22DA1658 for ; Wed, 28 Feb 2024 11:33:50 +0000 (UTC) X-FDA: 81841003020.02.42A4184 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf05.hostedemail.com (Postfix) with ESMTP id B73A2100012 for ; Wed, 28 Feb 2024 11:33:47 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of gehao@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=gehao@kylinos.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709120028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=Dk+CZxG6yuLFYwpMuvnwgZ44IsSnJHcDD1c9jRhY+mo=; b=m2GtlbkB25T1tz7mFYHH6kPXrnW5spnKetQqq9HIbOedtEKJMi+dJNkdr4d6qZuXWMHmeq mUg7uxSBge+YMnj277gKjfrIfBJcAsIlefYmuVIQpbT81M5eSac4Ldd8IBwHOJpYErQ85f /1EnaDeLytyRdnSpmGsyPtV9Nk2cMcE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709120028; a=rsa-sha256; cv=none; b=iITtGEwj3TI5rgRh305kNu5s41DwwFtQA43ApBRV8pQg1H7bQnIoJC8CU0Dl5pZ1hi34h7 OzgB5ZXdNDewyj1Wj9MD22Q0sTjFv41xeLXGblUDoeRBcmNC29oJfXtCoiwjdXgbFBjJoQ sXAZggk3k6wN8IJltrsOIf3+KtjonVA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of gehao@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=gehao@kylinos.cn; dmarc=none X-UUID: b331c0d2936e4880b6bfc3d435175d7c-20240228 X-CID-O-RULE: Release_Ham X-CID-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.37,REQID:dba71da5-5978-45d9-9c37-9661dd073651,IP:25, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:35 X-CID-INFO: VERSION:1.1.37,REQID:dba71da5-5978-45d9-9c37-9661dd073651,IP:25,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:35 X-CID-META: VersionHash:6f543d0,CLOUDID:17184dff-c16b-4159-a099-3b9d0558e447,B ulkID:240228193342X0FU5XHX,BulkQuantity:0,Recheck:0,SF:66|24|17|19|44|102, TC:nil,Content:0,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil ,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: b331c0d2936e4880b6bfc3d435175d7c-20240228 X-User: gehao@kylinos.cn Received: from localhost.localdomain [(116.128.244.171)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 1088047072; Wed, 28 Feb 2024 19:33:40 +0800 From: Hao Ge To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, gehao618@163.com, Hao Ge Subject: [PATCH] mm/vmstat: Add order's information for extfrag_index and unusable_index Date: Wed, 28 Feb 2024 19:33:32 +0800 Message-Id: <20240228113332.358801-1-gehao@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: B73A2100012 X-Rspam-User: X-Stat-Signature: jk9ny7ef9o4dt13okzis7phyh5agxrhb X-Rspamd-Server: rspam03 X-HE-Tag: 1709120027-926922 X-HE-Meta: U2FsdGVkX19F0dXqS/pLJ+4glHNH+Kgvtxmk0HhT/Pw7ql1TmgOl+GMANhAW6QgtMhlRtAfO4rFxAFl3s8QuOT7Vm3a2pm0TGpRbvemwjk44ffY7Ml8RQfC5jsEwZyFinVC0ngpMLaMfMmT9m4rCjIldVVKORVUdhAd0ajEEAh8Zu8ZpAOpXiHsmXoKAhopCKcqQDOhuvasLu4BsoJlzi03lre/MphvYv0miu/6lrjigjO/iaW8gSPyrgsf3E3+WP2OYpnO5H4Uvr7v4bcdvcKYDTSKHPuIE5UIDYQdd7GwAoGxsgQHZA8EaKCpyP2aU7v/LcuogeCoUISMgCi8JGlYq2e6Cy6dwIFaXLtgcLKBW0Hig1QdguJiXQ0qXQD5zxZEOtY3Wmt0dJoMwLOds7weNI0g70EJlEw6VSjIH/0iXlOlkeTYAQz+LncsodCzdpnBd0T+HSMTXZCALWH6nnMXp0HMD3dPL5EhLgUETIv0KagEDJ16oT7Ql/1ULrwswTIPRK+T+N2NNXf+GZUZvDOfmMFv6OVUjXM653I5i6FjV5YXBljbTRGr2qk1yFnobhqdk+pPgg3R/ADiiLxERAe6DYvAnyqVjM+2X3vU4qsLmZ8n9xBiCWw78Z+Qr5u6BAwsMS9yc8IWKxxzYSWwz4tMj93zDzbqPsvdGHOMHJ2mCxvrmioqcB9fU5jMbiMt5imvHOdXysbKe4WGvilgyuGI+TQ+H0+Q/leN4xc0cP3Bjg67aM4m1buxoetRql/KIlW3H9hKYRo/OhXFrFW5TCNv0mG1iNQE+U6Li95nvfNQmkeEBsYh+tyyTra54eP5fYbF/EAgi9vE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Current cat /sys/kernel/debug/extfrag/extfrag_index and /sys/kernel/debug/extfrag/unusable_index is not friendly to userspace. We should add order's information so that users can clearly understand the situation of each order at a glance like pagetypeinfo. befor: cat /sys/kernel/debug/extfrag/extfrag_index: Node 0, zone DMA32 -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ... Node 0, zone Normal -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ... cat /sys/kernel/debug/extfrag/unusable_index: Node 0, zone DMA32 0.000 0.000 0.000 0.000 0.001 0.003 0.007 ... Node 0, zone Normal 0.000 0.053 0.106 0.159 0.205 0.244 0.265 ... after: cat /sys/kernel/debug/extfrag/extfrag_index: Extfrag index at order: 0 1 2 3 4 5 ... Node 0, zone DMA -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ... Node 0, zone Normal -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 ... cat /sys/kernel/debug/extfrag/unusable_index: Unusable index at order: 0 1 2 3 4 5 ... Node 0, zone DMA 0.000 0.030 0.059 0.085 0.096 0.102 ... Node 0, zone Normal 0.000 0.225 0.427 0.569 0.776 0.827 ... Signed-off-by: Hao Ge --- mm/vmstat.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index db79935e4a54..f604d91e904c 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -2178,7 +2178,7 @@ static void unusable_show_print(struct seq_file *m, int index; struct contig_page_info info; - seq_printf(m, "Node %d, zone %8s ", + seq_printf(m, "Node %d, zone %11s ", pgdat->node_id, zone->name); for (order = 0; order < NR_PAGE_ORDERS; ++order) { @@ -2201,12 +2201,19 @@ static void unusable_show_print(struct seq_file *m, */ static int unusable_show(struct seq_file *m, void *arg) { + int order; pg_data_t *pgdat = (pg_data_t *)arg; /* check memoryless node */ if (!node_state(pgdat->node_id, N_MEMORY)) return 0; + /* Print header */ + seq_printf(m, "%s ", "Unusable index at order:"); + for (order = 0; order < NR_PAGE_ORDERS; ++order) + seq_printf(m, "%5d ", order); + seq_putc(m, '\n'); + walk_zones_in_node(m, pgdat, true, false, unusable_show_print); return 0; @@ -2230,7 +2237,7 @@ static void extfrag_show_print(struct seq_file *m, /* Alloc on stack as interrupts are disabled for zone walk */ struct contig_page_info info; - seq_printf(m, "Node %d, zone %8s ", + seq_printf(m, "Node %d, zone %10s ", pgdat->node_id, zone->name); for (order = 0; order < NR_PAGE_ORDERS; ++order) { @@ -2247,8 +2254,15 @@ static void extfrag_show_print(struct seq_file *m, */ static int extfrag_show(struct seq_file *m, void *arg) { + int order; pg_data_t *pgdat = (pg_data_t *)arg; + /* Print header */ + seq_printf(m, "%s ", "Extfrag index at order:"); + for (order = 0; order < NR_PAGE_ORDERS; ++order) + seq_printf(m, "%6d ", order); + seq_putc(m, '\n'); + walk_zones_in_node(m, pgdat, true, false, extfrag_show_print); return 0; -- 2.25.1