From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14678C5478C for ; Wed, 28 Feb 2024 18:44:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E6C66B0078; Wed, 28 Feb 2024 13:44:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 795F26B0080; Wed, 28 Feb 2024 13:44:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65DB86B009C; Wed, 28 Feb 2024 13:44:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5546A6B0078 for ; Wed, 28 Feb 2024 13:44:02 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 00DABA00E6 for ; Wed, 28 Feb 2024 18:44:01 +0000 (UTC) X-FDA: 81842087082.29.713DE99 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf11.hostedemail.com (Postfix) with ESMTP id D64B840015 for ; Wed, 28 Feb 2024 18:43:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=AeB1GBFU; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf11.hostedemail.com: domain of quic_eberman@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_eberman@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709145839; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bSo4+TpCIpKA9iK73ekA6ybmOXrnbL0luk3/aCyRvoY=; b=6r4wiZ4R5oO/WU8lglrhGgNhahh6w3WM6WuqxWuGap8L7EQqe5W12oQPpfrVptrnLuWPWZ blw1izPlO8YcwMvBXbFdgr4hIcU9yuEyZppgDKZBndOOgTqbjW5M1IeSjqdK5zzieSjbAk +J9oGZQKnaQtpGzlHYr6feJaoSmGSOY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=AeB1GBFU; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf11.hostedemail.com: domain of quic_eberman@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_eberman@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709145839; a=rsa-sha256; cv=none; b=LtGHnQoIaHhIRutYNRAQsiorfBLfCGCIFOLLRFwCDymgKiRfJR3/lj99q/dykOmK4JU/qP 0Lz+4LzFk2pIYFcfKvLOtAwyLNVKl/yubnVIci/xGGL5ah4dxgD/ANnNjTilK2BowJNxFA YEjoD60qaj8xgmHQzJfKzL8CAqGtUPg= Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41SHHq0K010622; Wed, 28 Feb 2024 18:43:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=qcppdkim1; bh=bSo4+TpCIpKA9iK73ekA6 ybmOXrnbL0luk3/aCyRvoY=; b=AeB1GBFU3sw8vhRbnKYXxCqKG14kR9yXz6rm6 Ud4b/y6NBZau3Onf0TQAeok9MWEXpa0ty6Qt1tu5r8nQ1zTEVebLdgWEiP4QfTGw R2SycslKjHpLHT/ODlo82PFad11vnBlCneXbay6Q2aQw33SZtNRdc0rcVIwi81xA 5vB1XkjkeT7DPj47+aWN6Ts99BppABMPWMqNY4kgAL9jCG+AAGq8Zv5baJxLCQvq 5yj5ZUvSBBSWVlSVlarAAY81QvzyIHnR/b1vPaypHpnt5AEcLk4fysgOmnWLcoYC FM6Xfm8kzomGMFegH78eAqxfbrL2Iv3+rtd0qN7VM6sEC1VAQ== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wj1d9sk6c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 18:43:29 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41SIhSir023355 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 18:43:28 GMT Received: from hu-eberman-lv.qualcomm.com (10.49.16.6) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 28 Feb 2024 10:43:27 -0800 Date: Wed, 28 Feb 2024 10:43:27 -0800 From: Elliot Berman To: Quentin Perret CC: David Hildenbrand , Matthew Wilcox , Fuad Tabba , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: Re: folio_mmapped Message-ID: <20240228103842643-0800.eberman@hu-eberman-lv.qualcomm.com> Mail-Followup-To: Quentin Perret , David Hildenbrand , Matthew Wilcox , Fuad Tabba , kvm@vger.kernel.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, keirf@google.com, linux-mm@kvack.org References: <20240222141602976-0800.eberman@hu-eberman-lv.qualcomm.com> <40a8fb34-868f-4e19-9f98-7516948fc740@redhat.com> <20240226105258596-0800.eberman@hu-eberman-lv.qualcomm.com> <925f8f5d-c356-4c20-a6a5-dd7efde5ee86@redhat.com> <755911e5-8d4a-4e24-89c7-a087a26ec5f6@redhat.com> <99a94a42-2781-4d48-8b8c-004e95db6bb5@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: BFRptV3lhNexvrzyysi2BMBXycZH1YyV X-Proofpoint-ORIG-GUID: BFRptV3lhNexvrzyysi2BMBXycZH1YyV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-28_08,2024-02-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=630 mlxscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2402280147 X-Rspamd-Queue-Id: D64B840015 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ocn4ppuc6gfphk686bme3cuh1j41ei8q X-HE-Tag: 1709145838-527134 X-HE-Meta: U2FsdGVkX1+sOyGJIc2w/MHv/Tlm9vpZmGrjZWpokI+lxAPDC8Be3AE68rBcskG9zWS4xw3CIKfxXlIaJWss+Z7duMxanjxmHEejteQ3IZ0ApKWvgFTkdD/2vAK17beMhoCh/AtrY9EkyYLKqoafrhZqyivvlf6VXTtWaIMO417vTnYcOZvlzk6vK3rDqanCYwhcrGB1b7G/auPJb0foZWGEAjmQdVHhlcbQc/gAdU/V2CBR0ivbShH0aS5vu0rcL9lSdQyIuGUJQAfWMWDiChxwmChQ7gOo9+wBeP808ew5/C6mjauCShwsCHWOq+C9VLrtcMt09XkwIaCM1VN+S7m9ehfxiBjYKAQBnNE+WNUFpkKvSq81LVKlTOWarOB2MVJzsi30qzcMwWr4NMxuy32AZZhz64CtzvpgLeeKW0GAGzWLKhgEjOFVY49UaaEP53PU5fEXgaWTaDxBppkJc74yaqOtv/OsskAuyRhvXBPcoV8SNljeqZ7R2SgDFTocFajoY0roGvk6CgbY18Up9MtvJc+5W15ECqVhnBGqeXepBHdLBqbPw/uYV9W5/HDqlKaY4vM0N11V7TBXIt4xfiiB/HYG9Ma1L0K9CTKGsLuKkZfYRvIRHFCtIRpEEy7j3Wb/Igeo1d1p0Sm+waPNxls7+3Z9eZHl/lon4dLNBvscSdghLKwPguZhOVKUU4n+OfHomsPaWPXKwNv7uHwIGxwnPVfiRW3+6EttA5URn85Pv8uoFbQHO5dIydTmEdmS0TucomKTcwyXevkTEhZqdItz4CQ7ew3ymQOPkvf+//UcLRo5vs36DurIt4MTOM4fa7X3QHsdFfG+3cUg4Na7WNhUBCL0BI5rDy4i+Er36NqXWjk1h88t4HZyE6qvCT30043Q9BVO/ijNzlyt9nqxh/VGl9+U5HwVpcLTUAkOsEblBnczHLgbmNDbyJX5pDEI4attf/aXMZ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001934, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 28, 2024 at 01:34:15PM +0000, Quentin Perret wrote: > Alternatively, the shared->private conversion happens in the KVM vcpu > run loop, so we'd be in a good position to exit the VCPU_RUN ioctl with a > new exit reason saying "can't donate that page while it's shared" and > have userspace use MADVISE_DONTNEED or munmap, or whatever on the back > of that. But I tend to prefer the rmap option if it's workable as that > avoids adding new KVM userspace ABI. > You'll still probably need the new exit reason saying "can't donate that page while it's shared" if the refcount tests fail. Can use David's iouring as example of some other part of the kernel has a reference to the page. I can't think of anything to do other than exiting to userspace because we don't know how to drop that extra ref. Thanks, Elliot