From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB8ECC47DD9 for ; Wed, 28 Feb 2024 14:45:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E7F76B0082; Wed, 28 Feb 2024 09:45:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 498236B0095; Wed, 28 Feb 2024 09:45:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3870E6B0096; Wed, 28 Feb 2024 09:45:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2A71A6B0095 for ; Wed, 28 Feb 2024 09:45:04 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DAABA1210BA for ; Wed, 28 Feb 2024 14:45:03 +0000 (UTC) X-FDA: 81841484886.17.3B6F96B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 38C2940020 for ; Wed, 28 Feb 2024 14:45:01 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=kAVQ=KF=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=kAVQ=KF=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709131502; a=rsa-sha256; cv=none; b=B9Xt9RWhQY0/iDwBugl8zuNUUoxYBCCEXcB9whtClO2SDtP7kR/curVuLcS3iGr2BCX14b kKth1V6nAMHOR8Nr30ZbdT6UV0QzekhlrF9wMR8cXdnjoJZL/CTmIzCw6g8BQYt0dZd/I7 twR4FDyLHo0LzrhUDZcNebfxgE+hRks= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=kAVQ=KF=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=kAVQ=KF=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709131502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n8Wi1Rs6i7bxtFbEc3nTCW9ulUDYTgEUWijKmkN35bQ=; b=YxZSJrK6dGke4GMjA2jPAekiZSm0z8xvdJKfIt0jC/nrhQpbRN9EA1GbVL961l6CmIhK3J IUIxDGBC7rRgSXebr9r3FtHGMK9tqY4BZOwpEO42dNUHXjhcpciOorTFGibqrJG2CfvJUJ Jvk5T541sm6lw6Eo+ejjWrBTG9T24jQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F0CE461857; Wed, 28 Feb 2024 14:45:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C8FEC433C7; Wed, 28 Feb 2024 14:44:59 +0000 (UTC) Date: Wed, 28 Feb 2024 09:47:03 -0500 From: Steven Rostedt To: Richard Chang Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, liumartin@google.com, surenb@google.com, minchan@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm: add alloc_contig_migrate_range allocation statistics Message-ID: <20240228094703.0aeb5ae5@gandalf.local.home> In-Reply-To: <20240228051127.2859472-1-richardycc@google.com> References: <20240226120728.3f495fa7@gandalf.local.home> <20240228051127.2859472-1-richardycc@google.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 38C2940020 X-Stat-Signature: bhbyyhd848nt8a96jqmyfdf4dcp3513x X-Rspam-User: X-HE-Tag: 1709131501-605017 X-HE-Meta: U2FsdGVkX19W+4rKBZ8eejWmRGFXUggpq18XDy+d4fSA2W7U8BdIJHBTt0x+uG6Okzy2Wa6OpFWeL/WS8+WtXWWFElIx5g1HHZb61cxwjlCA2SaqKEQMM7m8EmhRmM626oWofdOaV8D0vYnzmGW9MEfvKW/t+k8knWC2g40WyAETe+TOvCc0nIQZ8LHhllQxamMfnOTOqn/wragvIngZwzhLNQzeraolaPNGm9s9sBbABhbssVcny676q+dkLpZ/AWRJfGaHR/RoYHmNvUZFWbSgZHOWzyDpMeo/4v36SMioJRetkvvpy+ycllOhg5d8BKlde45JS6yWaDElnfDL2rZtJ5/k6xUENKtz8KQegqNCtQEZyMXORezbtDBUDUyEloXj+QcmqoTsm33170p40NynRfu99V9YeRUIRvGRAIGIV3kZILotXVB+YtIBU5zdqsyb8+TKbHOvGfdVDiZvfVM8qqTNQuz3YPN8Kd5rYhQogLWkbep4mnwlxcbWwApNPdVxNahkHRscNl86aS6ZqALxtVxJaLJr7F9cEd1kzw79SF4J6eZnbvCmBmiIWtPRGeaZ9rqjGLh+Yh7RfuJxbc3u22vo8meZe0dcWTMAYqaPFiCD/nMHKf4dYSH/VeIl4kYXYcs9VE1kG+3LK2uVfj0MLzypOju7Y6DzsUAAr4OBTULqQZLN24J6UFaOF+uN4Jz9vpBUPjZR3jJPzQiLkdU7vBUaYnBL4SE+JEpgVahC+K+B4q0gUZW32bxq5h+vtcI/s4Pwko8BjFwdJWZFKq640WRcZH6+rDKjc9JXtNqB41Y4K4lzLube9mI+4PPaYouD4ojYIhJPgmMAYYGX3MdgCejQFUh1L7CNybW/6cHyrU4rcSdZkkLEZ0p4qpFYk3bxI65VP+CUZM9ZlGfHm4zWvefUibKP2CMJohHq4JlBBCDnsYjdsFWuG+XlY4FuwuJQo+nmZy0WylYmFTY dwh6ZWSe YVvjnVBDEug4oST0AfABKZR0X+wNk1W/Xhlpw9qONw547XDMsZXImM4i5kejxR+VDD4+ePAZ2pOb28066bBQEKdIOd5P0FplhU2SHORdrYXavbAU1cZxetRG4a9qocp4CtJZINYdCeFy3UwPjySYfWo6bCTJhruTetvWfHtht2/gSSVZ3mDuWNXyxVG1jhT3LCL1boqirikQkmQ74mJi8q77iyvxV48q/8d9lCOro2Sbtp0xU1dciwg8fmrlGoilPbLB5De5JbHOzY4cRXqAXbWNHp6SP1cwueVJ/Xv+Yoww9gD52YneH0Pd8CtKQNev/0gQ+SIm7wDHqRkf+akIAz9uhUR2KxrAx2PQjmm8It+S8N78724Gwo6d/8rI5W0n5icXUEwjEYEkIbjkwchiwHJzggpB4CekQkIgd9lVxrs207jTS3WuAobFnaA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 28 Feb 2024 05:11:17 +0000 Richard Chang wrote: > alloc_contig_migrate_range has every information to be able to > understand big contiguous allocation latency. For example, how many > pages are migrated, how many times they were needed to unmap from > page tables. > > This patch adds the trace event to collect the allocation statistics. > In the field, it was quite useful to understand CMA allocation > latency. > > Signed-off-by: Richard Chang > --- > * from v1 - https://lore.kernel.org/linux-mm/20240226100045.2083962-1-richardycc@google.com/ > * Move the trace event int field to the end of the longs - rostedt > * Do the calculation only when tracing is enabled - rostedt > > include/trace/events/kmem.h | 38 +++++++++++++++++++++++++++++++++++++ > mm/internal.h | 3 ++- > mm/page_alloc.c | 32 ++++++++++++++++++++++++++----- > mm/page_isolation.c | 2 +- > 4 files changed, 68 insertions(+), 7 deletions(-) > > diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h > index 58688768ef0f..6e62cc64cd92 100644 > --- a/include/trace/events/kmem.h > +++ b/include/trace/events/kmem.h > @@ -304,6 +304,44 @@ TRACE_EVENT(mm_page_alloc_extfrag, > __entry->change_ownership) > ); > > +TRACE_EVENT(mm_alloc_contig_migrate_range_info, > + > + TP_PROTO(unsigned long start, > + unsigned long end, > + unsigned long nr_migrated, > + unsigned long nr_reclaimed, > + unsigned long nr_mapped, > + int migratetype), Well, you didn't need to change the order of the parameters. Anyway, from a tracing point of view: Reviewed-by: Steven Rostedt (Google) + > + TP_ARGS(start, end, nr_migrated, nr_reclaimed, nr_mapped, migratetype), > + > + TP_STRUCT__entry( > + __field(unsigned long, start) > + __field(unsigned long, end) > + __field(unsigned long, nr_migrated) > + __field(unsigned long, nr_reclaimed) > + __field(unsigned long, nr_mapped) > + __field(int, migratetype) > + ), > +