From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25D33C54E41 for ; Wed, 28 Feb 2024 06:14:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98A968001D; Wed, 28 Feb 2024 01:14:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93A2A8001A; Wed, 28 Feb 2024 01:14:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 802BE8001D; Wed, 28 Feb 2024 01:14:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 71BE48001A for ; Wed, 28 Feb 2024 01:14:08 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 222621A0491 for ; Wed, 28 Feb 2024 06:14:08 +0000 (UTC) X-FDA: 81840197376.22.48B4ABB Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by imf03.hostedemail.com (Postfix) with ESMTP id 695F720018 for ; Wed, 28 Feb 2024 06:14:06 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EgmRnI1P; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.167.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709100846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3YZK9rYAKLKlbEkTkUln4qXABZAOuRPgZMIaxIIRKSU=; b=l7n7//0RFVgGvPdbWBUCt5spXQXVZPihPPzfx+1ZsiQhFrhFTJ8v2WWh0ie0wmvFfY+Itg +0tbW0BN+qxvLj6T4woksQNAe4VrYcxkf+9haY7v9olqIwqM818zeN+4vtnzSSykR1iXD3 bH1L5ktuQRr6cwVaj/zSbvC1JCqV73o= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EgmRnI1P; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.167.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709100846; a=rsa-sha256; cv=none; b=DkCsaSpW/a9425YYbHdP45x/x6e2vyTi9ireBTf0nWDgGFd41zkMef62TDmbJU8cZsPlAf r/OcI32hIUWsYvGmK+IIIMilLQfAuELXkK31SQiayfkhbOSk+EJpGqE6Q8OJ22QSZxN+MI UiUFd9nXo4tSynYICsYYXSiiG2eojI8= Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3c15b7b36bbso2031474b6e.1 for ; Tue, 27 Feb 2024 22:14:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709100845; x=1709705645; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3YZK9rYAKLKlbEkTkUln4qXABZAOuRPgZMIaxIIRKSU=; b=EgmRnI1P+udgye0lGKzMWbOgQq7+wdtt1K7x2WbOkpASbGYVvd4g0rp+rT3YMEcCvW j0nr1FXx1Cg2Q/kB+HwnYdYe9BbhTcb1WPQ2zLl9cZnRzX2kPLWErHdgFpGfRpHMzyCp VHLGNvPkvr1AsN4fF6vhflkG+WI9pu6Jad7b4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709100845; x=1709705645; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3YZK9rYAKLKlbEkTkUln4qXABZAOuRPgZMIaxIIRKSU=; b=jFk5jY0WgmqU7snJvzXeBkpk4SmtbDOa9b2T9a7SIV4KfNkcyIoq/PdSKuivWpvEGu sDsZpikgjHurlpUF4FWiCDAurLOV1y7vrLc6tSa1Faua72GtVEfoykK0gX4yCguuTfC0 GayRfrY6G5KPNqPUW93AsBw9tglJS7WCaDG0V7OBheDnGgSgmeA/JV+qINvtLQYQGTgE UmvlLtL9IcrCABZZpvnapepOkUrkKWCQdq5c9jZ8WS2aFrXkUKgeU9jUn+bVjlcGGSkJ UuAcmNGkzxDuZNCJnPpp9HyxLMrKbX1hiytY4goD5vKQYxXTgemDhw0dMoEqJ/rqCSbt Bbwg== X-Forwarded-Encrypted: i=1; AJvYcCVdlPtgGhsBLmlBFEcPkYu0tmb7a1PFNT5WrYQ37uF5ccqkYrTYRAxmf1pfK6I0mlVcGj3UE1rLnJ89FYDacMnG618= X-Gm-Message-State: AOJu0Yz6/TjOAj4jFfEsoDVg6XCRvzeu+CB1QtVyTIWWLWClMfO91vFq 5UOBMtmnYJDas/MVNSs6gREza1RfTT9giluR0ExamPD0S8m/aiNBxu+Lv61l22VUI0jkHaTdZ7+ OPw== X-Google-Smtp-Source: AGHT+IEI8ekSagUeDaZFwR7wTPlSjwTCQ44y3FRd5rcJuls7tY+oxNVJARqKthLwgp48Es+n/vRmGw== X-Received: by 2002:a05:6808:486:b0:3c1:66e4:47dd with SMTP id z6-20020a056808048600b003c166e447ddmr4062283oid.16.1709100845504; Tue, 27 Feb 2024 22:14:05 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:50c1:1ad2:3268:cacd]) by smtp.gmail.com with ESMTPSA id e13-20020aa7980d000000b006e1463c18f8sm7002428pfl.37.2024.02.27.22.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 22:14:05 -0800 (PST) Date: Wed, 28 Feb 2024 15:14:00 +0900 From: Sergey Senozhatsky To: Chengming Zhou Cc: yosryahmed@google.com, Sergey Senozhatsky , hannes@cmpxchg.org, nphamcs@gmail.com, Andrew Morton , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] mm/zsmalloc: don't hold locks of all pages when free_zspage() Message-ID: <20240228061400.GL11972@google.com> References: <20240226-zsmalloc-zspage-rcu-v1-0-456b0ef1a89d@bytedance.com> <20240226-zsmalloc-zspage-rcu-v1-1-456b0ef1a89d@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226-zsmalloc-zspage-rcu-v1-1-456b0ef1a89d@bytedance.com> X-Rspamd-Queue-Id: 695F720018 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 3ef4o9kg95bautb85weykmutrskb34c7 X-HE-Tag: 1709100846-300893 X-HE-Meta: U2FsdGVkX18I6PPAU3jwWyeh/PpShE4W5nged2xul4Y5s82YbRhg4uNkxpEKTM1ZNNx4ZmXWxPogdhpRLEGc+AnZnqYBBw0X5eqZXE2cN+EOmkYz01Z50pvARpPavLYoEx3PN9n1x52PKAXfLc4XqC3Ca9hLEesx6J2jOTTTbGBgtutcGQDnSJ5zZTO95Q/DUNae9rsIoWY6zZZjbzq5gmFtLBjkHa6UOP0DiVhlGlP/kIPnkkIvqb6Nxwslp4SQSS3yDITs3ogAvykJvOgSH2i0tUMBwjHkxP9EfrwUCsRuxXtmhUnxDKwqhtKZJkPd/gqiPmq9dLrpCsf8c7+g/Gq7pjyjClRt/J8AT4p8gi4821THXDBZilO3ASXvxjDhJCcjfV9Hbpbx5NX0A4flVhTRsBaRpKTLojAY/RYdDLTObBNpvffq+8TTBVcbL9TE5WwkVFxUK/S5Gdd38fkA7zEufcoOikLKE+Q8+goCUbj+TvCfJ9fY1iM0a/1P7IXMCwZCS1KSKB4ltb5mNCSUHR8LBsrZpcBisvmPsRMD7vZCnCYg5Cf/ojOLJ9wDgH5KS+SBSMlz6oo2JlnRz4yYe1LTrVXYfuLWw+TH17n1LEgE8y7+YmJjTyRmZR0XChfChkvhMQMv3wQqzEw/M8rT6OTN/7LqxW0/s8MgQj9K+rvTJrX3lVujF1aTIwxt7nvIfGVpaYCYm90RZXOSemgQ6Fc1ydrMXVISmgmdWKA4YDu6EneqC3j3g9witG7CgxS81kzNRIdA5TfUPUAC2u1V7Z2i7qy3QteCjKLf5JpBs9l5zMVEjBe2C43qAuPwyJhSKP7QLvT8ecRLMuLHFg85/n3V+ZXo7Iv6bSpboROgVaUSu7bB5sSoUZkywSdJDHmgk87iQYH/3/1s2doAOFSelZvx4NZdZRz8EonW0Iot4CgxQw/t9KGMI++/FseWnrHEsHHGi10a+EGnDnetD7I YIcOl4MM U29CufyFnheQVX2rwGuw/NaHFIy6ugZqqtdCFKmOc9J5cLiqUFfOOY6HOD4ThFzqrEHR7ravQAoN27A7FjvvAnwaB3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.006182, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/02/27 03:02), Chengming Zhou wrote: > @@ -834,13 +841,12 @@ static void __free_zspage(struct zs_pool *pool, struct size_class *class, > VM_BUG_ON_PAGE(!PageLocked(page), page); > next = get_next_page(page); > reset_page(page); reset_page()->__ClearPageMovable()->PageMovable() expects page to be locked. > - unlock_page(page); > dec_zone_page_state(page, NR_ZSPAGES); > put_page(page); > page = next; > } while (page != NULL);