From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEF28C54E41 for ; Wed, 28 Feb 2024 06:08:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 602376B00C8; Wed, 28 Feb 2024 01:08:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B2316B01FC; Wed, 28 Feb 2024 01:08:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 453D68001A; Wed, 28 Feb 2024 01:08:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 323B96B00C8 for ; Wed, 28 Feb 2024 01:08:04 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 83EB4140DC9 for ; Wed, 28 Feb 2024 06:08:03 +0000 (UTC) X-FDA: 81840182046.27.9AFDE4B Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf08.hostedemail.com (Postfix) with ESMTP id B291416000F for ; Wed, 28 Feb 2024 06:08:01 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ESk4XMD6; spf=pass (imf08.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709100481; a=rsa-sha256; cv=none; b=EZ3xyMJrsR0rzKRMsnq5DvtyC95PikV7E4D4+lWpjwxvCNyYsfcn9FMzIJQjTZxG4x0A+d BVI7Vfky8Bh7zJv1Lk7OduU7l14tXbyt/a2l9pIIZ3c0zSyP7xYfhdeA3Pv+K8z7dIZ4XW eGJPxWj8vFmEuDclJQOO9jFVYuUxV40= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ESk4XMD6; spf=pass (imf08.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709100481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MeKU9LAERyJoKW+mNk4qVeJIhy/Zeo/llG2Crnx8dtI=; b=FVHeN8Ic5fBHYocGY1srjsouf2BOxAAaSObJoI2fkH7//00v5MCwJKpR0pNDcxp/nc5qDg 9AE9fkJgHq36sgkf2qCzDYC1fInxPJaH2d+1LudMnWbvrdkrP987HDoc2LY+GhxsAE53B2 CZQG9wcIZgWRt/fTXR/ENrNy0mKce5k= Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-299b818d63aso431983a91.0 for ; Tue, 27 Feb 2024 22:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709100480; x=1709705280; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MeKU9LAERyJoKW+mNk4qVeJIhy/Zeo/llG2Crnx8dtI=; b=ESk4XMD6WNdczVd+FZEhSMz96Stf3hVzpKAvvwALqMtVy+aLvFYH5S0NU+eergCPi5 KBFmVWRpCAjLmrTHXfqqrfrbMD1MXKcyTuqwE3slmiH6EpjuZG5jimOMN+al3GQOcCqb Sf+fVAqXqSm+E+5/27q9NJM+Nhb/NblA9WcLY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709100480; x=1709705280; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MeKU9LAERyJoKW+mNk4qVeJIhy/Zeo/llG2Crnx8dtI=; b=U1UuxNg63LnL2GQT0ytIX6v9L7kaxfOV6t5q+xNiJq9buJ4KGsvaCtE6tzfl5AMDng grhDbkPdHjstzFLD+OIq6opkllwLUQ4L8L3RJBQ/lPDdkJexAka6RU7+QHf5Ldm+vYd4 4Lb+DRn/BIAN7bGiAUXsQe61ycEH9Bo1Xb+YzammM9zeC+rsUOOYOwVqitFDOp1o90k+ lxsFJJSdVqzTa0egrDuL4vMCBy3tvQCTPLH+nxnbWBvYEeuNLGfAIXdINFZq3oz4tSrl EXunSQJpel0pITxiwGMFlhzmFWevzQYQ+6/PYq73Xbncmt+0VahAmVPE7fbhkvy8DgmP S/MA== X-Forwarded-Encrypted: i=1; AJvYcCUDeuK1+WncPCgb0peliYG3gg2NUxVbRKI59aLAXPaFIxh7nSoMy7JrUqc60L44cH2F/NlhSEvUFw9kS6YEpmcvmSE= X-Gm-Message-State: AOJu0YwiQge2mmATWLoHYYhlbFSyXNuRNLlmaqUvaDhcHcI/tj2woOHh p+0qt9wj6h1A4si5XV7jjda7S2SpMBLi+GoY49p0QRiGwCtBLJaObF81u2q5ag== X-Google-Smtp-Source: AGHT+IEu++Dtdm+Ls8/lxFgAIO7qDrPLVd2IJ6PrQUeBFnqrJPVzqTCR5jKvm4uWQjzqFBDNcn0Qsg== X-Received: by 2002:a17:90a:2ecb:b0:299:1cce:f3c3 with SMTP id h11-20020a17090a2ecb00b002991ccef3c3mr2161789pjs.7.1709100480487; Tue, 27 Feb 2024 22:08:00 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:50c1:1ad2:3268:cacd]) by smtp.gmail.com with ESMTPSA id ta6-20020a17090b4ec600b0029a849e7268sm647056pjb.28.2024.02.27.22.07.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 22:08:00 -0800 (PST) Date: Wed, 28 Feb 2024 15:07:56 +0900 From: Sergey Senozhatsky To: Chengming Zhou Cc: Sergey Senozhatsky , Chengming Zhou , yosryahmed@google.com, hannes@cmpxchg.org, nphamcs@gmail.com, Andrew Morton , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] mm/zsmalloc: don't hold locks of all pages when free_zspage() Message-ID: <20240228060756.GK11972@google.com> References: <20240226-zsmalloc-zspage-rcu-v1-0-456b0ef1a89d@bytedance.com> <20240226-zsmalloc-zspage-rcu-v1-1-456b0ef1a89d@bytedance.com> <20240228043358.GF11972@google.com> <5a556476-05b2-483e-8875-eeb3e2a51151@linux.dev> <20240228052906.GI11972@google.com> <913f1a04-8fa2-46b0-85dc-edd23477a1d6@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <913f1a04-8fa2-46b0-85dc-edd23477a1d6@linux.dev> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B291416000F X-Stat-Signature: ricynm5inei4tjuqcpyq8xsyafejm4mn X-Rspam-User: X-HE-Tag: 1709100481-399159 X-HE-Meta: U2FsdGVkX1+fCNelOB4uFJjNSKRuQDNdMuF2FyBgwbalkjeCuN5uJLdYWO/zdKKxYZp2oykXQX+fb/9ch6Mr/t4LNx7+5LvfdEskhtD7dB2achUpfWiHGEorHuEruP9up26ghrCTykJKGCOPALNaueTPyJE3ZDi/lxZQeaY16iXYGFNV6W+i/IgmjYPFk19spQjNn3xoC0I6rK1MyW/m7MM0zlNeNzIbWMoDBKVI8AbX1ysZTy9Gy9zzS8F7Dzho+KZubXfUFq5yLc+5LFY8SizY4tYAJGa5IU9+7Kcl2PvM0UFYl+gjTr2k+cZohJWK4UfF+W7fvFtk4JPXrZ4dNVDjURAwco6Q6ygUG2H8VfaJoFmeL/Pv0iqRHC9fVO2KJ8qYaHj2GL0B5TeZDZBcIURSOjfBBNCeJshDG5cJErixrh2xjlsQklEfo1pffkWqNHAWZ3x+WvymCajVlZ6cuE+VJn8Ws5JFfX6po2IcGk/1L4B0tV49KogSm/OitMWuZHDvwk0zgbcQyBU2DTBrEfc0NU0MML6aVfiFXuYSrj+iMcWNhuv1A9bpR/m4CTOQ+h0V8plEA4v3MAM95UyAz5bKliJfC3auYT3wLsjDtn5NjSPMjjDsOBunRElO76oZpBG11kcw18H3GlO5mqvtMnCFkmkO67gteKpAyGrQey1jbPMGOWv8TVTBqUalKWghDgjzs2nbGwnfwINfaiZ8KpgMQ/bVMX4SNlD09B4VZyzzKHsY3zrZjPV/NfH8E8gEWDoww2uDsVU5O7I9d3VQb6uwKWsXhxNCCkqSUv1srAklIyyi89ellJ2MyVYn/MDI1XZHhWZ1aDmFk9Bm1eRXd6lFBLjiyo8Dy4O/LcjHbr778mVyeM8Er71Ud6bDnufjNgngq7MH/D2EdDUWjrzDGysRLUHeLfzNHFDIkgOpsJ32kW72UB28H5BvskDHNUaRhv10g385Tgz42K4V/qu fd61kF8x XV1XEzGWqjOeUSRLu5jPChuljI17FJQcGuxfGsWYoeDLoPEpdFdcosFMu3o3CTLU0o4tgQZSJ/a1u5/HciLRYicdjl1KtZUBiQxTouEeWklAKldClgQcRPBDjYxi+e5EmYfTi5wjMvKv4JoKUsyVWp6+dtYQJ0/KoyGfOiw7i1OlaXVeLUiQCbFI9rS7NgU4Da+D2xm527tqb2KP9aEbHHhZI9gJ5zVczPPFZzrzVQrOGAUzZBnUUPR4CAD2rNeUb+L/+OrTbAuHsJOjtkYfNVU9dS+eG7LJENnfQQkwJJyMHBGYvClBOD34VJk/qrzVat8l5UtZzFb/X04vLjz1DblXttdODXOTdbpvh6xVFDfTgKtJHnhwn3liRSt6ihGdkIKoeRQhVB9nsEtKo87m9+wUN2nSrv0U/QYzQ9QKSBTGfrcbnRtFtq1KisA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.108072, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/02/28 13:42), Chengming Zhou wrote: > > I'm curious if we want to add RCU to the picture, given that zsmalloc > > is quite often run under memory pressure. > > Yes, it's a reasonable point. But given struct zspage size has only 56 bytes, > it maybe not a problem to delay its free to RCU? Hmm, yeah, probably. I think it'll make sense to wait for more "go for it" from Cc-ed folks before we land this series.