From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13AE6C54798 for ; Tue, 27 Feb 2024 19:55:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F5B86B00D2; Tue, 27 Feb 2024 14:55:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A58A6B00D5; Tue, 27 Feb 2024 14:55:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56E496B00D6; Tue, 27 Feb 2024 14:55:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4602E6B00D2 for ; Tue, 27 Feb 2024 14:55:50 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 12B96407EB for ; Tue, 27 Feb 2024 19:55:50 +0000 (UTC) X-FDA: 81838639260.21.84C353B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf23.hostedemail.com (Postfix) with ESMTP id 1B45A140005 for ; Tue, 27 Feb 2024 19:55:46 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ops7MKwB; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709063747; a=rsa-sha256; cv=none; b=A+gWZFGiVltHI7FVfCSHabBU7l4Ghr64rkqYbl+djA4rIVUD/lHDL+92JQf3aiPqMnx9MB PAXfXH4loNGomx2W0tIqk0LPc6vHHID357guRmQH/X4JJ+tk5myxbGOpsdJz6+u+xCHKX6 1Ax2uZ/YYEKy2X8cuIid0/9d9xmEsLM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ops7MKwB; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709063747; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nVKKjBGZBNVGf6OwLZyZyGonKoSO3R8cfxdMlfH8u6g=; b=CHsWYDLRE+CHukzR7N6a5NQ9ED2NYIVwNTT4hHZyRAzHUyxOkjMBhnJgOtI/ltABHqhkON M+rJqqkJ6vkTWJGmtbWbyMKI4yS/BElEd69ayhtc/Ra4dQE1jQHg7Kju0OwpZWn9Y+a/s3 wv2TCMbRc/uPi+vrFbzdo/m/VqkyCPA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 84796CE1E0C; Tue, 27 Feb 2024 19:55:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E71BC433C7; Tue, 27 Feb 2024 19:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1709063741; bh=OyB1FZjaf1PzIZ/uCQbw5IVpIlu4PSebi+PSu2voeKw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ops7MKwBwhD/cocQhoMGmD2bkf4MEs8CR4daooX6zw3zMxK57OCDSh4wP9WlEiSbf 7z/NFrFlLx2OPxLQWj0lMnIf0kq8HSAYbM180rXxP2OW9XsirlnDKvIz8cK0GSfqh/ Am42SX326legpzG7i2w4cJXkSIg1JiNQtcQetVEY= Date: Tue, 27 Feb 2024 11:55:40 -0800 From: Andrew Morton To: Kent Overstreet Cc: linux-mm@kvack.org, paulmck@kernel.org Subject: Re: [PATCH 1/2] mm: vmalloc_bytes() Message-Id: <20240227115540.2dbf9bde0f3ccb7163030ab0@linux-foundation.org> In-Reply-To: <20240227072515.3736069-1-kent.overstreet@linux.dev> References: <20240227072515.3736069-1-kent.overstreet@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1B45A140005 X-Stat-Signature: gbfqaghx5fqiwwoujhczu6mto8yo47xy X-Rspam-User: X-HE-Tag: 1709063746-315673 X-HE-Meta: U2FsdGVkX1+4id6eVrfpkzupsndXQ8fwOdGXgmVzaLJeSymTEf0c34/Yj5w0HRmEe5hdXISfCEmTeEsAIsIxMGd3jX+qJlwTp4OHuC69TeF8EF6aBFAf5m58dsstTkLIWJQe0ysq/e9kPiQE6YS6hKUSRpVQbO49ib8JaT38oDiY29q56DSX0lYudBJMRRmj0ELmC3b29Bj1b0jbrYDatNoFLH+A7OhNy58G5GIJ5js6wJ3R+i/72oD0J31G7EdO8Rdh8e3c2HavpX0CJrWkbZck3s3VfAFcLN32iJtufOKzb51gL3o6cmsWEH/0kTvxWJVFvqpgavXSalYqCRRmvQrYX0u3PhgdKseA9Qa0fljRm+kam0LwrMhG9htrq7X32h+J4NaaOYDJynFWT+xDNK3zxD8cCAciebt/V8FimuVynRgPv2LqLdVhTPtwO4BOZbNiND9Lj6+8Hq75g7f9TX3JYFCi18e/MltgnVebb+zU3XsmSruEQfW1vfajMKCY4FOVYL7m7g3z7iEDRuTulRHd7x5+N4KPYLH4Y9Ajmp5Wt78y9mDb5h88qI8YW/QEIHAw0AlpGiQPeP8OPthsVVdOS33gItEOsixKABaFx0uWwCMXSf/hulPk3SOiCN6xjGZgeB3n7s7RrOLffuWJpgqE4+I8bdiZxyRC5TOu5mDhJi7SEXXYxfFklzNY+aqwHLeIv9mFcImEiQMr0vNNNTW8vBjYvtY2bdG1FmXCgZuGdcJr4Nc4m9KJWJmzx/za9BF5PnSRfgVMJXIUQNJIKL5KbImwaP0NnX1j7z5ultOMYDAJ9h+fO70PY65g9uS+ozpEX8b0JAXxNz6MhOvMayFWaF0gMvTZ7rLQqhVr7Yuzz+H6y/LKuxBEn2GcRgiG7bxLIxp5JvCmPLvc2SmdWzctAz/2s31o+l3ykIWixq78xEn5ksl/nF2iU069mfOai5Xb2JcqOpNq4J7JnSt FXQryJ3n O8C5V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 27 Feb 2024 02:25:14 -0500 Kent Overstreet wrote: > Add a __ksize() equivalent for vmalloc. > +++ b/mm/vmalloc.c > @@ -2848,6 +2848,26 @@ void vfree(const void *addr) > } > EXPORT_SYMBOL(vfree); > > +/** > + * vmalloc_bytes - Return size of a vmalloc() allocation > + * @addr: Memory base address > + * > + * Returns the size of the allocation as passed to vmalloc() rounded up to > + * PAGE_SIZE; does not include extra internal allocations. > + */ > +size_t vmalloc_bytes(const void *addr) > +{ > + struct vm_struct *vm = find_vm_area(addr); > + if (unlikely(!vm)) { > + WARN(1, KERN_ERR "vmalloc_bytes() called on nonexistent vm area (%p)\n", > + addr); > + return 0; if (WARN(!vm, "...")) and I don't think the explicit KERN_ERR facility is needed?