From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DFC3C48BF6 for ; Mon, 26 Feb 2024 17:32:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD89C44018B; Mon, 26 Feb 2024 12:32:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C876344017F; Mon, 26 Feb 2024 12:32:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B28AB44018B; Mon, 26 Feb 2024 12:32:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9F08E44017F for ; Mon, 26 Feb 2024 12:32:50 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7E94216038E for ; Mon, 26 Feb 2024 17:32:50 +0000 (UTC) X-FDA: 81834650100.17.DA892B1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 8450C1C0006 for ; Mon, 26 Feb 2024 17:32:47 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="bP/tW2NF"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708968767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kqqrCFIsY8CEirHFadCU6rUAaGvN/swA6tLqh5Cpgso=; b=AxkM2kaTEL5Ex/GUIFSjRSTRqizPDzNeMpdhzPEKfTcqvonJyN5bs0m4jAwzE+NpsO5rtS AyYrU2Uk3hBSb6V565Mcxep7ntMa6ivImpbds7uoOcd+ONnOkwJhG+N1YWrUOUPfKqFDNK UQn6Nn+3Ml9+8uTk1kixENycUwGNKsI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="bP/tW2NF"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708968767; a=rsa-sha256; cv=none; b=2nID+5dt++zEYieW39I7FotPWGHfWA8gdpIMLO+Qh07pnFLcdiL3Ky5ds5Lhoid9Ww7vFu 8UnnQMkTrMp20V2NnHeex0q4OQ81dbwtUfXnfBEAh5GRtCV42wuDputCaq7r6eTzamPHV7 bQqpDuFp+jMI+tCLbgL355ksCwBSd6E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708968766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kqqrCFIsY8CEirHFadCU6rUAaGvN/swA6tLqh5Cpgso=; b=bP/tW2NFRXfnyGHvqkaZT8Y+tGBlxSrZbrGXbZIYwBvzsYPTdEb0mOnayK+ZZlwIv+A0Dy LsjY5Nh36puIOyngZqmq3o5aIb/bvisxhe8dkl8RkqQyk+rT4qP7pfkMfrejSgVG3727CW 9TNuhhskIY5X6VQpDxy4AdPfqj6rld4= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-133-fom4yQvXOm2J5fDsMVL6Xw-1; Mon, 26 Feb 2024 12:32:44 -0500 X-MC-Unique: fom4yQvXOm2J5fDsMVL6Xw-1 Received: by mail-io1-f71.google.com with SMTP id ca18e2360f4ac-7c49c867608so299772039f.3 for ; Mon, 26 Feb 2024 09:32:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708968762; x=1709573562; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jjX5ODwMNKFdWrkJxr6VORv+MaO7Rg0pnbcoAEeofYk=; b=ew/Ev0pZnma0c/seui1MMWhAIADX45BvD9GH42uc47zYFBZDDIgWAd6j7crXS2003o aLRLUVOZPYx6BptlPG8pJgobxRr4aJWY9gi3u63wyEGg/4BPp/8yUxSBiX2d/ogjYH4E pZDWfF0WS3QwLOKXi3Z7SnzYhBFB84IBh0+s7QuyYRfTfiXhN0Ntp8Y2X1+ESAdugZrj zlgFKOFc6dvtNr0yRKgreNKqauRF3hzraHiCeVwRRP/CxVfLsiMzLFo5BTPNNRDuXEkH Q2mc4SWczqhIoxLDlfcqvkpWx960Ko1ALVgtBtW1quHGJw+ffxOtlGb1QfmttwunT4YC E+Wg== X-Forwarded-Encrypted: i=1; AJvYcCWZcvZN1eAYVjRI7MLHhvt6EjBVeFOULn5Jl7o9Qol7XR4yyx4vUDs9wJE3EQMDMLIq+02+Rqe7VpBS6o01Xij2EoM= X-Gm-Message-State: AOJu0YxzF/9A4nWre2NbXQl4//QpFAvLM5qgBD4RQ8Ov1QgH3r9JLjrq mKFB/n3cZbg++JUiqxcQ/2nbXrGDmRd2tMutR8x/EO9qDo4XEkVebhLxbwVkPTan3gKgwzVCVzE af0BkbSrjZqM3E9mA/aqgzfY8XhtSdvYI3SQsRsg+jVuJSpvl X-Received: by 2002:a5e:9918:0:b0:7c7:ddef:e11c with SMTP id t24-20020a5e9918000000b007c7ddefe11cmr1182617ioj.13.1708968762182; Mon, 26 Feb 2024 09:32:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IE3PtDchAWOks2wYjwP0Dxg5ziZwMLLpYh1GoHJItPvKLJWbBcCVrM6sR+YAQ8RAultSmbccg== X-Received: by 2002:a5e:9918:0:b0:7c7:ddef:e11c with SMTP id t24-20020a5e9918000000b007c7ddefe11cmr1182575ioj.13.1708968761491; Mon, 26 Feb 2024 09:32:41 -0800 (PST) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id r17-20020a6b4411000000b007c7a2b8ee98sm1356778ioa.2.2024.02.26.09.32.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 09:32:41 -0800 (PST) Date: Mon, 26 Feb 2024 10:32:38 -0700 From: Alex Williamson To: Yisheng Xie , akpm@linux-foundation.org Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] vfio/type1: unpin PageReserved page Message-ID: <20240226103238.75ad4b24.alex.williamson@redhat.com> In-Reply-To: References: <20240226160106.24222-1-ethan.xys@linux.alibaba.com> <20240226091438.1fc37957.alex.williamson@redhat.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8450C1C0006 X-Stat-Signature: gj6pnqj1jmiuizx1sqjen7jep3odq6b3 X-HE-Tag: 1708968767-470873 X-HE-Meta: U2FsdGVkX19KyXi+jDMcuw9yVRzzQFCfGwo26Jm0cNADUUsUOHBbvxtwxmw2eiOb11umMu7kP6kExsWQxDShfyg4P3dI30HGKlsx0m3iQUPndQkt+qf8FopQi8nVU+VwEtsGLMZt1sG8eAt6jk8Cb1l33idYYmg89iNcxlE7cQYIXxViEj3n34Enar7nW0UMsgWCIB308wAOAcHmhO1bVzjyPyQ1yhHxoIj8QjZAbYZV3CTfFvNAQW9I4BRgincJ2F4vUNb5fXvxt7ir76G9+r9nUBol0GOZEJ2RARusFI6v1PbXokyeY5v5Yf0lgpnwaMUIlzyhq5+ClUcwOebP/MKwtkOXypDTFG/khcev1CuLuV5B2kVxR37W3bdaKH3QxqZJq0F5uAkVaBFEhi2NGpY39/ZXa061se1TbyZqNj/J6S2UAxFOkRNeh1g6R20wR0ZHvPh7PosdOoqG6REJWFKurEVGJwf9A5nxVJmgc127wi/4QapmGhSzVVCfTylTYLUaFjJBqY+lNt0+qxJGrT7seuAZBVDzmbeizwj3y6ntEULCSlXSSSTqcqCIosndvY6JG+Yif/3jTmgCt3FGgLsEGtpxzxqK334Xxe9YRORumrUxEupSe/nGAotWCSKZZzQ1nqv4aNy6cfYQp6z6S/KSAIr2k86H/WJSwjAaE62Mo/9VFmplHJPKegkBZSaibY8TpB2Wmr84C2fxSe0K1B/eOYrfOpe23du/9Tkby2FmN/C4Os1PNDjI2QEqTGbVQRPUB+jg2Zjo2n+Mb0IgRydNREevvFMEkC56aR5h33IFviad1HpJicOQLTxZjyKHDlNhpfQ4nmuNp03vzmeBvikxIKcdoFfYQdVtfxONhTT9Cr8XqZXQyk7GlZIfgJy9dB/2jZ3sqPfTo06CSF478BxzMkkUFvQn8+CG3lqHbWNj6V7HgAuEhsneflJIzmm/qYuVgYVyYn5LeXe1hot 5g9KILde l89EBQ9R1ZRLMHer6ai7qee3lD+4KdbwNsC2bxqWjeSXxcjAIyfpabFQCP2+FZCLcfQLBsi6RVTW1n+0gelTBblauQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 27 Feb 2024 01:14:54 +0800 Yisheng Xie wrote: > =E5=9C=A8 2024/2/27 00:14, Alex Williamson =E5=86=99=E9=81=93: > > On Tue, 27 Feb 2024 00:01:06 +0800 > > Yisheng Xie wrote: > > =20 > >> We meet a warning as following: > >> WARNING: CPU: 99 PID: 1766859 at mm/gup.c:209 try_grab_page.part.0+0= xe8/0x1b0 > >> CPU: 99 PID: 1766859 Comm: qemu-kvm Kdump: loaded Tainted: GOE 5.10= .134-008.2.x86_64 #1 =20 > > ^^^= ^^^^^ > > > > Does this issue reproduce on mainline? Thanks, =20 >=20 > I have check the code of mainline, the logical seems the same as my=20 > version. >=20 > so I think it can reproduce if i understand correctly. I obviously can't speak to what's in your 5.10.134-008.2 kernel, but I do know there's a very similar issue resolved in v6.0 mainline and included in v5.10.146 of the stable tree. Please test. Thanks, Alex > >> Hardware name: Foxconn AliServer-Thor-04-12U-v2/Thunder2, BIOS 1.0.P= L.FC.P.031.00 05/18/2022 > >> RIP: 0010:try_grab_page.part.0+0xe8/0x1b0 > >> Code: b9 00 04 00 00 83 e6 01 74 ca 48 8b 32 b9 00 04 00 00 f7 c6 00= 00 01 00 74 ba eb 91 8b 57 34 48 89 f8 85 d2 0f 8f 48 ff ff ff <0f> 0b 31 = c0 c3 48 89 fa 48 8b 0a f7 c1 00 00 01 00 0f 85 5c ff ff > >> RSP: 0018:ffffc900b1a63b98 EFLAGS: 00010282 > >> RAX: ffffea00000e4580 RBX: 0000000000052202 RCX: ffffea00000e4580 > >> RDX: 0000000080000001 RSI: 0000000000052202 RDI: ffffea00000e4580 > >> RBP: ffff88efa5d3d860 R08: 0000000000000000 R09: 0000000000000002 > >> R10: 0000000000000008 R11: ffff89403fff7000 R12: ffff88f589165818 > >> R13: 00007f1320600000 R14: ffffea0181296ca8 R15: ffffea00000e4580 > >> FS: 00007f1324f93e00(0000) GS:ffff893ebfb80000(0000) knlGS:00000000= 00000000 > >> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > >> CR2: 00007f1321694070 CR3: 0000006046014004 CR4: 00000000007726e0 > >> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > >> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > >> PKRU: 55555554 > >> Call Trace: > >> follow_page_pte+0x64b/0x800 > >> __get_user_pages+0x228/0x560 > >> __gup_longterm_locked+0xa0/0x2f0 > >> vaddr_get_pfns+0x67/0x100 [vfio_iommu_type1] > >> vfio_pin_pages_remote+0x30b/0x460 [vfio_iommu_type1] > >> vfio_pin_map_dma+0xd4/0x2e0 [vfio_iommu_type1] > >> vfio_dma_do_map+0x21e/0x340 [vfio_iommu_type1] > >> vfio_iommu_type1_ioctl+0xdd/0x170 [vfio_iommu_type1] > >> ? __fget_files+0x79/0xb0 > >> ksys_ioctl+0x7b/0xb0 > >> ? ksys_write+0xc4/0xe0 > >> __x64_sys_ioctl+0x16/0x20 > >> do_syscall_64+0x2d/0x40 > >> entry_SYSCALL_64_after_hwframe+0x44/0xa9 > >> > >> After add dumppage, it shows that it is a PageReserved page(e.g. zero = page), > >> whoes refcount is just overflow: > >> page:00000000b0504535 refcount:-2147483647 mapcount:0 mapping:000000= 0000000000 index:0x0 pfn:0x3916 > >> flags: 0xffffc000001002(referenced|reserved) > >> raw: 00ffffc000001002 ffffea00000e4588 ffffea00000e4588 000000000000= 0000 > >> raw: 0000000000000000 0000000000000000 80000001ffffffff 000000000000= 0000 > >> > >> gup will _pin_ a page which is PageReserved, however, put_pfn in vfio = will > >> skip unpin page which is PageReserved. So use pfn_valid in put_pfn > >> instead of !is_invalid_reserved_pfn to unpin PageReserved page. > >> > >> Signed-off-by: Yisheng Xie > >> --- > >> drivers/vfio/vfio_iommu_type1.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu= _type1.c > >> index b2854d7939ce..12775bab27ee 100644 > >> --- a/drivers/vfio/vfio_iommu_type1.c > >> +++ b/drivers/vfio/vfio_iommu_type1.c > >> @@ -461,7 +461,7 @@ static bool is_invalid_reserved_pfn(unsigned long = pfn) > >> =20 > >> static int put_pfn(unsigned long pfn, int prot) > >> { > >> -=09if (!is_invalid_reserved_pfn(pfn)) { > >> +=09if (pfn_valid(pfn)) { > >> =09=09struct page *page =3D pfn_to_page(pfn); > >> =20 > >> =09=09unpin_user_pages_dirty_lock(&page, 1, prot & IOMMU_WRITE); =20