From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5356CC48BF6 for ; Mon, 26 Feb 2024 17:27:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A14C76B0168; Mon, 26 Feb 2024 12:27:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C38B6B0169; Mon, 26 Feb 2024 12:27:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 864216B016A; Mon, 26 Feb 2024 12:27:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 725C66B0168 for ; Mon, 26 Feb 2024 12:27:55 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 40D8A8084F for ; Mon, 26 Feb 2024 17:27:55 +0000 (UTC) X-FDA: 81834637710.28.5CE5F26 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf28.hostedemail.com (Postfix) with ESMTP id C6F58C0002 for ; Mon, 26 Feb 2024 17:27:52 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=iGXtAiZe; spf=pass (imf28.hostedemail.com: domain of quic_eberman@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_eberman@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708968472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xo8BL5z8F/dpS6FAXBqNDypdFj4PXEGX78m0qafgn+w=; b=LkYbe0m44UID44HPMpFFFhvzEfmWB156FUFLoMAecXcARyp7u8Z2VUP9MPtThkRvRRMl4s llGFUiVUVnujk0lc75k503AQIKfqhZvfhSZbcuKarrgJot1Hsc2Xo4K7DqWE9p2N+dP6Uy eeflB3NLozdgf6sjYEqw789RN8iAFUc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708968472; a=rsa-sha256; cv=none; b=mAMrWvwajLBx7hJjygkQ4vDuMjLMPPxONfmz2ngOJtlCHW/8BVau8oYDWZPtBd3lRAKXMi uGgoqeTNRb4ez1xNOTxX98JKhxhePxl1y+QesMgIVUtQVwUQ30MsO7GtfSDMVARAI7KR1q hz1bMR09H3ZJwITXJSw0IwZPp+Dx4VU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=iGXtAiZe; spf=pass (imf28.hostedemail.com: domain of quic_eberman@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_eberman@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41QF8hTo032325; Mon, 26 Feb 2024 17:27:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=qcppdkim1; bh=xo8BL5z8F/dpS6FAXBqND ypdFj4PXEGX78m0qafgn+w=; b=iGXtAiZeAnwWh00/pCFGofQ1KwaPva7d/Ihol 0Ov4ZNEBvedo37tPPfAZwlFnbSuYct7ZSAWsgiPahpvbN+eEsVP8OL3+8pOQBg8U u4HD3ZjcPt/2yDsZDxiR+mL+Fc1E4XVPrmU3lbPgQU+9afqdXyMHNUNlr9Kr3WHh 1ZI2W8z+f+9NFZaGJ4424ErG+q/uE4SdilrHmGbSS97kY/6Mw/y7VkzEDPVQF0ZO gBPG2xT23IB74x5kxPKpVNyWs4AwivfqAZA5Ay7flOnWAJCSXAjQ+jNGtBc+HyXG x5IvoYWAMaen/lCj+g1+r/OwN/NRhKan+MMrgHgj8rDHDQMVw== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wgkxq9hfy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Feb 2024 17:27:42 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41QHRWV4026940 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Feb 2024 17:27:32 GMT Received: from hu-eberman-lv.qualcomm.com (10.49.16.6) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 26 Feb 2024 09:27:31 -0800 Date: Mon, 26 Feb 2024 09:27:31 -0800 From: Elliot Berman To: David Hildenbrand CC: Christoph Hellwig , Will Deacon , Quentin Perret , Chris Goldsworthy , Android KVM , "Patrick Daly" , Alex Elder , "Srinivas Kandagatla" , Murali Nalajal , Trilok Soni , "Srivatsa Vaddagiri" , Carl van Schaik , Philip Derrin , Prakruthi Deepak Heragu , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Konrad Dybcio , Bjorn Andersson , "Dmitry Baryshkov" , Fuad Tabba , "Sean Christopherson" , Andrew Morton , , , , , , Subject: Re: Re: [PATCH v17 19/35] arch/mm: Export direct {un,}map functions Message-ID: <20240226092020370-0800.eberman@hu-eberman-lv.qualcomm.com> Mail-Followup-To: David Hildenbrand , Christoph Hellwig , Will Deacon , Quentin Perret , Chris Goldsworthy , Android KVM , Patrick Daly , Alex Elder , Srinivas Kandagatla , Murali Nalajal , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Philip Derrin , Prakruthi Deepak Heragu , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Konrad Dybcio , Bjorn Andersson , Dmitry Baryshkov , Fuad Tabba , Sean Christopherson , Andrew Morton , linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org References: <20240222-gunyah-v17-0-1e9da6763d38@quicinc.com> <20240222-gunyah-v17-19-1e9da6763d38@quicinc.com> <20240223071006483-0800.eberman@hu-eberman-lv.qualcomm.com> <2f4c44ad-b309-4baa-ac21-2ae19efd31fb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2f4c44ad-b309-4baa-ac21-2ae19efd31fb@redhat.com> X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: LdjTkC-YCMeGWoOjKwhoFF8DF33-q3k1 X-Proofpoint-GUID: LdjTkC-YCMeGWoOjKwhoFF8DF33-q3k1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-26_11,2024-02-26_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 bulkscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2402260133 X-Stat-Signature: hju38z4nagkq68dd8m4q983q6pwpzwp3 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C6F58C0002 X-Rspam-User: X-HE-Tag: 1708968472-591459 X-HE-Meta: U2FsdGVkX18i6P9TGRzH6+42mWutjlA56OkV7+0AMAF3lcIDdvCchIOnQD4d5ai39ZE93D0fcJGo3ViYl/Hoo0goF43pbvFrNLVXytgpJDFJJ8OGQlQOhhvMi2TXp7gjAgrPZvrYAHECmKry3x2Tuher5cODpG4SsJYpwNb9GbCTbrCZc2mBLYwwsSDufzXLxhlb6FADvg3pzhqFIgT28Q/sArJsN6mBs0j+an0amp2F6mEms0gzKnr8dq0R9t/YCgfbCHtZ5UlPCiMIMYdSxB+9JxtJdlX9d6vG+FslqcEf8RV2ssafgrMavfZOnlG0zGB+fLgW2RBdKXAGIXGtlFKo27ND7yxxZdqzHcELN+rqbQ6Y1uVCQpQrlNgqliCZVGdWuW9lrtYSl7KcuYnpYmFpy1GX1tzmfKSa1Z1c8+nXVda2vccXAHOGkehbacIz4Q4pHH+A+MXHDtY3M1XGnuwirhWP9WqlEYr2cPhJcXLls/1gBak8bS2lo+KG5t4TgEEVYxxmpeZ/Q2vtGiMaNWumI/evMX28w2nHkXnnBVaLp8crAHIFR9K8bQuPyX4XzusFlwt6TpDUkJz5Gt+qF4FKNnY8+j3ktPHNl7eYsYVs3wQy9iLB6Nx1YFKSsx9mCcLX5WR0B77+vQulfrZGhmrxhBGGgeX1UeQuHZcgB5Uvu+fsddrJtc1BnUhCHiELLpQ/CVL3vGjVpM8uJ/9EMr7RQmzVpLvVks12X+UYSFPwBeZMH+AOPvavxWZtfvPx96N2rHlsQDT3COiWOIVbHlN+3gbCFkqI81ExUkn1i76Y1cp0KGZJfnuiHuDZy2pfL3FgEpmgyjColIAWWjL9tn6QSx7/HiYt8dGaKRlSgd0q+rdwEk9K6Y6WUCxicVkmv6IOgOovospCF3/zRlCLGrEVs+P3F+jompDv15Z+KFEG5SwF33A8ggNJdqvPdhmDL3Rw6njvPDHUzM7YzVm +9AjML6H bqKxdjuZsMfQFGKsYI3Gvz9Ke3MzUOFxtlfHNDB80gqd5k0mK4SOhYU1u1gZdks8qErlm2wR2MiN+2t2sJLOiOPgZ9oIFP+OMbwj2fIuvWZgoGQlLjXTKaGfdikEbGoqpuswosE4XqrEt6Z+oZKpNYOHeGfL1fgAqgAQKOGshxU7eSE6MeZs0kzQA/k+x0NOFJurLxGRrtkf53QH7wnJ6/HA1jySqvG0CIdjbB4eACH8lYt6O2QTwdixcwVSFEuexV0snE1dxkH10ryap6RDApzfs99WDK8HuPFBq1taLs506Tj8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 12:53:48PM +0100, David Hildenbrand wrote: > On 26.02.24 12:06, Christoph Hellwig wrote: > > The point is that we can't we just allow modules to unmap data from > > the kernel mapping, no matter how noble your intentions are. > > I absolutely agree. > Hi David and Chirstoph, Are your preferences that we should make Gunyah builtin only or should add fixing up S2 PTW errors (or something else)? Also, do you extend that preference to modifying S2 mappings? This would require any hypervisor driver that supports confidential compute usecases to only ever be builtin. Is your concern about unmapping data from kernel mapping, then module being unloaded, and then having no way to recover the mapping? Would a permanent module be better? The primary reason we were wanting to have it as module was to avoid having driver in memory if you're not a Gunyah guest. Thanks, Elliot