From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D41C54E51 for ; Mon, 26 Feb 2024 16:14:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFD4644017E; Mon, 26 Feb 2024 11:14:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B8616440147; Mon, 26 Feb 2024 11:14:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A008D44017E; Mon, 26 Feb 2024 11:14:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 893D3440147 for ; Mon, 26 Feb 2024 11:14:51 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5456B16092A for ; Mon, 26 Feb 2024 16:14:51 +0000 (UTC) X-FDA: 81834453582.18.4AE36E8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id B41E81A0027 for ; Mon, 26 Feb 2024 16:14:47 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="DRHCD/SF"; spf=pass (imf19.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708964089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zh3mDtCIv3auLG9zPOiKdCdk64UMolNzMr0oDDvC2P8=; b=spk9IGBip2n6bKlQ4lR3mzvYEMYC+v4JzRWt0Eft24v8Alule9vwIiGCoFp9K+m5JM2Ilx kGk1Brq+nPCiyi0ey1wW6sxS0a7hLj1mgbXlUMAM7RtjqJvDZcSVa4dGORxaOV9YKCQ9CZ n2NSmcv1FbboyC7m6Ic1igZkyJvCZoU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="DRHCD/SF"; spf=pass (imf19.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708964089; a=rsa-sha256; cv=none; b=IIdlVul0I3WtddqMVlHltyjMlk5JfZMsuRlTniYw3Z0solRST5a4WC7exljrfvGPATwC96 yHTHA2Rmal01Qg7+0LfniNs8/r6pu/1grp58VA2S67rZZd+67Srep+x49aIEj9x2Wh3lyj IhiWkCoSsVfvRNhc95dV7SK1aH/51OU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708964087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zh3mDtCIv3auLG9zPOiKdCdk64UMolNzMr0oDDvC2P8=; b=DRHCD/SF8f0dI/X7CTkLvkKHIt7tSxLOE9pyinNyfKnDw7pF1KkbkjEgJRwPDJM9lBlyM8 xlkTUdLVef/tGXJUoyPDLmr2pDxoEp6LTz/tuXiHXy/1ZI6ofqpkdk0YAXWxD0MLRRxdwy lkL/6a+vFrGn2/p4eBkLoB8/5ISMAA0= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-156-M5pU398aOruVxgzxRo9QTg-1; Mon, 26 Feb 2024 11:14:44 -0500 X-MC-Unique: M5pU398aOruVxgzxRo9QTg-1 Received: by mail-io1-f72.google.com with SMTP id ca18e2360f4ac-7c7877d4e2eso370488039f.3 for ; Mon, 26 Feb 2024 08:14:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708964083; x=1709568883; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zh3mDtCIv3auLG9zPOiKdCdk64UMolNzMr0oDDvC2P8=; b=U5CuScVbCn7qyrswDhFCglAgBbTPu2FL6qFJ5WxShd6iFt+vfaPkjwltc6ZyqQvM/h nl8MG3dK2FvhRJTQbMpHWAb0doDav5SoMZjOQORNbmhsyDSvh6Kk4juT4q7JIpeebGol ibLxOVc6eSDEav5hFrx1hTKNt0hv87geIku+K7dQNA3gGno0GsOs4YD5KiSF5fqzIiM5 lNDcYqW0jpOS5zAKIrMMXgxtBv0BcjIrVKI3qaEQj00a0aA9CP/qBxY4yrKZ6ZyhP+QD 4fVciL7mk3uCyGN2gYiZv55GnYwwj/eRPvD4ale+6OOOtmKTC7hn1hZTkO3MdL3Vnywe lvyA== X-Forwarded-Encrypted: i=1; AJvYcCXMz1HYnsJQDAbVeB1j1KJaboXU5mgkzTJfCGWRPyuY6bB0a3/FiFy+AV5Q/u5q+3StpO1bceEeTM+cj2b71JVB4QM= X-Gm-Message-State: AOJu0YxwX0KIR13GWq8gEaS8k8MQBU4WXr/O9SMH8LPYAbpU8m+XmbUd v3AgZbHzhVlum69l50gS/x1wXofs7ewy03FIIN1If4tRqPE3TcMXU0/vYzj5ChHRWvFkeqi4lBy QLUArh2P36CfI95TZQv9Z63wrEy07EqwjlTIuGHnOg7qK/3xbhCvuIOdd X-Received: by 2002:a5d:83c3:0:b0:7c7:ba20:5590 with SMTP id u3-20020a5d83c3000000b007c7ba205590mr5460957ior.14.1708964082703; Mon, 26 Feb 2024 08:14:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGEOWu1T2z+J1Gp1UZDUyQh8NW65H7pvXhZJgZkO41DXiNpZ6UF/UvqLLU6+ypJXEHMrDXlQ== X-Received: by 2002:a5d:83c3:0:b0:7c7:ba20:5590 with SMTP id u3-20020a5d83c3000000b007c7ba205590mr5460947ior.14.1708964082433; Mon, 26 Feb 2024 08:14:42 -0800 (PST) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id fj33-20020a056638636100b004747eb13d6fsm915292jab.41.2024.02.26.08.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 08:14:41 -0800 (PST) Date: Mon, 26 Feb 2024 09:14:38 -0700 From: Alex Williamson To: Yisheng Xie Cc: akpm@linux-foundation.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] vfio/type1: unpin PageReserved page Message-ID: <20240226091438.1fc37957.alex.williamson@redhat.com> In-Reply-To: <20240226160106.24222-1-ethan.xys@linux.alibaba.com> References: <20240226160106.24222-1-ethan.xys@linux.alibaba.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B41E81A0027 X-Rspam-User: X-Stat-Signature: o7n4upebkg1c8ajyy88m19k6n3ibsw8a X-Rspamd-Server: rspam01 X-HE-Tag: 1708964087-160564 X-HE-Meta: U2FsdGVkX19kN/n8qE/a4PeVXJ8V6oh6X45BZ7aXVvzZWVmaPgyP6GWGeVCYyu8WmZmTEnww95yB/1lcbF1PWvFfrWTwpz7XxPJEPn0hnReGkWXX8dhUCdx+HQ9+jeCP4tsfi+00jkqfxOqkUly2J7v3sX89oEu2myFWB2Fore8XqXHAMyxuOpJgqjVJ9JNrau4qo7VTQmKmPY/O4alXM7mwfRBiradMPVw/XKPnxTgUsA1cirEnsPB9KLOrUw5M3IAkrxpcZqQdTtfvNik2ktI2lTUgnguMSlcbQBErb9RRvCjT0YRlOBXsB8+KmAGEmlLzBNau3kCwOD+RL/mYzDPUMUvEd6v4XLAJ4kGCFvsshL9SE3JGScbgqp0TV2wwbIk6bTyQEefBmXVcg0bhIOWMFPnB30UyrX1QuLM5Bti2Dq3LX3Beu5uPeNdKaqsReyncPQh9Ke70UWnM5VDL15lzLtd5OE+xjRq3QPAmU4veFtRZKgH3DeJFPDieNCEdjVFQeSxYakBgyg39vcR3esq2oO1rfD0eHTdTY4gVFZjmU7a7WU2K+C/cfb9qLgZDKc/0AEs4oOtbWfzLmBnTE7iri2k53yfYEQsGI5x1SdYdyn0t2je4eaDjwNan5c+67MLitTVQbyXbCoX6ubrlrU4fp0ZbNwgFIN9AkhO71tdvJzN73kqIpIeRMqwKzFO1Wg32XKe0I7tJzPjWOglIIJQQazXkX8ifnXj/4jFPfntWZDtXuaZpZd7sxOny1/GpHXVFo+tMRcAdcbLyqJHVOaOegtYYE7Et8plwBaCISPpiJDNBwvadEfepSUuWFY2wyW0qeT3IwbHqJlkd2PrxaHPE0S9p24fJDFHwj72h1qBSK+7aln/iS5M+WZsovn9BKXV24fnpxjqFrHhuKUWHbNrYq3fUSc2TwkuMOmJi2qaqyHEZlSrOujcDSvcRT8hZ2HZzWHvBwSYDaLCnme8 zTg3D+hB pd2KPSUubIsb3NUYyhtUPh1htO8ub6nMYsM6WHhcfGirP0WkqrQE9MChxKoJlHHf2F1aUNvT3W1DKhAaodpoJI5yh0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 27 Feb 2024 00:01:06 +0800 Yisheng Xie wrote: > We meet a warning as following: > WARNING: CPU: 99 PID: 1766859 at mm/gup.c:209 try_grab_page.part.0+0xe8/0x1b0 > CPU: 99 PID: 1766859 Comm: qemu-kvm Kdump: loaded Tainted: GOE 5.10.134-008.2.x86_64 #1 ^^^^^^^^ Does this issue reproduce on mainline? Thanks, Alex > Hardware name: Foxconn AliServer-Thor-04-12U-v2/Thunder2, BIOS 1.0.PL.FC.P.031.00 05/18/2022 > RIP: 0010:try_grab_page.part.0+0xe8/0x1b0 > Code: b9 00 04 00 00 83 e6 01 74 ca 48 8b 32 b9 00 04 00 00 f7 c6 00 00 01 00 74 ba eb 91 8b 57 34 48 89 f8 85 d2 0f 8f 48 ff ff ff <0f> 0b 31 c0 c3 48 89 fa 48 8b 0a f7 c1 00 00 01 00 0f 85 5c ff ff > RSP: 0018:ffffc900b1a63b98 EFLAGS: 00010282 > RAX: ffffea00000e4580 RBX: 0000000000052202 RCX: ffffea00000e4580 > RDX: 0000000080000001 RSI: 0000000000052202 RDI: ffffea00000e4580 > RBP: ffff88efa5d3d860 R08: 0000000000000000 R09: 0000000000000002 > R10: 0000000000000008 R11: ffff89403fff7000 R12: ffff88f589165818 > R13: 00007f1320600000 R14: ffffea0181296ca8 R15: ffffea00000e4580 > FS: 00007f1324f93e00(0000) GS:ffff893ebfb80000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007f1321694070 CR3: 0000006046014004 CR4: 00000000007726e0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > PKRU: 55555554 > Call Trace: > follow_page_pte+0x64b/0x800 > __get_user_pages+0x228/0x560 > __gup_longterm_locked+0xa0/0x2f0 > vaddr_get_pfns+0x67/0x100 [vfio_iommu_type1] > vfio_pin_pages_remote+0x30b/0x460 [vfio_iommu_type1] > vfio_pin_map_dma+0xd4/0x2e0 [vfio_iommu_type1] > vfio_dma_do_map+0x21e/0x340 [vfio_iommu_type1] > vfio_iommu_type1_ioctl+0xdd/0x170 [vfio_iommu_type1] > ? __fget_files+0x79/0xb0 > ksys_ioctl+0x7b/0xb0 > ? ksys_write+0xc4/0xe0 > __x64_sys_ioctl+0x16/0x20 > do_syscall_64+0x2d/0x40 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > After add dumppage, it shows that it is a PageReserved page(e.g. zero page), > whoes refcount is just overflow: > page:00000000b0504535 refcount:-2147483647 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x3916 > flags: 0xffffc000001002(referenced|reserved) > raw: 00ffffc000001002 ffffea00000e4588 ffffea00000e4588 0000000000000000 > raw: 0000000000000000 0000000000000000 80000001ffffffff 0000000000000000 > > gup will _pin_ a page which is PageReserved, however, put_pfn in vfio will > skip unpin page which is PageReserved. So use pfn_valid in put_pfn > instead of !is_invalid_reserved_pfn to unpin PageReserved page. > > Signed-off-by: Yisheng Xie > --- > drivers/vfio/vfio_iommu_type1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index b2854d7939ce..12775bab27ee 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -461,7 +461,7 @@ static bool is_invalid_reserved_pfn(unsigned long pfn) > > static int put_pfn(unsigned long pfn, int prot) > { > - if (!is_invalid_reserved_pfn(pfn)) { > + if (pfn_valid(pfn)) { > struct page *page = pfn_to_page(pfn); > > unpin_user_pages_dirty_lock(&page, 1, prot & IOMMU_WRITE);