* [PATCH v2] Docs/mm/damon/design: remove the details for pageout as paddr doesn't use MADV_PAGEOUT
@ 2024-02-24 22:47 Barry Song
2024-02-24 23:06 ` SeongJae Park
0 siblings, 1 reply; 2+ messages in thread
From: Barry Song @ 2024-02-24 22:47 UTC (permalink / raw)
To: corbet, linux-mm, akpm, damon, linux-doc
Cc: linux-kernel, Barry Song, SeongJae Park, Minchan Kim,
Michal Hocko, Johannes Weiner
From: Barry Song <v-songbaohua@oppo.com>
The doc needs fix. As only in the case of virtual address, we
are calling madvise() with MADV_PAGEOUT. But in the case of
physical address, we are calling reclaim_pages() directly.
MADV_PAGEOUT on virtual address is much more aggresive to
reclaim memory compared to reclaim_pages() on paddr region.
This patch removes the details so that the description can
apply to both cases. And we don't need to couple with the
implementation details.
Cc: SeongJae Park <sj@kernel.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Barry Song <v-songbaohua@oppo.com>
---
-v2: decouple with the details according to SeongJae
-v1: https://lore.kernel.org/linux-mm/20240224215023.5271-1-21cnbao@gmail.com/
Documentation/mm/damon/design.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
index 8c89d26f0baa..5620aab9b385 100644
--- a/Documentation/mm/damon/design.rst
+++ b/Documentation/mm/damon/design.rst
@@ -315,7 +315,7 @@ that supports each action are as below.
Supported by ``vaddr`` and ``fvaddr`` operations set.
- ``cold``: Call ``madvise()`` for the region with ``MADV_COLD``.
Supported by ``vaddr`` and ``fvaddr`` operations set.
- - ``pageout``: Call ``madvise()`` for the region with ``MADV_PAGEOUT``.
+ - ``pageout``: Reclaim the region.
Supported by ``vaddr``, ``fvaddr`` and ``paddr`` operations set.
- ``hugepage``: Call ``madvise()`` for the region with ``MADV_HUGEPAGE``.
Supported by ``vaddr`` and ``fvaddr`` operations set.
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Docs/mm/damon/design: remove the details for pageout as paddr doesn't use MADV_PAGEOUT
2024-02-24 22:47 [PATCH v2] Docs/mm/damon/design: remove the details for pageout as paddr doesn't use MADV_PAGEOUT Barry Song
@ 2024-02-24 23:06 ` SeongJae Park
0 siblings, 0 replies; 2+ messages in thread
From: SeongJae Park @ 2024-02-24 23:06 UTC (permalink / raw)
To: Barry Song
Cc: corbet, linux-mm, akpm, damon, linux-doc, linux-kernel,
Barry Song, SeongJae Park, Minchan Kim, Michal Hocko,
Johannes Weiner
Hi Barry,
On Sun, 25 Feb 2024 11:47:51 +1300 Barry Song <21cnbao@gmail.com> wrote:
> From: Barry Song <v-songbaohua@oppo.com>
>
> The doc needs fix. As only in the case of virtual address, we
> are calling madvise() with MADV_PAGEOUT. But in the case of
> physical address, we are calling reclaim_pages() directly.
> MADV_PAGEOUT on virtual address is much more aggresive to
> reclaim memory compared to reclaim_pages() on paddr region.
> This patch removes the details so that the description can
> apply to both cases. And we don't need to couple with the
> implementation details.
>
> Cc: SeongJae Park <sj@kernel.org>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Barry Song <v-songbaohua@oppo.com>
> ---
> -v2: decouple with the details according to SeongJae
> -v1: https://lore.kernel.org/linux-mm/20240224215023.5271-1-21cnbao@gmail.com/
Thank you so much for your work!
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-24 23:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-24 22:47 [PATCH v2] Docs/mm/damon/design: remove the details for pageout as paddr doesn't use MADV_PAGEOUT Barry Song
2024-02-24 23:06 ` SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox