From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B185BC48BF6 for ; Sat, 24 Feb 2024 17:03:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 339F96B009C; Sat, 24 Feb 2024 12:03:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EA7B6B009D; Sat, 24 Feb 2024 12:03:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B2676B009E; Sat, 24 Feb 2024 12:03:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 088506B009C for ; Sat, 24 Feb 2024 12:03:14 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AE24A16010A for ; Sat, 24 Feb 2024 17:03:13 +0000 (UTC) X-FDA: 81827317866.08.9EA9D39 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf13.hostedemail.com (Postfix) with ESMTP id 9742B20005 for ; Sat, 24 Feb 2024 17:03:11 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=chNLt8QL; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708794192; a=rsa-sha256; cv=none; b=tp0Z+E8FHsd+pggDTJIfnYNnr8U7bSFxLQYBQBw42gSP/2BDE2zkQP6ynXTwpYzjOwmwQP MpBafdPdJ4ip/FWA6ILwOwL/wTxTORkgulz1+LCZh/h6Mq0YT/FM4P7ORLWGEFJtVhDD2S COq7akz7rG2kS/JHTIVVwdg1RQHD1ZM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=chNLt8QL; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708794192; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9AsaGt7+M/pMSQy5yJHqAwXDbzVVCcgiNDWJO5G7qjE=; b=la8LC6mCT6iiD1VlUPEaE9JOGlsZsgj58Za0O0g4js9iz4YRuFnLtREVKtCxXXTu7/Qsb8 qnrUe66fXy9+sw0Bud452kTDSijO7Eld7Y2YIBFlMdEYyi9ww92kAgC3kT41+YV+FIo/CP fssNaUn8VERfqeNRc6Pfi7kaHHO5yrA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CFF29CE0C70; Sat, 24 Feb 2024 17:03:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1019BC433C7; Sat, 24 Feb 2024 17:03:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708794187; bh=vf1J4XGP8ttoc+eTT7vjZBCjuz6YX6OyBN3XBleaBGk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=chNLt8QLPVfpWlo9KfuJvke+7y62wQSPfLUQTSAFpFedmSkflFSilLKG9Vb/ZFbh0 GMlZk80dHYTufgqTvTsM50eu6l5705EAqeD9nlMjM4guqzQ4LpjSkbXyKlHYeV+9Ll GC7EtpmZtLu63pBmnCG2XUoubZdchLQ7cMw3x7iQ++mM9xGT3gdS8n2I03VVlvWXQI 5nf8zCgaetW5Tu2GhIET8lK9Ge+C6MAHVQ0jYMHtkRwqSzAQBQNQW17WlYb9/Y5h5d wsCG96Z7FPjHQSfQmW2KmnfcAgKSVZxzGVo06B4FJQtJmjiK7j6yE2MAuT55OsZyaK hJk/ivBH7BN5g== Date: Sat, 24 Feb 2024 09:03:06 -0800 From: "Darrick J. Wong" To: chengming.zhou@linux.dev Cc: chandan.babu@oracle.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com, Chengming Zhou Subject: Re: [PATCH] xfs: remove SLAB_MEM_SPREAD flag usage Message-ID: <20240224170306.GI616564@frogsfrogsfrogs> References: <20240224135323.830509-1-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240224135323.830509-1-chengming.zhou@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9742B20005 X-Stat-Signature: z4xxq4jzg9kqfd986qk4bg595ppjnoo8 X-HE-Tag: 1708794191-201140 X-HE-Meta: U2FsdGVkX19v4pzSe7LngWnukleGCLCbB4IOR7WYT0XTyzII41mrX/5feHkWxTu2YREz2IC/FsjUHi78naQuNFfqlGU8zMoNKOfIdaruZs8WhhqLkGVfa+ry2ezHAINkyJg+2SNpzjP/1h0wWpzGNI/E8KgVV+3Lc/iYU6L+Ww5UefLwQq3W5MA0+MOfkEDCEjd599s70iVjL09udXkyeJMM2mpe49/2HCXI3tDS1cygwWLkvgZOkmaFW4GkWHWM6d5cVAAMGjLZwDor9kOVvXBmMgtoqUIf3NIXqi9MPxZ0SXTuJ17SF7WM/3Mz+xN//au6Dt6BrK73VsbDvQJwVqrhopJjpgSrR7E0q/6rg52b0ryHtdmnlh5UIWjJpe2hVLiEuSBWIoDHPXPr/EMlqQQHp2BE0SSVVFbdi+h6NIxxcezkTJs4drBMUT5+cAgte/o2lmV3NFnYWGm0MMmK/G/kwQ0ejOuUBWvFBstkn+4OBxDw/XnYR0o+8OLkVUWgbS/in1g9G0DklpjWHlSiIzdLuqQ2QMl4TCheU2Rxo4YTK7XJpR2ZpVA1xqYJx9Ns2f/mBF3JTQ3hmaB03WifbnlzPxIVMwpu5Zgpf85Vn35pljq7e08ax9VeAFlyc+am7BE9TTjYdRECTSJAkd/BByDWUQtLYTDNL3/6sV0mF/hZrH/T0gHczivfIlAgCvw7cGcHHyxPqo+pVy6tgMr5bMmwieJ54tvRVoYROmz1cu1edrUo2aR1FNh1p/5Jnr21xd31v1hG9hLVi4+ZDBLV7ui+jf6p0zOnxXs0Pljzd8Ml7qR5vK9ZoIgMTHUnCd26p370D8VKUiSF2rFh1PsbzPBiHTv3pD9Una7fP9mP/PDx7sIEDGMk9U/QBDvOr3eRmxKrWCGPultknY9IQJpMOtOkTRn647kb/V2uOC19VYmY0lE0mNd9jyPPvCwZpI586Pr7Chk/11w6C9lmN+1 6K56smoc gaeCXZZKl//9oHZ2cOnYv7kRj4gy0d5laVJEkKzycvs1uShXRmpSoxmCPbi/D8tDFiAqVqOPoHcw3cmoEat+mKOaGGbZShGHe1r9WYnTKcHYzSYo+Z3hehpc9bO3V5C4il03EA1Gwc+Vvt77pr6wpz8afMViQhgbnmHgtzxBtoguXLVDlHO8yVRXkGvkrCuqOfO/WtBwOGs3LLhWPi8oX7by9yZCuVxehIRkoozkNz2Kx3y2kCa4h51rwuM7bdWEebhQ/+LAjqXoR+EaAMJ5Uzeckdkyn9TonoLE8OFSB9OTg6fjPx2htvVRvJJ64XvP8qg82T7eZ+YrsS5O8tLCxuqbQ6+/IMI21YekG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 24, 2024 at 01:53:23PM +0000, chengming.zhou@linux.dev wrote: > From: Chengming Zhou > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove > its usage so we can delete it from slab. No functional change. > > Signed-off-by: Chengming Zhou Acked-by: Darrick J. Wong (acked, as in "this looks right, i don't know why it wasn't removed when slab went away, and from the -mm list traffic this seems to be in line with [1] but i still had to dig for details) [1] https://lore.kernel.org/linux-mm/20240131172027.10f64405@gandalf.local.home/T/#u --D > --- > fs/xfs/xfs_super.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index 56006b877a5d..171a1287b296 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -2042,8 +2042,7 @@ xfs_init_caches(void) > > xfs_buf_cache = kmem_cache_create("xfs_buf", sizeof(struct xfs_buf), 0, > SLAB_HWCACHE_ALIGN | > - SLAB_RECLAIM_ACCOUNT | > - SLAB_MEM_SPREAD, > + SLAB_RECLAIM_ACCOUNT, > NULL); > if (!xfs_buf_cache) > goto out; > @@ -2108,14 +2107,14 @@ xfs_init_caches(void) > sizeof(struct xfs_inode), 0, > (SLAB_HWCACHE_ALIGN | > SLAB_RECLAIM_ACCOUNT | > - SLAB_MEM_SPREAD | SLAB_ACCOUNT), > + SLAB_ACCOUNT), > xfs_fs_inode_init_once); > if (!xfs_inode_cache) > goto out_destroy_efi_cache; > > xfs_ili_cache = kmem_cache_create("xfs_ili", > sizeof(struct xfs_inode_log_item), 0, > - SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD, > + SLAB_RECLAIM_ACCOUNT, > NULL); > if (!xfs_ili_cache) > goto out_destroy_inode_cache; > -- > 2.40.1 > >