From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A24A4C54798 for ; Sat, 24 Feb 2024 01:04:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 021466B0074; Fri, 23 Feb 2024 20:04:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F13BB6B0075; Fri, 23 Feb 2024 20:04:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDADA6B0078; Fri, 23 Feb 2024 20:04:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C147B6B0074 for ; Fri, 23 Feb 2024 20:04:48 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 95EE4A129A for ; Sat, 24 Feb 2024 01:04:48 +0000 (UTC) X-FDA: 81824902656.22.CDD05DE Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf21.hostedemail.com (Postfix) with ESMTP id E52881C000E for ; Sat, 24 Feb 2024 01:04:46 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HEEJEcDj; spf=pass (imf21.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708736687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pQKkVKoC62UNhXK21zihqEnfMAgk8ODcwjqvMq7e3Fw=; b=m/wMoKwCo8AiLAMhoM2fZoVBlcKOScOCyS5FYqN8zHNIn6G1IREf0hAlkCv8T+2N0DpRNM wqd9yotrAMjQdUJNxY2ueABUIuDjnbFsTpqxEvddbjbvFa4gBNm9Xa2gj0YV0BXs1azMoD LalHRr73gUTy85xvQk/k0FCxtUsPjoM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708736687; a=rsa-sha256; cv=none; b=6uYDRxM/kjbk6QHixoj6ezWEp2H4Pg8AP02eundkmcVJ2zf1+jxYL8tUu4d7EpX8iEZbWb XjXOoPDMDkp149gXSZm4Di0mFR9mYigBOEnkwWmfKqA+c6nHfuL8+RaJo1b5w4GsJbP31o 739efNnHY+gVt+1OY0JGsND+6y4FOsE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HEEJEcDj; spf=pass (imf21.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-53fbf2c42bfso1257283a12.3 for ; Fri, 23 Feb 2024 17:04:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708736685; x=1709341485; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pQKkVKoC62UNhXK21zihqEnfMAgk8ODcwjqvMq7e3Fw=; b=HEEJEcDj+pqN4SgGTg4vuThRnHdk3AHfvKg+tIJ7C1nGRaUejDuvu+d5AzUZChCeOd 5yVfs4tF2nC4ITFd05ptL8hJfHuz8A8hkQ6cq/vYuQviW3FEJTUZB3kJi0EdSiS0MayB ybVmiKK4cFhC+clYlaOH5bXQh5CysC/rJcTR8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708736685; x=1709341485; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pQKkVKoC62UNhXK21zihqEnfMAgk8ODcwjqvMq7e3Fw=; b=Ewh0JaXeXDUddyzvVeuHfKfuRSRYVg3Y2V9iwoJdCDymxgEb8MoaPWjMVkcEf51xsx 529V4phL2GOaw41EE77yoR9SlFdjuI3cyN/af0VA7ECWHV+VX/gs8DjhRZH/7whMsLT0 2/1DdoIFXSMg6010JyHfm1iKVg1Uv9OZ1hhgDhX2Ud/MM5t+2nGLQDBPmchDBRb2sZ6y +qYG2rgMsLQQWBzoMOK4ZDBxho/R6VjapY9rIcreI2RZIcBFL3DiEOof5Ae/LdRRs6N+ aV9sjmAvOiKBpF9ZdQsPABvA0WouTbXgiNtvZ29eOn10DS+8JsxuA48mit2qHClGWUhE f0vg== X-Forwarded-Encrypted: i=1; AJvYcCVaiXboi7zeIneZge1cTSA3ZtX3Hqr1K+VQYzLlyV0G0t82psNFLzZvUzPVqKcICZHvMcx9cYfdD+w8dVnztusaK8w= X-Gm-Message-State: AOJu0Yws5q2Uriymg9ilGtq3VJY5K59+AKD1BZ4MhWTa+3TQ+asdQcrf PdTtaRrVqEa0WENWSRgVXlnWCqoZm+VWDUEtpaEmJgBU8WDA7wKP4SqMEckmcA== X-Google-Smtp-Source: AGHT+IG0YdtHF9dbaoGm8JzoVb9eQcmcaxlFTDtLUPRbBpYTUj0A/EB01yqRCMLQjT23cQBmTcoxXA== X-Received: by 2002:a17:902:eccb:b0:1db:b69a:3fb9 with SMTP id a11-20020a170902eccb00b001dbb69a3fb9mr1864564plh.25.1708736685645; Fri, 23 Feb 2024 17:04:45 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id bd3-20020a170902830300b001db6da30331sm33159plb.86.2024.02.23.17.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 17:04:45 -0800 (PST) Date: Fri, 23 Feb 2024 17:04:44 -0800 From: Kees Cook To: Li zeming Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, ebiederm@xmission.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] exec: Remove =?utf-8?Q?unneces?= =?utf-8?B?c2FyeSDigJhOVUxM4oCZ?= values from vma Message-ID: <202402231703.8D5E862@keescook> References: <20240220051830.61099-1-zeming@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220051830.61099-1-zeming@nfschina.com> X-Rspamd-Queue-Id: E52881C000E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: oz5ec43jkgrdzo4cn19udchbxj1ebwrg X-HE-Tag: 1708736686-102642 X-HE-Meta: U2FsdGVkX19tySnkFloLQTRMNgRNZNlS4y63J/kqTQYNe5iJVYjTIET96gQ327mOpFqZvXPQ63uyHLvv6zZy9U0SfJYY/tIJfQHe2qKj/qj2SIvTF2/1cjBSQ/AtvfI1DCAHMSKQTzEjrwuZZtON5ewLAImsYLKtTCWNve2I1zNE+64RywUbiXieoM/Nwc6Z8QjFgK5hPK87GtLZY/+fYQtEJPzaFiuduXwS6y8t7kyI4bA6QD4Sk/kIIGNjF/EItIEFBjjYJ18+IoXRZLTgf8ozF8fwAPmJS++27OJ1xhdRn9dk9+COP/HztrJsGyyiuOBWSavDltsCOns0yFeDizgTToWXfZ6tSRWPsE46bPjE8mpHu4oHLEZMeySBMzX3l81TfJrESoIft4mt0VvN5gckdgZyCVoDsE8yzVMTw80x31C3CJTLTEmJfqAMfET/vkriDp+5ejS3FwsJ22e+asKzcYI1QFNSqPYfTS7pympBvK8BdnXd02eUlhwYtfUg8GWyB25EfSIhMqMNl5necJWx8sKp6+noj34UvyD0pnFCzJnw4HpX2LCv6K/zsfsrt2edXh6ZYikKgsNr70MkbnhNB8SewnI8A6R+iQlym/g7Dt09NH9Rxh17RJTkF8g0ZBe8zivseFPKHlStd/mKhiDgX3eKsQ2JkfKMJq9oCcrxdP/NcgrkA3NFvBEuYAMdSPszyMLjNHnUR0xVPKtaWXOS+h5gQjbFFvWVktbjxNeIRIOy6jtROpYyJsSfyVW3FXZDQ/f5cZGRHtos8k9L01nvu7CQby3DWfQrc7hCJCUzv2C46B1Lca4Wfv2n8M2s0Y7UEcDHlThnof9VFooTck15IdznieMKbmPwQjse8Fq49WV00M6+IQEZZzPXcIz7d2V+k8zEhZqYRQcXxNyYcRjKl9zHsukMtd8ycC7aluPIXbzauA5R5V1rjDBgn+brkEFekA1J5eeSZivJ/+8 3jy4qfBH 0uFa/X6JZNwdLlMtK8onxVKGxdd5wCUd0W0Sg/0oJsyhbImREAIvqpt43PBb15h/rzN7jh6uQlKbQ5+s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.068911, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 20, 2024 at 01:18:30PM +0800, Li zeming wrote: > vma is assigned first, so it does not need to initialize the > assignment. I don't really like removing explicit initializations. They don't cause any problems and the compiler will remove redundant stores, so there's no benefit in dropping them. -- Kees Cook