From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA95C48BC4 for ; Fri, 23 Feb 2024 05:56:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3057D6B0083; Fri, 23 Feb 2024 00:56:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B5A26B0085; Fri, 23 Feb 2024 00:56:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17DB96B0087; Fri, 23 Feb 2024 00:56:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F267E6B0083 for ; Fri, 23 Feb 2024 00:56:34 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BE07F1A1006 for ; Fri, 23 Feb 2024 05:56:34 +0000 (UTC) X-FDA: 81822009108.20.C5C0C71 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by imf27.hostedemail.com (Postfix) with ESMTP id 080464000B for ; Fri, 23 Feb 2024 05:56:32 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=QMOG6rS0; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708667793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N0GRTyFRup/uDSwIpNY903bhAXEkCVn4KPWPZ3fepfE=; b=lravYjMlNFyxQmi1VA3qR1Wlkw/jwu6nEQqsTE6t9Lq4OAWXClQxQSVoLgkZ5RL6EFUCcK Hs06ZaEegLswKcFtFf5BHR/0mWc6XKO+M11mRLMefVL78qQaUD9PIiyce9IoXCmwocI4XZ HSccnjiVeUU5ecaH6VSjQSC5kTq0kpo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=QMOG6rS0; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708667793; a=rsa-sha256; cv=none; b=hE8dlw+usSXYcJxPA9SVXays5ynp4JOQrFDyKtIvKOUWDqxVwYrYgwsZ1WnEnzxpTIMMkm JqK56zBfBfCZ90359PPK8U+JYQkXRFrkB0puWXKUOctbizD+KqzzscvLSuBVrwG3y24IXY B1JkRRgMI0oewdHEPQJb5uAob+rbIlY= Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5cddc5455aeso419583a12.1 for ; Thu, 22 Feb 2024 21:56:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708667792; x=1709272592; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=N0GRTyFRup/uDSwIpNY903bhAXEkCVn4KPWPZ3fepfE=; b=QMOG6rS0FgOtV9KB3Y9ehcDq1g0OTvyf8aERoy4iLAFPl2sqTXTBBmplLLMwdefLzt TTaC8VRdFSbOgylkoDtrCQRlEMiHmB/hXmtK7KCcAsZjbckAn2QUZoCDwIxSkQDl9mzq tg0jxn52wB2ymO6+loJYGoF6g1dH7pMSfJ6UU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708667792; x=1709272592; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N0GRTyFRup/uDSwIpNY903bhAXEkCVn4KPWPZ3fepfE=; b=MxlBejb4Ec0+CrpveMOYayYks2MP9akYOOIByzU7Z6kd6vgdjwgpXCPmzIPWRPuDbA OPpzQvKdicvkLwM4xGz9kAlTISgzbnitcZXcxEwb8JFw1uyL+8RPXU+aWiEQILI9Z5nK rgZ/UtMdCuPrYTsoxkONhcHixPCrWaE0q2nXXBQm9+JOFJNrPhe7fNa4HWC9EDK8EGej jUNXZwKJFmJp4ISaZ+eMlWgcflMKHnq/Ntq1kdDO6HFUSejqwojOarsfZlZuCkGqChTw gi9+srPcAPDHnmkjKXNiLbv7IWacR6ESF3h5GdRZRGjKbY4Lc09uNAhSkN03dXKcEfBx IKjQ== X-Forwarded-Encrypted: i=1; AJvYcCWoMXIYqWkC9hGaYu9WLKKW88pfZ8G/XxRVkk2MzeHC2wwRaQhPLsG44fILpio47BdPxBxx3fryu6MrH22TwkVw3to= X-Gm-Message-State: AOJu0YxM3U24d6YbZUmoTJ7oetf/v9wOiIwWytk7PD8tm+QD3x6JhDZ/ jeG2r7b/OA6GQuosiikvqqXxQgf1kaXs8lFDw4Os7hZxdCNiuwu3BXj3TxG6lQ== X-Google-Smtp-Source: AGHT+IF0gilLsIGarp5ejEN9+WoSUvat7KELBEnCk7j3db1t5zOXCnzQZVr7cdr0DUvKNhCIi6vtmw== X-Received: by 2002:a05:6a21:278a:b0:1a0:e089:e25e with SMTP id rn10-20020a056a21278a00b001a0e089e25emr715788pzb.46.1708667791830; Thu, 22 Feb 2024 21:56:31 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:b194:4f71:568a:eeb0]) by smtp.gmail.com with ESMTPSA id x92-20020a17090a6c6500b00298d8804ba8sm557787pjj.46.2024.02.22.21.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 21:56:31 -0800 (PST) Date: Fri, 23 Feb 2024 14:56:26 +0900 From: Sergey Senozhatsky To: Chengming Zhou Cc: hannes@cmpxchg.org, Sergey Senozhatsky , Minchan Kim , Andrew Morton , nphamcs@gmail.com, yosryahmed@google.com, linux-mm@kvack.org, Chengming Zhou , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 2/3] mm/zsmalloc: remove migrate_write_lock_nested() Message-ID: <20240223055626.GV11472@google.com> References: <20240219-b4-szmalloc-migrate-v1-0-fc21039bed7b@linux.dev> <20240219-b4-szmalloc-migrate-v1-2-fc21039bed7b@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219-b4-szmalloc-migrate-v1-2-fc21039bed7b@linux.dev> X-Rspamd-Queue-Id: 080464000B X-Rspam-User: X-Stat-Signature: uqgcx9ef93oc7gg938co7bnrmafdmksf X-Rspamd-Server: rspam01 X-HE-Tag: 1708667792-277120 X-HE-Meta: U2FsdGVkX19s9vWKqG7jrFZNxrAlYDlCTKC+z/2HLgdUyRVxO8qFZJHolY3yM2xEGv0TtH+T4eDHFqMa6IlviBZSdunrdQAMxOzSQA9SWVMa1zl520+PcqHefuSX/MhC9H4j5IqhTuRHS4jB64eH9k8Z1+HMUZkmhmm7OOgjLz+DXZ1soMa9ZmeY3LW4KoN6eq9zcsfvcuyOxWI5vj+gLmaAgJB1Xw6IwP1LKhIRZ2G9vvP8Rj6rlwbr25HjTc+G6SvsT3Wt6TaL8YkdDnpp8Sa/rtREWdCYNYV0/3xGZkJRsGpvGonK/XqLsFasmw707CYquFx1/7LBX0UXci85wpQI/y2AZgFc97XYWmy4ELb4BnvsQj5hi9FWxCgQy5+CiGGRX7WbF8i/ngy26sfTXmZLgrdGBZflmyDQgbEQ84lvjoDGIz+ZisyYeBNLydjzOVlGvnkc22DM9rwIpMpMyGFC5eQwXd7q38+s3KFRTnmpeSXHY1nAgxvWRNN5uVAU34WU6vEbVRtKtl88xJ+ZNuppnKDRBNO3cg8d5Nq1gv7d2Aq0K0T0h4oPdoa9hl84W2CILoLTSxAw+4fM7HqqAt2LmnohczCeSAfi2MkoHdScYeL5eZ4y0TX1aos4BMoVv1xlgc6Vo56eabXzJjx1yTY/1KLm5wVNPGQ0708/A3CyDjsd6jdipT8rdtNoz49oCQMWONFsdBym9tq37vxDWmG+4zJMbZAKUWD/yWce+LV34RVxv//jtRinbx33UJ1vSd+E1n5WWA7RdtbRsDKBCzG3eEe+Lq5XvZQ52xiCHPwkCJYoWwGGH/ASF+tWnAF3QUv7qswjPP4sE5fGSJBw9qa2gn9evuHNwPzcjFoWTm+uglfv8Z5OvnjYJE+IYJKlBKlqbBTiIG1TcWALwladwq1MzaweBEnjRSvoogewpDcSwKzAseX/GYKWueCDNQvZsfqgrQe+Xq5EyTrp1+B xUmg8CVG lA36JWy3rXcleR8G1AiJ12snSeCziHrF8LYMZA0yPm1gk3iQkhuxJct+KCYAts8DENcmRonPC9vQIZHj9+xOh7palkw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000067, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/02/20 11:36), Chengming Zhou wrote: > From: Chengming Zhou > > The migrate write lock is to protect the race between zspage migration > and zspage objects' map users. > > We only need to lock out the map users of src zspage, not dst zspage, > which is safe to map by users concurrently, since we only need to do > obj_malloc() from dst zspage. > > So we can remove the migrate_write_lock_nested() use case. > > As we are here, cleanup the __zs_compact() by moving putback_zspage() > outside of migrate_write_unlock since we hold pool lock, no malloc or > free users can come in. > > Signed-off-by: Chengming Zhou Reviewed-by: Sergey Senozhatsky