From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65049C5478C for ; Fri, 23 Feb 2024 05:49:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFF286B0080; Fri, 23 Feb 2024 00:49:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D88896B0081; Fri, 23 Feb 2024 00:49:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C01D06B0082; Fri, 23 Feb 2024 00:49:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A69B66B0080 for ; Fri, 23 Feb 2024 00:49:29 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 47CA340FFA for ; Fri, 23 Feb 2024 05:49:29 +0000 (UTC) X-FDA: 81821991258.18.9A4DDA2 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf30.hostedemail.com (Postfix) with ESMTP id 6902C8000E for ; Fri, 23 Feb 2024 05:49:27 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=R1GxA3Nm; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708667367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MBESAnNJeprTqvz59zbcwjxkx2D2G7ynywNMleDeZzk=; b=m3qh+LJ34U0VW4C1k74KjwOD2jsumE+wBeK9ArBkWekKx/gwWc5NafL5hj/nkN89vaqKmx CAVlgsscn2Lq1F72YXP4sZhnzSlgNP9gMcNPyvmMJkKTT2m2XxLhFckYbYYpZ3aW8/9Po2 fvE2/+ICfT00etQE4FuUAUz5noqTIpY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=R1GxA3Nm; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708667367; a=rsa-sha256; cv=none; b=GbD2hJsfc7eoCFtW4G1DtHVkQinpOpGHOtXYMnvPsEHFmA1v/GVPxkYxvh8BtrwJbjynub U0pMbFVeGv9TDr7bSGJHtwaB0PJbyEJz2mXGkMsDfrC5C6oHbsLRC1t+qMaJwJzbJ3F+bP ifHJ63iXLeyhcgWGJT5D0R2NJu20kHc= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1dbd32cff0bso4971285ad.0 for ; Thu, 22 Feb 2024 21:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708667366; x=1709272166; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MBESAnNJeprTqvz59zbcwjxkx2D2G7ynywNMleDeZzk=; b=R1GxA3NmcerEmtxK7UcLgE+6y/Q0V471tzOHymee0f0qAwKJn0iXY6O3PIGP55xdBV K/cjJ1AXFUP9OMhsCHfNpFLqPR94yswOw79fAgmBsLzHur75LVhC/YlF4wu/3RzBcjAQ nTqAVG0JSRIg23TGeozYVDpMWfN7P9Cj5JBvA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708667366; x=1709272166; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MBESAnNJeprTqvz59zbcwjxkx2D2G7ynywNMleDeZzk=; b=fln7FvisopZ0YcE8sqCe2PTozUfd1+q40lykgVIvPG+Kqp7cUWAHIWhtdEu4NpcUFm wquhqT1RC2v1I4RmM8iQrMAuMQ6dF7t7AElxLUqr3kexstr8hXWK6kBMEGtsUBAZXfXZ 7oiPsGBZlpepC09tQeen66G0wU5b743qjeYrdUAHKyVgU1h1vK4sZnCxP6ro5YdCiKC8 wNs978ET4Ip3LfgCZcV+VWZCus5wc2RwxOWrbd+Ptg37veyKy7lB7RanwHPhGRbL04hf shl/aa9AyNUWlICbA65zMx47eia1Y4c+TOLV3o1bTVBP/eHWYv56uPI1Ig8CkpNTJiqQ FE9Q== X-Forwarded-Encrypted: i=1; AJvYcCXsILQtVzpOsuA+2PRBFLAzF+Nl1zB9FM9SdNOGLkZThOfYCOpTxVwdGWD9pyXGn4H2+JUsdgPgfDmVbaQ7WQiU5bE= X-Gm-Message-State: AOJu0YwqSWwS0JtzDqWh1Z9wSNo9UZIn+t7TEV9jvncC9JIgjG7zsYkT Qs8Efo3GoUicRRCE+XvYJ00a2v1ZQ6bAdiDi6WspCPigqe6ZHHi+yXarw37msA== X-Google-Smtp-Source: AGHT+IEN4m/ZdcDaPm89m3KXbtl5Q55DPJWRWcBtIrXE9D4k2meckqiLdB7h4zJojCPr0CzigmSeBw== X-Received: by 2002:a17:903:240c:b0:1dc:600b:12fc with SMTP id e12-20020a170903240c00b001dc600b12fcmr1274798plo.23.1708667366343; Thu, 22 Feb 2024 21:49:26 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:b194:4f71:568a:eeb0]) by smtp.gmail.com with ESMTPSA id u12-20020a170903308c00b001da11733477sm10890708plc.75.2024.02.22.21.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 21:49:25 -0800 (PST) Date: Fri, 23 Feb 2024 14:49:21 +0900 From: Sergey Senozhatsky To: Chengming Zhou Cc: hannes@cmpxchg.org, Sergey Senozhatsky , Minchan Kim , Andrew Morton , nphamcs@gmail.com, yosryahmed@google.com, linux-mm@kvack.org, Chengming Zhou , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 1/3] mm/zsmalloc: fix migrate_write_lock() when !CONFIG_COMPACTION Message-ID: <20240223054921.GT11472@google.com> References: <20240219-b4-szmalloc-migrate-v1-0-fc21039bed7b@linux.dev> <20240219-b4-szmalloc-migrate-v1-1-fc21039bed7b@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219-b4-szmalloc-migrate-v1-1-fc21039bed7b@linux.dev> X-Rspamd-Queue-Id: 6902C8000E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7bewogob6ox9659dko5a9m3mprjw9f34 X-HE-Tag: 1708667367-464690 X-HE-Meta: U2FsdGVkX18t5PejCJ0dj1iaPUBvg9/dtt9/yJtprkk4+wP281Bj7IWBNPwI5TCSxJ93/TAfEpF1viLu0uFbdQhHX/0kyEHjr9Bxkshwys6VjxGgh3TXAAFOoAcgKeoL/NQasiNkvkFzv/zbwJxuiD8nPXhr+CQOx+KhPAY6JrbgAxreByEumSJJHog9NMPsvPq3LvU2+4KwLiSILQV8zQo1hMWF8rVGpc5XCd9OWhFvIsXyqS8Gf9/bw7aA6dYVJv+o1dXFBEvVHc+SMg698/CtCF3z8tSSC9PU2g/4pNgZh70AWp3X9G4ePBu6dxz7pE0bhzOqx3zNVRyxJaiINf8zMFRMsx2s2IBBhx7ePmkp+wgXaldPLi0kwIApg7oK0k/8tM4B8vhNo1UjfTvmOHQAIIQvl3Zs93c4bVfh4bQFXhMkVVKF/GbbqhU7jahHDK0Ss+mWPOR6wua/bXr9YLbtoA6jiiLLc2k59ZRA+zuAObXAl9it2gccLluLuVyMm6ijxJ8SedGlBPMKsQ/NMFXmPZbomqbLO9ni+7bmc8ziLDVgkMkLcCC1QsYvo9j1ugLKKxmxlYMb+w2OmfGR1o/+dty5QsxVJLnAnLQvPJvTS+9mq7tlgK9sAGCuBMHb5bDx0tJVoplNeHmt32AU2X6CraocOQWQTSXbb9ueH1JeoTChGGICXKQ9fanZIneKhjXC0mObWHgAhTwJ8ezl6PrvomqHUJ/WpckgdjE/lOyVAPx/bd8tsQ1QAsDWuEQ51vcEgihJ6kuftbW1mPIYWjHSRV2CiPd8yzQ48tzothT36AQveffNEzI8Cnp2pb3TYSBid6MqmqVoNAMPqLaRD7SVvGZsXNop1e6uYx0Vdbtt9+hdkI0qjQXY7ppqiGm/lsebKTxCGLTxxw0tTcWTjNwIx4jFMyg+p6c5io/jVMhMKgJVeJsE6X/E+Y2CpHurm7Zi8/FUDqSqe5nMxTy fYYkvr8B uQ91Tbc7BBIApYtfNWICUw1CM/9uRLcG47VIQHJesCgt92BlMNGYbcCxFFo5sgtPhtaow49PyJ3PZJ5U+9SLz9BbrDYGedCQwORelP9SzlWhjL5NkA3jM7dItVxdhnKLsI8cXw8eWG67aVcxp5g20idZT7BNjDfLUscvhvIsg0fCXAh40HEbrTuu82tOu+RIxOOAZ2Hifj/fiRfDpKrdqGCWbawTPxX7gd0WOTr7lj5J+tgkuIc751Lch8Cys+fG+FNWo+3DgZaxEaqGmaB5zHnE077ek1UiQG2wyyekDANz5K4M/il8ijpXjOzklh4wKNGsstMQyGnfzGQaZ6FjKWdyWfvFCtc90fA1LVVcQKEc2LanEQI22JuQFqVI5H8WqD0auz+qZaSPJayksPN2/84RWEev+Q7X0uMT7BGp8BYWT280l3XiXwy1T31gq3WbougbdRq+DVoCpStAgSPzh+mexGQbrWCVeBvk0L7I61P9nU/q7DXJ8qRLHjSoMoWh8MIMSaLajhR4LEvjPYH68vmSEV3gXIdTqlMDxdyNy+R3pAcniDefSK2uuBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/02/20 11:36), Chengming Zhou wrote: > From: Chengming Zhou > > migrate_write_lock() is a empty function when !CONFIG_COMPACTION, in > which case zs_compact() can be triggered from shrinker reclaim context. > (Maybe it's better to rename it to zs_shrink()?) > > And zspage map object users rely on this migrate_read_lock() so object > won't be migrated elsewhere. > > Fix it by always implementing the migrate_write_lock() related functions. > > Signed-off-by: Chengming Zhou Reviewed-by: Sergey Senozhatsky