From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE5CC5478C for ; Fri, 23 Feb 2024 05:48:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D3CC6B007D; Fri, 23 Feb 2024 00:48:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65C7A6B007E; Fri, 23 Feb 2024 00:48:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FDDA6B0080; Fri, 23 Feb 2024 00:48:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3C8E96B007D for ; Fri, 23 Feb 2024 00:48:55 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B6F1180F7D for ; Fri, 23 Feb 2024 05:48:54 +0000 (UTC) X-FDA: 81821989788.21.6A3B714 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf20.hostedemail.com (Postfix) with ESMTP id 8BA2B1C000A for ; Fri, 23 Feb 2024 05:48:52 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Cv/puCUi"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.177 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708667332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+iMLOG0YNrj8W5POWDY0W8AqRXR08VTXCk+0hnG8vyw=; b=Do4P+imIthTaqPSS7Ap/l9j+rQssvacBHSRhCaGVZtUdY1HTeXyFOTKlGyWbxt9z70Ke33 tCs659slVv6dkJG8E7oOYyc698zzMI9N4s4vj7/LA5cRwwAusV+qkrqMnZosq43XP2GbDA TF43nF9iWcuquvT3pHCnwgDa35vefTo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Cv/puCUi"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.177 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708667332; a=rsa-sha256; cv=none; b=V424jS3cIt61grhUP0UyrPQ7DXJ4bu+w3QCNffVAzvsjIrqKhWA5+0z7PwbT4DYEWg2Lix SAFJubVj3GSeo0Q8TcQ2DPCHdJEIO3U0CaHUl947r9uXNviArkiH0UDksu17DoL0hd1aLN QE0unPsE+7FXYxeGW8kNU8XB+6MpEs0= Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6e435542d41so339477b3a.1 for ; Thu, 22 Feb 2024 21:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708667331; x=1709272131; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+iMLOG0YNrj8W5POWDY0W8AqRXR08VTXCk+0hnG8vyw=; b=Cv/puCUi+DlDc/mDwa10djy5Pyn4l7Y1ZDxi40g4QSXhZbvSJVpqFSauYRMSYo0+kw Pd2CsmQSMJ9zQdClvc7IKjoQxWL1fgYRoYu4R1dSNR3vaMpQSEZ2YPlb2sjjNZlzud3Q LigZJZylXOUZ4/hzcMcZqdr5ffvKclbAh0TpM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708667331; x=1709272131; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+iMLOG0YNrj8W5POWDY0W8AqRXR08VTXCk+0hnG8vyw=; b=THZuIlKfnu47/UifUMFiFvxwwAXtFkoHW9tQysNMdUUkAckq2YWCSUXhUuPcY499QK NtRmEVvW8Uk785VeHUg6bLRCafbmvq0ZNdouROduQcPo61F2spPKHuGpTKcb6IX5o99j pRsKAVfQoC4rk7T61hyFLd4+WWMSVgfvtg3G3sQCjB16wCJdQXt8iJs9WUiC7lfGdIe9 sO55/PAcSWS+EeRVLwS0PTIhpUVv17uJ9ZEPZHcI34ECGj30zhVAOWpYIi231njWP8bW 326j7sKDmdmH3yi42hQ58XQvVBYkGgng4zJfDINzAeTBkZB2DqzVuniDOKZGHywzgoSA cw2g== X-Forwarded-Encrypted: i=1; AJvYcCW6VS7UohpNNo6UDJew6Z1C1ui1wn1iwDOsam2oWoWEFBsc1683/x6G1edmyerbB01ANnSZ7dVKpxCeX5s5Le7OBWI= X-Gm-Message-State: AOJu0YytDdvMJ5sOV8Y2mP8AkMKaAxmZAIFyuQaX2dzZRlahu7iz/7IX LIxmOugFtIs7dvwp+6kiYwFJMzVwMEedBNRjpOjPXVhQmRqs7/Y0hz0BtAzMWA== X-Google-Smtp-Source: AGHT+IEtOskVc5laQXTU6Y8W/mg/KfvsSYoM2fvLEtL1FBDUZbtV+LE9j/gGPLRLaxKzAJYH10ET+g== X-Received: by 2002:a05:6a20:3a88:b0:19e:3b15:2176 with SMTP id d8-20020a056a203a8800b0019e3b152176mr837311pzh.38.1708667331454; Thu, 22 Feb 2024 21:48:51 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:b194:4f71:568a:eeb0]) by smtp.gmail.com with ESMTPSA id kn14-20020a170903078e00b001dbbcff0b5bsm10757324plb.232.2024.02.22.21.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 21:48:51 -0800 (PST) Date: Fri, 23 Feb 2024 14:48:46 +0900 From: Sergey Senozhatsky To: Chengming Zhou Cc: hannes@cmpxchg.org, Andrew Morton , Sergey Senozhatsky , nphamcs@gmail.com, yosryahmed@google.com, Minchan Kim , linux-mm@kvack.org, Chengming Zhou , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 3/3] mm/zsmalloc: remove get_zspage_mapping() Message-ID: <20240223054846.GS11472@google.com> References: <20240220-b4-zsmalloc-cleanup-v1-0-b7e9cbab9541@linux.dev> <20240220-b4-zsmalloc-cleanup-v1-3-b7e9cbab9541@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220-b4-zsmalloc-cleanup-v1-3-b7e9cbab9541@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8BA2B1C000A X-Stat-Signature: ec1khqcs51ahqhmx7otisb4hwyg76fny X-HE-Tag: 1708667332-713046 X-HE-Meta: U2FsdGVkX195vj+2QxcejcMqSF8esWmLtpJQQtVazT/vhjd33PdQ5vv2+akP82JEFo2nhL7BNescSJ3f9DfrbWDWVN87fy3RY1kUbCrd1C/uSPa20q3lLAHV/tiX+JVfPkYYcNBHFcSr0lZKocnotUtSMdiS3+NpK9mvbjEgRL1A/An3P9T/DByCPOCNblQFWKPiDsAevW7tkS4uImQ48LXf3hdh8J48fPDQlGzq6VmZPtLd2mHHX596WLEHPBx1Gy1Pf14rZeuYm2kU3MIBU+lWsbcizM4M057jFbq7DENP60penPerRHMuV3GNd7HhxMRZ9ywnzK1HlZvhGwgGSIjHFk9keiy2Nq78bWZ0tbEEAcQNQcGO4YhIvDKHehJ+l496+fFQYXNmmRIUvVtaadZueU/SidFfOWIvBS1hfcyitdLD5pbg8wMpFnrATO+FxoHeplDcGXbd5hFFItW0UmPdidi3t7nbNVXlqScQjImhZK5YOAg6kjfwi422iEltrZOX7ps3sqNeM1V/aggtydtYnEHg4ud3pGXh1DKLH3o37SI7oq0H772+YC9HMG6etHR9+42eH4pAqlua1Bq82Q3m31jw9WromHsTvuQUHjXQmwbwySE+MKLpafn/+LzyXZpMiFHgnQYmng+PcMPF9QbYJ4tlZcTzBGuNQycUCcMPSkGN+uYUwiY5VogN3hC64GNNWdRocqhqgdvQ2ndUBDbeo+59eyayyj8qnrH/Bq57eJmUkhCF+o0Nxzu23kKsBzrxfYUddAW0ls0ZWyoXPEFIr8HUx12r764DJxxR6Cb4jQUxgfjm4N0wgTrO3o+jBVSi2Nu7FbtiCiTYhjUbukCUESh3z5kAEI+EPRMDW/2zFlRs8ch5BUkdyo/TJH9TWsaGYQsuFQeG46BfBETxJ8at4D5XsshbX6g/jWgiE7YWsYxJStnt0RbfJaevbCPi4i8SjNRTtBcbCwqYuGx KywuNPv2 929oOZMQpzpBgJfA3vlu9vm5OW1+1gWL1kCsJJRLDjjvKErWzNn+2GI1qmbyCOMkXbfybtueM7GQtThxqX8Z1kxv227ZTwXg+Uwb/WT59DLpK1+J3HGt95DlmfnTZpUs+TIZSEVeizlIswZdBea9hZb5B0C/h2lvLLbaNvYUxz5cvEysih609ExGQS6UD6z8Xj6oNY+judPrnD+eARaI0+QQ6bM6sRmIuPKEAfE6nfQuASpZsH1dU1veaDQZQSBazZWYK2fWwo1ZkG/eCWwLZ/xdudFOTDz4jHQDKN8kUEioWc8NctzxyGd9z+rm2dyQ7+rHsNe23XAZeEhWPvB+YGHtMQiUbnMICEJ6aonOQu6XGFdpKUY7PcLWbhEqQcQo3z9E5IZjBbYwSjgGq76cWl6rQpRWeQSprsT/4JyF9wGgNr35RP607LMKhl2VpvVSp/y0z21Atn/S/9PtteroTD2Wr7vZEY4owWYY6AuLyoDzGFQdrrde/Vv3mMgFUoWd9Tvlo X-Bogosity: Ham, tests=bogofilter, spamicity=0.184150, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/02/20 11:44), Chengming Zhou wrote: > From: Chengming Zhou > > Actually we seldom use the class_idx returned from get_zspage_mapping(), > only the zspage->fullness is useful, just use zspage->fullness to remove > this helper. > > Note zspage->fullness is not stable outside pool->lock, remove redundant > "VM_BUG_ON(fullness != ZS_INUSE_RATIO_0)" in async_free_zspage() since > we already have the same VM_BUG_ON() in __free_zspage(), which is safe to > access zspage->fullness with pool->lock held. > > Signed-off-by: Chengming Zhou Reviewed-by: Sergey Senozhatsky