From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4601EC48BC4 for ; Fri, 23 Feb 2024 04:51:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0AE76B0078; Thu, 22 Feb 2024 23:51:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBB996B007D; Thu, 22 Feb 2024 23:51:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B83F76B0087; Thu, 22 Feb 2024 23:51:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A7D106B0078 for ; Thu, 22 Feb 2024 23:51:40 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 810DB1C123E for ; Fri, 23 Feb 2024 04:51:40 +0000 (UTC) X-FDA: 81821845560.11.F949A46 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf04.hostedemail.com (Postfix) with ESMTP id CE82D40006 for ; Fri, 23 Feb 2024 04:51:38 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Zc3+YUNk; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf04.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708663898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lyfVn1iwxylZLLoWYCg2pfNNrBNYSfri0DItXMJEGuo=; b=I2CIJ+xciaLfo+ODijWLh0aE4+NrlurjB4lPGN8IE7ogktyeKHdZ3cbPeOwn8RIHhlN4L9 rsFq8UtrT83SuEyryJuEUeLx3nCdyPnvUyw5BfrZasUZXn0jkMZRKzRQxs9iXlo4psKZdE WOf4UniwFGGdTuo39AYSfe4o1KtWejg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Zc3+YUNk; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf04.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708663898; a=rsa-sha256; cv=none; b=ThiqfQIeBHjb/UNIhHkSseCbg5FkuoxLuMJzwnPHWP5Fvswj6CEnMbj5+poC0YluYwJWmM VHSNY2Guyd0totGZjyZD9PFwKcWvLix3hccfxu/zp+HjllNSba9+OGSLipQOxZyLfGhQPZ 31j97glCtzSuFpZ3EUj0Q7wz+PyenB4= Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5cddc5455aeso385773a12.1 for ; Thu, 22 Feb 2024 20:51:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708663897; x=1709268697; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lyfVn1iwxylZLLoWYCg2pfNNrBNYSfri0DItXMJEGuo=; b=Zc3+YUNkTXLSHKFcgnkTWr3jiJM4M0EyejDzjevARaWXk18IvWhiH+TEgLvmpVrSps yIRSRG98vLo8Vg66kkcdsFUHUOQ8l8uPXaawKpA7pPz4a52rO8LMNFymiNOH+FFZaBrO ulvswT1R/XJNVoQTWiv3oWrrDcf5OC2ciQwdo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708663897; x=1709268697; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lyfVn1iwxylZLLoWYCg2pfNNrBNYSfri0DItXMJEGuo=; b=K1ORrtILSKHPviD1sGnGjrmyZcUW7JnvYQ3G+8Ln6BMzFBg/PJ7hcJOVLdpLIV+Wm9 C74IlIuCVLF1KeulA4PX5S6gP1+GLyCK1UbHMuCWCXXax1tpq2CCJPZnjZcs71IydhoG fIt8gSTmjCBm8mJCfPAFTyIF4qWRUZ/iJzqzzrk9zDxxF1UsEg5tePf6XWc4X0vqdZrK tMS/TeAMutw3kVhAw62mOkjXs39Jb0u8dQDqzKeAGqRqVmAj1FO6ZqbYA+9skWVAn8/Q g7oOQYWkXvYPxtiGLEw+VsdahtWUhG/jGzAsZ4Ksz6mHvbt72FHuP/lw+vYtJmVC8TeB 3NeQ== X-Forwarded-Encrypted: i=1; AJvYcCVAvYLc0ebrW2eIKvumNsqe8ci0Fw7Ltlm6Nutk6h2/x6xW0A5KGBpF559QmrOChwKGvGPUbKas5UYYbFC1h6Q71aI= X-Gm-Message-State: AOJu0YxBrS5zOWz472AscJ8lS3kSuLZq8tMEqW8ZcG4L4cZ0DJKvlKru wVU7HDp3AY2T1X3TNPGXsXMpupVWaQuFbtv7/c4bkItkwtlBRV+myUp4YvbRhQ== X-Google-Smtp-Source: AGHT+IEtWx0eoRVoFdevZ/nRdWdFaxRcLnJtYSotL1tOFfcl9+IduEB3z+vqBMxsRfsA3KooyjzTCQ== X-Received: by 2002:a05:6a20:d805:b0:19a:43b9:d460 with SMTP id iv5-20020a056a20d80500b0019a43b9d460mr984209pzb.62.1708663897513; Thu, 22 Feb 2024 20:51:37 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:b194:4f71:568a:eeb0]) by smtp.gmail.com with ESMTPSA id n5-20020a17090a928500b0029967638141sm382718pjo.37.2024.02.22.20.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 20:51:37 -0800 (PST) Date: Fri, 23 Feb 2024 13:51:32 +0900 From: Sergey Senozhatsky To: Kefeng Wang Cc: Johannes Weiner , Yosry Ahmed , Nhat Pham , Andrew Morton , Chengming Zhou , Huacai Chen , Minchan Kim , Sergey Senozhatsky , linux-mm@kvack.org, linux-block@vger.kernel.org Subject: Re: [PATCH 0/5] mm: unify default compressor algorithm for zram/zswap Message-ID: <20240223045132.GL11472@google.com> References: <20240223035548.2591882-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223035548.2591882-1-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: CE82D40006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: by7fiy93zy979ug3gmcxugfqf6ns8s1z X-HE-Tag: 1708663898-470526 X-HE-Meta: U2FsdGVkX1+80CkyFzO9g0i4WzSCEp/ydbdPGl9ysXPTQ5bZKdmz/gcPNDJtFAQY1KbDGGqXoLYAMgxYnIL87SWX5LHm9osZwYU3Tls7kpWKJFG0wb/WAxlysKdwZ2jPK3wr9XEs2sJr2GgbiwCZQk2DBXOIQMcD26/33aFZmtrtZVYnJjMncNoFnZO5f6+jB/K2Ydw6Qln9YwamonRlq0QEgpYJ8OOf7IcZ9/kyCXeix9k04ME5tcu01cGOh89jIMBZDzLNFyYbIK9o7zQSB840Y5TM/1itxUjiL4DRCwWoXa9tA3Li83YLC6PVkkEFQ2hYoUzh79SsWu0LFENDQPVAi/2mjOIebRqvuxDA2dHyDFH6PReP39TK2RI3HFyEAgNITORH9a/STaX0JQDbfIYBPMiWmKFgfwaR0JnsZk0x8+monW6lSEeAj5e/XI/MLeFHp2RsIT6AulJxOQhW8XtXqIj2kAmT3zWMPIiBt/FmWz7K6Kwc+25A/PdH3Y4dgDR2fOtCy5A37u7Yf414aO0FHTuAl2RekSK8FpzV47X48vSmrig4IyK71soE4mIv3QgzXKwSIsbrUpL38RchkIDnK02s1zzoKMMlERkxdfNBOP3IIfjy77Oypmg/Dh2U1UAXRUD4fMUowFvh4bLkTRZYbIorfF788Eqy/K2BznX1IwnBC7OVpuL6uovCw/BC5UbzbNCh54x8UEFUH+RBzLEcY7qTet/MJjM3/uzhJ0pr4wySSnCiICeN0F9cfpSQHcbLFxwoU+2YrxhNDL/xOFYHhtmkNqxNmZxT3gDMmLEydlvpDoEe91gcgpqDUQkP7TCS+VU/DTdiFhsMbyFBQAQVHABERSqnfsJlaHZHmVczARyYDWY6VGJI6kgo7aYQTNEbf36nYPRUSkizY+KdXZq3dVpQ2TGmfMdnCnCYseiaZEB2L9rl9F1W93SUVp4BDcOsW4H61PYpgaa6ujn kftVAjnn RGQIYGDAR1Qud1xdgnDWXstCczoeeVljW8FmHkor859Lao6w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000166, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/02/23 11:55), Kefeng Wang wrote: > > Both zram and zswap are used to reduce memory usage by compressing cold > page, a default compressor algorithm is selected from kinds of compressor > algorithm as the default one from very similar Kconfig, also both of > them could change the algorithm by sysfs interfaces, so unify the > default compressor algorithm to cleanup the default algorithm chosen. > > Kefeng Wang (5): > zram: zcomp: remove zcomp_set_max_streams() declaration I'm afraid this (1/5) is the only patch in the series that we can land. The rest of the series doesn't look beneficial nor correct. Sorry. > zram: make zram depends on SWAP > zram: support deflate compressor > mm: zswap: default to lzo-rle instead of lzo > mm: unify default compressor algorithm for zswap and zram