From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92030C48BF8 for ; Thu, 22 Feb 2024 15:07:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1E806B007B; Thu, 22 Feb 2024 10:07:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ACE286B007E; Thu, 22 Feb 2024 10:07:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 948F36B0081; Thu, 22 Feb 2024 10:07:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 808B26B007B for ; Thu, 22 Feb 2024 10:07:25 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4AEF0140E83 for ; Thu, 22 Feb 2024 15:07:25 +0000 (UTC) X-FDA: 81819768450.29.2EC154F Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf07.hostedemail.com (Postfix) with ESMTP id E74524007D for ; Thu, 22 Feb 2024 15:07:15 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=fZFuiScZ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=J1rOJ07C; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf07.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708614436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GcH9v6Ww3NgkhwdANf0QhPk5rTB/fdTp1nBrmv6170E=; b=n3bEQbtTSGKQ63HSJP5XB8hfaRdH0wuOCEFZeuUxVWkUTNtI5pKP2aPRGjIpMCyDiQhqZw Kk/Bzn1msvzatSurE/DsXhXxPyAoOcz9TNbGKLh/TzNkAbuEyYung4ZyvTo+diXfs3pvlu d2whLPesXtA5/D6jB1m392Tzy7CgjJ0= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=fZFuiScZ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=J1rOJ07C; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf07.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1708614436; a=rsa-sha256; cv=pass; b=IxQeRvS5NJzrZsNGi2C1Wm9eTFKHlZHJktj8jc5c5m3pYNDWxxY62nCcG3+0EGiN5oMbIg LYFIw2gmlbfSdXsACcrZOAdF6qGoKvQFNnTJhpHql+Hn3Am7Q316mcxa8jZ5LdGptuA5k/ +IyQw8m0mfuGGwuVyE7HQUut3TKrrUQ= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41MB8j6r031006; Thu, 22 Feb 2024 15:07:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : content-transfer-encoding : in-reply-to : mime-version; s=corp-2023-11-20; bh=GcH9v6Ww3NgkhwdANf0QhPk5rTB/fdTp1nBrmv6170E=; b=fZFuiScZt2+cnrLBhJU5UvCUhYMMpL5Vy9pyyuAeAjalYZX4gqkeRD+Hb1UxIvPisYyZ PZCkgFLAnV64ZPVkdxcH9vljicun12Zs6eIEnNhXXgdqkjmsrpjTzqh4eUtlLNhCEf09 l5/0Wh13S7kC3CTcQhfCrIl2rBtTc1kAWcLAVhPrQS+6yTPNsmvcWHZ1KgcV7eO1SdkD HV2KIahDHmN2ZgXcrDsUq2q+YhudouAQ0pUroyWhRJTR9hUlmfoWeKTkoiRrKeFvAoaV JBmE4ioacsscIHJCYqzlEzYcNmkQ9tf2JDB2qvIcnuWyZ+N4lEsMSUuMh7eG9VZ/xy6z dw== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wanbvmuqq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Feb 2024 15:07:11 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 41MEoeoX024458; Thu, 22 Feb 2024 15:07:08 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2040.outbound.protection.outlook.com [104.47.66.40]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3wak8as85e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Feb 2024 15:07:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aPsUC0wPV8SuUVqcf85lDkK6AJHgN4Cc5eOZRZzXdLmjvepj61ih+kPJo2ewUFx4uK+Rgxh/DJEqcVbVM5fJzUgEkaOTTyNHVf5GLvPm86EohDap2qbudT6AsdOgoZJb6J/CeZM6GLUsXoX1jfm4C4Zr5rXCQoipdt+d4wX7ST5/H0MdEdnESj4qSFmnNFlSECNYuf47VJq4EWvi3hnQMWaBPLvsVPeUkXh5/MVObyxZH2q7P/8zZrymvDGTwLhuW20GgZvAJ5Fam6q3MCrdE31Vm+I1POiA/OXh0xg/wCjmW3Vq2nI6sQZLMQDaAEyW4Jn3oKirz4tBwyNs33dz+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GcH9v6Ww3NgkhwdANf0QhPk5rTB/fdTp1nBrmv6170E=; b=a3G0Ti3FRIuvBuxQ9pT1KQRzBVDJOvi0q0u7nbpEuVbwNJGNC08FPkK6VXZYwiKaQj6AV0F7oO+H04WnmNjS3bfRsyoqpn23fdF9Kv4fXnDOUqrkcVyzvT8x4K3ZePWvkTMBMElJhDsyHaIBgQxyugHMd+jvms2+vi8sTFRLUWanyNwq0V/4S129iubYKNS3mBPb/JShc3LQXFCpzil3JmkMzKwtbWLdt68oi3HpNRIs5VMc2qPbJNv+kz1FfjsPeDothb6jpasdq0ykLMSyRae52Yx+nCihnytbFVMcEmTH5Gfm91/TE1PJ0UzAB49OMse928oLV3hZc/EUozTdHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GcH9v6Ww3NgkhwdANf0QhPk5rTB/fdTp1nBrmv6170E=; b=J1rOJ07C4hL2z0Gkr9gDJWi0vHIHsGqLZW8dSvzjLcKbiivMfYXIJMe1QrDo2gm5Jj+QtCZInerdY7lPIOz+9UdLXdUx/LXZvYK5wE81DvWq3lYo+i4UNOJ/MAiUdL1ZMPIdVpxra6hsiEIHluRNq2MI3Qx9tWOpnfN1HgT0LLQ= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by DS7PR10MB7277.namprd10.prod.outlook.com (2603:10b6:8:d8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.26; Thu, 22 Feb 2024 15:07:05 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::20c8:7efa:f9a8:7606]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::20c8:7efa:f9a8:7606%4]) with mapi id 15.20.7316.018; Thu, 22 Feb 2024 15:07:05 +0000 Date: Thu, 22 Feb 2024 10:07:03 -0500 From: "Liam R. Howlett" To: Yajun Deng Cc: akpm@linux-foundation.org, vbabka@suse.cz, lstoakes@gmail.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mmap: convert all mas except mas_detach to vma iterator Message-ID: <20240222150703.u55kpmdlog5hrld3@revolver> Mail-Followup-To: "Liam R. Howlett" , Yajun Deng , akpm@linux-foundation.org, vbabka@suse.cz, lstoakes@gmail.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240218023155.2684469-1-yajun.deng@linux.dev> <9f76ce23-67b1-ccbe-a722-1db0e8f0a408@linux.dev> <20240220180603.dhnthx2nk5455opm@revolver> <0ff93990-b8b6-89ce-0174-4023599059e7@linux.dev> <20240221143103.bkhewpq2wirsoyqw@revolver> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: User-Agent: NeoMutt/20220429 X-ClientProxiedBy: YT4P288CA0037.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d3::19) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|DS7PR10MB7277:EE_ X-MS-Office365-Filtering-Correlation-Id: be4017f8-be58-43d4-c2be-08dc33b7ee38 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b4jOsbd0luOyqJUOlA+XqtR+0eExTGaI9/a4LtkYLG46hBbvMX8zCu6JWTdgnsSJMEp4tEZNMLPuPjgLW1egbhZ9YudBexgRy3jYtlPqALI8U+nUo89+qjD5cKJbMyF611l9vFKKpTOntCZ4hZ12YdfybgrSNw6ReQJBE5olYlP5UFVSuru9ej/Gi30stBNbxTO9GyLL5lV7nIo5UvL/qBf5cdq1+4VyuGcjSYosYVr1l94rJOI81+Vo/sv+wVZJk83copHTJXsvZygv+S4M7gx1NSClDMqhZEuCYC6kPGcbGyyckzCQDtSJBDalhEKgp5+E1bVAgRP3WrbAjJmCbWMWc88rQPhUZXxy+F9mBZH6391BKLhqh4/StUkb6EL5lW/31KZ9ZLqLHEKK2/kvHr1yCHFndhuWtrKM7w/+15L/g7wzfhPbFDWJoCPlNRQ3amN0q5vioDe2k9V5IWEZD30nIv+1p94sctAYwsKPYzHo1Zi8wNre5i6MRl4O7HWo7USXPBm5tl53G66iRBp+GxzQgFlIoxcGWgHm+/fodqA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?KaEvAmFdWe7OET9zq47pVfh1Ca7mU2loTCv9ZK00xtvLXqbcEqCMPFQKmH?= =?iso-8859-1?Q?7slvj1jmeMo39VWGM5YkUyyPGJDJTZu3S3YbbT7v5dBgxz/dLIXAcSdE8F?= =?iso-8859-1?Q?bRniKEIIRE1Af8Uvh0/qNRneq03wVvPMSANEwR5P7BnFpLlf+G90mWwbdT?= =?iso-8859-1?Q?O1N/zdi6eOtoGfm2+ZAk+arH+IYyFZ43btLziNy21vdpcymjrPMzuACEuE?= =?iso-8859-1?Q?BqMA/p5LJ1jf6QBfjZM7ubTPuGUwERc60gOlYE5XuOk7imKjukfABVQe7u?= =?iso-8859-1?Q?ZRY4lhfQGSMb1Cr2zoTAao/I4wHSl1o4v3Ae8PBOYkII1cmh+5plOvtwGr?= =?iso-8859-1?Q?mIbsNuIRyDhznPbDlRVnHmrDaZ76MuJbZRG8BSpjXE+g/HOs499cmApcAy?= =?iso-8859-1?Q?o0h7LD+u9nreu1v9H3nHwF0+21Dutpun9gTSDyhM+jEU4g3NAX6n8kz6PY?= =?iso-8859-1?Q?rBthWXCoopR+/qwx8aLjePBZi6bULu8x3lz6VIau+lzckw/YPHPXq9hW5e?= =?iso-8859-1?Q?Ol2O9ArK1tg/SMY8qjjZugLXbf54ohvP9UK/eaMd8MVPjT/Rp8vkFmUOze?= =?iso-8859-1?Q?GKw0uM+BMDDqsJDEgT8ZKUFT5JCEt1YfzA1/YAMB7KYcShm/UXg4PTvZpv?= =?iso-8859-1?Q?HJPHSouI5WYYKqww+cmcW+/FKqfVmhDvgsffJZfNaeOIN+6Dhrwd/lFfFO?= =?iso-8859-1?Q?wIKV9vbBsYmLi1PbGyOzC8uLDgH+0ZxcTAmLxPuzbLeoHsHRn8APYIQVrP?= =?iso-8859-1?Q?QQeu97HD551Rw6Y21IW9u5U1pdOgg4hCPGiImP04qaFDC7GcbnOzJLvv4w?= =?iso-8859-1?Q?bOyw+t57OuIwkA9J39NrlW3ay84bIUdmlQ/AsgutGTIeeeKQUXvVvyHa+8?= =?iso-8859-1?Q?ddutmg05WROvU3KEXS7btYAWx1dGf29BiwjbkG/WVZF4sFABpEcZeZ7hRw?= =?iso-8859-1?Q?OzXOJuaTCoGIeZmo2C4m/YK483rqx0vGr+yL1/CzLZeFqCJGKN97Mp5pFP?= =?iso-8859-1?Q?zBs4/BxyfTWVgTgoRiy0SzjuMewa/PRlt9BRnDNAUJbJwhwGfjmJ4EpZiX?= =?iso-8859-1?Q?EPXRwB9xe469SzwI9Z7GN4fbrO5FnT5mcgvO93VrpB2iyql3ZWTTeqlSqu?= =?iso-8859-1?Q?kMvAv6f0FwsIqpCEzhP9lJSBTlG0uv7Tksp7v1EhO0nA7+2P5UpHDMdRHJ?= =?iso-8859-1?Q?8XrnhehsMQscPNIh8wOAcp03AVQfx297+dtop2UABD3U127x45HYXR/Jx9?= =?iso-8859-1?Q?twhA6UFXAZ1sQb9VYVBVm7SDx+mtMqONc8HFjilrdOuibVYwZBm0nWerFV?= =?iso-8859-1?Q?yxTX3Q+idHyxEDjUBNtriucddPzXFYRn2/TEWZ1Miw9CFkYZwdxtUB3q2/?= =?iso-8859-1?Q?Rypo/ywgnaZ3CKZw+92uPEc8aCMAPlNY4OjfkonYkZMPtMPVGH0EHbnDMg?= =?iso-8859-1?Q?QbAC8qa+evtK5Ekek9ejZWABOUMdquOcrLKzm3zXkjFK3Kinr6aQA8XQQb?= =?iso-8859-1?Q?Jk0xJ9QzALUcj8TtDAAn3Rk+kqzSvIyhf10oXJfN7kMELUCrLJg/eMo8eZ?= =?iso-8859-1?Q?FyJmUMw9NS1bbgFkiEurslu+jcAJe5dceYb+Ego9FajW7Lcj7zxRXJ1wOo?= =?iso-8859-1?Q?aOV8R69XdAcIoto4HqVjFMll/Klc0tl9hJ?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: GtnrhgxiXE4GaE0TU+IZyFk5d2pMmgJmWzgcq6g56VZ73ZSkQLw5csrCT+71gtQoAKxEYm8dfDcaeZ252YDES/tlYPeXuanUdoMm0QW0qVPLkKiytR3NP3WTOJ21PFgvKsdoZX6W9s0PJUZzwBTCWfBOevzbeMikP48d/B303U+NF81OMaa9QzWY0aVTjdCNu19Df00PzSbRX6uzDQOYvekoINrIbdqN6zHjkyRNWp5HJbyLKVQj8Lu1Mh+ZeJI7O30jtwkh7zIQbVcCKodZ0P2/OzQqZ7XYUXFAapPGeZZAil/B2uStCF1X0i7XN2DhrLb1Ka+AvXKy1Wrwyi2ptjqXbBZ/fYh9F50B19Q2cZoOvpYtN6JjrP/mBWg65TRCduP5avHh2HBoUqGkbw25BSXpXJZpbOJ27DmOE4WEPYa6+d52N6UmCPW9A5pRSqg/6mS+u8BQrjlBzi2tRkQhBTJ5FxYH0MoOS2aiLqNHt1kSeWsNjHl4uV+L2IIhCDMKb9BneXiyqoE2iMSOVDa6T9Edyz+/x8W8mE8B6kthmosSG+zS+IMBh5oGscBPcvplaOfUEdyUeg3X7S2ovX6XXXlL0KUhp77k5V3TwPsaezE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: be4017f8-be58-43d4-c2be-08dc33b7ee38 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 15:07:04.9938 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LiPzRaAYyjxaAJFpjvSPvjhEhb00X7HpTPgo4rBkiGCt2zAtLlEEXGfPMK7NY1A4zJwFtZ/swkkQsuc4sqFmPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7277 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-22_11,2024-02-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402220120 X-Proofpoint-GUID: veZ0LG3zZLTkT18JZWyvnvEXUNMx3zNp X-Proofpoint-ORIG-GUID: veZ0LG3zZLTkT18JZWyvnvEXUNMx3zNp X-Rspamd-Queue-Id: E74524007D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: mu5gfme3j4noyt4tie8jrzgu5148f99s X-HE-Tag: 1708614435-560838 X-HE-Meta: U2FsdGVkX1+WuGf21o39DQ+BPFXZUQ0chrp8AHAYqKTLS02a14sES0LJvFRz7h7Mp652GQYmsHNXURze6i++iDCqb7GZRvpPC+EiRtC0R++gIDtzE6YWmzhEFiHcvoIPeI4qY4XL0iIJIeQza7Z6oMPXTfqt5sOhAqYWg06KLVmwKhm2re3b1wSBmvHT8nyLQRBn7ZAyW9GKYMM46KtWHmVhZm0udVpBYzP1DTKks01Sm7ziGKzRqwBzgaqsWP4uEcinEXanfjffkU54JGzzvgsdC55L5wJPS8KlO0UZJ8ipXy0COuwdvGNraBHvgswc4P8HfYcwGdlzfC6ZVymTffv8HUdiykp/wUpjvhqSyEF8fLX/1bMAcFNaSxkVdUP/RnAxdoXId/ooK0XIh5lszqXehaAV1A/gqsUZzPGx06x7N2gfIfaytTj8P95DNXmOCyNV4+YELsSMqUDvP62RiwV0NnlPf8bR9Ek/zWAM+OGUNKBGAcB9/Pggw3ipdmbR3y7zcrngTk8kTIbnRvPn5bIU0G/xRGkTmOliQ01dp0JemBZWNfbCI9RvUgTBa6dhwN+6gJoBRtpSUPZtdCV/DOhY7fCVxkiFeN/vG2okXdydIf4UeW7OIa0V0YpmntLrwGBBZXKpukZoCHeyE3ddHeCKkq4OivpfJTyhHI8N+E/3qZcO4x1uITKRdL3lIW8oF5PxCOo2EA7Ar7Q7kkOOJON0VUz244/87IqSXz87nvxSzeZWFq7c/aXtd+IYmS97iokTH+YBB+unKEriuFKir8QJ4oJyN8UbClMEzo/L8RHZr4GgJLLbV7J6LUZRH+cITGs45CNokvoTGbQvYR0qv6QvzOhUrMiPlAnlvVbcUjVwbSdgVLB60RSM7CXOIsu7qrq1Z6IePDmBQOLjkGSk8vMF0jm5e5n4bXvK+9ENJVZIxtDvtANYuMHxdSnofJIkjrjji3x1IW0SZrd4YGe IQ2ruszA B4qo3TuQoIdhi8/9hFDwxQep9J4qSa+UeDPYHYlK3NTG3U6RQ9Ey0JhktkteuSWCm9Bxbgc8vJH9LWBLexOo/r85aEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000646, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Yajun Deng [240222 03:56]: ... > > > > > > @@ -1959,11 +1958,12 @@ static int expand_upwards(struct vm_are= a_struct *vma, unsigned long address) > > > > > > struct vm_area_struct *next; > > > > > > unsigned long gap_addr; > > > > > > int error =3D 0; > > > > > > - MA_STATE(mas, &mm->mm_mt, vma->vm_start, address); > > > > > > + VMA_ITERATOR(vmi, mm, 0); > > > > > > if (!(vma->vm_flags & VM_GROWSUP)) > > > > > > return -EFAULT; > > > > > > + vma_iter_config(&vmi, vma->vm_start, address); > > > > This is confusing. I think you are doing this so that the vma iter= ator > > > > is set up the same as the maple state, and not what is logically > > > > necessary? > > >=20 > > > Yes, VMA_ITERATOR can only pass one address. > > >=20 > > > > > > /* Guard against exceeding limits of the address space. */ > > > > > > address &=3D PAGE_MASK; > > > > > > if (address >=3D (TASK_SIZE & PAGE_MASK)) > > > > > > @@ -1985,15 +1985,15 @@ static int expand_upwards(struct vm_are= a_struct *vma, unsigned long address) > > > > > > } > > > > > > if (next) > > > > > > - mas_prev_range(&mas, address); > > > > > > + mas_prev_range(&vmi.mas, address); > > > > This isn't really hiding the maple state. > > >=20 > > > Okay,=A0 I will create a new helper function for this in the mm/inter= nal.h. > > >=20 > > > >=20 > > > > > > - __mas_set_range(&mas, vma->vm_start, address - 1); > > > > > > - if (mas_preallocate(&mas, vma, GFP_KERNEL)) > > > > > > + vma_iter_config(&vmi, vma->vm_start, address); > > > > The above maple state changes is to get the maple state to point to= the > > > > correct area for the preallocation call below. This seems unnecess= ary > > > > to me. > > > >=20 > > > > We really should just set it up correctly. Unfortunately, with the= VMA > > > > iterator, that's not really possible on initialization. > > > >=20 > > > > What we can do is use the vma->vm_start for the initialization, the= n use > > > > vma_iter_config() here. That will not reset any state - but that's= fine > > > > because the preallocation is the first call that actually uses it > > > > anyways. > > > >=20 > > > > So we can initialize with vma->vm_start, don't call vma_iter_config > > > > until here, and also drop the if (next) part. > > > >=20 > > > > This is possible here because it's not optimised like the > > > > expand_upwards() case, which uses the state to check prev and avoid= s an > > > > extra walk. > > > >=20 > > > > Please make sure to test with the ltp tests on the stack combining,= etc > > > > on a platform that expands down. >=20 >=20 > It seems something wrong about this description. This change is in > expand_upwards(), but not in >=20 > expand_downwards(). So we should test it on a platform that expands up. Oh, yes. Test on the platform that expands upwards would be best. Sorry about the mix up. >And > drop the if (next) part >=20 > is unnecessary. Did I get that right? Yes, I think the if (next) part is unnecessary because the maple state/vma iterator has not actually moved - we use find_vma_intersection() to locate next and not the iterator. This is different than what we do in the expand_downwards. Note that, in the even that we reach the limit and cannot return a usable address, these functions will call the counterpart and search in the opposite direction. >=20 > > >=20 > > > Okay, I will test it. > > Testing this can be tricky. Thanks for looking at it. > >=20 ... Thanks, Liam