From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34149C54788 for ; Thu, 22 Feb 2024 14:05:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C51856B009A; Thu, 22 Feb 2024 09:05:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C01B26B009B; Thu, 22 Feb 2024 09:05:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC9416B009C; Thu, 22 Feb 2024 09:05:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9AAF46B009A for ; Thu, 22 Feb 2024 09:05:33 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7794A1C0F86 for ; Thu, 22 Feb 2024 14:05:33 +0000 (UTC) X-FDA: 81819612546.28.664FFD9 Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [91.218.175.187]) by imf15.hostedemail.com (Postfix) with ESMTP id 6F583A0032 for ; Thu, 22 Feb 2024 14:05:02 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EWql7fnc; spf=pass (imf15.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708610702; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P5dkM7DuGNd3n4uTkQacavwzunNC39kM4edC7ugWujE=; b=vTmkLil9z/iBpT7wySWXcTRlcNRMPJAzDFQ4K3lKdwSuuZ6ASrRxPIRZvzTl0GozTls57W iD4UBIrmeMYCdk+oJv6Nam4kS+LmTaKSEV7mozvEcbF2/3SwTkInDLRhxSoyD+XwLl4iaI AHjAxKdQMP97Vlc5pRrW76BImlwHlXU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EWql7fnc; spf=pass (imf15.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708610702; a=rsa-sha256; cv=none; b=CUEUo7HIXUAI0rKVPW+NmSsWOrFzo+sh+n/X2mkxS7RQNE52JUPNOiIYkDL6bVejt5iy6M d65MXMeCVr1+Xpo3MuZLWe/9bpyOqsS7W76RTGodPqipeANTsRrhXzOJNvPlJFMz357Qg/ gqyxF/mWOSUJpy2ZfpkOiTAP34XoNqA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708610701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P5dkM7DuGNd3n4uTkQacavwzunNC39kM4edC7ugWujE=; b=EWql7fncR1Nj1MIpD5GRXCTp3WENf4dEY69tv+jJU3JilH4N5PjL/V0Pe5FGwckjEP/Uyc TMSelN5Z8oMXIJ4mqBgNDiz4LmUYpAOxzwz8N/sBA/f6cjS1ksHyDB50z50WXk6Wjh9xGP vTIbBboABNWUcFmQwXUyWrABeLtlfvs= From: Gang Li To: Andrew Morton Cc: David Hildenbrand , David Rientjes , Muchun Song , Tim Chen , Steffen Klassert , Daniel Jordan , Jane Chu , "Paul E . McKenney" , Randy Dunlap , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com, Gang Li Subject: [PATCH v6 5/8] padata: downgrade padata_do_multithreaded to serial execution for non-SMP Date: Thu, 22 Feb 2024 22:04:18 +0800 Message-Id: <20240222140422.393911-6-gang.li@linux.dev> In-Reply-To: <20240222140422.393911-1-gang.li@linux.dev> References: <20240222140422.393911-1-gang.li@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 6F583A0032 X-Rspam-User: X-Stat-Signature: 35gwfoa1m6c4ztz1971o4egp59y3grhn X-Rspamd-Server: rspam01 X-HE-Tag: 1708610702-677869 X-HE-Meta: U2FsdGVkX18u4g5drJxP2Vonb0JeelaLH3Nh/Rl8VmmtDa2gzhy7PCRn+pdPhnaOjeW+UBTu+2aucmmydjrWh5SdqgW1TPaOJHa5mBC/KBTvbT2YeAnRRkkaIXGerOhNHGFH2qOOJXRNpv5Gj2eUXql4wmFryhRDM4xTAnbUTWnm2Zh8mW8xVJoMbkDeCvLXpBvrXCHYhFNCKhlCraQ3m/HMI3MAMNBXDZjmZ2hrd6RGF1DX7FDkb6yQJpxOn3lzmawwjxp9J0LJXVkT+7RBKO6XSfDDuwG6RRSZwZ10pcsSbg/VapZCNd20U3Bhd/7iquqcZgpSGPgylprU9m9tCT/qqUCdBFbYF5dMVNaQhEIklxpnI1b+C62bMkDc6vnTpXhFtVSemogKqz58nlH3A3eP1FxBmpe5nXrsfUpKgYwoxrAzdIcK0puIQrQOD4x0hKx3OjLIiZ6eZHKFMzCJHAjZ1na6ZFI2FMIWncCKZjym1kUdsON+iJ71f7aXXUlkbGA8HiixiWCzz9IQ9k1fHEPokwxUZFsUrIsTRCp2LzJWMdMR98vrecOMqN0DdcrVPgbLxjw+zBkYjubPr7DtBW+ywwJpTt9zKVjd1v8ERfFqPKfiUnl/vU4xQ1AROuVg2KeSRaVLScH0ZqmGaJn1uKSQynlX/sYrmClYbZrjoy9SFSCO3R/2MCRWHsWMvGrzCW3F+fiU8LeQBK1y7sBSuWBed908tR0YkdDR/f9z3F6hDRR8mhH1bQ+YktfVeSr8ct57TJdIxjdpJpIQFqlrnZJi+ErHtmrnOcQH9HWwRR6e4YDP9b89/R84zANezCd199sEmPlReSIU6aJiy4g9Y+jpU8XNOxGBL+anEElcd2BUrXkjByG0V1+i+Zed3NN172sXTNKKa3MNYgs5XcgbpgFMGZZJIVz/xla2lAvPGC6vOzVUyjwFsHbo/B9qlcYNca0Zj441uS7eRZMhziz DL3HF84X cN9ar9BtmAKmAkL5NwI8rKLskC2djYCG7cFAucuRYHc2FAyaxrgPkOHiLeW9mxCQEz3ssiPPJOpBMGeYfevH3QVwLE6qMtu3wkj7pXI4p8x7YBVaMhm1bLUaL810VNEKj/ecUACUHGtt8D6HQL6C/x4DMuGpfOBq/ca1wzb10R+DLgCFNQBN4x3GUdjToZeB0GWGjHalZxy158ni3uubtU6+gOOW2JnjEVBZPV3RGnzxh++Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: hugetlb parallelization depends on PADATA, and PADATA depends on SMP. PADATA consists of two distinct functionality: One part is padata_do_multithreaded which disregards order and simply divides tasks into several groups for parallel execution. Hugetlb init parallelization depends on padata_do_multithreaded. The other part is composed of a set of APIs that, while handling data in an out-of-order parallel manner, can eventually return the data with ordered sequence. Currently Only `crypto/pcrypt.c` use them. All users of PADATA of non-SMP case currently only use padata_do_multithreaded. It is easy to implement a serial one in include/linux/padata.h. And it is not necessary to implement another functionality unless the only user of crypto/pcrypt.c does not depend on SMP in the future. Signed-off-by: Gang Li Tested-by: Paul E. McKenney --- include/linux/padata.h | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/include/linux/padata.h b/include/linux/padata.h index 8f418711351bc..0146daf344306 100644 --- a/include/linux/padata.h +++ b/include/linux/padata.h @@ -180,10 +180,6 @@ struct padata_instance { #ifdef CONFIG_PADATA extern void __init padata_init(void); -#else -static inline void __init padata_init(void) {} -#endif - extern struct padata_instance *padata_alloc(const char *name); extern void padata_free(struct padata_instance *pinst); extern struct padata_shell *padata_alloc_shell(struct padata_instance *pinst); @@ -194,4 +190,12 @@ extern void padata_do_serial(struct padata_priv *padata); extern void __init padata_do_multithreaded(struct padata_mt_job *job); extern int padata_set_cpumask(struct padata_instance *pinst, int cpumask_type, cpumask_var_t cpumask); +#else +static inline void __init padata_init(void) {} +static inline void __init padata_do_multithreaded(struct padata_mt_job *job) +{ + job->thread_fn(job->start, job->start + job->size, job->fn_arg); +} +#endif + #endif -- 2.20.1