From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F1CC54788 for ; Thu, 22 Feb 2024 14:05:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59AE76B0085; Thu, 22 Feb 2024 09:05:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 523D46B0087; Thu, 22 Feb 2024 09:05:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C4A36B0088; Thu, 22 Feb 2024 09:05:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 26A586B0085 for ; Thu, 22 Feb 2024 09:05:01 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A38D4A0E79 for ; Thu, 22 Feb 2024 14:05:00 +0000 (UTC) X-FDA: 81819611160.09.71BDE44 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf14.hostedemail.com (Postfix) with ESMTP id D50FD100014 for ; Thu, 22 Feb 2024 14:04:58 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=p1Ko7q4H; spf=pass (imf14.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708610699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MgzBTPzPKbW03C1p+bf5b2VOJPKCTieqosPALSU6d3A=; b=kDH/Q/TFosMLaQDAbB1BPYeIsoLOJ//UmM1uzpldcPxsKBHMgutvfVEX4XZJBTz73K0GKI mMLWQuUWMi6OqWpVA102nMqmjzL0r1DiU8p+vZQ1yBm/F7fhuk8/RL38ZsCq8xYjmGDeqz +GF3Q/lmE+jTVIipUcVBQ3ULRdLf1pk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708610699; a=rsa-sha256; cv=none; b=5b8F7845mZ8UtQ7/qT01UKwryTAJ1H1BfpawNAqLLt+fxs6NGew3OYldGzzMHhmBwvgUYV CJGv9OcHTodKCC+tNBMVPV1ADZzr47zoivSKcbUYSortukBB8+PHUK8Eod2C20AnOQBt1H p8YwFiI7oaHzCRSmuzGsdMK0h1OpLhU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=p1Ko7q4H; spf=pass (imf14.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708610697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MgzBTPzPKbW03C1p+bf5b2VOJPKCTieqosPALSU6d3A=; b=p1Ko7q4HwLZ8IRyvsRmFPEObb08w0kLTfT8Eo/yUShmw9X8SanRExrBoYN4E8QizQ7JtJr y6CDhqCmusgjbGbPQnWZj7zwS/EdtoiwysOQK8U4EQ2jhWPEDI0N15nmbWXhOwCYYBftee 20rXO2q25jdViRTYxjq4nVcOPEYzQBk= From: Gang Li To: Andrew Morton Cc: David Hildenbrand , David Rientjes , Muchun Song , Tim Chen , Steffen Klassert , Daniel Jordan , Jane Chu , "Paul E . McKenney" , Randy Dunlap , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com, Gang Li Subject: [PATCH v6 4/8] padata: dispatch works on different nodes Date: Thu, 22 Feb 2024 22:04:17 +0800 Message-Id: <20240222140422.393911-5-gang.li@linux.dev> In-Reply-To: <20240222140422.393911-1-gang.li@linux.dev> References: <20240222140422.393911-1-gang.li@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: D50FD100014 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ycm99grfizonang1tws7bwhbh1psf8g8 X-HE-Tag: 1708610698-474182 X-HE-Meta: U2FsdGVkX183VezUmBK42nReOA8j5QbF4MQsFFSCAGjYzozBrHoKRhS60Jl2sEIf0WwYsH2bCD3XMwYWZmb34Hh8lwH5V/KnucMsQC5y9FjncV3TULL7XW3njaO4ueBi3G47g0jHWMxhRy1i4OjhRrFr0Ligwxbh/FSzbYhSF4Rt2twpd63L/WEd2ppaf/Uqi9GfpUYv0212DTB7agMoB9gWmysGknadEHyrEZALzWeO52M3PdxdYvoXXp22W77eKlVFIvX/MBhZWdqG01DZ7Jsse+wUQrPy03D2vF0W142JZQmZQLCKTRHlGkqWhZTvNNSeU4E5H5Qp3ZeQ4OwTVy8t9KnbaROevPriC9WeRfnt8AkcsMMfyta53EqQpPvWE5hdBN6d6JAmewSPONXY3FpeRX/doHkDfT80Ef9YUqnEBRw2bHP6zgrzgfZnNWIO/ZENiEIMsRYRWl5QetiWfq4qeL4T8jyUsZ73xqPbyP5SXKFPoZWE2rGz1Pa+jaSSj34FjKiRWh3gr1tGtuCj46dXjfmG8KNKFIkXJbF1+ZA+PROMQkvY3SBGoSVPhwEe6xHV3QSGGSh1QvxZfoalHeC3mJcie7lNeBM4RMBIQQd4VfeTG4onB6f1kVAgqIox8i1bgDmRwReEArefCXXZ0Qoa5qZdOg6tdfp72cqO6CJmIn88is5KULhtwCnuPgafIn2YpRjA2j7Eop/hKzourcXYq0eNxFypWWNNuu+GhALvL2GfZNGQcyffnELkqTQbJY5MFDs0UG3wAx9ozMW3stEvWgFKW/nU/3bSAoJ7M5hfLafp0rxA144cNIyHG+0zo/cO8uV861zqZxxVvklOqTGsCoc92FOlsfizvZkNUYQKKPnlfxDui8DstTOqeZMRxleZpTMwim6SmeE6J8zAx80plYWZGQpgLfFl7n3mAgOwP555jqE3Y4eJHDblCT6fwJfiBSdh8HrJHGrzxnO BiSpyriH oTJrqPqur0MbGWaG1HTjGU3S7+OPkSHQejWEuJP/n8ot7jA1OMzQniM5IbtsFuZELU0WTOa3u238nZVzJx7iuL1xw+nqsQNlIM9Km4uIe/stp3kmQXMrcQOA4giNBn24Xr7NqwIqUcNlgWk+X8jbZ+d5zPSUnl0FRuSM5t8u0EyC0jjC3UdTV5UBfyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When a group of tasks that access different nodes are scheduled on the same node, they may encounter bandwidth bottlenecks and access latency. Thus, numa_aware flag is introduced here, allowing tasks to be distributed across different nodes to fully utilize the advantage of multi-node systems. Signed-off-by: Gang Li Tested-by: David Rientjes Reviewed-by: Muchun Song Reviewed-by: Tim Chen --- include/linux/padata.h | 2 ++ kernel/padata.c | 14 ++++++++++++-- mm/mm_init.c | 1 + 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/include/linux/padata.h b/include/linux/padata.h index 495b16b6b4d72..8f418711351bc 100644 --- a/include/linux/padata.h +++ b/include/linux/padata.h @@ -137,6 +137,7 @@ struct padata_shell { * appropriate for one worker thread to do at once. * @max_threads: Max threads to use for the job, actual number may be less * depending on task size and minimum chunk size. + * @numa_aware: Distribute jobs to different nodes with CPU in a round robin fashion. */ struct padata_mt_job { void (*thread_fn)(unsigned long start, unsigned long end, void *arg); @@ -146,6 +147,7 @@ struct padata_mt_job { unsigned long align; unsigned long min_chunk; int max_threads; + bool numa_aware; }; /** diff --git a/kernel/padata.c b/kernel/padata.c index 179fb1518070c..e3f639ff16707 100644 --- a/kernel/padata.c +++ b/kernel/padata.c @@ -485,7 +485,8 @@ void __init padata_do_multithreaded(struct padata_mt_job *job) struct padata_work my_work, *pw; struct padata_mt_job_state ps; LIST_HEAD(works); - int nworks; + int nworks, nid; + static atomic_t last_used_nid __initdata; if (job->size == 0) return; @@ -517,7 +518,16 @@ void __init padata_do_multithreaded(struct padata_mt_job *job) ps.chunk_size = roundup(ps.chunk_size, job->align); list_for_each_entry(pw, &works, pw_list) - queue_work(system_unbound_wq, &pw->pw_work); + if (job->numa_aware) { + int old_node = atomic_read(&last_used_nid); + + do { + nid = next_node_in(old_node, node_states[N_CPU]); + } while (!atomic_try_cmpxchg(&last_used_nid, &old_node, nid)); + queue_work_node(nid, system_unbound_wq, &pw->pw_work); + } else { + queue_work(system_unbound_wq, &pw->pw_work); + } /* Use the current thread, which saves starting a workqueue worker. */ padata_work_init(&my_work, padata_mt_helper, &ps, PADATA_WORK_ONSTACK); diff --git a/mm/mm_init.c b/mm/mm_init.c index 2c19f5515e36c..549e76af8f82a 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -2231,6 +2231,7 @@ static int __init deferred_init_memmap(void *data) .align = PAGES_PER_SECTION, .min_chunk = PAGES_PER_SECTION, .max_threads = max_threads, + .numa_aware = false, }; padata_do_multithreaded(&job); -- 2.20.1