From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6E69C48BF8 for ; Thu, 22 Feb 2024 16:30:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36FCF6B0085; Thu, 22 Feb 2024 11:30:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 320126B0087; Thu, 22 Feb 2024 11:30:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C03B6B0088; Thu, 22 Feb 2024 11:30:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0A1816B0085 for ; Thu, 22 Feb 2024 11:30:35 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D2EC5160E6A for ; Thu, 22 Feb 2024 16:30:34 +0000 (UTC) X-FDA: 81819977988.21.C715B35 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf29.hostedemail.com (Postfix) with ESMTP id 0656F120016 for ; Thu, 22 Feb 2024 16:30:32 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=D7xN54FW; spf=pass (imf29.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.182 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708619433; a=rsa-sha256; cv=none; b=xCMUl5d2au44zeLSXVNizsB/aPhvOiLNrGlohPeKuDHM7STEJKkxLsi+VtcrI10lrDCvXj n0VgYUTkk3AmlMady42wFNY7pFVCelS3xxqS1TYMS0VBf7ZofUZcCbUf4DYgIs98Glg37z +jMorW8DPp2zUorsx/jng+05wUy+TRc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=D7xN54FW; spf=pass (imf29.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.182 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708619433; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L4tXYxptIN6sn70Hbug773/ZkZ9SuuIE2T60bhUM/kc=; b=EqC4U5tzqRomH2d+aolpJmQa+pWfViBW/kIk0/oDByjOOdJ6QAL3gkWVCKXFJwD+tzv+JV Yg7LnfjMPwPNXXbKyGgdfKZn892c2t0q8Gjl8MJ01lFzeStCe6hTyUHRBGBwo+Ry7Zq/Pe BH0RkHC26RwIwzmgvre6WZLrOBAREb8= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6e3ffafa708so5338644b3a.1 for ; Thu, 22 Feb 2024 08:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708619431; x=1709224231; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=L4tXYxptIN6sn70Hbug773/ZkZ9SuuIE2T60bhUM/kc=; b=D7xN54FWAcQEfmcOdIDdeZQlBR2myBsZJOk7nTvzVkk76Ia/QRubYKO3srRT7D/5LL +WMlONTUvXskCKCtKrXrmhSDd/+uzT7BtlyVNXMF/+5gczoO06P/+7FJ0AZuXQJ5ofQw 2ZZB5eSGNi//t/O3A1SCD/uP7tuxp3nVgstsc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708619431; x=1709224231; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L4tXYxptIN6sn70Hbug773/ZkZ9SuuIE2T60bhUM/kc=; b=T12W/gGTy7I6rWgkS5JMrNLzZAGYQCf5CPJ/PJmRxmpyyfbYNwKllhcjrWBiwxxFIM ajRiTzcUQin7gga7OTjXAOZDHRThnTOZ0GfbCV+jltc7t32vYKJhhnry/hj6uLcIJJ70 VUxOhFNcybAhMz6HV/HromFpWg3hHROOVlylz3armjRLta+srMulQKsvSmreHN6fJ0LB /1fdDE4t4kLn3WPSaPq93ijgaoCcx7ijJVuzotwpOJdQ0wNwWzWcVO9OCavVp25ERmkb vvBXsFrycyQoUBx6Rk3I353pRvHbwxXx7g7IQwLInHeUkXuKBB+zXkN1YoIVds7dDWEH UEIA== X-Forwarded-Encrypted: i=1; AJvYcCVgpl9ZsLlmogcMFIjEfBi+tq/y/yZsdMAZOTiWriN/I1h3RVfxp/16ZkdiagouJw3n/fjDeWBj4EAIc31IRgFoLqQ= X-Gm-Message-State: AOJu0Yxnh20VuxFogDPa4QSXqPY9VWihhbQT2FN107grnfTqkDkUxfbG kF/fu+pKDMBQshYgtBxlBFbsJRF7TbNlciRcyvvDyzKO5We7nxBnC84vpcWAqA== X-Google-Smtp-Source: AGHT+IF+SlttyWkoW2fWR8cBn7Swso3loSheNnjJ5MidjvOtmykg6loZB+iLagMLSSGm57scJMtnAg== X-Received: by 2002:aa7:9833:0:b0:6e4:6dcd:8d88 with SMTP id q19-20020aa79833000000b006e46dcd8d88mr10571629pfl.24.1708619431651; Thu, 22 Feb 2024 08:30:31 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id y5-20020a056a00180500b006e45daf9e89sm8874736pfa.131.2024.02.22.08.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 08:30:31 -0800 (PST) Date: Thu, 22 Feb 2024 08:30:30 -0800 From: Kees Cook To: Arnd Bergmann Cc: kernel test robot , linux-hardening@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Andy Shevchenko , Cezary Rojewski , Puyou Lu , Mark Brown , Josh Poimboeuf , Peter Zijlstra , Brendan Higgins , David Gow , Andrew Morton , Linux Memory Management List , Nathan Chancellor , Alexander Potapenko , Zhaoyang Huang , Randy Dunlap , Geert Uytterhoeven , Miguel Ojeda , Nick Desaulniers , "Liam R. Howlett" , Vlastimil Babka , Dan Williams , Rasmus Villemoes , Yury Norov , "Jason A . Donenfeld" , Sander Vanheule , Eric Biggers , Masami Hiramatsu , Andrey Konovalov , Linus Walleij Subject: Re: [PATCH 6/9] fortify: Split reporting and avoid passing string pointer Message-ID: <202402220829.10C6C7C@keescook> References: <20230406000212.3442647-6-keescook@chromium.org> <202304061930.4Au0PASm-lkp@intel.com> <19930c5a-f1ed-4b04-b69a-d7259966f020@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19930c5a-f1ed-4b04-b69a-d7259966f020@app.fastmail.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0656F120016 X-Stat-Signature: k7fqftrijq4juo4hmu9og63kyip4bj6a X-Rspam-User: X-HE-Tag: 1708619432-195645 X-HE-Meta: U2FsdGVkX1/wBV0f9wakqVcRnir0Zr+77MFit017OFq8JLLwWavtiP7jdTGHAbyoNoROMt3EIiVycYBnojURW4V17yU3YqnkxzCeIogV8lnRtocwx2w6hKKHY8/TCyFJTQa0SJLEXNwrz+nl/jHJEOBRhXlyEhc23n12lfKOoRhnVwYEK9wiJwk1H+xPNOMdto3OXKAvgfzkuWwiOBN8kpGrw0uXbI0Gb6Pb15OYYjb3JVghDKgzzv8BYWIRf121Hvjgv99PRvy9g1gXHP2TOhO9WX6P/yaAyjpe01xAtsWmVns3kS3A5FOxmwiqLr4A0sspP+d1FYaAXThaE+lj9h96Prs7WkU5hU0SAoq5dTYNtQJU1bMNPtAkbuGJhSxjYVp45M4ScsFztskU8cIBuH8z7BuF/lXCi2soZkB1Xjc7k7XVKY9t/VVwvuojzqi6c6xvwncuRylNRH/JkuPbcxuHN54Phr9N/inyOfvGGA5q5XcCOHjb7b1UBi5hxPb3Wije4W4iWdolIQPWQuACQz0Ki/rqkquJxPZeClBOoHDDYxhGLBlWST/c5Useb0pizZE/Yb+CeGn6+eIReLzclupLbP1YtYJqlGT2pRHZnWNW+CNhPQQI1i3BaEI5LdAOL3jZihh90OI01MSZ+nK6FALJnVxO/ZpHoMeQKXouLotgKcDQalhdN5hQyFvML90rsXeYv6yHgcIO+kDXCEeKyoVMsrF0Imc61NK0zxpNWz7yYWsHeB8NcLs7dLukrcwKwFyKLydOWXF9zvgDKB4aWzF06r5MneFpYkBrKfQ1hgByQmnyFc/NwW1gKi1tcyW5c95RcIG1WO20IJ/pqtanaLfPTVSYmeeDZAaPLNuIuOHnDMXFQqRHeyP6fIolHr1ekuKwQWyvNpfUznTSOtAj3BTc2r9pQx/D/O2xouLvVopMVsEcmhZBtzpSRp+YJjbxpxPKx5Le0dk7i/RTB9D JMc+wx7o aHZnZuS7ANghyPHw5GS0LGumJEdGt6BrNBS7QjqFqnn/eu2mcS6HS7TQnMUhpd/EjOtQ0zMwj+tbOFDSZZQop35En9wFAF/s1/HX/jQa/TNMzS5ukFaWK45iKaa1b/ZzXHsfauvLg9xRr4BPVYqDxnWtZcbC4SmYUZDNN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 22, 2024 at 02:00:26PM +0100, Arnd Bergmann wrote: > On Thu, Apr 6, 2023, at 13:19, kernel test robot wrote: > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot > > | Link: > > https://lore.kernel.org/oe-kbuild-all/202304061930.4Au0PASm-lkp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > >>> ld.lld: error: undefined symbol: __fortify_panic > > >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208) > > >>> arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_count) > > >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208) > > >>> arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_search) > > >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208) > > >>> arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_get) > > I get a related build failure from the same commit: > > arch/arm/boot/compressed/misc.c:157:6: error: no previous prototype for '__fortify_panic' [-Werror=missing-prototypes] > 157 | void __fortify_panic(const u8 reason, size_t avail, size_t size) Whoops, thank you! This series got a refresh after you did the missing-prototypes work and I missed this one. I've fixed it and double-checked for any others. Hopefully this will be clean in the next -next. :) -Kees -- Kees Cook