From: Byungchul Park <byungchul@sk.com>
To: linux-kernel@vger.kernel.org
Cc: kernel_team@skhynix.com, torvalds@linux-foundation.org,
damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
mingo@redhat.com, peterz@infradead.org, will@kernel.org,
tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org,
sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com,
johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu,
willy@infradead.org, david@fromorbit.com, amir73il@gmail.com,
gregkh@linuxfoundation.org, kernel-team@lge.com,
linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org,
minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com,
sj@kernel.org, jglisse@redhat.com, dennis@kernel.org,
cl@linux.com, penberg@kernel.org, rientjes@google.com,
vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org,
josef@toxicpanda.com, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, jack@suse.cz, jlayton@kernel.org,
dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org,
dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com,
melissa.srw@gmail.com, hamohammed.sa@gmail.com,
42.hyeyoo@gmail.com, chris.p.wilson@intel.com,
gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com,
boqun.feng@gmail.com, longman@redhat.com, hdanton@sina.com,
her0gyugyu@gmail.com
Subject: [PATCH v12 27/27] dept: Add 'Dept' documentation
Date: Wed, 21 Feb 2024 18:49:33 +0900 [thread overview]
Message-ID: <20240221094933.36348-28-byungchul@sk.com> (raw)
In-Reply-To: <20240221094933.36348-1-byungchul@sk.com>
This document describes the concept of Dept.
Signed-off-by: Byungchul Park <byungchul@sk.com>
---
Documentation/dependency/dept.txt | 283 ++++++++++++++++++++++++++++++
1 file changed, 283 insertions(+)
create mode 100644 Documentation/dependency/dept.txt
diff --git a/Documentation/dependency/dept.txt b/Documentation/dependency/dept.txt
new file mode 100644
index 000000000000..7efe3bc59b2d
--- /dev/null
+++ b/Documentation/dependency/dept.txt
@@ -0,0 +1,283 @@
+DEPT(DEPendency Tracker)
+========================
+
+Started by Byungchul Park <max.byungchul.park@sk.com>
+
+How lockdep works
+-----------------
+
+Lockdep tries to detect a deadlock by checking lock acquisition order.
+For example, consider a graph built by lockdep like:
+
+ A -> B -
+ \
+ -> E
+ /
+ C -> D -
+
+ where 'A -> B' means that acquisition A is prior to acquisition B
+ with A still held.
+
+Lockdep keeps adding each new acquisition order into the graph in
+runtime. For example, 'E -> C' will be added when it's recognized that
+the two locks have been acquired in that order like:
+
+ A -> B -
+ \
+ -> E -
+ / \
+ -> C -> D - \
+ / /
+ \ /
+ ------------------
+
+ where 'A -> B' means that acquisition A is prior to acquisition B
+ with A still held.
+
+This graph contains a subgraph that demonstrates a loop like:
+
+ -> E -
+ / \
+ -> C -> D - \
+ / /
+ \ /
+ ------------------
+
+ where 'A -> B' means that acquisition A is prior to acquisition B
+ with A still held.
+
+Lockdep reports it as a deadlock on detection of a loop.
+
+CONCLUSION
+
+Lockdep detects a deadlock by checking if a loop has been created after
+expanding the graph.
+
+
+Limitation of lockdep
+---------------------
+
+Lockdep works on typical lock e.g. spinlock and mutex, that are supposed
+to be released within the acquisition context. However, a deadlock by
+folio lock or other synchronization mechanisms cannot be detected by
+lockdep that basically tracks lock acquisition order.
+
+Can we detect the following deadlock?
+
+ CONTEXT X CONTEXT Y CONTEXT Z
+
+ mutex_lock A
+ folio_lock B
+ folio_lock B
+ mutex_lock A /* DEADLOCK */
+ folio_unlock B
+ folio_unlock B
+ mutex_unlock A
+ mutex_unlock A
+
+No, we can't. What about the following?
+
+ CONTEXT X CONTEXT Y
+
+ mutex_lock A
+ mutex_lock A
+ wait_for_complete B /* DEADLOCK */
+ complete B
+ mutex_unlock A
+ mutex_unlock A
+
+No, we can't.
+
+CONCLUSION
+
+Given the limitation, lockdep cannot detect a deadlock by folio lock or
+other synchronization mechanisms.
+
+
+What leads a deadlock
+---------------------
+
+A deadlock occurs when one or multi contexts are waiting for events that
+will never happen. For example:
+
+ CONTEXT X CONTEXT Y CONTEXT Z
+
+ | | |
+ v | |
+ (1) wait for A v |
+ . (2) wait for C v
+ event C . (3) wait for B
+ event B .
+ event A
+
+Event C cannot be triggered because context X is stuck at (1), event B
+cannot be triggered because context Y is stuck at (2), and event A
+cannot be triggered because context Z is stuck at (3). All the contexts
+are stuck. We call the situation a *deadlock*.
+
+If an event occurrence is a prerequisite to reaching another event, we
+call it *dependency*. In the example above:
+
+ Event A occurrence is a prerequisite to reaching event C.
+ Event C occurrence is a prerequisite to reaching event B.
+ Event B occurrence is a prerequisite to reaching event A.
+
+In terms of dependency:
+
+ Event C depends on event A.
+ Event B depends on event C.
+ Event A depends on event B.
+
+Dependencies in a graph look like:
+
+ -> C -> A -> B -
+ / \
+ \ /
+ ----------------
+
+ where 'A -> B' means that event A depends on event B.
+
+A circular dependency exists. Such a circular dependency leads a
+deadlock since no waiters can have desired events triggered.
+
+CONCLUSION
+
+A circular dependency leads a deadlock.
+
+
+Introduce DEPT
+--------------
+
+DEPT(DEPendency Tracker) tracks wait and event instead of lock
+acquisition order so as to recognize the following situation:
+
+ CONTEXT X CONTEXT Y CONTEXT Z
+
+ | | |
+ v | |
+ wait for A v |
+ . wait for C v
+ event C . wait for B
+ event B .
+ event A
+
+and builds up a dependency graph in runtime, similar to lockdep. The
+graph would look like:
+
+ -> C -> A -> B -
+ / \
+ \ /
+ ----------------
+
+ where 'A -> B' means that event A depends on event B.
+
+DEPT keeps adding each new dependency into the graph in runtime. For
+example, 'B -> D' will be added when it's recognized that event D
+occurrence is a prerequisite to reaching event B, in other words, event
+B depends on event D like:
+
+ |
+ v
+ wait for D
+ .
+ event B
+
+After adding 'B -> D' dependency into the graph, the graph would look
+like:
+
+ -> D
+ /
+ -> C -> A -> B -
+ / \
+ \ /
+ ----------------
+
+ where 'A -> B' means that event A depends on event B.
+
+DEPT is going to report a deadlock on detection of a new loop.
+
+CONCLUSION
+
+DEPT works on wait and event so as to theoretically detect all the
+potential deadlocks.
+
+
+How DEPT works
+--------------
+
+Let's take a look how DEPT works with an example that was mentioned in
+the section 'Limitation of lockdep'.
+
+ CONTEXT X CONTEXT Y CONTEXT Z
+
+ mutex_lock A
+ folio_lock B
+ folio_lock B
+ mutex_lock A /* DEADLOCK */
+ folio_unlock B
+ folio_unlock B
+ mutex_unlock A
+ mutex_unlock A
+
+Add comments to describe DEPT's view using terms of wait and event.
+
+ CONTEXT X CONTEXT Y CONTEXT Z
+
+ mutex_lock A
+ /* start to take into account event A context */
+ folio_lock B
+ /* start to take into account event B context */
+
+ folio_lock B
+ /* wait for B */
+ (1)
+ mutex_lock A /* DEADLOCK */
+ /* wait for A */
+ (2)
+
+ folio_unlock B
+ /* event B */
+ folio_unlock B
+ /* not interest until reaching (1) */
+
+ mutex_unlock A
+ /* event A */
+ mutex_unlock A
+ /* not interest until reaching (2) */
+
+Focusing on wait and event, the example can be simplified like:
+
+ CONTEXT X CONTEXT Y CONTEXT Z
+
+ | |
+ | |
+ v |
+ wait for B v
+ . wait for A
+ . .
+ . event B
+ event A
+
+Event A occurrence is a prerequisite to reaching event B, and event B
+occurrence is a prerequisite to reaching event A.
+
+In terms of dependency:
+
+ Event B depends on event A.
+ Event A depends on event B.
+
+Dependencies in the dependency graph look like:
+
+ -> A -> B -
+ / \
+ \ /
+ -----------
+
+ where 'A -> B' means that event A depends on event B.
+
+A loop has been created. So DEPT can report it as a deadlock.
+
+CONCLUSION
+
+DEPT works well with any synchronization mechanisms by focusing on wait
+and event.
--
2.17.1
prev parent reply other threads:[~2024-02-21 9:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 9:49 [PATCH v12 00/27] DEPT(Dependency Tracker) Byungchul Park
2024-02-21 9:49 ` [PATCH v12 01/27] llist: Move llist_{head,node} definition to types.h Byungchul Park
2024-02-21 9:49 ` [PATCH v12 02/27] dept: Implement Dept(Dependency Tracker) Byungchul Park
2024-02-21 9:49 ` [PATCH v12 03/27] dept: Add single event dependency tracker APIs Byungchul Park
2024-02-21 9:49 ` [PATCH v12 04/27] dept: Add lock " Byungchul Park
2024-02-21 9:49 ` [PATCH v12 05/27] dept: Tie to Lockdep and IRQ tracing Byungchul Park
2024-02-21 9:49 ` [PATCH v12 06/27] dept: Add proc knobs to show stats and dependency graph Byungchul Park
2024-02-21 9:49 ` [PATCH v12 07/27] dept: Apply sdt_might_sleep_{start,end}() to wait_for_completion()/complete() Byungchul Park
2024-02-21 9:49 ` [PATCH v12 08/27] dept: Apply sdt_might_sleep_{start,end}() to swait Byungchul Park
2024-02-21 9:49 ` [PATCH v12 09/27] dept: Apply sdt_might_sleep_{start,end}() to waitqueue wait Byungchul Park
2024-02-21 9:49 ` [PATCH v12 10/27] dept: Apply sdt_might_sleep_{start,end}() to hashed-waitqueue wait Byungchul Park
2024-02-21 9:49 ` [PATCH v12 11/27] dept: Distinguish each syscall context from another Byungchul Park
2024-02-21 9:49 ` [PATCH v12 12/27] dept: Distinguish each work " Byungchul Park
2024-02-21 9:49 ` [PATCH v12 13/27] dept: Add a mechanism to refill the internal memory pools on running out Byungchul Park
2024-02-21 9:49 ` [PATCH v12 14/27] cpu/hotplug: Use a weaker annotation in AP thread Byungchul Park
2024-02-21 9:49 ` [PATCH v12 15/27] dept: Apply sdt_might_sleep_{start,end}() to dma fence wait Byungchul Park
2024-02-21 9:49 ` [PATCH v12 16/27] dept: Track timeout waits separately with a new Kconfig Byungchul Park
2024-02-21 9:49 ` [PATCH v12 17/27] dept: Apply timeout consideration to wait_for_completion()/complete() Byungchul Park
2024-02-21 9:49 ` [PATCH v12 18/27] dept: Apply timeout consideration to swait Byungchul Park
2024-02-21 9:49 ` [PATCH v12 19/27] dept: Apply timeout consideration to waitqueue wait Byungchul Park
2024-02-21 9:49 ` [PATCH v12 20/27] dept: Apply timeout consideration to hashed-waitqueue wait Byungchul Park
2024-02-21 9:49 ` [PATCH v12 21/27] dept: Apply timeout consideration to dma fence wait Byungchul Park
2024-02-21 9:49 ` [PATCH v12 22/27] dept: Record the latest one out of consecutive waits of the same class Byungchul Park
2024-02-21 9:49 ` [PATCH v12 23/27] dept: Make Dept able to work with an external wgen Byungchul Park
2024-02-21 9:49 ` [PATCH v12 24/27] dept: Track PG_locked with dept Byungchul Park
2024-02-21 9:49 ` [PATCH v12 25/27] dept: Print event context requestor's stacktrace on report Byungchul Park
2024-02-21 9:49 ` [PATCH v12 26/27] fs/jbd2: Use a weaker annotation in journal handling Byungchul Park
2024-02-21 9:49 ` Byungchul Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221094933.36348-28-byungchul@sk.com \
--to=byungchul@sk.com \
--cc=42.hyeyoo@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=chris.p.wilson@intel.com \
--cc=cl@linux.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=david@fromorbit.com \
--cc=dennis@kernel.org \
--cc=djwong@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=duyuyang@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gwan-gyeong.mun@intel.com \
--cc=hamohammed.sa@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=hdanton@sina.com \
--cc=her0gyugyu@gmail.com \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=jlayton@kernel.org \
--cc=joel@joelfernandes.org \
--cc=johannes.berg@intel.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@lge.com \
--cc=kernel_team@skhynix.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=max.byungchul.park@gmail.com \
--cc=melissa.srw@gmail.com \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=ngupta@vflare.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=sj@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox