From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79902C48BC3 for ; Wed, 21 Feb 2024 02:17:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EB796B007B; Tue, 20 Feb 2024 21:17:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09BAB6B007E; Tue, 20 Feb 2024 21:17:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA5746B0080; Tue, 20 Feb 2024 21:17:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DB8566B007B for ; Tue, 20 Feb 2024 21:17:58 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B66EAA0BBC for ; Wed, 21 Feb 2024 02:17:58 +0000 (UTC) X-FDA: 81814200636.14.E50AF2D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 435EC4000C for ; Wed, 21 Feb 2024 02:17:57 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BXAokH4m; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708481877; a=rsa-sha256; cv=none; b=FokHbA3s/aQc1A8otTIdtfSq3xIao2LkDLZFrlhmRLHlS007etsnQNI82pBekxHc30ICnm mny9hJEIszw27GZ0tuPwUDQU8LbGx2H7hwsAfugSqsHmfbWKEyF/lbe/9+43lFGKvINLP7 McTV+BQDXGO6HBDaA4RcwIiCSfLiVkQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BXAokH4m; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708481877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UWSCnPoCJ8P/YMyrtsOrz4KWB5rtxHSb2m2RxEMbT64=; b=WfmFLTl5E63ZL+BKOX+Vl/uT/MiIGMUQSRkpmbqoyThmRdUJYwHRGEvZT2OEkXx+/LkfTc pVsBCVGPuy1JW2H2Ik+PDhnzCV6puU6HK+tFqi4xC0nCm8XXLDbWPmpF7wWPGjtyzSSJq4 KqCuxHe4mJ+f3ao6K5FjPn5vaeKXauk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7445B612A3; Wed, 21 Feb 2024 02:17:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13B24C433C7; Wed, 21 Feb 2024 02:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708481876; bh=LvEHLFcLjOxIFDUr54wNiVZ8DXFw1S3BWSPUXevmi34=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BXAokH4muhwf047+cmFjjyeUiJBOR7xaoTsAm36BDOPubbBWo+TVySUn6YqzfZABF qc2jcN98ZWkyETT+COJRaN0/kaf7v8eQgjRgpgeLLQ9HpdNCz/IdBBtNhGbGyWT1zF JdyBB+ySMjnI3JLuzIbsMQzILZAz5MRaLWbNbZF5F0BtGybEvS2E/+6SGaIuD88RIc zlNtSTDp8pRRfRLNwpALkbtp2XcszNOi7cRva+l0zEVtCOQtorpLoRDtRXeJp9wjt4 AwazJ80HfUckevZA+De61Je6t7UGzHdKyCfTsuV2ayHcSZ5FSb/6ibviFF0+3URv3r xwY/ez4vtxwCw== Date: Tue, 20 Feb 2024 18:17:55 -0800 From: "Darrick J. Wong" To: Dave Chinner Cc: Christoph Hellwig , Chandan Babu R , Hugh Dickins , Andrew Morton , Hui Su , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 22/22] xfs: remove xfile_{get,put}_page Message-ID: <20240221021755.GE616564@frogsfrogsfrogs> References: <20240219062730.3031391-1-hch@lst.de> <20240219062730.3031391-23-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 435EC4000C X-Stat-Signature: t1877ejnb5cff1robjk5n8qc36s9tgsx X-HE-Tag: 1708481877-286651 X-HE-Meta: U2FsdGVkX19yW30ix9v4k2yN3Q1JBvnffCH1zjieIVQZRrPufeRlIsSNI2uRNAR4cWutjMvN9YjiVefe8hlrdNTR3S73UxxU1sNzDN5KaNonpYJAt/iWtWD3F9gx+N5zG5fwRWzAcIZgctRRNxOE487kJRzaVO6XrgBZnAWjOdu8EC3mQPrMTKEyel4BjenD+QEP45MIfY0sFqxjYeRpv5bEEYhefA4LhIWKPFzvPmhemxbFNOVwsdN1+yEfgXX9VXFLPYWGOtvPjBHmw3CAUOyqHNo6R66AUYk0XD/tN09mYDRdFo4bq2GoNO6G9CpIB3Ebay2OXPw5eXp02yRLO+Sfs/Bydb/67W7UEB32oXIJ2S1gLiM4k66WysGcfozPMKJZywzkfZPFeKJm63f+XdEltKHqloeWPMOs4wuFdKdRVST5VcDWUBI35/uKpRscFnsFEfFAoxvw1Ol5G35JNxnspCvrfAbCpdpUbFv2Eu/mXGh9V2bejlrx3TcALZ+Iz632mOteK95JJcaxenlFIkYDcIjbzeAgX+l5Hz8CaV+j+MjzonwpKg0x/bkEnGpFK+19xXRW9toQXTss9czfvJU2YLNeMeprQyuRxYiCJIZ2599xxZR8SCGx5/lFHGK49ffJDb5+5rRiSidaDRIgKMlJkmR3W2PSgJ6YlAwcmdGt9tJiv0MO4BEHyHzIi51jKcKV3hyGDYMY3uEvoNGud+oUSlZ0T3kbLHtT/quc7SWvFqZtY7OaA4uWQnAZ2XusgWwpEDie9EJg3ymgdXa+gYuAo7xpdHfSznUkqpt9jKxyTJ3Sqv23WjIP7ZHzpPzBMjyzoIicDyAMhQyF77pMq791f/T1ytWmyvmuBArvosnlMBxuLUdQ3KQQmyyXchsn2K7MdUV+lMgjfw9Otku+7zNPx2BAC0tqOIz4+S2pEX7dKkb28IImpw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 21, 2024 at 10:57:46AM +1100, Dave Chinner wrote: > On Mon, Feb 19, 2024 at 07:27:30AM +0100, Christoph Hellwig wrote: > > From: "Darrick J. Wong" > > > > These functions aren't used anymore, so get rid of them. > > > > Signed-off-by: Darrick J. Wong > > Signed-off-by: Christoph Hellwig > > --- > > .../xfs/xfs-online-fsck-design.rst | 2 +- > > fs/xfs/scrub/trace.h | 2 - > > fs/xfs/scrub/xfile.c | 104 ------------------ > > fs/xfs/scrub/xfile.h | 20 ---- > > 4 files changed, 1 insertion(+), 127 deletions(-) > > Looks fine. > > Reviewed-by: Dave Chinner Thank you! --D > -- > Dave Chinner > david@fromorbit.com >