From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B46EEC48BC3 for ; Wed, 21 Feb 2024 02:17:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 223E16B0074; Tue, 20 Feb 2024 21:17:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D3B26B0078; Tue, 20 Feb 2024 21:17:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09B7D6B007B; Tue, 20 Feb 2024 21:17:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EDE266B0074 for ; Tue, 20 Feb 2024 21:17:32 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7E617807A0 for ; Wed, 21 Feb 2024 02:17:32 +0000 (UTC) X-FDA: 81814199544.13.BC7593E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id DC176A0009 for ; Wed, 21 Feb 2024 02:17:30 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SsGlZpw2; spf=pass (imf15.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708481850; a=rsa-sha256; cv=none; b=TxTnsJKocP7r5X9qrKeeKBstFqhdLsfeo1NbGGq7AeDWPfjXom+G9m3SosUK0MfbG/a7yW P6/tmBxtk5A85/tGJO3+/AumjrxQ2hF5j1J4Skr9yUhfFkhPuCiJJi3OZjfKRbXFvQ7OvJ gHV2ILKk0F6tqUthk8secidI/XsAEME= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SsGlZpw2; spf=pass (imf15.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708481850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ObORLxm1hLWRqKUw4w8FGtmfwPFrl7c+01ohEQCDTh4=; b=FLZ7q3F+WW3JSECzoQ3oJph1ex4rsDuHA/zHLekOejhbddLQHAiCHHrS+n/cG0+wcy+kqx vfiwNHnC1BxzK7GsvqNeyRzB9HhLDQQGsHWqIVQYQT0BBmF6RTaKyuE9ZXoeBd6tCL9fz1 aU4GYVYHZS+lvnms29Mek7Bgz+yMyjQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DF5D6612A3; Wed, 21 Feb 2024 02:17:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99882C433F1; Wed, 21 Feb 2024 02:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708481849; bh=fG10la6HkZl3Cf0hmrnwUOBE/u8UN3enCJqXUOALu/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SsGlZpw2/xIomRZeYnMl/G53jn5sLX4MMA/Tbw+XsVLHDVNlHLxem/R/WPAE7qkJg RCfYKJe9IiokhSpnI6eCdqr5/ZboJKrbbCruwzcaV6PxuN5kmagsaYjtB9OEd1NjSM 21j6kVeQFX/gAODZaPwichfF3n2kQ3T6kzLg7V2fngH1JixBIwEkr6BNTQleZUBzlO lo2kxTpj5ZxyTGqw3R5TYMGkzI5lQOo8CMK0RhIUp65UKXh8VLzSVRj5fqfy7wfT8X j/nxHbYIWQ0YyDxFtHm1X69QdM2SzdV4Hbdt7lIge+8DSc9JNmxEyhrB054ioKbaq2 Ocnu0xrCn2U3w== Date: Tue, 20 Feb 2024 18:17:29 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Chandan Babu R , Hugh Dickins , Andrew Morton , Hui Su , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 10/22] xfs: use shmem_kernel_file_setup in xfile_create Message-ID: <20240221021729.GD616564@frogsfrogsfrogs> References: <20240219062730.3031391-1-hch@lst.de> <20240219062730.3031391-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219062730.3031391-11-hch@lst.de> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DC176A0009 X-Stat-Signature: c5a1567hqtw59mp9s7keamp6fpizgg3f X-Rspam-User: X-HE-Tag: 1708481850-865998 X-HE-Meta: U2FsdGVkX19Gvu7e7FpUePp/slzAtkrqSXA/TQXjwZiYecIatYIBS70tEcVd6dDMT2K5s2HXWgjbyP6b2emV/kjHfAN6LrGyP0bGwkKqhgcMWFVSuJH4UJmQtvrEFWQrifxdkIpt0kgwVrsAT3fqFwTuaqMc+g9SINL3DQVzTYrSV52VOzNpPDcUgUd1hbCQZYHA0YEQO3zw/7wN0/CJPMm4l5Uu7xq+SEHC65mhF5qX73Fk03+LOqp6CJnwazLZ+C8/2dluHYvLdHeYVBH90X/3rRws5vGbuQ0+MjWpt/zqPvVwiYqG9YPjKsgypPOCKI6uARtRsBKKSnNWmgohp6ebXzGJuJZMZG5214MWeafx/AlayfwrRyBKgG27DhA1usTVZE3BhUy56WRbhAWT86XvgELnLOLfQ013nJpGVEWBFtKyeLw9/IgpZ1Q4pMiZTgtPjTQA5IIPAPxHpMh8EHDhyhQ8yHZEUsregkn4fdFHq2RMonuQd0noFGKtAbjV8YV4N3ZOtLb5U9iNez0GZIz0jSf3pBlxWPsXc2lZAW7OfIDLfXQ8oHajrSU5gRAdQ4e/U8JBbDTXC/GVOE3FHWoZsJES7rVLrekowAZ+cOD/9E+3tlhdTIlpbMf0wui0heD03xIOMscN5BhDvlSdLvGKNhNcYAyO+BaUbjIGrjU6sm0Lo/OItrXMJvBH3/iPVTJawlDjHQozxOcuG55ugaoLos6OQg3PYShbw0qFGkXnaMHOobsxXMHpL7h49wCGGFxTNS1V7MUVQ6zcYPV8I3mMNJA7SBJ8r1FdorfA4c/v0aQ7zcK10hfkQzvsoz0mjJzHB+CAVs2BnDyQ2VWmgxhcmtXBKmyzBu6Bq82X88U9Xd/Q52qcKiZL9r6EW48M1kqKbFrZHD28l1UXc7VrkeVEYJY+6S0OVPBk2Wm4PBqDQz05hyzOkiseMbpgQfRxa9Ycx2rb0yk26yAbt8M CGUpfNE2 adsAgNKvHftuhQFEyo3NeUomflI2vsnybwG15ghp6lm3BTT2TqrSZRMLNFR9Q32j0ZwDQU2qe0+cV45AgU0a6adTmN7YSfe3FgEUKSxM5LL7h69jGqeuKAfF7gtWMJdSYLHWbQ9fsmsWEZwntUSGMbPaFRklspgJCSxs+9JK0Ynrmu1eKUSbVldu0cRjXD1EAeW4fgo0DSB9Gb6GyL+JwHLogBFaX78OhuXdNFANkluSEWT4cUz2dgKvDj5H18dt1Jc8BIY4gkcjDzVX2ZjTrS/bGQNuolW/ww7g0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 07:27:18AM +0100, Christoph Hellwig wrote: > shmem_kernel_file_setup is equivalent to shmem_file_setup except that it > already sets the S_PRIVATE flag. Use it instead of open coding the > logic. > > Signed-off-by: Christoph Hellwig Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/scrub/xfile.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/xfs/scrub/xfile.c b/fs/xfs/scrub/xfile.c > index e649558351bc5a..99a2b48f5662e6 100644 > --- a/fs/xfs/scrub/xfile.c > +++ b/fs/xfs/scrub/xfile.c > @@ -68,7 +68,7 @@ xfile_create( > if (!xf) > return -ENOMEM; > > - xf->file = shmem_file_setup(description, isize, VM_NORESERVE); > + xf->file = shmem_kernel_file_setup(description, isize, VM_NORESERVE); > if (IS_ERR(xf->file)) { > error = PTR_ERR(xf->file); > goto out_xfile; > @@ -85,7 +85,7 @@ xfile_create( > FMODE_LSEEK; > xf->file->f_flags |= O_RDWR | O_LARGEFILE | O_NOATIME; > inode = file_inode(xf->file); > - inode->i_flags |= S_PRIVATE | S_NOCMTIME | S_NOATIME; > + inode->i_flags |= S_NOCMTIME | S_NOATIME; > inode->i_mode &= ~0177; > inode->i_uid = GLOBAL_ROOT_UID; > inode->i_gid = GLOBAL_ROOT_GID; > -- > 2.39.2 > >