From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DF93C48BC3 for ; Tue, 20 Feb 2024 13:32:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBDE46B0072; Tue, 20 Feb 2024 08:32:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6D6A6B0074; Tue, 20 Feb 2024 08:32:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0D986B0075; Tue, 20 Feb 2024 08:32:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8E4016B0072 for ; Tue, 20 Feb 2024 08:32:10 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5645816068D for ; Tue, 20 Feb 2024 13:32:10 +0000 (UTC) X-FDA: 81812270820.10.5B784A2 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id 4B36140018 for ; Tue, 20 Feb 2024 13:32:07 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YJsUQi5K; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of horms@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=horms@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708435928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LLXAi/pAeGYAdfXaywrssLA5lObEkEYjw2/9QTJ05bU=; b=hXIWKuxV/Ouo0LRm7sEkjhPKUAzqkT0oEjPE2YKsXAwZ8J9mpfmz3PhqOOGQRn4PeXwLv0 ZVdZNNZPqCQusgSD8INnmN0RXOP5WHxdDo8HoaZBZP8MbvJcorqMeebvIQhAyzia0JCJJd rop/Bu99IHOzKKaAkYkDbKbH4s93Ak8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YJsUQi5K; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of horms@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=horms@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708435928; a=rsa-sha256; cv=none; b=zGcfPP716kRfeM6Uv5rXPq7xvo6VNYtHdx5ntLqPDKWZbGsEyKV3/N6twAcYHlkeWwYHuh w9WdCk3+LOvsDtqbvi0CmcZlDlOCqAd+dX5lKk/QYiuDy99IdNonzHvpmMFEJzrhdLhzJ8 hRjJX7+l5IS+t5JGqHIrVFzf/f5rFJY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 59194CE194E; Tue, 20 Feb 2024 13:32:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 556E2C433C7; Tue, 20 Feb 2024 13:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708435923; bh=kSbCNkvZKv7xzsaEeoxDKEEwm8/5FhdatiejKc2BuLY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YJsUQi5KCSO8MtsgHZ+Vn/m7BcHINEuYM5ToUiaFq7kh2KQMRPea4IFD5yzNstNiD 1rIrxcgdE21DiDSY+Q2JJxcDATS0zp9n2BOMTPLWHFRlbsXLbHaaqN5dvJRaiDArc7 v/X9MUp8DeIQZnjEpz/WW9n9i2tUrPb1ZFwv+vbErFChi21tJp2tWkJtX7HBup9UZQ IRBcqjs1VlPXekQrY3dUUtseVwFyj5b9J8dvDyM/KdT59kDx5Z9w6ypWLA4FsSESQH 3j7QwtZUDUGkVZR1WWGjNCetelLouTz+eg5OLO2Ij0xwNRIa3n6pZCBufJmoXudWHV 3xQ463OyS0adQ== Date: Tue, 20 Feb 2024 13:31:58 +0000 From: Simon Horman To: David Howells Cc: Steve French , Jeff Layton , Matthew Wilcox , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Christian Brauner , netfs@lists.linux.dev, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Steve French , Shyam Prasad N , Rohith Surabattula Subject: Re: [PATCH v5 09/12] cifs: Cut over to using netfslib Message-ID: <20240220133158.GL40273@kernel.org> References: <20240209105947.GF1516992@kernel.org> <20240205225726.3104808-1-dhowells@redhat.com> <20240205225726.3104808-10-dhowells@redhat.com> <140602.1708355444@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <140602.1708355444@warthog.procyon.org.uk> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4B36140018 X-Stat-Signature: fa9k1ef3e9g67fbej15tqys7qzdcrh5o X-Rspam-User: X-HE-Tag: 1708435927-585562 X-HE-Meta: U2FsdGVkX19pub7vHawfytevxmoYM/Z22L89LE1VfJo3LQq1uBAKkdoAkVUUXSNcMlw6+JOh9TRHI7o0OLxx799ldSWUEzfmLTyR4K7bGXrCyov2saYNcgjih6d/Yalg1vaAD1HyeVevNFdHwoq0eHN7w7Z+v0E3RlajxMjU4N6mcd3x/Tdd9bHBNtAXMwR0r/BVpkHRfdqfkyLoNomXQL8F75iQnjc3QFk0/ce+xj5S1IOyq5DtGPSdR0Zcn9yYgLopouACEM+t5kIzSFYlTznqoYg3lw28NTFc0N4r4EW049fh3/S0hhMC2KhwSvNdXlBzN/5TAGUxBY4CiB0pOQFDGqlKnxwzRkdN4WvtIsjemAWhhhcPi22w4rf3TgdCfuse8INZNi8LWk/9Kkzzannz5hrXePeQRDWXg76mUzykhmz9R9OVQek+4xxN8wEsry7Ajo9rDsYBfr8+VBHoZpN1fcrsMRBEv5xmggNt1XKAotuxgUTTmdkoGeQwZJno664XVGceAKnyKvRI23/O/QPqHAQMp8Bg/jvpjPBDkBszrRcS5RaoPXUjsGK3hIvfecqaaTDX0omByPAkJT29Pk92Wxyqt50MZQtYXnJvPHq8oQYlXfWvT8ukVOzRhEKDUSf227eIdzg5oD6WUsF9fHnrJoe+i6GTNRGGpXLfWb/qISSft8R3zR7qENpAA/znLgVvy5B+O2uzlc52voe8yIzXYkh/kXR2yPhx6F702JnXnCAWzqMp8EueGQElAATYxn5DjWyjsL7xs/iGXWjzwPpDkgf6BrjFo3X/3iP/faTSDboWIsr6sBA3EejHMq78FubpTBSTlP76nMeuBAMbcJGbNvyNQSyEyZvU26KRmtWRgwfySrMaYRUjexpQQPL8I1BC3cP9iMt6Y//M86K5KdBTfe1Bre7yDxGaNOYV9ODrkTISxWZkvnDJCyFZDrQywPaRvDdVqwtYoIHAVL2 r+ijeNsi 5SUClxiyyQ1bS8c2XpCYk5fOkJArgC3tVWuFLKVCTZVX0eJQcif0ro+POK4Sy2/4MirG3VreMehSkglpyezIEdi1Euv75R1h3jl43ctpWtzGA6HRaFeIIu43qkT7P3p7LFE0kJEkK2vU/Jf6m4Vk34gLvZWvQZ8M98Re1tf3vCrbhqZJOjWobZhusn/GOK06uta5qsnd4krQ6rV8f7U6eH/Pw8tt0+piJo719DZL9uSsHJCiuIzNUIVc77cN/4yW4IOQt5OvHAbr0NqrwaQOhSf1xsB+ev6yXwE4FGhpPCdfikTrKEkXDK0G7fP+6Z4xOQMhV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 03:10:44PM +0000, David Howells wrote: > Simon Horman wrote: > > > > /* Functions related to files and directories */ > > > +extern const struct netfs_request_ops cifs_req_ops; > > > extern const struct file_operations cifs_file_ops; > > > extern const struct file_operations cifs_file_direct_ops; /* if directio mnt */ > > > extern const struct file_operations cifs_file_strict_ops; /* if strictio mnt */ > > > > Nit: this hunk would probably be better placed in the > > patch at adds cifs_req_ops to fs/smb/client/file.c > > I'm not sure I understand what you mean. Is there a bit missing between "at" > and "adds" in that? Sorry, "patch that adds". What I meant is, the declaration of cifs_req_ops and it's definition seem to appear in different patches of this series. And it might make sense if they were both in the same patch. But given that both are present by the end of the series it is more cosmetic than anything else.