From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1A9EC48BC3 for ; Tue, 20 Feb 2024 18:46:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78D626B0095; Tue, 20 Feb 2024 13:46:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73D446B0096; Tue, 20 Feb 2024 13:46:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 604DA6B0098; Tue, 20 Feb 2024 13:46:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 49A106B0095 for ; Tue, 20 Feb 2024 13:46:58 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DF60D80821 for ; Tue, 20 Feb 2024 18:46:57 +0000 (UTC) X-FDA: 81813064074.03.3A627A9 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf13.hostedemail.com (Postfix) with ESMTP id 2916E20021 for ; Tue, 20 Feb 2024 18:46:54 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=WZSr3cyY; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf13.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708454815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7IOuxIDb5Z0KCM+pcpaR4R/cgjAJTg+4LwAhQ75Rsbc=; b=7Sg1NNXOX3tlCtHWpSX5DYnWc1w2uTc9jbsDVEa+BduWJ3lfClBkW757Wz4ZZ9EnnswfxP Vz1hnI/CqSMA+DsXORLzWKLVnuK1Bfbl1TviBJw68vik1A1E1WTj2wNhiBqusrIgFnP9YA y0Hsu1lYuiAaooBv2AjDEWR8xKpPPAE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=WZSr3cyY; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf13.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708454815; a=rsa-sha256; cv=none; b=lzPqtmQfT+RJk4+c8j6mkkrSnaEIsfsF0AvFBcqGJm3lS1ExWbmwTPf0EaOPHprIzUr2/J wV7j3PyNZ1zo/A5EvejX1YL5UTEMAjWIBBm5IxVc/Ckmo+5OWKjywzk+1jQ4bn+FMFpnig +dJZzJt24p1znTf/5Z5MsAvpUxrFtMo= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1dbd32cff0bso23157725ad.0 for ; Tue, 20 Feb 2024 10:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708454814; x=1709059614; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7IOuxIDb5Z0KCM+pcpaR4R/cgjAJTg+4LwAhQ75Rsbc=; b=WZSr3cyYGl5r1ihOhTLQA75d9vqOkln8dPh4fX+61Rq2BHbR5lrZkKanQpfbaljEgl LZ6TyaIGMVN7OX7aRZVpEOAaNh3irjc6BgpZdnXSa5K0810E0LwMSuSlrhYxJ8iZfP84 3sYuJPtQruk2Sy1URRxqQNgPZ5HLLlxfbpRsU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708454814; x=1709059614; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7IOuxIDb5Z0KCM+pcpaR4R/cgjAJTg+4LwAhQ75Rsbc=; b=HuP9ABjU1kQpIsx/n5mEEwnIOtKgCINz+S9rFPVGTKMn4ipK6f1oaTqdcZFLYcFOuh 9zHgVUVTIjR0X1mIrKT68TI0e9quBV9x78G4VNEisdArZrCDtR0HtBcHx6ZhsMmMhgYB KTeZ9QAOrAxhpBgvmgz1fLIMzHbDpeTgdqQRovMJ5638plmp+RbdoEy+AT4v7x/U0RV6 FYHeA2MZgfuFqXNq/s5FcRxh5jbEK9YOlqy9Fo25e5FftGD6n7KLdMlIXnCBWBv/bYZ/ x7IxLN7MV/q+gtpmP2Iuv2q6Ck95/pPKPzzbzqR2Ib14IAb/IIRzjj0oCtnOI2XcRAUC UchA== X-Forwarded-Encrypted: i=1; AJvYcCUFk+Ytx4jc93W1imkUDvUx1at8EfzXktIkBVBjgbLmD7BLlcGMmfSIqTLO1cRmp6A5WV6Z/eQOBUqpok8xc2/mEMY= X-Gm-Message-State: AOJu0Yz0JtMqNXmooHrTR8r6vQScA4uJaLDHT9W7XYjen35mz3s2amA4 6TIS31OFbumV7/z1NrlD7q+HhZjYIyW/er+9scAchwdZ+IvBu//Voz9T1i6Ukw== X-Google-Smtp-Source: AGHT+IFWA7Nied3uq9/sUXiW7CQVX4GmtTjuyjDQg/qgZ6qivlQZYt51G4sdK+dbdLKr9lHPIDBdrg== X-Received: by 2002:a17:903:22c7:b0:1db:f372:a93c with SMTP id y7-20020a17090322c700b001dbf372a93cmr6133046plg.43.1708454813927; Tue, 20 Feb 2024 10:46:53 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id mf8-20020a170902fc8800b001d9fc6cb5f2sm6596094plb.203.2024.02.20.10.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 10:46:53 -0800 (PST) Date: Tue, 20 Feb 2024 10:46:52 -0800 From: Kees Cook To: Oliver Hartkopp Cc: syzbot , akpm@linux-foundation.org, gustavoars@kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [mm?] [hardening?] BUG: bad usercopy in raw_getsockopt Message-ID: <202402201045.F3C4279A9D@keescook> References: <00000000000038b6700611d207b3@google.com> <9a98f3f1-6a39-4b05-b100-93be1361fd76@hartkopp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9a98f3f1-6a39-4b05-b100-93be1361fd76@hartkopp.net> X-Rspam-User: X-Stat-Signature: j9rzbfz8r1frsdhz89c1j9yaxua5m54h X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2916E20021 X-HE-Tag: 1708454814-734106 X-HE-Meta: U2FsdGVkX198aGgCkCNA+mrEPwoKHzM4u/5IHwzCVBJjfRgi2NQT61sjLZ3GWY14eEpdm6Ld9cA4+iJabHx51/IQ4BuST8W4iA9EsIKO6iFwAIG7SBl/D2HnVTmz30tYYUjwrvdKr5ex3kek1LsYxePQgzPr1hBMQHMzR0BtnEzK+E5DBCEX4zjGXaG8lbNS/gcKQfMVGtq2mB8N7Tf+epR8/akdh76UX+QuMJ0n7EDfjT56mSk2E/NWnJcenUtw4/h0b2HKIUAmfcljt0IbH4VBmjJm3mjNrCWZrF0J2LtHoE2W30eM7kAnAn9D8OMEsBdvrFKPnCwcFAu4K0p/UAJio9C9LmHPY5ONZKC79LdqHiu5RuMm1+7T248h5ft/a5JxSI0EYTF+KgaInb/HlKyFlPrs/vXrEzlXqHq0xJYyiUAIXtJ9jW2dr2cMiyj+HVHWqSKp1SqJE/CLIKy7Q4jlL8rKn2hzpc1ld6oGunplbeI6PQB9Foe7z/cPqSUxWp1n5yMGcN9RzRVxDhWe06bFFmji3vG2LCjSWqT+ooNC+Oz1gRrqgM9qBTVykyJyArjl5XZxzhy6NnWsEN70TwxUGb0ONiqi1dLEfbPSxqhv9ZpSVW5KU0LpGmraAy0th32adttppkXnHLUwTd3k2jqqJlwuqZwYgifwEwdwm3B87Lzd2FLzoSp4VmnhuOBYdkZYqePaU1CRvTreaxk8msdm148MLB6vaIUnDLxtkkLjFa7/Re2PveGlU4PA4JHMoGpnwdHoVnJCpQORmowlOWhGDMHfBKliPoIcErHcKgd6acTKr6S/ztDmmq8BrWEkFy2QD0mFakeqc+mpQvLYq78D4kvpfPcjdKg1ve2LHhSSDwM1k0RJ0i/7dD1K7LF8go1bYHwt+Tqg+HpNWANPbz7NYOqF0RZMg5WtUhEqKm0nDnfcogXUfnXe6CtUAiSo8Sv3027E1OTUHfZPeeX BQOw28Yt E2rBcK1t0ndmmM3jf2CaY5RYmUkh07TAx4N0U0/9Cg/cSMTu2gSYHcwH5KyfeMHC7nd54MCmcbphgCFlQKDDb3fZdS5x2DRxoHDd6t3SsOSOm1AKQW8uNn5eg9Zg9mjU6JEFuKBbjqyw/5Td5H+WYGsa9Ik2S0oW/Khw1/v7xrmwF8hvFrptXJOXuRm2JKg8nxw1SxRxWxBzAbOc0cNPv3BDDNq/tVdAb1exC3W8+7u7wdGuwKn4tjv6emu0s0h4TvND/UlIov3g44E58tAgpvUfzQ1xov6IPz8K/vIu5/pqBLNW/H9zeNb6ORcyP90gn9QXiVmySYNpP9CiTrz4Yhi3VU7DDznNBbNXrZJH6FmxEorUmsFuU0PEkPvxPnigDkEq/6HoaaSzCYVUAcknITUI6VXx6HqBdXr9br0T2cyTg2iI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 20, 2024 at 05:28:17PM +0100, Oliver Hartkopp wrote: > The issue has already been fixed with the next commit in net-next: > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=c8fba5d6df5e476aa791db4f1f014dad2bb5e904 > > Sorry for the effort - but really good to see, that the problem has been > catched automatically. Good job! Thanks! And this also nicely demonstrated the zero-init mitigation as well: the uninitialized "val" pointer was NULL, not random stack contents. :) #syz fix: can: raw: fix getsockopt() for new CAN_RAW_XL_VCID_OPTS -Kees > > Best regards, > Oliver > > On 2024-02-20 16:40, syzbot wrote: > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit: 74293ea1c4db net: sysfs: Do not create sysfs for non BQL d.. > > git tree: net-next > > console+strace: https://syzkaller.appspot.com/x/log.txt?x=13dcc4b4180000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=970c7b6c80a096da > > dashboard link: https://syzkaller.appspot.com/bug?extid=0c35af046fa98c893c84 > > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10f38cf8180000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=136d41c2180000 > > > > Downloadable assets: > > disk image: https://storage.googleapis.com/syzbot-assets/9bca2f6e074e/disk-74293ea1.raw.xz > > vmlinux: https://storage.googleapis.com/syzbot-assets/611a08387d8f/vmlinux-74293ea1.xz > > kernel image: https://storage.googleapis.com/syzbot-assets/78c388071345/bzImage-74293ea1.xz > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > Reported-by: syzbot+0c35af046fa98c893c84@syzkaller.appspotmail.com > > > > usercopy: Kernel memory exposure attempt detected from null address (offset 0, size 4)! > > ------------[ cut here ]------------ > > kernel BUG at mm/usercopy.c:102! > > invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI > > CPU: 1 PID: 5070 Comm: syz-executor201 Not tainted 6.8.0-rc4-syzkaller-01053-g74293ea1c4db #0 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024 > > RIP: 0010:usercopy_abort+0x84/0x90 mm/usercopy.c:102 > > Code: 49 89 ce 48 c7 c3 40 db b7 8b 48 0f 44 de 48 c7 c7 e0 d9 b7 8b 4c 89 de 48 89 c1 41 52 41 56 53 e8 01 c5 60 09 48 83 c4 18 90 <0f> 0b 66 2e 0f 1f 84 00 00 00 00 00 90 90 90 90 90 90 90 90 90 90 > > RSP: 0018:ffffc90003a3fc50 EFLAGS: 00010296 > > RAX: 0000000000000057 RBX: ffffffff8bb7db20 RCX: b071ef5fcc834300 > > RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000 > > RBP: ffffffffffffffff R08: ffffffff81753e6c R09: 1ffff92000747f28 > > R10: dffffc0000000000 R11: fffff52000747f29 R12: 0000000000000001 > > R13: 0000000000000004 R14: 0000000000000000 R15: 0000000000000000 > > FS: 0000555555f8e380(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 0000000020001480 CR3: 000000001f404000 CR4: 00000000003506f0 > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > Call Trace: > > > > __check_object_size+0x601/0xa00 > > check_object_size include/linux/thread_info.h:215 [inline] > > check_copy_size include/linux/thread_info.h:251 [inline] > > copy_to_user include/linux/uaccess.h:190 [inline] > > raw_getsockopt+0x37a/0x490 net/can/raw.c:852 > > do_sock_getsockopt+0x373/0x850 net/socket.c:2373 > > __sys_getsockopt+0x270/0x330 net/socket.c:2402 > > __do_sys_getsockopt net/socket.c:2412 [inline] > > __se_sys_getsockopt net/socket.c:2409 [inline] > > __x64_sys_getsockopt+0xb5/0xd0 net/socket.c:2409 > > do_syscall_64+0xf9/0x240 > > entry_SYSCALL_64_after_hwframe+0x6f/0x77 > > RIP: 0033:0x7f21bfe782a9 > > Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 > > RSP: 002b:00007ffcdfc8f038 EFLAGS: 00000246 ORIG_RAX: 0000000000000037 > > RAX: ffffffffffffffda RBX: 00007ffcdfc8f208 RCX: 00007f21bfe782a9 > > RDX: 0000000000000008 RSI: 0000000000000065 RDI: 0000000000000003 > > RBP: 00007f21bfeeb610 R08: 0000000020001480 R09: 00007ffcdfc8f208 > > R10: 0000000020001440 R11: 0000000000000246 R12: 0000000000000001 > > R13: 00007ffcdfc8f1f8 R14: 0000000000000001 R15: 0000000000000001 > > > > Modules linked in: > > ---[ end trace 0000000000000000 ]--- > > RIP: 0010:usercopy_abort+0x84/0x90 mm/usercopy.c:102 > > Code: 49 89 ce 48 c7 c3 40 db b7 8b 48 0f 44 de 48 c7 c7 e0 d9 b7 8b 4c 89 de 48 89 c1 41 52 41 56 53 e8 01 c5 60 09 48 83 c4 18 90 <0f> 0b 66 2e 0f 1f 84 00 00 00 00 00 90 90 90 90 90 90 90 90 90 90 > > RSP: 0018:ffffc90003a3fc50 EFLAGS: 00010296 > > RAX: 0000000000000057 RBX: ffffffff8bb7db20 RCX: b071ef5fcc834300 > > RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000 > > RBP: ffffffffffffffff R08: ffffffff81753e6c R09: 1ffff92000747f28 > > R10: dffffc0000000000 R11: fffff52000747f29 R12: 0000000000000001 > > R13: 0000000000000004 R14: 0000000000000000 R15: 0000000000000000 > > FS: 0000555555f8e380(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 0000000020001480 CR3: 000000001f404000 CR4: 00000000003506f0 > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > > > > --- > > This report is generated by a bot. It may contain errors. > > See https://goo.gl/tpsmEJ for more information about syzbot. > > syzbot engineers can be reached at syzkaller@googlegroups.com. > > > > syzbot will keep track of this issue. See: > > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > > > > If the report is already addressed, let syzbot know by replying with: > > #syz fix: exact-commit-title > > > > If you want syzbot to run the reproducer, reply with: > > #syz test: git://repo/address.git branch-or-commit-hash > > If you attach or paste a git patch, syzbot will apply it before testing. > > > > If you want to overwrite report's subsystems, reply with: > > #syz set subsystems: new-subsystem > > (See the list of subsystem names on the web dashboard) > > > > If the report is a duplicate of another one, reply with: > > #syz dup: exact-subject-of-another-report > > > > If you want to undo deduplication, reply with: > > #syz undup > > -- Kees Cook