From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
nphamcs@gmail.com, yosryahmed@google.com,
Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
hannes@cmpxchg.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mm/zsmalloc: remove migrate_write_lock_nested()
Date: Tue, 20 Feb 2024 14:02:34 +0900 [thread overview]
Message-ID: <20240220050234.GF11472@google.com> (raw)
In-Reply-To: <a6c22e30-cf10-4122-91bc-ceb9fb57a5d6@bytedance.com>
On (24/02/20 12:59), Chengming Zhou wrote:
> On 2024/2/20 12:53, Sergey Senozhatsky wrote:
> > On (24/02/20 12:51), Chengming Zhou wrote:
> >> On 2024/2/20 12:48, Sergey Senozhatsky wrote:
> >>> On (24/02/19 13:33), Chengming Zhou wrote:
> >>> [..]
> >
> > Not really. We have, for example, the following patterns:
> >
> > get_zspage_mapping()
> > spin_lock(&pool->lock)
>
> Right, this pattern is not safe actually, since we can't get stable fullness
> value of zspage outside pool->lock.
>
> But this pattern usage is only used in free_zspage path, so should be ok.
> Actually we don't use the fullness value returned from get_zspage_mapping()
> in the free_zspage() path, only use the class value to get the class.
>
> Anyway, this pattern is confusing, I think we should clean up that?
Right, looks so.
next prev parent reply other threads:[~2024-02-20 5:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 13:33 [PATCH 0/3] mm/zsmalloc: fix and optimize objects/page migration Chengming Zhou
2024-02-19 13:33 ` [PATCH 1/3] mm/zsmalloc: fix migrate_write_lock() when !CONFIG_COMPACTION Chengming Zhou
2024-02-19 13:33 ` [PATCH 2/3] mm/zsmalloc: remove migrate_write_lock_nested() Chengming Zhou
2024-02-20 4:48 ` Sergey Senozhatsky
2024-02-20 4:51 ` Chengming Zhou
2024-02-20 4:53 ` Sergey Senozhatsky
2024-02-20 4:59 ` Chengming Zhou
2024-02-20 5:02 ` Sergey Senozhatsky [this message]
2024-02-19 13:33 ` [PATCH 3/3] mm/zsmalloc: remove unused zspage->isolated Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220050234.GF11472@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=yosryahmed@google.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox