From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B888EC48BC4 for ; Tue, 20 Feb 2024 04:03:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 358E96B0083; Mon, 19 Feb 2024 23:03:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 308886B0085; Mon, 19 Feb 2024 23:03:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D0546B0087; Mon, 19 Feb 2024 23:03:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0C75C6B0083 for ; Mon, 19 Feb 2024 23:03:23 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D9EC8A0705 for ; Tue, 20 Feb 2024 04:03:22 +0000 (UTC) X-FDA: 81810837444.24.305A765 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf24.hostedemail.com (Postfix) with ESMTP id ABCC0180010 for ; Tue, 20 Feb 2024 04:03:18 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708401801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5ITL/um3IfLcAMuQYP0f/EP7OTFRVY3kSMPFAohPvj0=; b=a9hh7MmruP7nvYk3Fz6cCJ8Fx3vEEjVWlFL/bI4PnpMOYZgJc1a3iL0bLouc7E1iT5u8ee h84M8bAbipZ4TFyuzdIO+svTGW4hdzLGIWobkG6prtTfYNEuQxFs925B5X9sJ/EKzTkqRs smE1bIZpPcqe0vi9wTvfk88YmiyGv1w= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708401801; a=rsa-sha256; cv=none; b=UZWZpL8fmh+7/8Qaf+s+1zdztWzmjWh8PGC21wOZr8lBSPPEN2LpnluWvVqiEtg/ZvCMnq k+DAb0+a+00Q+VMSLvaQBQMm0KfxVlmbhkGD2JM3pImzR0M0tD1dOzlSH7HmyyUnRqVAdk zGNCTRWlRHtVSaOHzyXz13Yibtv+gwk= X-AuditID: a67dfc5b-d85ff70000001748-c0-65d4247f8241 Date: Tue, 20 Feb 2024 13:03:06 +0900 From: Byungchul Park To: "Huang, Ying" Cc: akpm@linux-foundation.org, osalvador@suse.de, baolin.wang@linux.alibaba.com, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, stable@vger.kernel.org Subject: Re: [PATCH] mm/vmscan: Fix a bug calling wakeup_kswapd() with a wrong zone index Message-ID: <20240220040306.GI65758@system.software.com> References: <20240216111502.79759-1-byungchul@sk.com> <871q97rec8.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871q97rec8.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsXC9ZZnkW69ypVUg4k9ZhZz1q9hs/i/9xij xepNvhaXd81hs7i35j+rxZlpRRYLNj5itDg5azKLA4fH4TfvmT0W73nJ5LHp0yR2jxMzfrN4 7Hxo6bH5dLXH501yAexRXDYpqTmZZalF+nYJXBnd0+YxFqyTrdjzexd7A+MT8S5GTg4JAROJ jnX72GHsm/3zmEBsFgFViZ5/i9lAbDYBdYkbN34yg9giAhoSnxYuB6rn4mAWOMMosWr2elaQ hLBAtMTjd3PBBvEKWEg8n9nDAmILCWRKdE7tYIOIC0qcnPkELM4soCVx499LoGUcQLa0xPJ/ HCBhTgE7iWPfnoPtEhVQljiw7TgTyC4JgQNsEve+LmCEOFRS4uCKGywTGAVmIRk7C8nYWQhj FzAyr2IUyswry03MzDHRy6jMy6zQS87P3cQIDPlltX+idzB+uhB8iFGAg1GJh/dB3OVUIdbE suLK3EOMEhzMSiK87k0XUoV4UxIrq1KL8uOLSnNSiw8xSnOwKInzGn0rTxESSE8sSc1OTS1I LYLJMnFwSjUwrniUetTU7fEdrjiprdVHPH5J1O5omTKFy3Ri5l8Vl3UfexeWaJrv2nrpnmTM 5Xth823rwrJ1jwgy2QSLHD3UVnUo+sOp+8t8ZO17qxLsXJNO8yh/3ySds6a1+JuB2beK96re hz79Y7U8NbuEW0qZ7e57NYF7gnMFkl6LGx1TePuq8Ft2V0iJEktxRqKhFnNRcSIATAjaAXUC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsXC5WfdrFuvciXVYOtbNYs569ewWfzfe4zR YvUmX4vDc0+yWlzeNYfN4t6a/6wWZ6YVWSzY+IjR4uSsySwOnB6H37xn9li85yWTx6ZPk9g9 Tsz4zeKx86Glx+IXH5g8Np+u9vi8SS6AI4rLJiU1J7MstUjfLoEro3vaPMaCdbIVe37vYm9g fCLexcjJISFgInGzfx4TiM0ioCrR828xG4jNJqAucePGT2YQW0RAQ+LTwuXsXYxcHMwCZxgl Vs1ezwqSEBaIlnj8bi47iM0rYCHxfGYPC4gtJJAp0Tm1gw0iLihxcuYTsDizgJbEjX8vgZZx ANnSEsv/cYCEOQXsJI59ew62S1RAWeLAtuNMExh5ZyHpnoWkexZC9wJG5lWMIpl5ZbmJmTmm esXZGZV5mRV6yfm5mxiBAbys9s/EHYxfLrsfYhTgYFTi4X0QdzlViDWxrLgy9xCjBAezkgiv e9OFVCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8XuGpCUIC6YklqdmpqQWpRTBZJg5OqQbG+0+d L/44dC2sbstlg89Np1ZVlSoe2lrHbWS3aX3qX+64TKE54ivL702rk3mzrkqml0NXymy+Zbvp DL/TTlqbL0umhK9p+3g1+74Xp5v1GQ+euTYT1/+u/DTVYtvKc1f3+Qc2xd+55mW7TMzu1+yA grraeRcb6iN5dT2Szp6LP6xaVq2itTpViaU4I9FQi7moOBEAq2C0/1wCAAA= X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ABCC0180010 X-Stat-Signature: tkumd8ryjf4154id1k6cy4mc7x7buwm7 X-HE-Tag: 1708401798-201939 X-HE-Meta: U2FsdGVkX182kWoFK/gf8bSttkLdJWNqlSvte4zINYm07JXlD2q0aEsNsBpXGoPLnomj8QEUB7ToAyItwFyZnXCabfsQcOtWPbXJddvydXElYQH93qQNRUVRgigm4y5afEmYdYX2t8RAJSONRwde5WIlNRLvNZF4fGVdNbHTxhnsCzC/vXlpW30uFvt8tNh/AtYqTymHgw72dKv9x/98LxJ7y0WlSPh9RGj1j36BxOMx1W82FmCF9jk8SXdD+Fx8DGyMJ8A1Uv+kjTuWV1xjjb+kjOz3qVQCnkhP9vltfr8kdsAT/cQnAlzHrizz9eYvRWpyPc3NTGEo1LklZxUAzi0koWbB2NYSB2HDc+MOZxp2RRPnMw/chGJcaeLKLygUVJO08oWE4Q5uS8sVyFYRXOe5EZu35BT98UNQkXzCWxvXBfKxxMXF6XFyNeqejXOiOz8buGplNlaTZt5MbOtxjbKvDqiErvvXdINLsOOZrAz9Onu4MtdlPyOfzmhd6sdTOhs4SjpEZSKa9ao8A2KFA9bQ/SotJY/zDH+gTsbyNxQmZXftp4pTw+RSWdnA+PCp1pSCveuT46NUQAhwikmLRyNRfZWRln3Ub/0I8oqoBcodVdj7KWo6ZdGlpnNg3xiGFBJRwxcCvydkMNL/x4EzFigNhQm+NjIMn09c4ZwnCGuhkwSm1KvkGPsWLlYVbquSBmAyyIvvc517jXwgXbdmO9/+yHDy/N4WZQuHhrCumdUHISfK85DuCscWN4YlBqMAs+0KxUEsnyQHO59Gfz9y0yIxiCko8TszQpONW4bCaTZPIBztH2NzBKBRT9wx9ZfcREzBVpU5UO7ufvHOBildAtLozPEVJyzmDMJTLyP9bITfaNc6+omwWsvdOyEL4flgGOkkDCdNpzYmaO482QBoTdo2fR3GZdxd5gtOMsit+kc0y+4h8dqZc4SYeBZjd1yuODtSU4x471uvr75O7jo TI5EfdiN VyNc5pnrhRWIF8iEfaTtqhVar42eN6doqQw/Ri35mZbrHh0lt2Cl+Afi8zK9jGHPPs8yklqkZyLsMgc5jAaoKrZyfL7XH0bTQQ6sMEpMOGJ3GfEaLqLjPuLegyrF1FUhitGiQ66vtd4+Jn/GotYTiD6T9LEQiEAnSVG6h X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 20, 2024 at 11:42:31AM +0800, Huang, Ying wrote: > Byungchul Park writes: > > > With numa balancing on, when a numa system is running where a numa node > > doesn't have its local memory so it has no managed zones, the following > > oops has been observed. It's because wakeup_kswapd() is called with a > > wrong zone index, -1. Fixed it by checking the index before calling > > wakeup_kswapd(). > > > >> BUG: unable to handle page fault for address: 00000000000033f3 > >> #PF: supervisor read access in kernel mode > >> #PF: error_code(0x0000) - not-present page > >> PGD 0 P4D 0 > >> Oops: 0000 [#1] PREEMPT SMP NOPTI > >> CPU: 2 PID: 895 Comm: masim Not tainted 6.6.0-dirty #255 > >> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS > >> rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014 > >> RIP: 0010:wakeup_kswapd (./linux/mm/vmscan.c:7812) > >> Code: (omitted) > >> RSP: 0000:ffffc90004257d58 EFLAGS: 00010286 > >> RAX: ffffffffffffffff RBX: ffff88883fff0480 RCX: 0000000000000003 > >> RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff88883fff0480 > >> RBP: ffffffffffffffff R08: ff0003ffffffffff R09: ffffffffffffffff > >> R10: ffff888106c95540 R11: 0000000055555554 R12: 0000000000000003 > >> R13: 0000000000000000 R14: 0000000000000000 R15: ffff88883fff0940 > >> FS: 00007fc4b8124740(0000) GS:ffff888827c00000(0000) knlGS:0000000000000000 > >> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > >> CR2: 00000000000033f3 CR3: 000000026cc08004 CR4: 0000000000770ee0 > >> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > >> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > >> PKRU: 55555554 > >> Call Trace: > >> > >> ? __die > >> ? page_fault_oops > >> ? __pte_offset_map_lock > >> ? exc_page_fault > >> ? asm_exc_page_fault > >> ? wakeup_kswapd > >> migrate_misplaced_page > >> __handle_mm_fault > >> handle_mm_fault > >> do_user_addr_fault > >> exc_page_fault > >> asm_exc_page_fault > >> RIP: 0033:0x55b897ba0808 > >> Code: (omitted) > >> RSP: 002b:00007ffeefa821a0 EFLAGS: 00010287 > >> RAX: 000055b89983acd0 RBX: 00007ffeefa823f8 RCX: 000055b89983acd0 > >> RDX: 00007fc2f8122010 RSI: 0000000000020000 RDI: 000055b89983acd0 > >> RBP: 00007ffeefa821a0 R08: 0000000000000037 R09: 0000000000000075 > >> R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000000 > >> R13: 00007ffeefa82410 R14: 000055b897ba5dd8 R15: 00007fc4b8340000 > >> > > > > Signed-off-by: Byungchul Park > > Reported-by: Hyeongtak Ji > > Cc: stable@vger.kernel.org > > Fixes: c574bbe917036 ("NUMA balancing: optimize page placement for memory tiering system") > > --- > > mm/migrate.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/mm/migrate.c b/mm/migrate.c > > index fbc8586ed735..51ee6865b0f6 100644 > > --- a/mm/migrate.c > > +++ b/mm/migrate.c > > @@ -2825,6 +2825,14 @@ static int numamigrate_isolate_folio(pg_data_t *pgdat, struct folio *folio) > > if (managed_zone(pgdat->node_zones + z)) > > break; > > } > > + > > + /* > > + * If there are no managed zones, it should not proceed > > + * further. > > + */ > > + if (z < 0) > > + return 0; > > + > > I think that it's better to check pgdat->nr_zones directly earlier in > the function. That is a little easier to be understood. No. No matter what the value of ->nr_zones is, the oops is going to happen if there are no managed zones by any reason. Byungchul > > wakeup_kswapd(pgdat->node_zones + z, 0, > > folio_order(folio), ZONE_MOVABLE); > > return 0; > > -- > Best Regards, > Huang, Ying