From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F9CC48BC3 for ; Tue, 20 Feb 2024 03:20:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81D836B007B; Mon, 19 Feb 2024 22:20:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CD6A6B007E; Mon, 19 Feb 2024 22:20:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 695416B0081; Mon, 19 Feb 2024 22:20:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 590CC6B007B for ; Mon, 19 Feb 2024 22:20:21 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 272E51A0521 for ; Tue, 20 Feb 2024 03:20:21 +0000 (UTC) X-FDA: 81810729042.05.A1719D6 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf07.hostedemail.com (Postfix) with ESMTP id 7836D4000A for ; Tue, 20 Feb 2024 03:20:16 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708399218; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sPkojpOj4mEXY2sXduHYqpUIr7apyOyHwKyoyXZHgKc=; b=F6APl0eX76aYLTshfquPSGfTuwjRU6xUZqubYKnzi7kN9C8j5J7H6ynoZC0pLBlFh/FZSX GarwV49wzQH9citXS+cVVTbOZLMrJgbV4jSAMpcisGsGWJiXAbFsPGbuiJDJRkc6Anzz8X BGxozD4D3l5nltc69gpcPIw0Xe1L18o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708399218; a=rsa-sha256; cv=none; b=1QxhJq2ExLiAL+SOznYTzI2sQGYKjsvMYq3QAAWPzr0BbMlfdA7on/mp1NnGf1so+qvHBM 0k3CZ6d43XunQTvLCSk8NiBzUfYovjccIKpHgndwnQ8subpkvmg3KWN/ae5pHwP6Yd+ybj BvbLH6thk0wcRPM+K1nYkfR/m3zJG3g= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none X-AuditID: a67dfc5b-d6dff70000001748-83-65d41a6d8cd9 Date: Tue, 20 Feb 2024 12:20:08 +0900 From: Byungchul Park To: Andrew Morton Cc: "Huang, Ying" , mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com Subject: Re: [PATCH v4] sched/numa, mm: do not try to migrate memory to memoryless nodes Message-ID: <20240220032008.GH65758@system.software.com> References: <20240219041920.1183-1-byungchul@sk.com> <87o7ccrghz.fsf@yhuang6-desk2.ccr.corp.intel.com> <20240219174508.bc6256248a163c3ab9a58369@linux-foundation.org> <20240220015343.GD65758@system.software.com> <20240219190520.b5e373273ec743aacbad263b@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219190520.b5e373273ec743aacbad263b@linux-foundation.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMIsWRmVeSWpSXmKPExsXC9ZZnkW6u1JVUg63/jC3mrF/DZnHp8VU2 i+kvG1ksnk7Yymxxt38qi8XlXXPYLO6t+c9qMfndM0aLSwcWMFkc7z3AZLGv4wGTRceRb8wW W49+Z7c4OWsyiwOfx5p5axg9WvbdYvdYsKnUY/MKLY/Fe14yeWz6NInd4861PWweJ2b8ZvF4 v+8qm8fm09UenzfJBXBHcdmkpOZklqUW6dslcGVc33KUueASd8WL/ZINjDM4uxg5OCQETCQm fY3rYuQEM7smn2QBsVkEVCWmtq1jBbHZBNQlbtz4yQxiiwjoSqx6vgvMZha4ziRx/V8hiC0s ECUxY8kXRhCbV8BC4sb1DvYuRi4OIYGZTBLffm6CSghKnJz5hAWiWUvixr+XTCA3MAtISyz/ xwES5hTwlmju/cIEYosKKEsc2HacCWSOhEA7u8TX3llsEIdKShxccYNlAqPALCRjZyEZOwth 7AJG5lWMQpl5ZbmJmTkmehmVeZkVesn5uZsYgVG1rPZP9A7GTxeCDzEKcDAq8fA+iLucKsSa WFZcmXuIUYKDWUmE173pQqoQb0piZVVqUX58UWlOavEhRmkOFiVxXqNv5SlCAumJJanZqakF qUUwWSYOTqkGxlrJObMTlNvL1m1e/ixN40/l/OtTM7e77rnNECIlrdk0WdR+R5uplKB+yTWu zC3BSWvNdhhy/6pkO9rAc8my51WRYcehkskMjF/rP00O2Wuw1G5ict+PbbscjaLcHHed2lHE OqMzzP/txaMPTlR9XZXVHu3tUqXtdszwjnzh9qb+SWUnTqecVWIpzkg01GIuKk4EALQAcKqm AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNLMWRmVeSWpSXmKPExsXC5WfdrJsrdSXV4OA7eYs569ewWVx6fJXN YvrLRhaLpxO2Mlvc7Z/KYnF47klWi8u75rBZ3Fvzn9Vi8rtnjBaXDixgsjjee4DJYl/HAyaL jiPfmC22Hv3ObnFy1mQWB36PNfPWMHq07LvF7rFgU6nH5hVaHov3vGTy2PRpErvHnWt72DxO zPjN4vF+31U2j8UvPjB5bD5d7fF5k1wATxSXTUpqTmZZapG+XQJXxvUtR5kLLnFXvNgv2cA4 g7OLkZNDQsBEomvySRYQm0VAVWJq2zpWEJtNQF3ixo2fzCC2iICuxKrnu8BsZoHrTBLX/xWC 2MICURIzlnxhBLF5BSwkblzvYO9i5OIQEpjJJPHt5yaohKDEyZlPWCCatSRu/HvJ1MXIAWRL Syz/xwES5hTwlmju/cIEYosKKEsc2HacaQIj7ywk3bOQdM9C6F7AyLyKUSQzryw3MTPHVK84 O6MyL7NCLzk/dxMjMEqW1f6ZuIPxy2X3Q4wCHIxKPLwP4i6nCrEmlhVX5h5ilOBgVhLhdW+6 kCrEm5JYWZValB9fVJqTWnyIUZqDRUmc1ys8NUFIID2xJDU7NbUgtQgmy8TBKdXAWP7VrCJs e9+qbKEJqvIJzaLbw+M2v3msxH7lzbar1np6FsLPEtnNTPj9pqZNPPn3z8IVi216N6zJ2fFp zezYGWyFMsk+b5YJfrWOfS5b0fbx35Rtuhnp/6JjHqqr83w/PGXLx7mPzt9Ot077O2nLg4Xb XWcaqci9m8o0gbv6T8nbGx1x0gmuM5RYijMSDbWYi4oTAaUpDKOOAgAA X-CFilter-Loop: Reflected X-Stat-Signature: odcoz8a51atpnsktorhdhdqqs9izcgic X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7836D4000A X-Rspam-User: X-HE-Tag: 1708399216-932681 X-HE-Meta: U2FsdGVkX1+qgTr4yPMihjrD+anE/bD3wAEBcocByEF2GS8R4621yt6VtPdbt60KOTJACIzMM3Rz+wcqkiyt1FBvLHd8blTcxTU3UpaDIe1yFC8do3QP/yW/8Ee7GgrJup46dYjE/zVuX5sR979S+7KodD7MqUKEf6CIKoHm2AfjKwW3qYpuuTyAUedGxofJH9cz+/pEE1bWeFxXU3LBVZ2o+9GyHJgtv6U3ACfytvya2gYwfm3PoZTFISmoX2+x3gurlL77e5FbLlebMz/lA7sGOcRqDHsa5iIzXi3Kvxb9ixPpF4/Ou25eF1ndswd3Pw/qC7h+K/Pgjv/Toe/ScGnIxzcSpO0Knjf640aBuyuJ1eiK32Sez57o1HMHh/GnmIUAUd3KOz+1InvLikGAxbDwHtFkpsHRxSQuMY9VQBic52vYQ02XCZf0Pb7CPlhLKK62JUOq5XSEJb+KyXSCXHdSKP4h/KUH1wFJ0saoeOB6Yb8MKose0gHZyInVuKDd1xmcGcxLhVag5kah0Z/ne2nEz3mgVmMNYw5IMT0X3qwAOYz6bRTA4Nnqc/aQD3TCO0Zj4PL8im2xAXeZ01xNDsTbACW2K06nkY5w7J2UWjog0dHBUmhF8zGxFwo1y6HDyXXqV4KYXjkBiUC5ye/YaiRjfbdBsjIiNDE+BofJBTUGpQHfyAhG4k9HwKoqq5HJ76BbqY4qjNua3kRc1UNqBsHObYqAVZchFmdj4R3hWNj1YkhBLPrFmEDI76oq1lIvWg+ljgS48CNHUjdkVQoK3UmUv5kE9DnhMSse4x5Shi7uYwE8SydZsTvuRkQNJjZ1jXZpW4iZZ4FZDS/LP6FYtK5J5kNw8IG6EpqVaXXYxNV46H385wBHBG+wOnmivbjf7WbYtAJLn4lU90se0g/J60nPuL+sa4IEmbJKS+qsC38sxdACt1InvOE3D+HfUOx18deR5KpKwwK8zxeFwRQ Rjdn1xsM Rz9cTIMqdbg1A1cXxLnE9SKiYbWOJ+1E69CKts0+URnHF/ZCPx9v+0LKMEIusS5x/8LAO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 07:05:20PM -0800, Andrew Morton wrote: > On Tue, 20 Feb 2024 10:53:43 +0900 Byungchul Park wrote: > > > > > IIUC, you will use patch as fix to the issue in > > > > > > > > https://lore.kernel.org/lkml/20240216111502.79759-1-byungchul@sk.com/ > > > > > > > > If so, we need the Fixes: tag to make it land in -stable properly. > > > > > > Yes, this changelog is missing rather a lot of important information. > > > > This is not the root cause fix any more but just optimization. > > It would have been helpful to have told us this in the changelog :( Sorry for that and making you guys confused. > > That's > > why I didn't add Fixes: tag and cc stable@vger.kernel.org in here. > > > > Instead, I added Fixes: tag and cc'ed stable@vger.kernel.org in the real > > fix patch. check the following link please: > > > > https://lore.kernel.org/lkml/20240216111502.79759-1-byungchul@sk.com/ > > But doesn't this patch "sched/numa, mm: do not try to migrate memory to > memoryless nodes" also fix the bug? Do we truly need both? Yes. The oops is gone with "sched/numa, mm: do not try to migrate memory to memoryless nodes". However, as you know, wrongly manipulating array index is very dangerous - what hackers are looking for. Even with security in mind, both are necessary. Plus, no one gurantees the problematic code is gone through with a numa node that has no managed zones in the future. Byungchul