From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29566C48BC3 for ; Tue, 20 Feb 2024 02:08:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF17F6B008A; Mon, 19 Feb 2024 21:08:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7B126B008C; Mon, 19 Feb 2024 21:08:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F4556B0092; Mon, 19 Feb 2024 21:08:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7B36A6B008A for ; Mon, 19 Feb 2024 21:08:09 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 47C08A0521 for ; Tue, 20 Feb 2024 02:08:09 +0000 (UTC) X-FDA: 81810547098.25.DF1721C Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf16.hostedemail.com (Postfix) with ESMTP id 46F8918000D for ; Tue, 20 Feb 2024 02:08:03 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=temperror (imf16.hostedemail.com: error in processing during lookup of byungchul@sk.com: DNS error) smtp.mailfrom=byungchul@sk.com; dmarc=temperror reason="server fail" header.from=sk.com (policy=temperror) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708394887; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A4yWuRegRJp/v8zZUHIaNDU3TdyDboGG3nf/FFjGR4w=; b=udc+D414TX7WvojVCZI422quUPyJg3WfCksWNvx1CnpiyqzAPEDBSSYtiLFpOrgW6KErla TLKUtfCt2M1QaE/buKy4jI9KoMLtnnqCS//M5q6CXNstsKj+gWGMh9Q1BDuNq0Ho0yMEdP +XvS7SOPbvT4orD/M7ZQoHRMCvn/hrs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=temperror (imf16.hostedemail.com: error in processing during lookup of byungchul@sk.com: DNS error) smtp.mailfrom=byungchul@sk.com; dmarc=temperror reason="server fail" header.from=sk.com (policy=temperror) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708394887; a=rsa-sha256; cv=none; b=NJikvDNQxtUtymhdzymi7YNU9q1uMmTDFxO+8l98WxoUeVP0xOgSTbL5kAYTXRYD1GraqM 6nOzxDnIIc/pySIjIrcFiw8YL5N/jIU4I96ZCimmep5q81gjryf/86VoTQQPtf3LRFGlHs QyJ204owpctudqz3oaq5egDkhYaSQX4= X-AuditID: a67dfc5b-d6dff70000001748-96-65d40980b13f Date: Tue, 20 Feb 2024 11:07:55 +0900 From: Byungchul Park To: Andrew Morton Cc: "Huang, Ying" , mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com Subject: Re: [PATCH v4] sched/numa, mm: do not try to migrate memory to memoryless nodes Message-ID: <20240220020755.GE65758@system.software.com> References: <20240219041920.1183-1-byungchul@sk.com> <87o7ccrghz.fsf@yhuang6-desk2.ccr.corp.intel.com> <20240219174508.bc6256248a163c3ab9a58369@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219174508.bc6256248a163c3ab9a58369@linux-foundation.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRmVeSWpSXmKPExsXC9ZZnkW4D55VUg/M7tS3mrF/DZnHp8VU2 i+kvG1ksnk7Yymxxt38qi8XlXXPYLO6t+c9qMfndM0aLSwcWMFkc7z3AZLGv4wGTRceRb8wW W49+Z7c4OWsyiwOfx5p5axg9WvbdYvdYsKnUY/MKLY/Fe14yeWz6NInd4861PWweJ2b8ZvF4 v+8qm8fm09UenzfJBXBHcdmkpOZklqUW6dslcGUc+zmVvWC9RsXE5p/MDYwTFLsYOTkkBEwk bsz9zQJjNzROAbNZBFQlvs6dzgpiswmoS9y48ZMZxBYR0JVY9XwXmM0scJ1J4vq/QhBbWCBK YsaSL4wgNq+AhcS7b6fYuxi5OIQEVjJKXDyxlR0iIShxcuYTFohmLYkb/14ydTFyANnSEsv/ cYCEOQW8Jd6degc2X1RAWeLAtuNMIHMkBLrZJaZ27IE6VFLi4IobLBMYBWYhGTsLydhZCGMX MDKvYhTKzCvLTczMMdHLqMzLrNBLzs/dxAiMrGW1f6J3MH66EHyIUYCDUYmH90Hc5VQh1sSy 4srcQ4wSHMxKIrzuTRdShXhTEiurUovy44tKc1KLDzFKc7AoifMafStPERJITyxJzU5NLUgt gskycXBKNTD2TOrmO3Hl2+lZOvxcj2wtnn86nPjwate3rlvtiW1lcncX9tVFsHWtrauWKrg9 Xfx0qsami9UnZ6jdsXarKnZaJ3bTcsFUw28fvZsie6+fOdb1guGq9rkrT79sD3nTuVAnup69 y+dyWTrnmwiR319krPWOv86+tr3X/vJnhs6dytPiQxLrfnoosRRnJBpqMRcVJwIAILNVLqgC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsXC5WfdrNvAeSXVYM8aBYs569ewWVx6fJXN YvrLRhaLpxO2Mlvc7Z/KYnF47klWi8u75rBZ3Fvzn9Vi8rtnjBaXDixgsjjee4DJYl/HAyaL jiPfmC22Hv3ObnFy1mQWB36PNfPWMHq07LvF7rFgU6nH5hVaHov3vGTy2PRpErvHnWt72DxO zPjN4vF+31U2j8UvPjB5bD5d7fF5k1wATxSXTUpqTmZZapG+XQJXxrGfU9kL1mtUTGz+ydzA OEGxi5GTQ0LARKKhcQoLiM0ioCrxde50VhCbTUBd4saNn8wgtoiArsSq57vAbGaB60wS1/8V gtjCAlESM5Z8YQSxeQUsJN59O8XexcjFISSwklHi4omt7BAJQYmTM5+wQDRrSdz495Kpi5ED yJaWWP6PAyTMKeAt8e7UO7D5ogLKEge2HWeawMg7C0n3LCTdsxC6FzAyr2IUycwry03MzDHV K87OqMzLrNBLzs/dxAiMk2W1fybuYPxy2f0QowAHoxIP74O4y6lCrIllxZW5hxglOJiVRHjd my6kCvGmJFZWpRblxxeV5qQWH2KU5mBREuf1Ck9NEBJITyxJzU5NLUgtgskycXBKNTD6Xe9c kWIT0zuzz3O1bpGrKluMwfuoG75zUyxdfp/1u2h1RGfj8f176tSWCapPvmATmXtcJ2RmjnyW KO9myU97K3y9lnP8/vkm74qV+4cGub+L17/95nng8Be/xSlVfJfyrnCer9jfJn/3X5NG2L+i +8HvH918Fen+imOWHPch0W/NtyTSvFOUWIozEg21mIuKEwE9GqczjwIAAA== X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 46F8918000D X-Rspam-User: X-Stat-Signature: 3p3c4tqj1ds36pbc3u35eidc4ztwinr3 X-Rspamd-Server: rspam01 X-HE-Tag: 1708394883-724479 X-HE-Meta: U2FsdGVkX18CLiuJzmNxe1kPAmA+JFj9rwNZwcsMEiQsWRhySuX+rzEOmEDYi+Dx0KzgeiSCrOua13Q7hBwqA3qSl2kHfOC42nRq9yLdjCYc/O4p9FbgYR8t2oZ9Wc75nDz1UiBwXu7X1ojQAt4nqrmBnv0zlCMzJkHGWDkbrjsku0Jm9PSPUaBefVsYYXaTxMaKFo/Hprj0bO7PH/ldCSJoaHeQyrWb7Bv1ruX8NQe9N9fUvFI0fjZI9bHjBwopuCgOqODbUxTHXAbX0bm0hHxzixoPGgv7gRrDkxVk3u9M98JH8VgpyRCm1KNcpkT2rAZ3sR1fAzrYbEc6APkaJkdAKwQUyhNW2N/pNsu117WAadTPdnSCPsAlR0+LMKOye0VnBUIWQvpHOCvc4Ijhji0iXUVNf+FgMLxqkt7GfyX7MR7xDSSYDwKhm8FAa9x/HzCmXidC7++sCd0ylp0rj4vvrvNXm1l7ylEIyOYJR1OU9dLnlYvORXe5O/yYkI7cyE+yFXrEemrZJRoAfvuuhxNLK1eANpzw4IhrzM03OnrBZAiydGVkcec3BhKmktg+7pxxVCNGQCyq1vOcQoDtcBDfVrTi4OEDnt6/6sV34Kt+m7FzvlDp7tuMhM4USOGF0exj6s4jQmOxPhyx/2RMe+RypPWFbeYDm8/7Crj3OfrxLQtjVkRuSKuVCWHN2OMf8Z4iAQ5FxWw1ZBSywCHV5pQa/NX6s2ZnYxxlHf9Zd7EA8wHShDshESEwGeDEu2+0MAkGjL5Z44MIb0iwVL5V0yxC3I1PkUVeOyMxqkZkxqROl4VfqFfa9SEKaOTTX2T1P9SLI0Qj+pRj9q/N21siwXGP/lWL3u8K5ZGjEMTt6QgmVssDhKxcu+/PnLstvQe2p0dides0xX+qtmSL2BJGMoTDFiXud+IRAhFebs31oXSitarCfY457ckhMzEkmKaLdQXaGcpKc8EhjihBdkl FfHSnyeU MkvxC4ivmx7D6c9Ww+ZjopC9oJXdPl1WcnwHOT6pwv2/8n4KswKDNaO9fhILZfFBKnkR+6SAj1pbbiHp/6DH4Lv9T/Hdefl7YIccc+xWjUoN471PF2cYT+XMDcpjBTBoCjdG5fNNp1xScJH6nTJtRl9FGwJMRisw1DICBR+BcFyXBO+NpCWoLAhktHw/NE1udY7fxasoggPxDPxoylHE6dOmlZS6+bBaGJinMJQmaITj3s11Wh+j/XJSoXP/FTiCBK9jd+/uI+3tPN4gSdZ32rwEmu10rQyLaH35yc3j0OSBYr/4asE3sGGWDtqTtInQ+naJfaAw0yaYRMc16ljLG9kh6Yy0LQHphVcwroWeXUznrg0Q9mIYEQLqHHZL2z9s2gAynAgn8Lf56f5mYuRvVAAuMljHj8yMbIoivWmTgc9GtdjsACXgIpFqpPukszeXxEyGo8VP+1l6l81dnXRxc9W8n2XjrwvXl6ACDkLyOGqpL/KDtSRxZcMaKlLscmZvrD9gW8vpqqldv/qWdPAJsaZXYbPoXeTFd8dmqTkqKJvaXKvt+Mxe1X0uV7iom5JrO6VMY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 05:45:08PM -0800, Andrew Morton wrote: > On Mon, 19 Feb 2024 16:43:36 +0800 "Huang, Ying" wrote: > > > > + /* > > > + * Cannot migrate to memoryless nodes. > > > + */ > > > + if (!node_state(dst_nid, N_MEMORY)) > > > + return false; > > > + > > > /* > > > * The pages in slow memory node should be migrated according > > > * to hot/cold instead of private/shared. > > > > Good catch! > > > > IIUC, you will use patch as fix to the issue in > > > > https://lore.kernel.org/lkml/20240216111502.79759-1-byungchul@sk.com/ > > > > If so, we need the Fixes: tag to make it land in -stable properly. > > Yes, this changelog is missing rather a lot of important information. > > I pulled together the below, please check. Plus, two guys gave the tags for the optimization patch as well: Reviewed-by: Davidlohr Bueso Acked-by: David Hildenbrand Byungchul > From: Byungchul Park > Subject: sched/numa, mm: do not try to migrate memory to memoryless nodes > Date: Mon, 19 Feb 2024 13:10:47 +0900 > > With numa balancing on, when a numa system is running where a numa node > doesn't have its local memory so it has no managed zones, the following > oops has been observed. It's because wakeup_kswapd() is called with a > wrong zone index, -1. Fixed it by checking the index before calling > wakeup_kswapd(). > > > BUG: unable to handle page fault for address: 00000000000033f3 > > #PF: supervisor read access in kernel mode > > #PF: error_code(0x0000) - not-present page > > PGD 0 P4D 0 > > Oops: 0000 [#1] PREEMPT SMP NOPTI > > CPU: 2 PID: 895 Comm: masim Not tainted 6.6.0-dirty #255 > > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS > > rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014 > > RIP: 0010:wakeup_kswapd (./linux/mm/vmscan.c:7812) > > Code: (omitted) > > RSP: 0000:ffffc90004257d58 EFLAGS: 00010286 > > RAX: ffffffffffffffff RBX: ffff88883fff0480 RCX: 0000000000000003 > > RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff88883fff0480 > > RBP: ffffffffffffffff R08: ff0003ffffffffff R09: ffffffffffffffff > > R10: ffff888106c95540 R11: 0000000055555554 R12: 0000000000000003 > > R13: 0000000000000000 R14: 0000000000000000 R15: ffff88883fff0940 > > FS: 00007fc4b8124740(0000) GS:ffff888827c00000(0000) knlGS:0000000000000000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 00000000000033f3 CR3: 000000026cc08004 CR4: 0000000000770ee0 > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > PKRU: 55555554 > > Call Trace: > > > > ? __die > > ? page_fault_oops > > ? __pte_offset_map_lock > > ? exc_page_fault > > ? asm_exc_page_fault > > ? wakeup_kswapd > > migrate_misplaced_page > > __handle_mm_fault > > handle_mm_fault > > do_user_addr_fault > > exc_page_fault > > asm_exc_page_fault > > RIP: 0033:0x55b897ba0808 > > Code: (omitted) > > RSP: 002b:00007ffeefa821a0 EFLAGS: 00010287 > > RAX: 000055b89983acd0 RBX: 00007ffeefa823f8 RCX: 000055b89983acd0 > > RDX: 00007fc2f8122010 RSI: 0000000000020000 RDI: 000055b89983acd0 > > RBP: 00007ffeefa821a0 R08: 0000000000000037 R09: 0000000000000075 > > R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000000 > > R13: 00007ffeefa82410 R14: 000055b897ba5dd8 R15: 00007fc4b8340000 > > > > Fix this by avoiding any attempt to migrate memory to memoryless nodes. > > Link: https://lkml.kernel.org/r/20240219041920.1183-1-byungchul@sk.com > Link: https://lkml.kernel.org/r/20240216111502.79759-1-byungchul@sk.com > Fixes: c574bbe917036 ("NUMA balancing: optimize page placement for memory tiering system") > Signed-off-by: Byungchul Park > Reviewed-by: Oscar Salvador > Reviewed-by: "Huang, Ying" > Reviewed-by: Phil Auld > Cc: Benjamin Segall > Cc: Daniel Bristot de Oliveira > Cc: Dietmar Eggemann > Cc: Ingo Molnar > Cc: Juri Lelli > Cc: Mel Gorman > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Valentin Schneider > Cc: Vincent Guittot > Cc: > Signed-off-by: Andrew Morton > --- > > kernel/sched/fair.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > --- a/kernel/sched/fair.c~sched-numa-mm-do-not-try-to-migrate-memory-to-memoryless-nodes > +++ a/kernel/sched/fair.c > @@ -1831,6 +1831,12 @@ bool should_numa_migrate_memory(struct t > int last_cpupid, this_cpupid; > > /* > + * Cannot migrate to memoryless nodes. > + */ > + if (!node_state(dst_nid, N_MEMORY)) > + return false; > + > + /* > * The pages in slow memory node should be migrated according > * to hot/cold instead of private/shared. > */ > _