From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F4B3C48BF8 for ; Tue, 20 Feb 2024 01:53:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1F476B0082; Mon, 19 Feb 2024 20:53:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A7BF6B0083; Mon, 19 Feb 2024 20:53:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8213A6B0085; Mon, 19 Feb 2024 20:53:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6B6DA6B0082 for ; Mon, 19 Feb 2024 20:53:58 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0D58D804EA for ; Tue, 20 Feb 2024 01:53:58 +0000 (UTC) X-FDA: 81810511356.23.C734BED Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf20.hostedemail.com (Postfix) with ESMTP id BD17D1C0009 for ; Tue, 20 Feb 2024 01:53:52 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708394036; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rKJDf8g9FI6YN51TKBsiJbLjyU9VYGBzeyf5L/UAwro=; b=oj7Ds8lM9+QU5R2Se4HdNu+ZXOsR1Z/RhjAzqEfHcFoUZAD0diYXotye9jk3Fi6KTOzuq5 2+zga4eshuBpWGK8E14lr5TD/r9+mAaBkpkcaYJjk1a18/szGTcrNH4HEYc9nukC3/n38p cePtTStDNEDKtDQZB9FVWoheqHrHdZ8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708394036; a=rsa-sha256; cv=none; b=lyhlk9uI8CMdHIH/EIGyP1zAahWAdCogPHUFujmiVm6ea4AozxjCgVWa+jgXMQmoMsooWP FI8X+a9sdifJ64xS5/DMPzQfwJiitlsmBbxx8pGC30RM708Ux/Yir+U0i8P8d0T7y3h2jp Fce75a9bJrd+M2aeS3TZBTnjRvafA74= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none X-AuditID: a67dfc5b-d6dff70000001748-63-65d4062c8186 Date: Tue, 20 Feb 2024 10:53:43 +0900 From: Byungchul Park To: Andrew Morton Cc: "Huang, Ying" , mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com Subject: Re: [PATCH v4] sched/numa, mm: do not try to migrate memory to memoryless nodes Message-ID: <20240220015343.GD65758@system.software.com> References: <20240219041920.1183-1-byungchul@sk.com> <87o7ccrghz.fsf@yhuang6-desk2.ccr.corp.intel.com> <20240219174508.bc6256248a163c3ab9a58369@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219174508.bc6256248a163c3ab9a58369@linux-foundation.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMIsWRmVeSWpSXmKPExsXC9ZZnoa4O25VUg/5HmhZz1q9hs7j0+Cqb xfSXjSwWTydsZba42z+VxeLyrjlsFvfW/Ge1mPzuGaPFpQMLmCyO9x5gstjX8YDJouPIN2aL rUe/s1ucnDWZxYHPY828NYweLftusXss2FTqsXmFlsfiPS+ZPDZ9msTucefaHjaPEzN+s3i8 33eVzWPz6WqPz5vkArijuGxSUnMyy1KL9O0SuDJe9cYUXNGsOLjqBUsD41ylLkYODgkBE4nv jZFdjJxgZnfvN1YQm0VAVeL4q/VsIDabgLrEjRs/mUFsEQFdiVXPd4HZzALXmSSu/ysEsYUF oiRmLPnCCGLzClhInH92E6iXi0NIYCWjxMUTW9khEoISJ2c+YYFo1pK48e8lE8gNzALSEsv/ cYCEOQW8Jd6degc2X1RAWeLAtuNMIHMkBNrZJbY3tbFCHCopcXDFDZYJjAKzkIydhWTsLISx CxiZVzEKZeaV5SZm5pjoZVTmZVboJefnbmIERtWy2j/ROxg/XQg+xCjAwajEw/sg7nKqEGti WXFl7iFGCQ5mJRFe96YLqUK8KYmVValF+fFFpTmpxYcYpTlYlMR5jb6VpwgJpCeWpGanphak FsFkmTg4pRoYy8x5PqgxW+WZaCl/3vaJT/TevvlfDuV/teqw0rhb9im3lXli585w8cbFU5uK jxdE7phie2fCtDe/nNe2P3igujig0kfx8Q8mWQE3n2RLz73ZBznPXRZabZyq1LfZsyex7/qO 6m99nPtW9d/N4LqgdH1a67ro303/cnu3GHMqsE/7s6H8QKGVEktxRqKhFnNRcSIASgL1b6YC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNLMWRmVeSWpSXmKPExsXC5WfdrKvDdiXV4P4/aYs569ewWVx6fJXN YvrLRhaLpxO2Mlvc7Z/KYnF47klWi8u75rBZ3Fvzn9Vi8rtnjBaXDixgsjjee4DJYl/HAyaL jiPfmC22Hv3ObnFy1mQWB36PNfPWMHq07LvF7rFgU6nH5hVaHov3vGTy2PRpErvHnWt72DxO zPjN4vF+31U2j8UvPjB5bD5d7fF5k1wATxSXTUpqTmZZapG+XQJXxqvemIIrmhUHV71gaWCc q9TFyMkhIWAi0d37jRXEZhFQlTj+aj0biM0moC5x48ZPZhBbREBXYtXzXWA2s8B1Jonr/wpB bGGBKIkZS74wgti8AhYS55/dBOrl4hASWMkocfHEVnaIhKDEyZlPWCCatSRu/HvJ1MXIAWRL Syz/xwES5hTwlnh36h3YfFEBZYkD244zTWDknYWkexaS7lkI3QsYmVcximTmleUmZuaY6hVn Z1TmZVboJefnbmIERsmy2j8TdzB+uex+iFGAg1GJh/dB3OVUIdbEsuLK3EOMEhzMSiK87k0X UoV4UxIrq1KL8uOLSnNSiw8xSnOwKInzeoWnJggJpCeWpGanphakFsFkmTg4pRoYlZUl2Spb ObfP4eQJWyfmdnJv2PaN82dtnvtu4dd26RPSzoJWU1jsL2xtPMg88WU1k5HzgqmHLyqkp6tq 7A0t57+qGMSzWPQNW7GcTZHa5ut2lqoMn9Q4FtilXNZte/Mxzl9zJsOlf9F/Jx5721E001uY S0SSWUDN7fbsW8Ya138I3XnRWxCnxFKckWioxVxUnAgAxiV0yo4CAAA= X-CFilter-Loop: Reflected X-Stat-Signature: 16wys4i8ksg7xg5nq57nwzhbg1gs1mha X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BD17D1C0009 X-Rspam-User: X-HE-Tag: 1708394032-82479 X-HE-Meta: U2FsdGVkX19G+LK6/K8iuxlth3PBkDA5EPPc1MwB6Vu1Zu+Pxz5hI6J2XrSZ0bDtIXfum1xo8gUIPELMeAs3APAJuKPayqgaX9vuZOE0dlau5mrDHhIUKn2wmKjYZ+oT68I38ZkBsmqBhQw0Pq2qdEYd6jE7N71SXEwwahP1sNFhSY7doEtTbkV1u4WDpBLFLpcNMpqmnqa/8Z3dVBV1B9wM0TmH8aiJ396iE8UhiEvF0I0SbH1a0Y0so0jt8YZNdhnq2vjjDaTHFVU7eBfwg0TeKyZPz4ukwU+4dVZW7i85XSoxn9yJuSPBjik9QQ5KYsvlXWn/Lz+94nNnCZvXsBCMpbZ/szayhmgLE4zqyTDOTOKF6sGUqn8aLU7xqHPPHONgdhJmmcHwISJL9eYRqD562kick+O0ZOMrzMlNZXqZ5tu3b0+BgqpEdEQjJIaGX66cSFno6rXLanRLzjuLoPj6j1IvPHeEzZh88jXZGmb77axjztOc0Gl8j1S4QKede6hIAnW7qs8wc7In1ypX5AxrRtXyxrddOqNOm9vRuUpO/I3YoWbgytgnawszpPxP/2HcjQBO3TUT9mM2rL1RIx0QZyppFkPtcMsLafD9MLWKBibJGglw0avaa3Lu6Ru4cM2auGu+S7itKz+mzeGnn4eaMnF5gfmbpsPq725yHAU2DWxNqVxA8/SkDK2HR1YA3oHOPNsa/hA7owj4U8bp2i4JaiMp/ft2IOtqAtCRIZVBjVjHI3CFipAZ8FY043KN8yNb5nSFhR6KiB1GDqnNOE5N+NCjIJ8+3uZ1GG3bzEZSAjJlrTpPe+WfmGqrDuJ4Jm8ugEeTZyGoumgKEcXv2+BAmje6v4lFA2E1suZoFp+dyCKhVMb3cM8WcgP+KNDaJ5tI9diRSd3Hzmg/LelZhK0f4kpPyAsgfQGfl6FaYUVMfDJ+NFtxxztKScdQtfCLa4ZiFG9K41VyMcntXhu ANW//M+I Yi11UWOsWyPW/JRbTAr9cBY2WDdxh65gcSWPYFL/TzC8Hb9nNl93sdXCf8wlMMOW8RviLLPkqQ2pDzgVcEzQ+rl67ZN1LVBIQXuAWSSBb+XSpBTJOC952j8AFVAQZ4Fd7hFHETSDjwwPq8wTWC001rDiVkYBXJyKJScXklcSr2g0LXkLMCBuBkCJ2VFyGKhjCWq+pAJNLqInTrwbIJCvVcjbe1q1A5PJ0lzoeX1+jl+Pw+Suz1lMPrGEqgppvC/PrW0NoOZAjCVAy+xmQXxc5L3gBW5gtBxefbtqHnllE+nWePovC9Q93m+xOZ8om9c6f1xUdf25Qnob8EzAjDdWZSEhwV+W6Jr6WBUbV2FvIVi/39Wo5M0hxnQJ07GLT3iF2DpPD32b2llbKv5PMJh1B5zD+79VuoCtM3kKSTXlssUcWxK+BaLzF1Khzpy6hkHRw5GM86nRDMUY7kaY0fRG47hZcakYfd7vKVVc1F0btfyAftdU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 05:45:08PM -0800, Andrew Morton wrote: > On Mon, 19 Feb 2024 16:43:36 +0800 "Huang, Ying" wrote: > > > > + /* > > > + * Cannot migrate to memoryless nodes. > > > + */ > > > + if (!node_state(dst_nid, N_MEMORY)) > > > + return false; > > > + > > > /* > > > * The pages in slow memory node should be migrated according > > > * to hot/cold instead of private/shared. > > > > Good catch! > > > > IIUC, you will use patch as fix to the issue in > > > > https://lore.kernel.org/lkml/20240216111502.79759-1-byungchul@sk.com/ > > > > If so, we need the Fixes: tag to make it land in -stable properly. > > Yes, this changelog is missing rather a lot of important information. This is not the root cause fix any more but just optimization. That's why I didn't add Fixes: tag and cc stable@vger.kernel.org in here. Instead, I added Fixes: tag and cc'ed stable@vger.kernel.org in the real fix patch. check the following link please: https://lore.kernel.org/lkml/20240216111502.79759-1-byungchul@sk.com/ Byungchul > I pulled together the below, please check. > > > From: Byungchul Park > Subject: sched/numa, mm: do not try to migrate memory to memoryless nodes > Date: Mon, 19 Feb 2024 13:10:47 +0900 > > With numa balancing on, when a numa system is running where a numa node > doesn't have its local memory so it has no managed zones, the following > oops has been observed. It's because wakeup_kswapd() is called with a > wrong zone index, -1. Fixed it by checking the index before calling > wakeup_kswapd(). > > > BUG: unable to handle page fault for address: 00000000000033f3 > > #PF: supervisor read access in kernel mode > > #PF: error_code(0x0000) - not-present page > > PGD 0 P4D 0 > > Oops: 0000 [#1] PREEMPT SMP NOPTI > > CPU: 2 PID: 895 Comm: masim Not tainted 6.6.0-dirty #255 > > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS > > rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014 > > RIP: 0010:wakeup_kswapd (./linux/mm/vmscan.c:7812) > > Code: (omitted) > > RSP: 0000:ffffc90004257d58 EFLAGS: 00010286 > > RAX: ffffffffffffffff RBX: ffff88883fff0480 RCX: 0000000000000003 > > RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff88883fff0480 > > RBP: ffffffffffffffff R08: ff0003ffffffffff R09: ffffffffffffffff > > R10: ffff888106c95540 R11: 0000000055555554 R12: 0000000000000003 > > R13: 0000000000000000 R14: 0000000000000000 R15: ffff88883fff0940 > > FS: 00007fc4b8124740(0000) GS:ffff888827c00000(0000) knlGS:0000000000000000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 00000000000033f3 CR3: 000000026cc08004 CR4: 0000000000770ee0 > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > PKRU: 55555554 > > Call Trace: > > > > ? __die > > ? page_fault_oops > > ? __pte_offset_map_lock > > ? exc_page_fault > > ? asm_exc_page_fault > > ? wakeup_kswapd > > migrate_misplaced_page > > __handle_mm_fault > > handle_mm_fault > > do_user_addr_fault > > exc_page_fault > > asm_exc_page_fault > > RIP: 0033:0x55b897ba0808 > > Code: (omitted) > > RSP: 002b:00007ffeefa821a0 EFLAGS: 00010287 > > RAX: 000055b89983acd0 RBX: 00007ffeefa823f8 RCX: 000055b89983acd0 > > RDX: 00007fc2f8122010 RSI: 0000000000020000 RDI: 000055b89983acd0 > > RBP: 00007ffeefa821a0 R08: 0000000000000037 R09: 0000000000000075 > > R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000000 > > R13: 00007ffeefa82410 R14: 000055b897ba5dd8 R15: 00007fc4b8340000 > > > > Fix this by avoiding any attempt to migrate memory to memoryless nodes. > > Link: https://lkml.kernel.org/r/20240219041920.1183-1-byungchul@sk.com > Link: https://lkml.kernel.org/r/20240216111502.79759-1-byungchul@sk.com > Fixes: c574bbe917036 ("NUMA balancing: optimize page placement for memory tiering system") > Signed-off-by: Byungchul Park > Reviewed-by: Oscar Salvador > Reviewed-by: "Huang, Ying" > Reviewed-by: Phil Auld > Cc: Benjamin Segall > Cc: Daniel Bristot de Oliveira > Cc: Dietmar Eggemann > Cc: Ingo Molnar > Cc: Juri Lelli > Cc: Mel Gorman > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Valentin Schneider > Cc: Vincent Guittot > Cc: > Signed-off-by: Andrew Morton > --- > > kernel/sched/fair.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > --- a/kernel/sched/fair.c~sched-numa-mm-do-not-try-to-migrate-memory-to-memoryless-nodes > +++ a/kernel/sched/fair.c > @@ -1831,6 +1831,12 @@ bool should_numa_migrate_memory(struct t > int last_cpupid, this_cpupid; > > /* > + * Cannot migrate to memoryless nodes. > + */ > + if (!node_state(dst_nid, N_MEMORY)) > + return false; > + > + /* > * The pages in slow memory node should be migrated according > * to hot/cold instead of private/shared. > */ > _