From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB0EC48BC4 for ; Tue, 20 Feb 2024 03:30:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0319E6B0072; Mon, 19 Feb 2024 22:30:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F23516B0081; Mon, 19 Feb 2024 22:30:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEA1C6B0082; Mon, 19 Feb 2024 22:30:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CC9EE6B0072 for ; Mon, 19 Feb 2024 22:30:55 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9D280A045C for ; Tue, 20 Feb 2024 03:30:55 +0000 (UTC) X-FDA: 81810755670.03.6F8FC10 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id 7B9FC180012 for ; Tue, 20 Feb 2024 03:30:53 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kmNL7KnP; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708399854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZovvRLENiga4qgOf+13WD/uObzl2QeiHUb7op1d3sIM=; b=nvKjD+RczyIAVpjy1B5BjwdJOGks4w6xy8SyyqScj+O5dJTzCCC289MHze334w4kYuF+nX LNWIaFKnEsfTu5m1G8PwPu3wieN8t3ZpZv+BbrJTXzhJbzugWhDqlmTf+WgxcdOcyspWYv vfzCgi46SBsDXOrW8Tws/qW04YyguIA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kmNL7KnP; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708399854; a=rsa-sha256; cv=none; b=eqNZoHE2atD3Cha3lRepRLVge/WkbM40RNE3njDnwz6htgDzVeIF2egFh5hAdN4WjL5ry+ DaXWdz3mt/L1a7aP2H4NC4k8CF67ZRid0RTlMT5CgjJSykkogVwPJmqn6ldopPttTGsyfO Y/SgYXH0tEyaJTZnnJ8GRHL4HXsbbLQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 23956CE1724; Tue, 20 Feb 2024 03:30:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE2CAC433F1; Tue, 20 Feb 2024 03:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1708399849; bh=OWejHLNepLGujaSbGpbMAP1AbglW7ePwckLXsnJRIRA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kmNL7KnPWDgYtHVRH+k7+MYZngA/necwn0aQF/wGHYh/HzRTyQIpXcuc0lbVdJ2gB xvZHH912ChleVwhFE00ZEmE2MhsjkL5hrC6ZcN0oJFClARNqs6B0cWKjww25WNmLJa IwsNbkuXKvtgNbGvObptBrwtFvcQ9PWxKF0TtZ6Q= Date: Mon, 19 Feb 2024 19:30:48 -0800 From: Andrew Morton To: Baolin Wang Cc: Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Huang, Ying" , Ryan Roberts , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: Re: [PATCH v6 0/4] Enable >0 order folio memory compaction Message-Id: <20240219193048.cbd010579aa3d2c790f6e2b9@linux-foundation.org> In-Reply-To: <4f0b3586-25e2-4d21-bbb6-41f644d3d77f@linux.alibaba.com> References: <20240216170432.1268753-1-zi.yan@sent.com> <20240219180617.89a0daaba45ce124ef01be50@linux-foundation.org> <9E3E6CD6-45DD-4E7F-B6DC-0897F38D5E81@nvidia.com> <4f0b3586-25e2-4d21-bbb6-41f644d3d77f@linux.alibaba.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7B9FC180012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 8t5j5smwja5wsqhdnxgr7uxamch5o9g5 X-HE-Tag: 1708399853-467777 X-HE-Meta: U2FsdGVkX1/4/uOHQXZfs4sFvXizvqvmDEdEQQ/kUGncYQOtGKPx9BXENMGWYs0StcPgwxLqLIdixsHVdfvos/rz1plz8rpJAsGBcYVbCvpelxPwOZSmgISi0YFiJ/Zfq5cEeBruvvgpty75GfIem+aZCtxv4v1tMMzt/fEHU6ncgJWv5ri+snG6y1MKZUW8ltLQLaFfDiGkQja/AGfZf3RdFS5QVwHg30oL76jfvriYuVGeuF2pFGiev3EoGViCDl9hFFcEIwMMtTR5a9SJTIGoGa2O6QqS3qwvpPtwHm9fyWl6EWMqhGjtbht4hUeQp0RxeDXfW4B95x8iq/GSPROeIBYZ6NHCwWRSbOsLqqNgscRU+c4nlZkrnh5lCniRWsEs8u3DnY+izlBp9zfZTMez3UM1E0qaQl4oBA9Ftc6MvYiYXOztVgEhnqLabW3wtKf5qhGXxAtkG1BrasVXJy05OKY/cFjIvsl1WrLrG6fHt2IV+HH4hQS1rX7hR6Onxwzg8D4k/FzhOkRAPK7MzOTgPt+JJcln6VxZq6duR22YNK8FkM20suxdwKL8h6F1Lqpj8u2uBeU8zpuLPtdWIkc5uzENS1RE8w00aNLX7Bob6dcR/rdW8t37YrX3t1wc58R1k9uZN/Q3BnnVY54hCPy9+mW8VgOubTVlh9hfEzqoqw2mLS2wy7sINg5hc7lt9Bp6yxYrvGZ2AvHbzQxn+OeO0hkP0Dcx8eagFAEmHNDyGS9nu+FsVABK5IaUxGPlO6QgWVJS+bbvqPQKxJktAAXDFKDfuN0FaGZ+U8v8ePfvb1zwb4p32Wd8Z7F0K9LVjTYUJtS9A1Uwotmi5a60PJ0RyWSpUn8MigM51SKwvaqtCZo1XqnMeqeTPXk+qONpVDCPyOXIqJJNXxddMFJ0+jpqzumll20ISnBlABD2mxfpI8P2MbV05UgsVIsg34eJdVxzCHRoDFB+1Ahz9Ef iLFoF4PV WVLKepEq5oL2Gq1XN6rKuQtuokjHrishj1xZrCbiOmRPpzgUtUUeMHT2CDV00t/kzgtOX3D7syC2YrUEe6m0kYB7LWwuX1VDnGjYBzbAAlMoUDEaLn7IavSZ1/INUKRr9Y88DGTJxi+Ldd2nXUzgNxHeIH/lGXm5YRgiPeOFNWhgWDnCQNlX9kcWwCuvtZV+h5oEi27d6WvpE0hQ/gXXOETDgl90p9YN5zMxyt/SVOEimgIme2fqMH4QdhGzHEgcu3B9+0y68bspAdnwKhyIahQ4aws5T6YWD4IAnTpDL8jmfnrIiPxs8q/YilsYqnTx9/JiMxebNMmNIsLrpWdvUBcyoBErB8PR90jm4F/vNrh+iRb6x4AZVgoIure3m8140gWNA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 20 Feb 2024 11:00:39 +0800 Baolin Wang wrote: > > The patch was based on top of my early version of this patchset, thus > > uses "cc->nr_migratepages -= 1 << order;" and > > "cc->nr_migratepages += 1 << order;", but now it is applied before > > mine. The change should be "cc->nr_migratepages--;" and > > "cc->nr_migratepages++;", respectively. > > > >> > >>> on nr_migratepages was based on this one, a better fixup > >>> for it might be below. Since before my patchset, compaction only deals with > >>> order-0 pages. > >> > >> I don't understand what this means. The patchset you sent applies OK > >> to mm-unstable so what else is there to do? > > > > Your above fixup to Baolin's patch needs to be changed to the patch below > > and my "mm/compaction: add support for >0 order folio memory compaction" will > > need to be adjusted accordingly to be applied on top. > > > > Let me know if anything is unclear. > > Hi Andrew, > > To avoid conflicts, you can drop these two patches, and I will send a > new version with fixing the issue pointed by Vlastimilb on top of > "mm/compaction: add support for >0 order folio memory compaction". > > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-everything-2024-02-16-01-35&id=97f749c7c82f677f89bbf4f10de7816ce9b071fe > > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-everything-2024-02-16-01-35&id=ea87b0558293a5ad597bea606fe261f7b2650cda Well I thought I'd fixed everything up 10 minutes ago. Please take a look at next mm-unstable.