From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84ACFC48BC3 for ; Tue, 20 Feb 2024 02:46:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F26F08D0003; Mon, 19 Feb 2024 21:46:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EADED8D0001; Mon, 19 Feb 2024 21:46:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4EC48D0003; Mon, 19 Feb 2024 21:46:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C17F78D0001 for ; Mon, 19 Feb 2024 21:46:51 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6CC651C054C for ; Tue, 20 Feb 2024 02:46:51 +0000 (UTC) X-FDA: 81810644622.27.A3811A0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id B2FDF120009 for ; Tue, 20 Feb 2024 02:46:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=2YszLqSS; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708397209; a=rsa-sha256; cv=none; b=4FHwOL/Koj5TXLI6CyDFtYHDTuKJ55ROEyWtEGRz1c7f2OwqoMU+H3aO09UBxIy/w97mr9 6hZt5b5WxUC8ns/ZmpOozVw/AFc2dDUnIxGaAIgi95SPAdjgwjdO5/o9Be+y6sXQpQCCXu IR9W598xYm7t0YtoZStvkbuGhcmb3zI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=2YszLqSS; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708397209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4+PBiLkJxprqDSdKQTFeYmdUITct0XwcKfpo3XxPVo4=; b=kE8j+pEmAU9MKP6AzwseFVdpK7i5FyP5khWZvy4TBSo5+iIuuyCZLHpx2Xg9y8eiK4meJ3 FeNTCvBUNL5Mo1yzGNCq3l+O7Ymq5Muv7ay3G7hSWuUyGk8cvwQXi/qMgN/HNoI+y4BwZm HI0KPy2P/wm76Tu59Z2R7HOsM+hHw0w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AC5E361005; Tue, 20 Feb 2024 02:46:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 325A5C433F1; Tue, 20 Feb 2024 02:46:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1708397208; bh=iek5/8kTmCnhRGZeyDjzDDsk+p7rU/waTEOkV9+w7nI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2YszLqSSaIYpuA1jCb8SV+LRKpggnXCg2V2ILyAMQnSs/x9+GKVpNss7g3s7wcRgd qxYoWFtVwkU6MUeHADM1kuacM2Un/3gJX8sLC8OUkf5IpnegmkGNwUSKH7K9DZ+ExA HSpthOY7/5UsaQr1POU3+DOyekYPlCgkOiHCeA2w= Date: Mon, 19 Feb 2024 18:46:47 -0800 From: Andrew Morton To: "Aneesh Kumar K.V" Cc: Anshuman Khandual , linux-mm@kvack.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] mm/debug_vm_pgtable: Fix BUG_ON with pud advanced test Message-Id: <20240219184647.66ca5f8a1a38156b61e43b9c@linux-foundation.org> In-Reply-To: <105963ed-b489-4b82-973a-9024d74c6e87@kernel.org> References: <20240129060022.68044-1-aneesh.kumar@kernel.org> <1b3c1513-826d-4908-93c3-212a6f1b2d74@arm.com> <504f70be-deca-4f7f-b28c-d1ec2cf5a348@kernel.org> <105963ed-b489-4b82-973a-9024d74c6e87@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B2FDF120009 X-Stat-Signature: y8c4ri8uubeyy8iudr5w179w9mik98ip X-Rspam-User: X-HE-Tag: 1708397209-454931 X-HE-Meta: U2FsdGVkX19m5UoyIlL1nz1xqNE+upklJnCXcLqBUwl/cmstfQFjElfQfmKhc6RGFyKZ1e474+cbcuFGUluJfXTfvWhq6X9ge9yL4wG4ZtoLrnJdoKZWEQoJ98z8Rq4KOFvFmisxbf6R19YI9QLcMHX6EGi5QpVZ9XAFpCS6/qXXbF1n0zS/PRwGTeJLcVkdVeAgvjtj1PdLUOg003A9xNSrabT2kldubQsKsaCXB5YmpVWxtstH4sXQC89kZewGjR4ecTd1EQ2TWs1PTGpbU/JKBBmEuUnp+XF2PsDWPYnfnSCFasS7sOGQrb3/eVCXOFP7OsiWMfYAfOfHu6NMaZtjxDAYP1YZh7GAYWJh71grU1EoF5IX/EjAZYaE2f692sk4w3TaJSunm30WyJR0TX7rrfVquCH4r8Mf1LnZ5QJrzUq8Yj+ObAGB5JsBhGD+v86F7IsfrP26W+QIw6Wzm3dCVe5uK6snShxFtTsL0LhRbi/ZQ4QMA0gk6s8S2qhiD/J13ry+0B4aYNKQpopBYYL1m4+xBDkmB0mO3kZfqkhTBrH/pcp2BVJ+U2Tje1jVKKgxGeO8t0em/53foMGOaXWftiNYnxu2el/6UIhvn6ANFcNeaOXu7z3CYXQiDjj7I+Rk71Hhzj6jXm7g+PvpJL+H1+dHfQAfgzeR1EFrC5zhSrkWPdgZ5mQz0fgmHwYUZ4cMsfQYyc8KZ9SokJB9E0qysiYkTQIZ5H7cde9OaCCpXP5vIpbVE961fk/3WjZtMKMbmwcZFuund48eOqvdMjf6O4m/p+9caL3Tn2fA/uYuHyV86JZ5s85ZpV/3zKcw1YY1iwg5bedaHqEpfCMuSlhwmsJu3q/3mLRc4+w1GcaeeEgjzUwa6o47z5e6ejgq+Aa8nQCSG8IbsIg1vlRkoL+BO0+fNA6I3FIH63gXNjeAE0vFo4E/c+BF6sFn8g8IEONMKmffyVCcdAFd6kA C7FaDhBH HWWWOFpRGIZBcB9M59SbfpoIEl/rrTbS6QJoW3uqBkTd4SxgYnjuJjyazjDdpTpLA2dYGG6uVr1oiZ35R6bozYejQNho5hM8JSbUaYIrzzzvYf2yVOzpAUJ14vQ5S5uo/sT90M2iWrrUjDBB3WjmnSKfHFcXQcsnDKg4Jifyvjejs0M23cvUTYUb+8vaCVvVLBMmFKiWbQqfmkvb1ABIlVn0O32ed3VylwBr1RzpuHQtgvd7by3U19Tiu2ne7YL2RYUHe4armu5NgernxGTd1gMyWb1r7TFC4srMz//KMunZk6ZvRJcFsMr3v7MZag1RIgwoVSodhNdzRVoc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 29 Jan 2024 13:43:39 +0530 "Aneesh Kumar K.V" wrote: > > return (pud_val(pud) & (_PAGE_PSE|_PAGE_DEVMAP)) == _PAGE_PSE; > > } > > #endif > > > > #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD > > static inline int pud_devmap(pud_t pud) > > { > > return !!(pud_val(pud) & _PAGE_DEVMAP); > > } > > #else > > static inline int pud_devmap(pud_t pud) > > { > > return 0; > > } > > #endif > > > > We might need some more clarity on this regarding x86 platform's pud huge > > page implementation. > > > > static vm_fault_t create_huge_pud(struct vm_fault *vmf) > { > #if defined(CONFIG_TRANSPARENT_HUGEPAGE) && \ > defined(CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD) > struct vm_area_struct *vma = vmf->vma; > /* No support for anonymous transparent PUD pages yet */ > if (vma_is_anonymous(vma)) > return VM_FAULT_FALLBACK; > if (vma->vm_ops->huge_fault) > return vma->vm_ops->huge_fault(vmf, PUD_ORDER); > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > return VM_FAULT_FALLBACK; > } cryptic reply, unreplied to. What's the thinking here? Should we proceed with the patch as-is, or are changes needed?