From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5387AC48BC3 for ; Mon, 19 Feb 2024 15:06:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0FAB6B007B; Mon, 19 Feb 2024 10:06:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BBF6E8D0001; Mon, 19 Feb 2024 10:06:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A87956B007E; Mon, 19 Feb 2024 10:06:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 998946B007B for ; Mon, 19 Feb 2024 10:06:28 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 40A248049F for ; Mon, 19 Feb 2024 15:06:28 +0000 (UTC) X-FDA: 81808879656.04.44A9D42 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 60FBFC000D for ; Mon, 19 Feb 2024 15:06:26 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=itXtJbmn; spf=pass (imf22.hostedemail.com: domain of pauld@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pauld@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708355186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iHnTRavFzccEVzSoX1iUfpV/3djTz6kfAI7fI53+wUc=; b=c4drBGak/2+1iYmW4vuL8DVVbLHjgjRnPYO3xTUSJucg7ho9mP6dqwim3bxI+oMiJB8ZFu okmgeVIedMZF7UQO1KCvYfFDMf60hxTuNQrrBC3grv+sz+Phi0oVKm3xMVH7Req6wcMhwc aaqp+c0vgKYGLbLF2c8lElsBWWv34JM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708355186; a=rsa-sha256; cv=none; b=dK/jBXhdMId+qr7+UDDCweENch+l2CFiRKXseO4ug4LtKhAWef1b12skHmdorL0BO1lyW2 tRwNLHfWGCKAjM3Gtz93uINZrs86bYreyEtSLATyhouWYjpmze76qaYPaw5aS0Y8HvBJ2T Y/lfR+ocqlYWGqkCZ1BVXLVnwjIXQMg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=itXtJbmn; spf=pass (imf22.hostedemail.com: domain of pauld@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pauld@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708355185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iHnTRavFzccEVzSoX1iUfpV/3djTz6kfAI7fI53+wUc=; b=itXtJbmn+hghaBYGnmuVA3EF3mXku1PnKendmTZYPPIYF5tNDWK/dbQa8B8Slb482WE2Km oqk1hQZqk/0NkJ8UnCEuk2Ycr80dGTFzuDqVmDyK1rhWftQ00VPlHadCaKWtRoodN8RPjF A2Vlb41dM8wGohH/4AIEHL5H4nPjvGk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-1AJLftrBPSisvJTcIv_9rg-1; Mon, 19 Feb 2024 10:06:20 -0500 X-MC-Unique: 1AJLftrBPSisvJTcIv_9rg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BAC4E106D112; Mon, 19 Feb 2024 15:06:18 +0000 (UTC) Received: from lorien.usersys.redhat.com (unknown [10.39.195.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 83A7340C9444; Mon, 19 Feb 2024 15:06:13 +0000 (UTC) Date: Mon, 19 Feb 2024 10:06:10 -0500 From: Phil Auld To: Byungchul Park Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org Subject: Re: [PATCH v4] sched/numa, mm: do not try to migrate memory to memoryless nodes Message-ID: <20240219150610.GB184804@lorien.usersys.redhat.com> References: <20240219041920.1183-1-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219041920.1183-1-byungchul@sk.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Stat-Signature: jo89wo37kq1udtohp94g1z43tm3izwq7 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 60FBFC000D X-Rspam-User: X-HE-Tag: 1708355186-379598 X-HE-Meta: U2FsdGVkX19FEUxc+0teeOXfS/oxqzein5nbfIZ2KOCdbL+vivPfp787f+nF/V3Hq+yliKMCrLOp3byBhqr2L9zqRgEouhSKPfafRjN/cOljL29JdUrZ1WYnV3b90jOw4Rgs0cG6gFSqkswpV3UaNWmbiI3MHdPPQ+IKNbL8lDl+BNDgxoLGy5V3jH4cKOu/W+lTRc59gncZ33ye52PPNi9o67rD8SIJPxZcMfb0jdZZ4Dl0qV9N/SBE+WJNF6DACDRr4s7fN4qul+CmJ0B6v9frPYqonY9oIlK4ExLifw2x9u6kWxSBXe+ZM0PaVir+JqLSnagR5S8TOptbzM4q1b8SLtvL1YeDKA0CNMHs8ym3mHPZbsh4dd5k5rrl//eGtOs33zFBPusyMWZCKeXfhNljzQbF707kV4Wvy5+4QquT9zcu1SrTbTrJwQvVuBEUQ4ZQCYPGlEAOjfGb9mtpmr0c6uJdCqz22I3EnImEvkE4Gigi4et32pFppsGePeDalK6xqKqgnrpRZnEV25CQkrPaaPiEzW0/OxrGLqH6y4GZPtwtP3q/PlIHSaqqCyFPZ3eMmmd8eZH+XcZdO2CJa7km9BqWr0jKIU5qkhJIcseIp7EBJyPz2SL3vGaBDvTlD2hHESKETSWDmYaKxJE8ZQ7HC5F2jafYPjE7KUWzYVantyDTr3dRw4Cemiu1PI86X0LzIJlut4ihcFRt+bYYy+DBX6zVfzCM0JiaPiN2Ff0nGVk34x+HN3bcgo1ug6OEmZ39rZL643lZPvoWNdyIGYt9eMkIuKw5pTbhQjmGgsfwjva0Js+aCuLdhlaJlA3mHsjkmF5eHeLvbrVnMeR+bOQ6PUQ3k0o0pVlHF37Nm3ZgWQERhhiq7UNGgbSsYoQxr+3pzm84v3Q91Xeu8K4KBoOCSTAygnFKAycy3fNaZ6LZIApp7QHUYzZwYD5OfCza+OjVNciDHDR82FSJdlp THlqh9Nl IuPwat1pGZ0v8pbcnoIvALRE3YOJCnwN5aQ9XdUpcL3P7ZtN13ELP3c1di8/saIqN+ziGBapo+j7PhfJR2gZ4sWwdgaQ4tDOud3mWMUeHxXXpGq2jObfLaBlYtq5WAoxkPK8bUCnk5pVhi11Zp4PjHATbpH/nmiz7lyGQgbreJz5D+/xczS2H+nL5uReVvGs1mmTNogSHYG6kD+dt6OxnuywbCQmRaYuDIfZbjP1pegupk/8Qcp+edJm5zxZi1eMo3kTO9G3/8wEnXqadhx/LzdG7eypaQ3tIR0SKEBG+x14bZumNhCAYIqRUFg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 01:19:20PM +0900 Byungchul Park wrote: > Changes from v3: > 1. Rewrite the comment in code and the commit message to make it > more clear. (feedbacked by Oscar Salvador) > 2. Add "Reviewed-by: Oscar Salvador " > > Changes from v2: > 1. Rewrite the comment in code and the commit message becasue it > turns out that this patch is not the real fix for the oops > descriped. The real fix goes in another patch below: > > https://lore.kernel.org/lkml/20240216111502.79759-1-byungchul@sk.com/ > > Changes from v1: > 1. Trim the verbose oops in the commit message. (feedbacked by > Phil Auld) > 2. Rewrite a comment in code. (feedbacked by Phil Auld) > > --->8--- > From 98f5d472c08e3ed5b9b6543290d392a2e50fcf3c Mon Sep 17 00:00:00 2001 > From: Byungchul Park > Date: Mon, 19 Feb 2024 13:10:47 +0900 > Subject: [PATCH v4] sched/numa, mm: do not try to migrate memory to memoryless nodes > > Memoryless nodes do not have any memory to migrate to, so stop trying > it. > > Signed-off-by: Byungchul Park > Reviewed-by: Oscar Salvador > --- > kernel/sched/fair.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index d7a3c63a2171..3e3b44ae72d1 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -1828,6 +1828,12 @@ bool should_numa_migrate_memory(struct task_struct *p, struct folio *folio, > int dst_nid = cpu_to_node(dst_cpu); > int last_cpupid, this_cpupid; > > + /* > + * Cannot migrate to memoryless nodes. > + */ > + if (!node_state(dst_nid, N_MEMORY)) > + return false; > + > /* > * The pages in slow memory node should be migrated according > * to hot/cold instead of private/shared. > -- > 2.17.1 > > Sorry, hadn't gotten far enough to see this version when I replied to v3... Reviewed-by: Phil Auld Cheers, Phil --